Commit Graph

29 Commits

Author SHA1 Message Date
Pascal Quantin 13672dc1e8 Put "GSM SIM" in protocol column
svn path=/trunk/; revision=53367
2013-11-16 13:15:44 +00:00
Pascal Quantin 53a29dee19 Add more GSM SIM Toolkit info to info column
svn path=/trunk/; revision=53302
2013-11-13 17:28:18 +00:00
Bill Meier 0ad98563a2 From didier gautheron: remove redundant or use faster col_xxx functions
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for  replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
    + before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set

   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344


svn path=/trunk/; revision=52948
2013-10-29 14:09:20 +00:00
Pascal Quantin c8be3dcee2 Add a MBIM (Mobile Broadband Interface Model) dissector
Still to be done:
- fragmentation support
- plug the MBIM dissector on USB dissector

svn path=/trunk/; revision=52279
2013-09-29 22:50:27 +00:00
Pascal Quantin 3a0fbea070 Add PDC and TETRA
svn path=/trunk/; revision=49889
2013-06-11 18:07:15 +00:00
Jeff Morriss 15adc6a3cd From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8788 :
ETSI TS 102 221 V8.2.0 (2009-06)
(http://www.etsi.org/deliver/etsi_ts/102200_102299/102221/08.02.00_60/ts_102221v080200p.pdf)
says that file ID 0x7F31 is reserved for use by iDEN network operators (e.g.
Nextel in the USA).

The attached patch updates the GSM SIM dissector's table of recognised FIDs accordingly.

svn path=/trunk/; revision=49888
2013-06-11 18:05:41 +00:00
Pascal Quantin 750b7659bb Add dissection of Terminal Profile byte 32
svn path=/trunk/; revision=48611
2013-03-28 14:04:23 +00:00
Chris Maynard f44b2c8088 Fix the incorrectly duplicated display filters for hf_tp_bip_tcp_local and hf_tp_bip_udp_local.
svn path=/trunk/; revision=48596
2013-03-27 20:26:06 +00:00
Pascal Quantin 6d99fb6a9f Add dissection of ENVELOPE 3GPP SMS-PP Download
svn path=/trunk/; revision=45768
2012-10-24 16:05:50 +00:00
Pascal Quantin 19f194813f Add a few EUTRAN related elementary files and reorder some value_string arrays
svn path=/trunk/; revision=45629
2012-10-18 11:01:44 +00:00
Pascal Quantin d7ae273d7a Add dissection of ENVELOPE event download and timer expiration
svn path=/trunk/; revision=45600
2012-10-16 21:30:24 +00:00
Pascal Quantin 16bb2a67ba Fix dissection of BER-TLV and COMPREHENSION-TLV length and COMPREHENSION-TLV tag
svn path=/trunk/; revision=45595
2012-10-16 20:25:46 +00:00
Pascal Quantin 5f4f0b2637 Enhance dissection of Terminal Profile
svn path=/trunk/; revision=45490
2012-10-11 21:29:01 +00:00
Pascal Quantin d0b892f450 Add another check for command APDU dissection
svn path=/trunk/; revision=45435
2012-10-09 20:11:48 +00:00
Pascal Quantin b126c01738 Fix dissection of more instructions when having only the command APDU
svn path=/trunk/; revision=45433
2012-10-09 17:49:14 +00:00
Pascal Quantin 00e6a66e4d Fix dissection of Get Response when not in SIMtrace mode
svn path=/trunk/; revision=45425
2012-10-09 10:48:59 +00:00
Pascal Quantin 1bed23e6d0 Add "gsm_sim.command" and "gsm_sim.response" dissectors and call them in btsap dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715

svn path=/trunk/; revision=45411
2012-10-08 21:46:30 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Pascal Quantin 6c8d938dd4 Follow-up of r44162: clean more filters
svn path=/trunk/; revision=44187
2012-08-01 14:07:18 +00:00
Michael Mann 175851fb40 Updated GSM dissectors display filters per checkfiltername.pl
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name.

svn path=/trunk/; revision=44162
2012-07-31 18:54:11 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Jeff Morriss 1731fc958e From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6977 :
The attached (trivial) patch adds some missing breaks in switch-case blocks.

This fixes coverity defects #445, #446, #1316 and #1380.

svn path=/trunk/; revision=41727
2012-03-21 22:18:15 +00:00
Bill Meier cb122a30ce From Harald Welte: patch adding the missing hf[] entries ...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6355#c11

svn path=/trunk/; revision=41651
2012-03-18 23:57:20 +00:00
Anders Broman 4a2699a2ef From Harald Welte:
GSMTAP dissector: introduce a dissector table.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6810

svn path=/trunk/; revision=40934
2012-02-08 19:31:23 +00:00
Jörg Mayer ca543968ae Small whitespace fix.
svn path=/trunk/; revision=40926
2012-02-08 07:43:33 +00:00
Jörg Mayer d69fe726b9 packet-gsm_sim.c was the wrong file to check in.
I meant ui/gtk/voip_calls_dlg.c.

svn path=/trunk/; revision=40915
2012-02-07 09:06:44 +00:00
Jörg Mayer dca8952441 Fix "variable set but not used" warnings turned error. In at least
one case this looks like a logic bug and should be investigated.

svn path=/trunk/; revision=40914
2012-02-07 09:03:14 +00:00
Alexis La Goutte 12f5231f68 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=40899
2012-02-06 22:12:59 +00:00
Jörg Mayer 4b3e6f6fff Checked in, with the following changes:
- Adapted packet-gsm_sim.c and CmakeLists.txt to match current content (trivial)
- Fixed warnings about //-style comments that were found running
   ../../tools/checkAPIs.pl -g deprecated -g prohibited -g abort -g termoutput packet-gsm_sim.c packet-etsi_card_app_toolkit.c
    Error: Found C++ style comments in packet-gsm_sim.c
- Not fixed (will lead to dissector abort if in a packet):
   ../../tools/checkhf.pl packet-gsm_sim.c packet-etsi_card_app_toolkit.c
    ERROR: NO ARRAY: packet-gsm_sim.c, hf_tprof_b19
    ERROR: NO ARRAY: packet-gsm_sim.c, hf_tprof_b18
    ERROR: NO ARRAY: packet-etsi_card_app_toolkit.c, hf_ctlv_bearer_descr
  Please provide the necessary element entries for the hf[] array in a
  followup patch.

svn path=/trunk/; revision=40854
2012-02-05 11:34:04 +00:00