- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
- Refactor capture info, A field, B field dissection.
- Clean up dissection, removing private A field, B field structures.
- Added standard references.
svn path=/trunk/; revision=35743
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
Updates to the DECT dissector:
- using proto_tree_add_none_format()/proto_tree_add_item() instead of
proto_tree_add_uint_format() where it makes sense
- fixed display of full slot data
- added some references to documentation
- cleaned up packet length checking
- put descrambled bfield-data in a tree
- cleaned up some afield items
- use custom columns instead adding all infos to COL_INFO
- add some more infos to the columns
Me:
- Replace proto_tree_add_none_format(..., strvar) by
proto_tree_add_none_format(..., "%s", strvar).
- Fix an unused variable warning.
svn path=/trunk/; revision=33210
add framenumber, extended fixed part capabilities and higher
layer capabilities
Me;
- replace div by crc to fix a shadowed global variable
- the last argument to proto_tree_add_item is the endianess
indicator, not the value
- replace // by /* */
svn path=/trunk/; revision=27904
Fix display problems with b-fields:
increase the length of the string and use sprintf.
Original German comment:
weiter hab ich festgestellt das das b-field nicht richtig dargestellt wird .
Entweder ist g_snprintf broken , oder wir sind beide zu unf\344hig die
funktion zu benutzen .
Der string wird aus 16x %.2x + leerzeichen zusammengesetzt , was nach
meinen berechnungen eine h\366chstl\344nge von 144 zeichen + nullbyte ergibt .
deshalb hab ich die stringvariable auf 145 hochgesetzt und benutze wieder
sprintf . hier der patch dazu .
svn path=/trunk/; revision=27844
Matthias Wenzel <dect (A) mazzoo.de>
Beginnings of a DECT dissector. This is a copy of the svn
repository at dedected.org with the following modifications:
- Change from plugin to normal dissector
- Change comments from // to /* */
- Change German comments to English
- #if-0-out unused variables
- Reorder functions to avoid forward declarations and use the normal
Wireshark conventions
- Fix the scrt table (as by email from Andreas)
- Fix Mask for hf_dect_A_Tail_Qt_0_Cn from 0x2F -> 0x3F (as by email
from Matthias)
- Initialize some variables because GCC isn't aware of the reduced
value space in a switch statement that switches on (var & 7).
- Declare some function parameters as _U_
- Add GPLv2 and later header (as by emails from Andreas and Matthias).
TODO (roughly in that order)
- Don't use structs to access the elements in the datastream.
- Use tvb_..._item wherever possible
- Add references to documentation (ETSI EN 300 175 parts 1-8)
including the section.
- Make things stateful
- Once the capture format has stabilized, get rid of the Ethernet
hack and use a proper capture type.
svn path=/trunk/; revision=27362
Bill Meier