Way back in 2006, svn r20041 (now gd408f2f6fc) worked around a problem by
limiting the amount of buffer dealt with in the udvm_state_access call (changing
it from state_minimum_access_length_buff[n] to STATE_MIN_ACCESS_LEN).
The very next line however, tries to read the same amount of buffer to display
to the user - since it seems nobody ever applied a proper fix for the original
case, just apply the same workaround to the second call.
Bug: 10662
Change-Id: I32c81ee2a8eb7b30ff7ab1fbbb6ea5f206385d4b
Reviewed-on: https://code.wireshark.org/review/5124
Reviewed-by: Evan Huus <eapache@gmail.com>
The original may be freed out from underneath us if a duplicate is registered.
Thanks to Bruce Fields for pointing out one case of this I'd missed.
Also replace a bunch of manual "foo.field = 0" with just wmem_new0() instead.
Bug: 10636
Change-Id: I342bd732f062b0a191cbbf5ae417356385d2fd53
Reviewed-on: https://code.wireshark.org/review/5046
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Leftover crud before I notied that RTLD_NEXT would do what I want.
Change-Id: I5e510e74c65b211e6cc6c300e760869abb399dc8
Reviewed-on: https://code.wireshark.org/review/5121
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The latest Xcode, as of today, has only 10.9 and 10.10 SDKs, which means
that, if we build Wireshark and request a deployment minimum release of
10.6, we'll be building against an SDK in which libpcap has routines
that aren't available in 10.6 and that doesn't use weak linking for
them, so the resulting binary won't actually work on 10.6.
Use the run-time loader to find those routines (currently, only
pcap_set_tstamp_precision()) and call them only if we find them.
On other UN*Xes, we still assume that we'll be running only on the
release against which we were built and newer releases.
Change-Id: Iab20d86fe3be4b299cfb6e25c1f95dc6e1581661
Reviewed-on: https://code.wireshark.org/review/5120
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Sadly, older versions of autoconf - such as the ones on the OS X buildbots - don't know about AC_CONFIG_MACRO_DIRS.
This reverts commit 89291ad4f3.
Change-Id: Ie4fa71062886f58c7f6014f6b7969921f0b824ae
Reviewed-on: https://code.wireshark.org/review/5116
Reviewed-by: Guy Harris <guy@alum.mit.edu>
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([./aclocal-fallback])' to
configure.ac
This is explained in the libtool manual:
"In the future other Autotools will automatically check the contents of
AC_CONFIG_MACRO_DIRS, but at the moment it is more portable to add the macro
directory to ACLOCAL_AMFLAGS in Makefile.am, which is where the tools currently
look. If libtoolize doesn't see AC_CONFIG_MACRO_DIRS, it too will
honour the first -I argument in ACLOCAL_AMFLAGS when
choosing a directory to store libtool configuration macros in. It is perfectly
sensible to use both AC_CONFIG_MACRO_DIRS and ACLOCAL_AMFLAGS, as long as they
are kept in synchronisation."
Change-Id: Ic203b0b5104ea3423cf8c0042b2278e82bcea332
Reviewed-on: https://code.wireshark.org/review/5113
Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
(Among other things: "2 ^ xxx" is *not* 2 to the xxx'th power).
Change-Id: I893b72e853ecbb5d7e6259e950fb347e89eed6c2
Reviewed-on: https://code.wireshark.org/review/5109
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Pick up change from Samba:
commit 87fb54b77f4b9caaf2b25635b7813e29a448aaa6
Author: Matthieu Patou <mat@matws.net>
Date: Tue Oct 1 12:04:02 2013 -0700
pidl-wireshark: add the type dom_sid28 and call ad-hoc dissector
Change-Id: Ide5041b901b5e1785b5cabd4b6320f830bbef2b8
Reviewed-on: https://code.wireshark.org/review/5108
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up change from Samba:
commit 4b09df897803e78265fd19f6ff19be6e3d8a3944
Author: Matthieu Patou <mat@matws.net>
Date: Tue Oct 1 12:10:18 2013 -0700
pidl-wireshark: SWITCH_TYPE is not always defined, SwitchType() will try to find a fallback
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Change-Id: I1f41ece23e8fec30f9cd89a2203ad63ee6e21e36
Reviewed-on: https://code.wireshark.org/review/5105
Reviewed-by: Guy Harris <guy@alum.mit.edu>
- get language as soon as possible (before creating any Qt objects) to make all
translations working
- dynamic list of supported languages
- runtime change of GUI language (no need to restart application)
- add flags icons support
- search for *.qm languages in buildin resources, then
data dir called "languages" (main directory in sources or
/usr/share/wireshark/languages), then user directory
(UNIX: ~/.wireshark/languages); "languages" directory should contains
files wireshark_xx.qm where xx is language code (en, en_GB, etc.),
and optional xx.svg for flag icon
- try to fix some untranslated manually-created UI items
(need manual reset text of those components)
Change-Id: I62ca8a8cddce47cec9dbcad6b0bd68b6cfd92229
Reviewed-on: https://code.wireshark.org/review/5041
Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Pick up change from Samba:
commit 93f262ee6d162bf007b79d2daf9de6c49c6163d1
Author: Matthieu Patou <mat@matws.net>
Date: Fri Oct 18 00:04:28 2013 -0700
pidl-wireshark: generate ALIGN_TO_x_BYTES instructions if the element has the align_x flag
Change-Id: I865eae69ea7a8200630d3ad69bda9ac7b1c12255
Reviewed-on: https://code.wireshark.org/review/5099
Reviewed-by: Guy Harris <guy@alum.mit.edu>
commit 3f6ca430b067705d556031d52736d5a5d5ae8f55
Author: Matthieu Patou <mat@matws.net>
Date: Fri Oct 11 13:18:37 2013 -0700
pidl-wireshark: if the structure has the flag no_align then set also no_align in the dceprc_info structure
Some dissection function will try to do alignment if the no_align flag
is not set.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Change-Id: Ie2377f4d6c1c4f2fde7084ba666bd417568122dd
Reviewed-on: https://code.wireshark.org/review/5098
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This is the part of this change from Samba:
commit f0a6043fb201940f438f63c809df7186aa307f01
Author: Matthieu Patou <mat@matws.net>
Date: Sun Oct 5 18:25:27 2014 -0700
pidl-wireshark: handle 8 bits enum and change the signature of enum function to pass the exact type
Instead of passing a uint32 in all cases we pass the exact type
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
that wasn't already in our version.
Change-Id: I7da99cb701c2eedadeb8acb68d32f657dfa85e5b
Reviewed-on: https://code.wireshark.org/review/5097
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up patch from Samba:
commit fa331f64d1a40350496c7acf68c20cb3fead6eaf
Author: Matthieu Patou <mat@matws.net>
Date: Thu Oct 3 09:45:19 2013 -0700
pidl-wireshark: insure that we have an entire match for the variable name
Change-Id: I1e730dfb3b9eb96a4cda34659297fddeac7801c8
Reviewed-on: https://code.wireshark.org/review/5095
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up change from Samba:
commit 5d0d45c9a71f137dc29ca79d49bd558f34bf1ff5
Author: Matthieu Patou <mat@matws.net>
Date: Sun Sep 29 00:42:36 2013 -0700
pidl-wireshark: generate an error for the new Pipe type in typedef
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Change-Id: I9e6da50b657f774fadf7c3777900d409999d4660
Reviewed-on: https://code.wireshark.org/review/5094
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up change from Samba:
commit 755bc4ed29c89fc15d4230ce8b828b3afcfa2912
Author: Matthieu Patou <mat@matws.net>
Date: Thu Oct 3 01:10:48 2013 -0700
pidl-wireshark: add a function to change the type of a hf_field
We can use this to change the type FT_BYTE when we realize that the
object dissected is an array of bytes
Change-Id: I1f24ce834b6a5be0d933b1fdfd9a0baa88c3761a
Reviewed-on: https://code.wireshark.org/review/5093
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up change from Samba:
commit 343db5326b369cbdef4b723e3056acc2a866a887
Author: Matthieu Patou <mat@matws.net>
Date: Tue Sep 23 01:28:40 2014 -0700
pidl-wireshark: Handle the case when the DATA_TYPE is not a simple type
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Change-Id: I511a60beb392e5e92701d5ace1260397fb4be851
Reviewed-on: https://code.wireshark.org/review/5092
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up patch from Samba:
commit 5740a06b320d56840439fb7fe3b8b27f341ddaa7
Author: Matthieu Patou <mat@matws.net>
Date: Sat Oct 4 21:19:12 2014 -0700
pidl: Improve string delection in function ContainsString
Change-Id: I702c12e4275315511728d5ef6db07e03be9c2b38
Reviewed-on: https://code.wireshark.org/review/5091
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pick up change from Samba:
commit 4986359816704f38d4fad3ddd0d07a0f0a25b335
Author: Matthieu Patou <mat@matws.net>
Date: Mon Sep 22 21:52:14 2014 -0700
pidl: Make the compilation of PIDL producing the same results if the content hasn't change
Newer perl versions don't generate stable results anymore.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Change-Id: Ifced47229b3033d1fae494adff0dee6671304812
Reviewed-on: https://code.wireshark.org/review/5090
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The case for type "char" wasn't fixed.
Change-Id: Ia745263cd4d11a3c00b1ecc72e044f4e404da283
Reviewed-on: https://code.wireshark.org/review/5088
Reviewed-by: Guy Harris <guy@alum.mit.edu>
dictionary.rfc6929
dictionary.rfc6930
dictionary.rfc7155
dictionary.rfc7268
As they give errors in the test suit, something may have changed in the
free rasdius syntax,
Change-Id: I27c2c4ea8b96601dfaf48b8dc29273fa6adca655
Reviewed-on: https://code.wireshark.org/review/5084
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Looking at RFC 5568 (http://tools.ietf.org/html/rfc5568#section-6.4.3)
It says that the Link-Layer Address (LLA) Option, should have an address right after the option code
Bug:10006
Bug:10627
Change-Id: I6fcd98a7c9896862e4c9547b945cf3848daaf474
Reviewed-on: https://code.wireshark.org/review/5075
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Use the wrong length for display mac address (6 and no the length of option)
Also fix update of item (don't update the root item)
Change-Id: I38cd1a6a045e797b01cd1a8de5add0949eaa0f01
Reviewed-on: https://code.wireshark.org/review/4950
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Update includes all new/renamed dictionaries in radius, but does not cover any differences in already included dictionaries, which will be handled in a separate update.
Change-Id: I6d1e1cc1815423fb71ec940366964a366ab41a25
Reviewed-on: https://code.wireshark.org/review/4947
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: Ib05b67c8741f90444e773e7c9e1378f00f41dad7
Reviewed-on: https://code.wireshark.org/review/5083
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
it returns the parent tree of a given tree object
Change-Id: I191e0221651ffb5b26df761e9a25075aa0eb2ad3
Reviewed-on: https://code.wireshark.org/review/4954
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Look for the binary in various places, rather than looking for
particular directories and adding them to the path. That lets us use
the PackageMaker binary from the PackageMaker.app bundle (it can either
be run as a GUI app or from the command line), so you don't have to have
a symlink to it from one of the directories in question.
Change-Id: I1ad701291698544f96d419663f0b4a669876d2f1
Reviewed-on: https://code.wireshark.org/review/5077
Reviewed-by: Guy Harris <guy@alum.mit.edu>