abb51ebe9b
Allocate correct size of int, not size of a pointer to int.
...
Coverity 717.
svn path=/trunk/; revision=36261
2011-03-22 18:53:37 +00:00
c0ea7f05bf
Redissect packets instead of reload file on UAT changes.
...
This way we can do changes while capturing.
svn path=/trunk/; revision=34709
2010-10-30 11:43:11 +00:00
17d4d51b7d
Make the third argument to a UAT copy callback a size_t (not that any of
...
the callbacks we have use that argument - is it really needed?).
svn path=/trunk/; revision=34694
2010-10-29 21:11:33 +00:00
04b977c4e6
Added a cast from size_t to unsigned int.
...
svn path=/trunk/; revision=34693
2010-10-29 20:54:08 +00:00
fd52258052
Added a Copy button in UAT dialogs.
...
Fixed setting sensitivity when having a selected row.
svn path=/trunk/; revision=34691
2010-10-29 19:48:51 +00:00
a64fe86786
Added tooltips for UAT column headers.
...
svn path=/trunk/; revision=32623
2010-05-02 09:59:02 +00:00
1bf2a7c78b
Replace GtkClist in uat_gui.c with GtkTreeView+GtkListStore. Pop up the
...
edit window when an item is double-clicked. Add a couple of convenience
routines to gui_utils.c.
svn path=/trunk/; revision=32621
2010-04-30 22:33:51 +00:00
2f8830b4d0
From LEGO via bug 3459:
...
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.
svn path=/trunk/; revision=32112
2010-03-04 12:50:18 +00:00
3e85c03c9d
gtk_option_menu() --> gtk_combo_box();
...
(Commit based upon discussion with and input from Jaap Keuter).
(On Windows replacing the deprecated gtk_option_menu()
with gtk_combo_box() has the effect of addressing a dropdown widget behavior
change seen when going from Windows Gtk 2.16 to Gtk 2.18).
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4487 ).
svn path=/trunk/; revision=31908
2010-02-17 22:26:30 +00:00
538dd47d5d
Fix various gcc -Wshadow warnings.
...
svn path=/trunk/; revision=31731
2010-01-29 19:09:01 +00:00
e03e8553dd
Fix for bug 4354:
...
Set Edit and Delete button sensitivity when deleting a row.
svn path=/trunk/; revision=31364
2009-12-27 13:26:00 +00:00
54c159cb41
Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
...
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats). Hopefully this will catch at least
some P64 issues on UN*X.
svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
605ef095f9
Fix the last of the Win64 problems in the gtk directory.
...
svn path=/trunk/; revision=28063
2009-04-16 03:18:10 +00:00
62f60df6b4
From Jakub Zawadzki (bug 3331):
...
g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
cae81ac405
Don't close the UAT dialog when pressing Apply.
...
Default to the ok button in the UAT edit dialog.
Append a ":" to the title labels in the edit and delete dialogs.
svn path=/trunk/; revision=27665
2009-03-08 22:56:12 +00:00
5742ede54c
Add an additional "title" attribute for UAT fields; that's what's
...
displayed to the user.
svn path=/trunk/; revision=27462
2009-02-16 04:10:06 +00:00
8608c8f1de
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26641
2008-10-31 09:53:56 +00:00
a8ddad6d91
Have the window being resizable
...
svn path=/trunk/; revision=25946
2008-08-06 12:03:16 +00:00
a4412aa3c1
Make the buttons of the UAT dialog usable again, and get rid of some gtk warnings.
...
svn path=/trunk/; revision=25940
2008-08-06 00:43:01 +00:00
42c3239a1a
luis.ontanon@gmail.com => luis@ontanon.org
...
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
449e40f6b1
From Abhik Sarkar:
...
Some buttons are always disabled in the "User DLTs Table" dialog.
svn path=/trunk/; revision=25904
2008-08-02 13:47:31 +00:00
56206e0002
Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
...
gtk_container_border_width() ==> gtk_container_set_border_width()
gtk_container_children() ==> gtk_container_get_children()
gtk_entry_new_with_max_length() ==> gtk_entry_new(); gtk_entry_set_max_length()
gtk_menu_append() ==> gtk_menu_shell_append()
gtk_menu_prepend() ==> gtk_menu_shell_prepend()
gtk_notebook_set_page() ==> gtk_notebook_set_current_page()
gtk_paned_gutter_size() ==> gtk_paned_set_gutter_size()
gtk_radio_button_group() ==> gtk_radio_button_get_group()
gtk_signal_connect() ==> g_signal_connect()
gtk_signal_disconnect() ==> g_signal_handler_disconnect()
gtk_signal_emit_by_name() ==> g_signal_emit_by_name()
gtk_signal_handler_block_by_data() ==> g_signal_handlers_block_matched()
gtk_signal_handler_block_by_func() ==> g_signal_handlers_block_by_func()
gtk_signal_handler_unblock_by_data() ==> g_signal-handlers_unblock_matched()
gtk_signal_handler_unblock_by_func() ==> g_signal-handlers_unblock_by_func()
gtk_spin_button_get_value_as_float() ==> gtk_spin_button_get_value()
gtk_toggle_button_set_state() ==> gtk_toggle_button_set_active()
svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
b6454e76ac
Fix some of the Errors/warnings detected by checkapi.
...
svn path=/trunk/; revision=25244
2008-05-06 05:50:31 +00:00
a287b0f3f5
From Jim Young (bug 2212):
...
Add the profile name to the title of all the configuration windows.
(this is a rewrite of Jim's patch)
svn path=/trunk/; revision=25016
2008-04-14 15:01:34 +00:00
644a474c95
sort #includes by directories
...
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
b51da2eb77
rename menu -> main_menu
...
remove old (and unused and confusing) ../menu.h
svn path=/trunk/; revision=24947
2008-04-12 19:18:26 +00:00
55c2be83db
move stock icon code from toolbar.c into specific stock_icons file(s)
...
svn path=/trunk/; revision=24921
2008-04-12 00:49:20 +00:00
8e58ec7085
last round to replace SIGNAL_CONNECT with g_signal_connect
...
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
1f4b5e5f07
replace SIGNAL_DISCONNECT_BY_FUNC with g_signal_handlers_disconnect_by_func
...
svn path=/trunk/; revision=24911
2008-04-11 20:34:30 +00:00
ae5f841083
replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
...
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
ab9c1b68fd
OBJECT_..._DATA --> g_object_..._data
...
svn path=/trunk/; revision=24899
2008-04-11 17:26:09 +00:00
e462fe69d5
Remove an unused function that is causing a warning/error on Unix
...
svn path=/trunk/; revision=24864
2008-04-09 06:09:07 +00:00
e01e158045
remove GTK1 code
...
svn path=/trunk/; revision=24857
2008-04-09 05:01:03 +00:00
726a1caaf1
- Remove GLIB1 code
...
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
g_strsplit code for the no longer supported GLIB1 builds
svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
56222aed0e
Fix for bug 1920:
...
Avoid double free, causing crash, and stop memory leak via normal code path.
svn path=/trunk/; revision=24152
2008-01-21 07:35:16 +00:00
d3e52cc1fe
Cleanup the whitespace.
...
svn path=/trunk/; revision=24137
2008-01-19 07:46:52 +00:00
be611615f8
From Florent Drouin via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2015 : fix crash when editing UAT tables
...
svn path=/trunk/; revision=23604
2007-11-26 18:00:21 +00:00
fc162617f4
enable esc for new/edit/delete dialogs; remove some redundant code;
...
svn path=/trunk/; revision=22782
2007-09-04 12:37:19 +00:00
30b61b7540
Fix my previous patch to enable esc on window
...
svn path=/trunk/; revision=22772
2007-09-02 23:37:40 +00:00
d5b126a552
Enable <esc> to cancel window; remove some redundant code
...
svn path=/trunk/; revision=22763
2007-08-31 23:22:45 +00:00
c22f70ec1b
- epan/uat.h: change the UAT_PROTO_DEF macro to handle both the name of the dissector and the handle
...
- packet-user_encap.c: use the new UAT_PROTO_DEF
- gtk/uat_gui.c: change the order of "containment" of the widgets to have the clist fields sized to the scrolledwindow instead of the whole window
svn path=/trunk/; revision=21934
2007-05-25 16:47:22 +00:00
1bc049906a
Add some GCC warnings to the standard set, and add some others to the
...
--enable-extra-gcc-checks set.
If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.
Constify a bunch of stuff, and make some other changes, to get rid of
warnings.
Clean up some indentation.
svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
4b4d4fed2a
protect callbacks of derived windows from dereferencing a null pointer if the main table has being closed in the meanwhile.
...
svn path=/trunk/; revision=20970
2007-03-04 02:27:11 +00:00
a2a25e7586
revert (most) changes in rev #20753 , to avoid items being created on a wrong menu on windows.
...
svn path=/trunk/; revision=20928
2007-02-25 18:03:05 +00:00
29755e2a35
Squelch a "used without being set" warning.
...
svn path=/trunk/; revision=20848
2007-02-19 01:21:10 +00:00
c63b0a6bc6
From Peter Johansson:
...
I have provided a patch for a crash that occurs in uat_gui.c if from the
"Edit preferences..." button when you choose Protocols -> DLT_USER ->
the "Edit..." button -> the "New" button -> the "Cancel" button.
The crash happens because dd gets freed prior to traversing its internal
structure, hence I moved the call to g_free for dd beneath the traversal
of the dd internals.
svn path=/trunk/; revision=20813
2007-02-14 19:21:37 +00:00
b26c1c4ca2
Add a description of UAT fields, and have it as a tooltip in the New/Edit Dialog.
...
svn path=/trunk/; revision=20797
2007-02-12 19:57:41 +00:00
5db2005993
Have Aply, Cancel and OK buttons instead of the save and ok button.
...
Have these buttons reloading the capture file if needed.
Some rearrangement of the window (the editor is still missing "ornaments" and tooltips)
svn path=/trunk/; revision=20788
2007-02-11 16:09:21 +00:00
7c57c05ed5
* Add a Submenu (/Views/User Tables) where UATs can be accessed.
...
* Remove macros_dlg, the DFMacros UAT goes in the menu with all the rest
* in packet-user_encap.c WTAP_ENCAP=XXX has become useless information for the user leave just the DLT#
svn path=/trunk/; revision=20753
2007-02-09 03:11:14 +00:00
5ec87e6eef
no gtk_window_set_resizable in GTK1
...
svn path=/trunk/; revision=20735
2007-02-07 13:55:34 +00:00
Stig Bjørlykke