12479a1376
From Jim Young:
...
Wireshark crash with new packet list if unknown custom column field.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4379
svn path=/trunk/; revision=31485
2010-01-11 07:56:29 +00:00
5c665874ba
Only mark/ignore displayed frames when doing mark/ignore all packets
...
svn path=/trunk/; revision=31345
2009-12-22 07:37:00 +00:00
2cd7003383
Add "Ignore all packets", just like "Mark all packets"
...
svn path=/trunk/; revision=31343
2009-12-21 23:07:14 +00:00
d9de90be12
Set new column minimum width and resize column when changing column title
...
from the packet list popup menu.
svn path=/trunk/; revision=31329
2009-12-20 23:15:04 +00:00
ef92b4ec11
Added "Ignore Packet" menu items to the main menu.
...
Show ignored packages in the summary dialog.
svn path=/trunk/; revision=31289
2009-12-17 12:05:13 +00:00
47be3577a7
Introduce "Ignore Packet" in the packet list.
...
This will remove the package from the dissection functions without
removing it from the capture file.
svn path=/trunk/; revision=31287
2009-12-17 01:18:14 +00:00
5333f8ac36
Cleanup some column alignment code.
...
svn path=/trunk/; revision=31217
2009-12-09 16:16:04 +00:00
0f8ab929a6
When freezing/thawing selection gets lost.
...
svn path=/trunk/; revision=31206
2009-12-08 16:14:01 +00:00
c5eabf762f
- Use the gtk_tree_view_column_set_min_width() method also
...
when crating the list.
- Set min width to the size of the title or COLUMN_WIDTH_MIN
svn path=/trunk/; revision=31167
2009-12-03 20:59:18 +00:00
eae70bf323
Set tooltips on the column button.
...
svn path=/trunk/; revision=31151
2009-12-02 14:00:04 +00:00
942d6e41f8
Indicate default column alignment in the popup menu.
...
svn path=/trunk/; revision=31150
2009-12-02 13:53:33 +00:00
8b1f93f288
Save column alignment in the recent file.
...
Added center and default alignment menu items.
svn path=/trunk/; revision=31143
2009-12-01 17:07:13 +00:00
81ffd50409
Added three states for sorting: ascending, descending and no sorting
...
(ascending on first column).
svn path=/trunk/; revision=31141
2009-12-01 16:23:20 +00:00
874657592c
Move the heading context menu to secondary-button and preserve
...
primary-button to toggle sorting.
svn path=/trunk/; revision=31131
2009-11-30 16:15:48 +00:00
bc35b6fc5a
Function rename:
...
new_packet_list_column_clicked() -> new_packet_list_column_menu_cb()
packet_list_column_clicked() -> packet_list_column_menu_cb()
svn path=/trunk/; revision=31130
2009-11-30 15:58:57 +00:00
62d9adf4c3
Build for GTK older than 2.18.
...
svn path=/trunk/; revision=31104
2009-11-28 00:28:16 +00:00
be49cd13f9
Added function to align columns.
...
svn path=/trunk/; revision=31099
2009-11-27 18:12:30 +00:00
028996daf0
Small fix in changing column title.
...
svn path=/trunk/; revision=31098
2009-11-27 18:00:07 +00:00
a68334bcec
Prefix tooltip with protocol name.
...
svn path=/trunk/; revision=31094
2009-11-27 13:15:41 +00:00
6bcb851e06
Added a descriptive tooltip to the packet list column headers.
...
We should probably add some more column documentation to each column.
svn path=/trunk/; revision=31093
2009-11-27 11:29:13 +00:00
5fa9b50863
Cleanup object keys.
...
svn path=/trunk/; revision=31090
2009-11-26 16:12:03 +00:00
2e06779073
Save preferences when adding and removing columns in the main window.
...
svn path=/trunk/; revision=31087
2009-11-26 09:11:55 +00:00
43de696a6c
Added a popup menu in the packet list heading to set sort order and some
...
functions to rename column title, resize a single column and remove a column.
svn path=/trunk/; revision=31086
2009-11-26 09:09:07 +00:00
c00e12fd9d
Corrected include guard in packet_list_store.h
...
svn path=/trunk/; revision=31083
2009-11-26 08:52:44 +00:00
f7425e276d
packet_list_get_widest_column_string() can return NULL, so check for this.
...
Use get_default_col_size() to get pixel size for string.
svn path=/trunk/; revision=31062
2009-11-24 00:16:26 +00:00
542a34ced8
Implement new_packet_list_recreate(). This should be reimplemented to
...
avoid building a new table and redissecting all packets.
svn path=/trunk/; revision=31024
2009-11-19 21:11:41 +00:00
cafad87fd9
From Stig:
...
Invalidate cfile.current_row instead(revert 30910).
svn path=/trunk/; revision=30925
2009-11-10 20:16:14 +00:00
989dcf58d1
In new_packet_list_select_cb() remove the check if the packet is reselected as the row number may be the same in a filtered
...
list as in the previous unfiltered list.
svn path=/trunk/; revision=30910
2009-11-09 21:32:32 +00:00
a7e3a1b3d9
Check if selected packet is already selected before doing any updates.
...
This was originally added in r26803 for the old packet list.
svn path=/trunk/; revision=30749
2009-10-28 22:17:18 +00:00
1c8f8b4f3d
Use prefs.col_list when writing recent entries for new packet list.
...
This is to avoid a mismatch between cfile.cinfo and prefs.col_list.
svn path=/trunk/; revision=30529
2009-10-12 07:55:24 +00:00
2d77aab376
Fix: jyoung SVN #30065 ; Sort order at start of new capture.
...
svn path=/trunk/; revision=30079
2009-09-22 20:09:04 +00:00
4827316ea4
- new_packet_list_resize_column() if we get an empty string from
...
packet_list_get_widest_column_string() (no visible row) don't
change the colum width.
- packet_list_moveto_end() selection no longer needed.
svn path=/trunk/; revision=30077
2009-09-22 19:36:14 +00:00
ffcaf32074
Select the first packet when doing a live capture. In the old packet list this is automatically done as the clist emits a selct-row signal.
...
Seting focus in new_packet_list_moveto_end() seems also to be needed to make it work properly I'm not 100% sure if it should be done differently.
svn path=/trunk/; revision=30074
2009-09-22 18:51:33 +00:00
08525e79d7
- Add new_packet_list_set_sel_browse()
...
- When scrolling to the end don't select the row.
svn path=/trunk/; revision=30065
2009-09-22 12:39:16 +00:00
60b4a9a3c5
Minor white space cleanup.
...
svn path=/trunk/; revision=30056
2009-09-21 20:20:02 +00:00
3ea9409792
Store 'color_filter' as const in 'frame_data'
...
svn path=/trunk/; revision=30051
2009-09-21 18:48:53 +00:00
7ca137e294
Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end
...
svn path=/trunk/; revision=30047
2009-09-21 18:09:19 +00:00
219ac9ebdd
Add a more verbose error printout.
...
svn path=/trunk/; revision=30031
2009-09-21 09:25:48 +00:00
4ac9d6b8c5
Try to fix(take II):
...
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened:
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.
svn path=/trunk/; revision=30027
2009-09-20 21:41:02 +00:00
f76fe1b808
From Jim Young via bug 4033:
...
With the "old" list if keyboard focus was initially in the details pane, the
use of the <F7>/<F8> keys will restore focus to details pane after the
prev/next move. Without this patch "new" packet list prev/next moves simply
moves focus to summary pane.
svn path=/trunk/; revision=30025
2009-09-20 19:39:54 +00:00
0474a38cc4
Add myself and Kovarththanan Rajaratnam as co authors.
...
svn path=/trunk/; revision=30006
2009-09-20 09:12:56 +00:00
8767b75876
Use G_STRLOC
...
svn path=/trunk/; revision=29991
2009-09-20 07:46:12 +00:00
b809359c65
Try to fix:
...
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened:
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.
svn path=/trunk/; revision=29989
2009-09-20 07:35:55 +00:00
3e9738ac89
Add support for opening separate packet window when you double-click on
...
a row in the packet list.
svn path=/trunk/; revision=29987
2009-09-19 22:51:42 +00:00
6e56815095
Set focus to packet list when a row is selected.
...
svn path=/trunk/; revision=29981
2009-09-18 14:01:10 +00:00
988b882948
Remove a cast.
...
svn path=/trunk/; revision=29974
2009-09-17 16:52:42 +00:00
3dbbc4cc4e
svn path=/trunk/; revision=29868
2009-09-11 20:36:01 +00:00
05519b323a
Reduce the spacing between new packet list items from 2 pixels to 1. If
...
we want the new packet list to look like the old packet list we'll have
to adjust the behavior of the cell renderer.
svn path=/trunk/; revision=29867
2009-09-11 19:13:39 +00:00
1e137770e6
Allocate col_text and col_text_len when the fdata struct is allocated.
...
svn path=/trunk/; revision=29817
2009-09-09 08:50:06 +00:00
de23d92163
Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter.
...
svn path=/trunk/; revision=29806
2009-09-08 19:00:54 +00:00
8d909ba79e
Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column()
...
svn path=/trunk/; revision=29782
2009-09-07 20:45:32 +00:00
4662b8c326
Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter
...
svn path=/trunk/; revision=29781
2009-09-07 19:50:19 +00:00
1ce02f035d
Add progress bar while constructing columns (which is time consuming)
...
svn path=/trunk/; revision=29777
2009-09-07 17:45:37 +00:00
4fbc99e411
Auto resize non frame_data based columns
...
svn path=/trunk/; revision=29766
2009-09-07 13:10:59 +00:00
0a09528611
Add initial implementation of new_packet_list_resize_columns() which just sets the column width according to the column format (work in progress)
...
svn path=/trunk/; revision=29762
2009-09-07 12:04:59 +00:00
5cc8d3e71d
col_fmt not needed.
...
svn path=/trunk/; revision=29760
2009-09-07 11:50:08 +00:00
7473e1e04c
Automatically adjust the time column width when time format changes.
...
svn path=/trunk/; revision=29758
2009-09-07 10:03:55 +00:00
2ab0685d8a
Make sure that we can enable/disable color filtering.
...
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12
svn path=/trunk/; revision=29728
2009-09-06 05:49:00 +00:00
e1eaab161d
Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort
...
svn path=/trunk/; revision=29717
2009-09-05 15:46:47 +00:00
583d41904c
Inline cache_columns()
...
svn path=/trunk/; revision=29716
2009-09-05 15:30:34 +00:00
4aa6c8baef
Remove dead code. We dont construct columns while reading the file. We do that when we have to display the frame
...
svn path=/trunk/; revision=29715
2009-09-05 15:25:53 +00:00
5a7d9922c1
Fetch old column width values if we have not initialized the packet list,
...
so we don't write zero width values if closing before loading a capture.
svn path=/trunk/; revision=29714
2009-09-05 14:37:02 +00:00
fcf25fe42b
Get rid of row_data_t
...
svn path=/trunk/; revision=29711
2009-09-05 13:27:34 +00:00
a71f9bbde3
Sort out some of the confusion r29706 introduced (visible vs. physical rows). We choose the wrong packet in the packet view because we used the physical row instead of the visible. I suspect there a couple more of these lurking.
...
svn path=/trunk/; revision=29708
2009-09-05 12:42:44 +00:00
95ddec4d07
Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible.
...
svn path=/trunk/; revision=29705
2009-09-05 10:36:29 +00:00
314b693828
Rename new_packet_list_reset_dissected to packet_list_reset_dissected
...
svn path=/trunk/; revision=29699
2009-09-04 17:42:03 +00:00
4930802fa1
Only store the last column as G_TYPE_POINTER. Hopefully this will soon make us able to sort again
...
svn path=/trunk/; revision=29690
2009-09-03 17:56:57 +00:00
5a8df08491
Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c
...
svn path=/trunk/; revision=29689
2009-09-03 17:39:42 +00:00
8a33ec23bb
Allocate and use an extra column at the end of the column list to indicate the 'magic' column which contains the _entire_ PacketListRecord
...
svn path=/trunk/; revision=29688
2009-09-03 17:00:17 +00:00
bd69669e1d
Make sure that we stop auto scroll if we start scrolling manually.
...
Caveat: we jump to first frame when auto scroll is stopped
svn path=/trunk/; revision=29685
2009-09-03 14:32:11 +00:00
7d2c55dc47
Adjusted int/uint check and fixed a comment in right justify check.
...
svn path=/trunk/; revision=29683
2009-09-03 10:50:30 +00:00
b462cace92
Right justify "Packet length", "Cumulative bytes" and custom columns
...
displaying numerical values.
svn path=/trunk/; revision=29682
2009-09-03 10:40:06 +00:00
865d14c43f
Right align COL_NUMBER.
...
svn path=/trunk/; revision=29681
2009-09-03 05:35:21 +00:00
7b916257bd
Don't set the minimum column width to the computed or stored value,
...
use a fixed minimum value and use the other as the size used to display the column.
svn path=/trunk/; revision=29680
2009-09-03 05:03:57 +00:00
47b766a998
Only try and select the last row if not already selected. This fix doesn't seem to work. Any suggestions?
...
svn path=/trunk/; revision=29677
2009-09-02 19:31:56 +00:00
283a4997ba
Mark unused parameter as such.
...
svn path=/trunk/; revision=29675
2009-09-02 19:15:02 +00:00
d96beaaecb
Trying to fix:
...
packets without color are randomly colorized.
svn path=/trunk/; revision=29673
2009-09-02 17:59:56 +00:00
cdd2959aa5
Adding new color rules should work now.
...
svn path=/trunk/; revision=29671
2009-09-02 17:51:48 +00:00
bc36849a9e
Add seperate new_packet_list_moveto_end() which scrolls to the end _without_ selecting the last packet.
...
svn path=/trunk/; revision=29670
2009-09-02 17:29:52 +00:00
6149d4be35
Make sure that we select the last row if autoscroll is enabled. The scrolling is still very jumpy. It seems that we always select the first packet before moving to the end.
...
svn path=/trunk/; revision=29668
2009-09-02 17:15:20 +00:00
1858d86612
Prepare abillity to add color filters with new packet list.
...
(Packets not recolored yet).
svn path=/trunk/; revision=29664
2009-09-02 15:07:03 +00:00
c5c569597b
In new_packet_list_append() all we need is in fdata.
...
svn path=/trunk/; revision=29657
2009-09-01 18:29:11 +00:00
5b3f74f9d5
We no longer store the column text in our record, so don't ever dereference the record column text pointer. In fact, remove it completely. This could cause a crash.
...
While there, throw in a few g_assert()'s.
svn path=/trunk/; revision=29653
2009-09-01 16:00:56 +00:00
1bc9f19f05
Add #include <stdio.h> in a few more places for Solaris.
...
svn path=/trunk/; revision=29577
2009-08-27 03:54:57 +00:00
2dd60e1b66
Custom columnfication:
...
* Deprecate COL_BSSGP_TLLI (GPRS BSSGP IE TLLI). Use bssgp.tlli
svn path=/trunk/; revision=29546
2009-08-25 05:42:14 +00:00
23d4eba3b1
Custom columnfication:
...
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta
svn path=/trunk/; revision=29524
2009-08-23 12:30:48 +00:00
b9cbd15469
Custom columnfication:
...
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative
svn path=/trunk/; revision=29523
2009-08-23 12:24:14 +00:00
55cf35e3a0
Custom columnfication:
...
* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci
svn path=/trunk/; revision=29522
2009-08-23 12:16:10 +00:00
51ca1739ae
Custom columfication:
...
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield
svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00
00670c55c6
Custom columfication:
...
* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid
svn path=/trunk/; revision=29517
2009-08-23 10:25:51 +00:00
205129d25c
Custom columfication:
...
* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys
svn path=/trunk/; revision=29516
2009-08-23 10:20:42 +00:00
56369978ae
Custom columfication:
...
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call
svn path=/trunk/; revision=29515
2009-08-23 09:52:57 +00:00
6b89de8393
Custom columfication:
...
* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority
svn path=/trunk/; revision=29513
2009-08-23 09:07:54 +00:00
1108352f00
Use col_text in frame data.
...
- colum-utils needs more work, based on
Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=29489
2009-08-21 10:12:47 +00:00
bbaf419559
Fix a memmory leak.
...
svn path=/trunk/; revision=29470
2009-08-19 06:04:30 +00:00
a47a4a5242
Add new_packet_list_recent_write_all().
...
svn path=/trunk/; revision=29469
2009-08-18 23:00:42 +00:00
3208870317
Make copy summary work for new_packet_list.
...
XXX The enum in .h file does not seem to work???
svn path=/trunk/; revision=29467
2009-08-18 14:40:51 +00:00
a1772b0197
Remove #if 0
...
svn path=/trunk/; revision=29455
2009-08-17 15:13:58 +00:00
a1a129abb5
Prepare to store column data from pinfo.
...
svn path=/trunk/; revision=29454
2009-08-17 15:05:43 +00:00
5b88477401
Add missing call to packets_bar_update() after thaw'ing
...
svn path=/trunk/; revision=29450
2009-08-16 15:33:05 +00:00
Anders Broman