osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
40,038 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

1599 Commits

Author SHA1 Message Date
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Jörg Mayer de68ad3066 H. Sivank <hsivank@gmail.com> 
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.


svn path=/trunk/; revision=34201
 2010-09-23 07:02:33 +00:00
Uwe Girlich 9a1c175692 interlink type is decimal 
some keyword substitution added

svn path=/trunk/; revision=34178
 2010-09-22 07:18:49 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
 2010-09-21 03:14:49 +00:00
Bill Meier 7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[]; 
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
 2010-09-17 04:51:21 +00:00
Jeff Morriss d2b84da490 prefs_register_string_preference() overwrites the given value pointer with a copy of the string. Since the string this dissector passes in is mallocated, keep a pointer to it and then free it after the pointer has been overwritten. 
svn path=/trunk/; revision=33872
 2010-08-21 03:44:36 +00:00
Bill Meier e600394937 (Trivial) Use consistent indentation; Whitespace cleanup. 
svn path=/trunk/; revision=33788
 2010-08-12 16:27:16 +00:00
Bill Meier 32ea9657c8 Add new expansion.h file left out of the previous commit. 
svn path=/trunk/; revision=33787
 2010-08-12 15:58:01 +00:00
Bill Meier ead0425688 From Don Newton: Added dissection of Expansion Module (KEM,GEM) messages to Unistim plugin. 
From me: Add expansion.h to list of .h files in Makefile.common;
         #include <stdio.h> not required.

svn path=/trunk/; revision=33786
 2010-08-12 15:47:31 +00:00
Jaap Keuter ccf61ec3b2 From Don Newton: 
Fails to decrement msg_len on 3 different message types which causes the
dissector to attempt to decode an addition or misplaced unistim cmd.

svn path=/trunk/; revision=33643
 2010-07-27 06:46:00 +00:00
Guy Harris 75ffa6bb71 The only reason to escape "%" in a string is if you are, incorrectly, 
passing a string directly to a routine that expects a format string. 
The correct way to handle that is to pass "%s" as the string.

As long as you're escaping non-printable characters, just let
tvb_format_string() handle that.

For null-terminated strings, get the length of the string with
tvb_strsize(), and then just put the string into the protocol tree as a
regular item.

svn path=/trunk/; revision=33482
 2010-07-09 21:27:08 +00:00
Gerald Combs bc9f8d0cd7 Add Visual C++ project files to the distribution. 
svn path=/trunk/; revision=33386
 2010-06-30 23:20:03 +00:00
Gerald Combs 423669df7d Back out r33088 for now. 
svn path=/trunk/; revision=33102
 2010-06-05 00:29:31 +00:00
Gerald Combs d123b9e737 Add a checkapis target. 
svn path=/trunk/; revision=33092
 2010-06-04 19:49:12 +00:00
Gerald Combs f6b2458924 From Matt Poduska via bug 1957 (with minor changes): 
New dissector (plugin) to support decode of the EPCglobal Low-Level Reader
protocol (see llrp.org for more information). This dissector has passed fuzz
testing.

svn path=/trunk/; revision=33088
 2010-06-04 18:45:02 +00:00
Guy Harris 1b444c55fd Refer to the endianness arguments as "encoding" rather than 
"representation" - we already use "representation" to refer to the text
representation of fields.

Change some routines with an endianness argument to make it a
representation argument instead; 

svn path=/trunk/; revision=32929
 2010-05-24 06:06:17 +00:00
Stig Bjørlykke aa6dc5e692 Fixed warning "Field width should have type 'int'". 
svn path=/trunk/; revision=32909
 2010-05-20 14:53:29 +00:00
Jaap Keuter eb6efdc4a4 Synchronize Makefiles even more. 
svn path=/trunk/; revision=32808
 2010-05-14 16:48:17 +00:00
Jeff Morriss 54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out. 
svn path=/trunk/; revision=32807
 2010-05-14 16:27:03 +00:00
Guy Harris 998677339e Create a new REP_NA value for fields where there are no representations 
from which to choose; use that for protocol fields in some protocols
(modify the CORBA generator to use it, and manually update the generated
CORBA dissectors accordingly).

svn path=/trunk/; revision=32777
 2010-05-13 00:20:40 +00:00
Jeff Morriss d85cc79af1 Add some information about how/why this dissector is (partially) machine-generated and what that means to Wireshark maintainers. 
svn path=/trunk/; revision=32577
 2010-04-27 13:50:43 +00:00
Jeff Morriss 85885007ef Make the OpcUa plugin's fields filterable (by giving them abbreviations). 
(Thank you, sed, for doing the 90% of the work for me.)

Note that two of these files says "do not modify" implying that they are
machine generated but AFAIK we don't have the means to rebuild them.

svn path=/trunk/; revision=32561
 2010-04-26 00:15:30 +00:00
Bill Meier 17b57d46d3 Simplify Makefile.nmake so that adding a new plugin to Makefile.nmake 
requires only adding the plugin (directory) name to a list of plugins.

svn path=/trunk/; revision=32516
 2010-04-19 14:38:20 +00:00
Jeff Morriss b09f79f414 Be sure we initialize the p_id in hf's. This fixes 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3010 .

Also finish the implementation of ShowTimes for GOGs so that the variable gets
initialized (preventing another uninitialized variable warning from Valgrind).

svn path=/trunk/; revision=32465
 2010-04-14 18:39:00 +00:00
Jeff Morriss ef2548d093 Fix up MATE's hf display values so MATE will actually run. 
svn path=/trunk/; revision=32464
 2010-04-14 14:20:16 +00:00
Anders Broman e611923124 Get rid of check_col(). 
svn path=/trunk/; revision=32428
 2010-04-08 15:51:44 +00:00
Anders Broman a10b76a99b Get rid of check_col(). 
svn path=/trunk/; revision=32426
 2010-04-08 15:21:07 +00:00
Bill Meier 5ccee6196a Remove some uneeded #includes 
svn path=/trunk/; revision=32419
 2010-04-07 18:24:18 +00:00
Anders Broman 846eed1d9e Get rid of check_col 
svn path=/trunk/; revision=32401
 2010-04-06 16:13:09 +00:00
Jeff Morriss a2241bf7b8 Don't use %s as the format string in val_to_str(). 
svn path=/trunk/; revision=32400
 2010-04-06 15:45:11 +00:00
Jeff Morriss 8f21d5c167 Don't use %s as the format string in val_to_str(). This fixes the fuzz failure in bug 4646. 
svn path=/trunk/; revision=32398
 2010-04-06 13:40:06 +00:00
Guy Harris 252178ed7e The third argument to val_to_str() is a format string that gets passed 
the value that couldn't be mapped to a string - it's an integer and
needs to be printed with an integer format.  Fixes bug 4644.

svn path=/trunk/; revision=32396
 2010-04-06 02:49:18 +00:00
Anders Broman 7cfa27b04b Get rid of a bunch of check_col(). 
svn path=/trunk/; revision=32388
 2010-04-05 20:04:52 +00:00
Jaap Keuter 9c05bc3bc5 Make the test compile. 
svn path=/trunk/; revision=32359
 2010-04-02 06:03:44 +00:00
Anders Broman dc5e066cae From sangaran: 
8-bit Bit Flag decoder method needed in wimaxasncp plugin dissecto.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4608

svn path=/trunk/; revision=32356
 2010-04-01 20:49:07 +00:00
Bill Meier beb8d29ad6 From Richard Kümmel: Added the bitmasks for port 10 and port 11. 
From me: As per Richard: Fix definitions of the bitfield for hf_esl_crcerror and
hf_esl_alignerror.

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3677#c10


svn path=/trunk/; revision=32324
 2010-03-29 16:52:47 +00:00
Jörg Mayer 96779de920 cmake changes: 
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
  This will make it easier to find matching plugin versions if
  files get just copied over.


svn path=/trunk/; revision=32231
 2010-03-18 10:27:17 +00:00
Kovarththanan Rajaratnam 2dc49da00d Some if (tree) cleanup 
svn path=/trunk/; revision=32207
 2010-03-16 07:53:48 +00:00
Kovarththanan Rajaratnam 4d2163dd3b Avoid some dead assignments 
svn path=/trunk/; revision=32206
 2010-03-16 07:49:13 +00:00
Kovarththanan Rajaratnam 737d0b5549 Whitespace cleanup 
svn path=/trunk/; revision=32205
 2010-03-16 07:45:12 +00:00
Kovarththanan Rajaratnam 4296471220 Indicate width of parent bitfield 
svn path=/trunk/; revision=32204
 2010-03-16 07:43:17 +00:00
Kovarththanan Rajaratnam 850aba71ac Inline truth/false table 
svn path=/trunk/; revision=32203
 2010-03-16 07:36:00 +00:00
Uwe Girlich c4d29dfd99 This adds a new dissector plugin: INTERLINK. This protocol is used in 
(real and simulated) BMW cars for all kinds of gadget communication.
My plugin only dissects the high level infrastructure and not any particular
messages. It uses a heuristic dissector to detect INTERLINK packets.

svn path=/trunk/; revision=32202
 2010-03-16 06:58:25 +00:00
Guy Harris 5535f4a598 Fix some compiler warnings, clean up indentation a bit. 
svn path=/trunk/; revision=32201
 2010-03-16 03:31:44 +00:00
Jörg Mayer 67072286bf - Remove the lib prefix for plugin names. 
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
  plugin's file name.

svn path=/trunk/; revision=31995
 2010-02-24 22:32:10 +00:00
Stig Bjørlykke 25dcd066b6 From Hannes Diethelm via bug 4525: 
Corrected values for IdentInfo (which was obviously wrong)

svn path=/trunk/; revision=31978
 2010-02-24 08:22:33 +00:00
Bill Meier c033a08313 Fix some gcc -Wshadow warnings. 
svn path=/trunk/; revision=31724
 2010-01-28 23:53:27 +00:00
Bill Meier bb79476b22 Fix gcc -Wshadow warning; 
Move proto_register... and proto_reg_handoff... to the end of the file.

svn path=/trunk/; revision=31723
 2010-01-28 23:11:54 +00:00
Bill Meier 1341fcd87e Fix some gcc -Wshadow warnings. 
svn path=/trunk/; revision=31722
 2010-01-28 21:49:30 +00:00
Bill Meier 2ea1e1962f Fix gcc -Wshadow warning. 
svn path=/trunk/; revision=31721
 2010-01-28 19:58:48 +00:00
Anders Broman 440c3f9261 From Didier Gautheron: 
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
 2010-01-13 20:32:01 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron: 
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
 2010-01-13 20:25:10 +00:00
Bill Meier de767f7dea Do some cleanup: 
- Separate .h file not req'd since not used elsewhere;
- Use bitmasks instead of using non-portable bitfields;
- Note possible incorrect display of crcError and alignError flags;
- Clean up spacing.

svn path=/trunk/; revision=31412
 2010-01-02 22:00:30 +00:00
Guy Harris 8e236e55de For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of 
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.

svn path=/trunk/; revision=31319
 2009-12-19 03:17:44 +00:00
Bill Meier 9587938020 From Martin Lutz: Patch tvb_memeql return check; 
... tvb_memeql returns 0 for truth.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3986#c7

svn path=/trunk/; revision=31294
 2009-12-17 16:22:50 +00:00
Jaap Keuter 0bd900a72b Fix header field names containing dots. 
Move excessive long texts to header field blurb.

svn path=/trunk/; revision=31207
 2009-12-08 22:05:55 +00:00
Gerasimos Dimitriadis c840cdd5a0 Remove the address operator from value_string arrays fed to VALS() 
svn path=/trunk/; revision=30995
 2009-11-17 18:35:27 +00:00
Jörg Mayer d2cc318f4f Beginnings of enabling static builds. Still to do: 
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua

svn path=/trunk/; revision=30987
 2009-11-17 11:58:36 +00:00
Jörg Mayer 9ee31d1d0e cmake will now honor -Werror if configured (default: on) 
svn path=/trunk/; revision=30852
 2009-11-07 10:07:00 +00:00
Ulf Lamping 06e6441c9e add "reserved for profiles" comments 
svn path=/trunk/; revision=30811
 2009-11-04 00:07:54 +00:00
Anders Broman 03c3b66945 From Benjamin Meyer: 
UserData in Profinet ProcessAlarm declared as UserStructIdentifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4195

svn path=/trunk/; revision=30808
 2009-11-03 20:11:19 +00:00
Anders Broman ecbe3c28f3 From Matthias FRANK: 
PROFIDrive parameter requests not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4193

svn path=/trunk/; revision=30804
 2009-11-03 12:30:59 +00:00
Anders Broman d0a15b4473 From Matthias FRANK: 
PROFISafe F-Parameter record not decoded in PROFINET dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4192
From me remove check_col();

svn path=/trunk/; revision=30801
 2009-11-02 18:09:46 +00:00
Stig Bjørlykke 9e4549de12 The stats_tree plugin deserves a version number other than "0.0". 
svn path=/trunk/; revision=30706
 2009-10-26 09:29:46 +00:00
Jeff Morriss 762af05327 Don't call PROTO_ITEM_SET_GENERATED(proto_tree_add[...]): that will end up adding the item to the tree multiple times. 
svn path=/trunk/; revision=30635
 2009-10-20 14:03:00 +00:00
Stig Bjørlykke a52bf035b7 Removed redundant redeclaration of delete_avpl(). 
svn path=/trunk/; revision=30618
 2009-10-19 14:42:10 +00:00
Stig Bjørlykke 8248955d7d Renamed tvb_new -> new_tvb to avoid name collision. 
svn path=/trunk/; revision=30617
 2009-10-19 14:36:26 +00:00
Stig Bjørlykke ce502fc59b Added cast to (void *) for pointers used in printf format %p. 
svn path=/trunk/; revision=30614
 2009-10-19 13:24:54 +00:00
Stig Bjørlykke d7ca2a6444 Initialize variables which may be used uninitialized. 
svn path=/trunk/; revision=30535
 2009-10-12 14:13:01 +00:00
Bill Meier 09393ee57d Replace GMemChunk usage with se_alloc(); 
Fixes memory leak for GLib > 2.8.

svn path=/trunk/; revision=30526
 2009-10-12 01:13:20 +00:00
Kovarththanan Rajaratnam 8b8399b711 Use register_dissector_files in the plugins dissectors 
svn path=/trunk/; revision=30435
 2009-10-09 16:39:34 +00:00
Kovarththanan Rajaratnam 6d93ca7c96 Use register_dissector_files in asn1 plugin 
svn path=/trunk/; revision=30434
 2009-10-09 16:33:16 +00:00
Anders Broman 4d2e653901 From Didier Gautheron: 
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
 2009-10-09 07:24:33 +00:00
Stig Bjørlykke c8605cc746 Don't include config.h in header files. 
svn path=/trunk/; revision=30382
 2009-10-07 06:28:36 +00:00
Stig Bjørlykke cf85342eec Build plugins with cmake on OSX. 
svn path=/trunk/; revision=30373
 2009-10-06 18:58:09 +00:00
Anders Broman b95ab896f7 From Benjamin Meyer: 
Profinet PDIRFrameData field FrameDetails not decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4091

svn path=/trunk/; revision=30321
 2009-10-04 19:34:48 +00:00
Anders Broman 7bff8c664b From Benjamin Meyer: 
PROFINET DCP ResetFactorySettings not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4090

svn path=/trunk/; revision=30320
 2009-10-04 19:31:02 +00:00
Kovarththanan Rajaratnam 0721ade9ed Remove check_col() 
svn path=/trunk/; revision=30317
 2009-10-04 18:40:44 +00:00
Kovarththanan Rajaratnam 80f0d3116a Use G_N_ELEMENTS instead of hard coding size of array 
svn path=/trunk/; revision=30315
 2009-10-04 18:29:51 +00:00
Kovarththanan Rajaratnam 09932ce535 Constify wimax_mac_calc_crc8() 
svn path=/trunk/; revision=30314
 2009-10-04 18:26:01 +00:00
Kovarththanan Rajaratnam 0c860d2cd5 Constify wimax_mac_calc_crc16() 
svn path=/trunk/; revision=30313
 2009-10-04 18:22:36 +00:00
Kovarththanan Rajaratnam 70d977764c Constify wimax_mac_calc_crc32() 
svn path=/trunk/; revision=30309
 2009-10-04 17:21:45 +00:00
Kovarththanan Rajaratnam c33111a841 Remove forward references 
svn path=/trunk/; revision=30308
 2009-10-04 17:12:42 +00:00
Kovarththanan Rajaratnam 86ca4a24b6 Move prototype to wimax_utils.h 
svn path=/trunk/; revision=30307
 2009-10-04 17:03:57 +00:00
Kovarththanan Rajaratnam 0bc65a23d0 Include wimax_utils.h 
svn path=/trunk/; revision=30306
 2009-10-04 16:57:04 +00:00
Guy Harris 0b17f67061 Until we either supply "yapp" or put "yapp" into the list of tools you 
need to install, don't include in Wireshark anything that requires "yapp".

svn path=/trunk/; revision=30154
 2009-09-25 20:05:16 +00:00
Jörg Mayer cbc3d3f772 Try to add tpg, but it seems it doesn't build with autofoo either. 
svn path=/trunk/; revision=30151
 2009-09-25 18:09:42 +00:00
Jörg Mayer 72ea6d56d2 Forgot to commit the unistim cmakefile 
svn path=/trunk/; revision=30145
 2009-09-25 15:29:15 +00:00
Jörg Mayer 6a2f689235 Fix build of make and asn1 plugins. 
svn path=/trunk/; revision=30144
 2009-09-25 15:17:45 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings 
* Remove check_col guards

svn path=/trunk/; revision=30127
 2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam 65c53fedb6 Don't guard col_append_str with check_col 
svn path=/trunk/; revision=30125
 2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam cf8138e195 Remove check_col() guard 
svn path=/trunk/; revision=30124
 2009-09-24 19:50:43 +00:00
Anders Broman 9ac672ca81 Update *.vcproj to visual studio 8 
svn path=/trunk/; revision=30111
 2009-09-24 05:11:47 +00:00
Kovarththanan Rajaratnam 124faf721c Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO 
svn path=/trunk/; revision=30089
 2009-09-23 14:52:01 +00:00
Kovarththanan Rajaratnam 633bb05380 Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL 
svn path=/trunk/; revision=30088
 2009-09-23 14:43:23 +00:00
Kovarththanan Rajaratnam 99624329fa Don't col_clear() followed by col_set_str(). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though) 
svn path=/trunk/; revision=30086
 2009-09-23 14:30:36 +00:00
Jörg Mayer ebfcf3c387 Build more plugins with cmake. 
svn path=/trunk/; revision=30084
 2009-09-23 04:41:14 +00:00
Kovarththanan Rajaratnam c28bafe341 Use col_set_str instead of col_add_fstr when adding constant strings to COL_INFO 
svn path=/trunk/; revision=30082
 2009-09-22 21:18:11 +00:00
Jörg Mayer 95182116aa CMake: 
- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

svn path=/trunk/; revision=30029
 2009-09-21 00:19:07 +00:00
Kovarththanan Rajaratnam 9441e9b344 Use tvb_get_ephemeral_stringz() instead of tvb_get_stringz() 
svn path=/trunk/; revision=30002
 2009-09-20 08:40:01 +00:00
Jörg Mayer 5a2247f5a3 Build a few more plugins 
svn path=/trunk/; revision=29942
 2009-09-16 06:30:03 +00:00
Bill Meier ed8483ae98 Save some memory: Don't statically allocate ett[] arrays used "dynamically". 
svn path=/trunk/; revision=29934
 2009-09-15 18:20:56 +00:00
Jörg Mayer 24fb135ffe Build the asn1 plugin. The only problem(?) is, that it is 
name libasn1.so instead of asn1.so

svn path=/trunk/; revision=29919
 2009-09-15 12:22:13 +00:00
Jeff Morriss 4661aad9a4 Run checkapi on the dissector header files 
svn path=/trunk/; revision=29883
 2009-09-13 19:48:22 +00:00
Kovarththanan Rajaratnam 2547ce21bf We no longer support the old plugin API so remove it completely from the build system 
svn path=/trunk/; revision=29821
 2009-09-09 14:01:57 +00:00
Gerald Combs ffd3a72374 Check our array lengths and refuse to process them if they're too large. 
Fixes bug 3986. Use tvb_memeql and proto_tree_add_item instead of
digging around in tvb->real_data.

svn path=/trunk/; revision=29813
 2009-09-09 00:18:15 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because: 
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
 2009-09-06 14:25:47 +00:00
Bill Meier 94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd. 
svn path=/trunk/; revision=29568
 2009-08-26 19:27:49 +00:00
Jaap Keuter ee9ef9f5cb Remove unneeded #includes. 
svn path=/trunk/; revision=29496
 2009-08-21 18:56:15 +00:00
Jaap Keuter bf580bfa14 Remove unneeded #includes. 
svn path=/trunk/; revision=29495
 2009-08-21 18:54:28 +00:00
Bill Meier 6f87844d0a (Minor) Remove unneeded #includes. 
svn path=/trunk/; revision=29492
 2009-08-21 14:36:27 +00:00
Kovarththanan Rajaratnam 27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere. 
svn path=/trunk/; revision=29490
 2009-08-21 11:03:30 +00:00
Jaap Keuter 929a92a454 From Geoffrey Kimball: 
DOCSIS 3.0 includes a new Bonded Initial Ranging Request (B-INIT-RNG-REQ) MAC
Management type (34).  A simple dissector is needed to decode this message.

svn path=/trunk/; revision=29487
 2009-08-20 19:41:53 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining() 
svn path=/trunk/; revision=29446
 2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 197d30a3b8 Use HFILL instead of hard coding the values 
svn path=/trunk/; revision=29431
 2009-08-15 11:21:36 +00:00
Kovarththanan Rajaratnam 2dfa5ccebe From Artem Tamazov via. 3899: 
Remove superfluous /MP

svn path=/trunk/; revision=29410
 2009-08-14 10:17:13 +00:00
Kovarththanan Rajaratnam 083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible. 
svn path=/trunk/; revision=29355
 2009-08-09 17:57:31 +00:00
Bill Meier d3174f0d03 (Trivial): Remove uneeded #includes; make a few fcns static; 
svn path=/trunk/; revision=29353
 2009-08-09 16:48:28 +00:00
Bill Meier 0a60e46adf 'if(proto_... == -1)' not req'd; Don't register ett[] more than once; 
svn path=/trunk/; revision=29351
 2009-08-09 15:07:35 +00:00
Kovarththanan Rajaratnam ac463d2697 Don't guard col_clear with col_check 
svn path=/trunk/; revision=29346
 2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29345
 2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check 
svn path=/trunk/; revision=29344
 2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check 
svn path=/trunk/; revision=29342
 2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam 24ca3c44c9 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29341
 2009-08-09 06:47:24 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Gerald Combs 53a24d94f9 Check TLV lengths before we try to add them to the tree. Fixes bug 3824. 
svn path=/trunk/; revision=29338
 2009-08-08 22:20:08 +00:00
Guy Harris 3d1e81ff3d Fix typo. 
svn path=/trunk/; revision=29300
 2009-08-05 00:13:38 +00:00
Guy Harris 6847b0b94d Put the initializers for the elements of value_string arrays into curly 
brackets, so the API checks for non-terminated value_string arrays will
not falsely think the arrays are non-terminated.

svn path=/trunk/; revision=29299
 2009-08-04 23:14:40 +00:00
Bill Meier 8589c2f11b Minor changes: 
- Move proto_register...() to the end of the file as per convention;
- Move ett[] to be local to proto_register...();
- "if (...==-1)" not req'd in proto_register...();
- #include <moduleinfo.h> not req'd;
- Remove unneeded forward declarations.

svn path=/trunk/; revision=29296
 2009-08-04 19:01:34 +00:00
Gerald Combs 9bc8469d96 Remove a couple of unused variables. 
svn path=/trunk/; revision=29286
 2009-08-03 23:50:55 +00:00
Gerald Combs 5bbd304601 Add some null checks. 
svn path=/trunk/; revision=29285
 2009-08-03 23:49:05 +00:00
Bill Meier 42a4efbb59 More minor cleanups: 
- Move proto_register to near the end of the file as per convention;
- Remove unneeded #include <epan/reassemble.h>;
- Comment out unused ett[] array and associated;

svn path=/trunk/; revision=29284
 2009-08-03 23:18:59 +00:00
Bill Meier b9b8fad812 Minor cleanups: 
- Comment out code which creates two dissector tables and then
   stores a preference value in each of them; 
   AFAICT the tables are not accessed elsewhere;
- Comment out the no longer required prefs callback specification
   in proto_register;
- "if (... == -1)" not req'd in proto_register;
- Remove unused proto_reg_wimax function.

svn path=/trunk/; revision=29283
 2009-08-03 22:38:43 +00:00
Bill Meier d6e5235eb4 Various minor cleanups: 
- Do all find_dissector() calls only once during proto_reg_handoff 
   (not each time a sub-dissector is called when dissecting frames).
- Move proto_register & proto_reg_handoff to the end of the file as per convention;
- Move a global variables to be local;
- Change a global variable to be static; 
- Remove unneeded multiple #include <string.h>
- Remove an unneeded variable and a few unneeded lines of code.

svn path=/trunk/; revision=29282
 2009-08-03 22:09:08 +00:00
Bill Meier cc3a2c97a8 Use find_dissector() instead of create_dissector_handle(); 
Fix some indentation.

svn path=/trunk/; revision=29273
 2009-08-03 16:18:06 +00:00
Anders Broman 617077e94a From Benjamin Meyer: 
Profinet dissector does not decode all defined error codes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753

svn path=/trunk/; revision=29150
 2009-07-21 06:08:45 +00:00
Stig Bjørlykke 221225e0f3 From Kovarththanan Rajaratnam via bug 3719: 
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.

From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.

svn path=/trunk/; revision=29137
 2009-07-18 20:10:14 +00:00
Anders Broman 1196da707d From Rajasekhar Reddy Gali: 
packet-wimaxasncp.c file need to update with latest wimax spec.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730

svn path=/trunk/; revision=29125
 2009-07-16 21:27:56 +00:00
Anders Broman 91caa01090 Add /MP flag to make use of multi cores. 
svn path=/trunk/; revision=29104
 2009-07-15 20:55:31 +00:00
Stig Bjørlykke 618d8b517a Removed header_field.h 
svn path=/trunk/; revision=28999
 2009-07-07 20:40:28 +00:00
Bill Meier 4a3f420843 Fix the esl protocol enable/disable handling issue introduced in SVN #28986: 
Use the standard "if (!initialized)..." logic in proto_reg_handoff().
Also: use "true_false_string flags_yes_no" as in the original patch.

svn path=/trunk/; revision=28994
 2009-07-07 17:03:11 +00:00
Bill Meier eac1f47fad Various fixes: 
1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin;
2. proto_reg_handoff: remove unneeded code;
3. Change the prefs callback to call a function which just enables/disables
   the protocol; (using proto_reg_handoff means that the dissector
   was re-registered each time the pref was changed);
4. packet-esl.h: use #if 0 instead of /* ... */ to comment out code;

svn path=/trunk/; revision=28986
 2009-07-07 14:26:38 +00:00
Stig Bjørlykke 87d24c9101 From Kovarththanan Rajaratnam: 
Remove trailing spaces in protocol/field names

svn path=/trunk/; revision=28978
 2009-07-07 11:37:15 +00:00
Stig Bjørlykke 09218f7338 From Richard Kummel: 
- New dissector for EtherCAT Switch Link Header added to EtherCAT plugin
- Changed filtering of EtherCAT commands to the abbreviated form:
  e.g. ecat.cmd = APWR

From me:
- Mark unused variables
- Fixed a string warning
- Do not initialize a static struct
- Use tfs_yes_no
- Reorder files in Makefile

svn path=/trunk/; revision=28976
 2009-07-07 11:13:22 +00:00
Stig Bjørlykke 7881d1ccd7 From Kovarththanan Rajaratnam: 
More FT_XXX cleanup.

svn path=/trunk/; revision=28970
 2009-07-07 09:00:33 +00:00
Stig Bjørlykke 6d472a50fc From Kovarththanan Rajaratnam via bug 3548: 
Minor hf cleanup.

svn path=/trunk/; revision=28968
 2009-07-07 07:46:57 +00:00
Stig Bjørlykke 3a6e56c25a From Kovarththanan Rajaratnam via bug 3548: 
Move header_field.h into packet-unistim.c to align it with all other
dissectors.

svn path=/trunk/; revision=28967
 2009-07-07 07:45:32 +00:00
Ulf Lamping ea7fa021fa fix install step 
svn path=/trunk/; revision=28945
 2009-07-06 09:46:28 +00:00
Michael Tüxen 9518d53ab4 Make the compiler on Mac OS X happy... 
svn path=/trunk/; revision=28934
 2009-07-03 10:29:45 +00:00
Ulf Lamping d180d37c8d update to the latest PROFINET drafts 
(defragmentation of RT fragments "FRAG-PDU" is still not implemented)

svn path=/trunk/; revision=28932
 2009-07-03 09:12:43 +00:00
Stig Bjørlykke 8531980952 From Kovarththanan Rajaratnam: 
More hf_register_info related cleanup.

svn path=/trunk/; revision=28832
 2009-06-24 02:17:12 +00:00
Stig Bjørlykke b11f44c741 From Kovarththanan Rajaratnam: 
Move hf_register_info declarations in packet-m2m.c to function scope

svn path=/trunk/; revision=28831
 2009-06-24 02:12:13 +00:00
Stig Bjørlykke 7f77783e20 From Kovarththanan Rajaratnam: 
More header field info cleanup in plugins/* and epan/dissectors/*

svn path=/trunk/; revision=28811
 2009-06-22 18:23:58 +00:00
Stig Bjørlykke f8c959dc8c From Kovarththanan Rajaratnam: 
Move header field info declarations into function scope.

This is the first step. Another patch will be submitted which actually scrubs
the header field info declarations (remove empty blurbs, etc.)

svn path=/trunk/; revision=28797
 2009-06-22 04:58:08 +00:00
Stig Bjørlykke 2bba6be84f From Kovarththanan Rajaratnam via bug 3548: 
Cleanup header_field_info in plugins.

svn path=/trunk/; revision=28771
 2009-06-18 23:22:10 +00:00
Jörg Mayer c321f29518 Trivial warning fixes: 
- Might be used uninitialized
- not a prototype
- comma at end of enum


svn path=/trunk/; revision=28730
 2009-06-15 02:34:53 +00:00
Stig Bjørlykke 0e1dc62fb0 Added missing $Id$ and convert to correct eol-style. 
svn path=/trunk/; revision=28678
 2009-06-09 21:30:41 +00:00
Guy Harris cf91fdf16b Have tap listeners specify whether the "packet" routine requires 
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
 2009-06-05 22:42:47 +00:00
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics. 
svn path=/trunk/; revision=28415
 2009-05-19 18:42:33 +00:00
Anders Broman fbd05f0fce Apply some of the patches from: 
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28355
 2009-05-13 19:44:44 +00:00
Bill Meier 3c84c0170e FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...). 
svn path=/trunk/; revision=28318
 2009-05-08 20:45:29 +00:00
Jaap Keuter f6122af9be From Reinhard Speyerer: 
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28205
 2009-05-01 06:59:37 +00:00
Jaap Keuter b7dc0a3e51 From Reinhard Speyerer: 
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28204
 2009-05-01 06:58:28 +00:00
Gerald Combs 17f0d877fa Fix Win64 compilation problems in the plugins directory. 
svn path=/trunk/; revision=28064
 2009-04-16 03:38:23 +00:00
Bill Meier 321506c076 (Trivial) Fix some spelling & etc in comments 
svn path=/trunk/; revision=27996
 2009-04-08 13:41:30 +00:00
Jaap Keuter 664ab35c79 Add missing header file of OpcUa plugin update. 
svn path=/trunk/; revision=27978
 2009-04-06 20:29:01 +00:00
Jaap Keuter 8ecf459611 From Gerhard Gappmeier: 
This patch updates the plugin to fit the released OPCUA protocol version.

svn path=/trunk/; revision=27974
 2009-04-06 18:30:04 +00:00
Bill Meier a0eee8c299 Replace some unnecessary use of g_snprintf and g_strdup_printf 
svn path=/trunk/; revision=27864
 2009-03-27 14:46:54 +00:00
Bill Meier e284ca63d5 (Minor): Remove unnecessary use of g_snprintf 
svn path=/trunk/; revision=27863
 2009-03-27 14:30:51 +00:00
Ulf Lamping f681477e33 remove GPLv2 CRC code, the new epan CRC stuff is working well 
svn path=/trunk/; revision=27803
 2009-03-20 10:44:42 +00:00
Gerald Combs dd903ca9c8 Create an "epan/crc" directory for CRC code. Add crc-16-plain.[ch], 
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.

Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.

svn path=/trunk/; revision=27790
 2009-03-18 21:59:30 +00:00
Bill Meier 4f34bb9b15 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1]; 
- As suggested actually use sizeof(...) rather than a numeric constant.
  - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.

svn path=/trunk/; revision=27772
 2009-03-18 15:03:46 +00:00
Ulf Lamping 870e139576 fix type 
svn path=/trunk/; revision=27749
 2009-03-16 22:36:34 +00:00
Ulf Lamping dcdda03610 update to the latest PROTINET changes: 
- add SubFrameBlock dissection
- add subframe heuristics and dissection
- update frame id "layout"
- raise plugin version to 0.2.4

crc16 algorithm copied from Linux sources (GPL V2 only!)

svn path=/trunk/; revision=27748
 2009-03-16 21:40:00 +00:00
Gerald Combs be943c8419 Go a little deeper into the Win64 rabbit-hole. Add tools/native-nmake.cmd 
and use it as a wrapper to compile a native version of lemon.
Untested on Win32.

svn path=/trunk/; revision=27734
 2009-03-15 22:40:29 +00:00
Gerald Combs 57dadc4664 More Windows compiler flag cleanups. Fix a problem with my last commit 
that would break compilation for older compilers. Create a "DLL_LDFLAGS"
variable and use it in DLLs and plugins. Use PLUGIN_LDFLAGS and
DLL_LDFLAGS where needed. Don't force i386 code in the TPG plugin.

svn path=/trunk/; revision=27582
 2009-03-02 21:33:11 +00:00
Gerald Combs 07e5df616e Disable manifest building for our DLLs. This attempts to fix bug 3272. 
svn path=/trunk/; revision=27579
 2009-03-02 18:57:35 +00:00
Jaap Keuter ace93cb4bb From Robert Groenenberg: 
As of version 0.99.8, there has been an annoying problem in the ASN.1 dissector: 
when using a 'type table' which discribes the ASN.1 syntax of the traced packets, 
wireshark would crash on the very first packet. The cause for the crash is an out-of-
boundry write, detected by g_free().

svn path=/trunk/; revision=27507
 2009-02-22 12:22:28 +00:00
Jaap Keuter 23461c4382 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27506
 2009-02-22 12:01:19 +00:00
Jaap Keuter 9da243b13c Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27505
 2009-02-22 11:43:37 +00:00
Jaap Keuter 4683efcfe2 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27504
 2009-02-22 11:25:16 +00:00
Jaap Keuter 80863f9568 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27503
 2009-02-22 11:10:29 +00:00
Jaap Keuter 9fb248f1c0 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27502
 2009-02-22 10:52:05 +00:00
Jaap Keuter 03bbd18a0b Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27501
 2009-02-22 10:29:14 +00:00
Jaap Keuter eb77f8a35e Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27500
 2009-02-22 10:04:39 +00:00
Jaap Keuter 1948ad3985 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27499
 2009-02-22 09:41:05 +00:00
Jaap Keuter b171a36a4f Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27498
 2009-02-22 09:24:27 +00:00
Jaap Keuter 56a1139bc0 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27497
 2009-02-22 09:09:27 +00:00
Jaap Keuter 663f835c1e Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27496
 2009-02-22 00:04:14 +00:00
Jaap Keuter 47f31f3f91 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27495
 2009-02-21 22:22:16 +00:00
Jaap Keuter 715fd1d169 Incorporate plugin dissector into build in collection. 
svn path=/trunk/; revision=27492
 2009-02-21 20:22:40 +00:00
Jaap Keuter 60d78eefcf Update the documentation to reflect the current state of plugin development. 
svn path=/trunk/; revision=27491
 2009-02-21 16:33:48 +00:00
Jaap Keuter cfd0be516b Rename source file to reflect Cisco specific protocol. 
svn path=/trunk/; revision=27481
 2009-02-18 07:46:28 +00:00
Jaap Keuter 56f631f9d0 Correct copyright statements. 
svn path=/trunk/; revision=27480
 2009-02-18 07:20:26 +00:00
Ulf Lamping f904f42f9d Remove an ugly hack: 
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created.

Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group.

svn path=/trunk/; revision=27407
 2009-02-10 03:54:55 +00:00
Tomas Kukosa 79e68576f0 - remove reference to AMR (submitted by mistake) 
- add new lines at the ends of headers
- fix struct usage

svn path=/trunk/; revision=27401
 2009-02-09 12:54:40 +00:00
Stig Bjørlykke 863674322d From Peter Johansson: 
Correct a misspelling.

svn path=/trunk/; revision=27399
 2009-02-09 10:29:17 +00:00
Ulf Lamping 043532d63e add missing mt.exe calls, to include manifest files into exe / dll files 
svn path=/trunk/; revision=27357
 2009-02-02 23:09:36 +00:00
Guy Harris 2ba37de400 Fix uninitialized variable. 
More indentation cleanups.

svn path=/trunk/; revision=27306
 2009-01-26 23:48:10 +00:00
Guy Harris 248db0a42a Non-constant strings should not be used as format items; the format 
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.

Clean up indentation.

svn path=/trunk/; revision=27304
 2009-01-26 22:58:47 +00:00