Commit graph

275 commits

Author SHA1 Message Date
Ronnie Sahlberg
e55dcb785e prettify ftam by puttign the command name in the info column
svn path=/trunk/; revision=14759
2005-06-26 06:16:03 +00:00
Ronnie Sahlberg
3a51ba4293 make dissect_ber_choice take a guint* that will return the
index of the branch taken or -1  to make prettifications easier to implement.


change the signature of dissect_ber_choice and rename it to dissect_ber_CHOICE to catch all
occurences of the use of this function

update asn2eth to use the new name/signature

update all occurences of this function to the new name and new signature.



svn path=/trunk/; revision=14758
2005-06-26 05:48:50 +00:00
Ronnie Sahlberg
ae7413d740 some updates for CMIP.
note taht cmip does not yet compile due to a possible asn2eth compiler bug


svn path=/trunk/; revision=14756
2005-06-25 23:12:24 +00:00
Anders Broman
788d843a9d Major rewrite to update to version TS 129 002 V6.9.0
svn path=/trunk/; revision=14748
2005-06-25 17:25:44 +00:00
Ronnie Sahlberg
12c6e46a49 new FTAM dissector generated by asn2eth
svn path=/trunk/; revision=14747
2005-06-25 12:40:53 +00:00
Ronnie Sahlberg
d0a7c6efcd Make ACSE export the EXTERNAL construct since both CMIP and FTAM rely on it.
svn path=/trunk/; revision=14746
2005-06-25 07:46:14 +00:00
Anders Broman
104bc44dbd From Valery Vybornov:
add register_dissector to packet-tcap.c

svn path=/trunk/; revision=14737
2005-06-23 22:15:47 +00:00
Ronnie Sahlberg
a52b44c54b fix for CMIP, we should set the opcode_type BEFORE we try to use it in the subdissector,
it doesnt work really that well if we have opcode_type set to INVOKE   from the previous packet and this new packet contains a ReturnResult.



svn path=/trunk/; revision=14733
2005-06-23 09:28:46 +00:00
Ronnie Sahlberg
1a663222b4 only create the ACSE protocol tree if there is an ACSE layer present.
do not create it if it is just a SES_DATA_TRANSFER PDU


svn path=/trunk/; revision=14726
2005-06-22 08:28:59 +00:00
Ronnie Sahlberg
5a3ff9906c remove a dissector table we no longer use from ACSE
and also from the CMIP and FTAM dissectors that tried to register against it.

Implement a workaround for the asn2eth bug (can not yet handle tagged assignments) to the conformance file and remove the warnings from the template file.

Since workaround is implemented in conformance file, make make copy_files install the dissector instead of printing a warning message.



svn path=/trunk/; revision=14725
2005-06-22 08:15:18 +00:00
Ronnie Sahlberg
33f4400f83 the maximum ASN OID length is 256 bytes and there is a define to control this.
fix bug251 and all other occurances where an oid string  passed to packet_ber_object_identifier()
is not defined as foo[MAX_OID_STR_LEN]

svn path=/trunk/; revision=14720
2005-06-21 09:38:59 +00:00
Luis Ontanon
bfa7197fcf if exists call the h248term subdissector.
svn path=/trunk/; revision=14717
2005-06-20 21:21:06 +00:00
Ronnie Sahlberg
5f334f7f7b move two functions that are not used by tcap and only used by gsm_a and gsm_ss into gsm_ss.
remove the include <epan.asn1.h> from tcap since it no longer needs that file.

only 9 dissectors remain that use asn1.h



svn path=/trunk/; revision=14710
2005-06-20 07:18:10 +00:00
Ronnie Sahlberg
a0a9d9ec06 add Sids email as the original author of ACSE dissector
svn path=/trunk/; revision=14707
2005-06-20 02:37:42 +00:00
Anders Broman
fa82445742 Update some OID:s and add some ASN1 code from ETSI TS 129 002 V5.7.0.
Will regenerate later.

svn path=/trunk/; revision=14704
2005-06-19 21:11:52 +00:00
Ronnie Sahlberg
fddc09d930 New autogenerated ACSE dissector.
There is a bug in ASN2ETH which means one can not do make copy_files
instead one needs to change two bugs in the generated code manually.
These two changes are in the comment at the top of the template/generated file


svn path=/trunk/; revision=14698
2005-06-19 11:51:23 +00:00
Ronnie Sahlberg
f8a0c37aca register cmip as ber oid dissector
svn path=/trunk/; revision=14697
2005-06-19 11:49:16 +00:00
Guy Harris
ddbee0ffd0 Clean up white space.
Register "standard" and "lock_info_col" as obsolete preferences, so
they're silently ignored rather than triggering warnings.

Propagate changes to check for "dissect_ber_octet_string()" supplying a
null tvbuff pointer from the checkins to the generated dissector ("Do
not modify this file" means "Do not modify this file"!) to the tcap.cnf
file, so that they're not lost if the dissector is regenerated.  (Don't
propagate the checks for "tvb_new_subset()" returning null - it never
returns null.)

Pass -1 to "tvb_new_subset()" when appropriate.

When looping over packet data, check against the reported length, not
the captured length, so we indicate a short frame if we get stopped by
the snapshot length.

Get rid of unused variables.

svn path=/trunk/; revision=14658
2005-06-16 07:46:03 +00:00
Jörg Mayer
2073fb5b5b No // comments
svn path=/trunk/; revision=14625
2005-06-14 13:35:24 +00:00
Anders Broman
e92c34b0f9 From Olivier Jacques,
- beautify TCAP decoding without upper dissector associated.
With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output

svn path=/trunk/; revision=14591
2005-06-08 18:53:11 +00:00
Anders Broman
05f62aae78 Cahnge ssn range
svn path=/trunk/; revision=14586
2005-06-08 05:06:30 +00:00
Anders Broman
58f30b265f Some fixes from Tim Endean
svn path=/trunk/; revision=14579
2005-06-07 20:30:04 +00:00
Tomas Kukosa
285d26c3e7 Usage of new #.FN_PARS directive instead of #.FN_BODY
svn path=/trunk/; revision=14576
2005-06-07 12:05:03 +00:00
Anders Broman
bdf3f907e9 From Tim Endean:
- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

svn path=/trunk/; revision=14574
2005-06-07 05:50:28 +00:00
Anders Broman
d89f479bbf From Tim Endean:
- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

svn path=/trunk/; revision=14573
2005-06-07 05:49:57 +00:00
Anders Broman
75ab9e7ad2 Let the sub dissector use the top tree.
svn path=/trunk/; revision=14571
2005-06-06 20:42:18 +00:00
Luis Ontanon
acdc3d771a - make sure there's something to add to colinfo.
- auditValueRequest is a request too

svn path=/trunk/; revision=14567
2005-06-06 18:51:05 +00:00
Anders Broman
02d9d606d2 Add makefile.nmake
svn path=/trunk/; revision=14564
2005-06-06 17:40:07 +00:00
Anders Broman
e490b40a24 Add the asn2eth generated TCAP dissector made by Tim Endean to the SVN tree.
svn path=/trunk/; revision=14561
2005-06-06 15:39:20 +00:00
Gerald Combs
12b7466381 From Steve Grubb: Fix a memory leak.
Don't pass a null to atoi().

Fixes part of bug 217.

svn path=/trunk/; revision=14495
2005-05-30 20:55:16 +00:00
Anders Broman
f462883ea8 Warning fix:
packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined
do this change also for the template file.

svn path=/trunk/; revision=14421
2005-05-23 18:37:45 +00:00
Luis Ontanon
bc1292ff1d some cosmetic fixes
svn path=/trunk/; revision=14401
2005-05-20 19:38:24 +00:00
Anders Broman
e1771e4342 Display version number and product number as strings.
svn path=/trunk/; revision=14397
2005-05-19 20:32:58 +00:00
Anders Broman
a78403ed18 Make it possible to dissect h221nonstandarddata and fix some errors from the new asn2eth generator.
svn path=/trunk/; revision=14387
2005-05-17 20:30:49 +00:00
Anders Broman
8198cbe9ec From Tim Endean:
Ss-code is Optional in some cases.

svn path=/trunk/; revision=14370
2005-05-15 21:15:53 +00:00
Luis Ontanon
1eeda6e946 - make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets
- set COL_INFO to something useful


svn path=/trunk/; revision=14361
2005-05-13 11:16:05 +00:00
Anders Broman
d87981ccb6 Reinsert Gerards patch (r14342) which was lost.
svn path=/trunk/; revision=14351
2005-05-11 22:19:36 +00:00
Anders Broman
00bd7965b2 pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages.
svn path=/trunk/; revision=14348
2005-05-11 21:46:16 +00:00
Luis Ontanon
5535853bf2 - export Audio Codec modes from isup/bicc
- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0)
- use it for H.248


svn path=/trunk/; revision=14343
2005-05-10 21:54:37 +00:00
Anders Broman
01adac2ffe Fix dissection of mt-forwardSM.
svn path=/trunk/; revision=14341
2005-05-10 20:06:04 +00:00
Anders Broman
b782032c1e fix some field rename errors turned up by the latest asn2eth compiler.
svn path=/trunk/; revision=14340
2005-05-10 20:02:14 +00:00
Lars Roland
20901fcedf only lower-case ASCII letters, numbers,
underscores, and dots are allowed in the
preference name. 

Fix it the camel dissector.

svn path=/trunk/; revision=14333
2005-05-09 00:11:03 +00:00
Anders Broman
513b781676 From Javier Acuna:
Added some code to dissect DateAndTime.

svn path=/trunk/; revision=14327
2005-05-08 20:34:57 +00:00
Anders Broman
c1a1967218 Add dissection of Q.850 cause.
svn path=/trunk/; revision=14274
2005-05-02 18:32:57 +00:00
Gerald Combs
082651c83e Define a maximum OID string length, and use it in a lot of places. Fixes a
buffer overflow found while fuzz testing.

svn path=/trunk/; revision=14169
2005-04-22 21:17:13 +00:00
Ronnie Sahlberg
b95490206d from Olivier J
bugfix for IMPLICIT NULL in BER sequences
and gsmmap updates



svn path=/trunk/; revision=14160
2005-04-21 21:37:23 +00:00
Ronnie Sahlberg
20a4d3257e Add a tree parameter to get_ber_length() so that
IF the length seems bogus, like longer than the reported tvb_length
we add a helpful text item to the tree  and generate a [malformed packet]


change all callers of get_ber_length to the new signature.



svn path=/trunk/; revision=14145
2005-04-20 08:35:47 +00:00
Anders Broman
7846adc5ad From Olivier Jacques:
- Add bearerServiceCodes decoding
- Fixed sendRoutingInfoForSM and reportSM-DeliveryStatus invoke decoding (argument mismatch)

svn path=/trunk/; revision=14090
2005-04-15 08:29:50 +00:00
Anders Broman
3a4e795c5e From Olivier Jacques:
- Adds callingPartyNumber and CalledPartyNumber parameter dissection uing ISUP dissector
- Adds IMSI and ISDN-AddressString parameter dissection
- A lot of changes in the .asn file to sort it, handle more parameters and error codes - contributed by Javier Acuna [javier.acuna@sixbell.cl]

svn path=/trunk/; revision=14087
2005-04-15 08:18:15 +00:00
Gerald Combs
2f3a371613 In dissect_h245_OpenLogicalChannelCodec(), make sure codec_type exists before
trying to access its contents.

svn path=/trunk/; revision=14072
2005-04-14 04:26:00 +00:00