Commit Graph

3178 Commits

Author SHA1 Message Date
Guy Harris 3c01b45ac2 Show dBm and dB signal and noise values differently, so that the user
knows what they're getting.

svn path=/trunk/; revision=15528
2005-08-25 08:16:08 +00:00
Ronnie Sahlberg 7acbc26396 when tracking PDU bondaries, only do this IFF
the next few bytes match an SMB header.

1,  SMB is the only important protocol transported atop NBSS
2, if we miss the first packets of a PDU, we DONT! want nbns to suddenly think  there are Xmegabytes until the end of it and thus prevent any real PDUs from being dissected.



svn path=/trunk/; revision=15527
2005-08-25 07:45:57 +00:00
Guy Harris 9b4994afcd I missed one OID string.
svn path=/trunk/; revision=15526
2005-08-25 03:43:16 +00:00
Guy Harris bcb91d2f45 The OID strings returned by new_format_oid(), and the OID string
returned by format_oid(), are allocated with the ep_alloc routines;
don't free them.

svn path=/trunk/; revision=15525
2005-08-25 03:31:54 +00:00
Guy Harris bd8c6df460 "sprint_realloc_objid()" expects to be handled a malloced buffer, so
hand it one (and check for malloc failures), and it returns a malloced
or realloced buffer, so free it when we're done.

That means that routines that use it can return/supply back a null
pointer, so check for that.

Don't ep_allocate fixed-length buffers for formatted OID information,
allocate one that's 'big enough".

svn path=/trunk/; revision=15524
2005-08-25 03:28:31 +00:00
Ulf Lamping 6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Gerald Combs ef81f7d060 Properly initialize our hf_ arrays. Make hf_rtcp_app_poc1_conn_session_type
an FT_UINT8 instead of an FT_BOOLEAN.  This keeps the Solaris builder from
crashing while running "-G values".

svn path=/trunk/; revision=15519
2005-08-24 20:34:15 +00:00
Ulf Lamping 4b0b7448fd fix a comment typo
svn path=/trunk/; revision=15518
2005-08-24 18:35:54 +00:00
Guy Harris f95233a889 The name in a Display TLV is null-terminated (or padded with a null byte
and extra crud).

Don't bother with length checking on the VLAN name item - if it's
zero-length, so be it.

svn path=/trunk/; revision=15516
2005-08-23 08:49:57 +00:00
Guy Harris a7933c7cc5 Use "format_text()" and "tvb_format_text()" when displaying strings.
(It's not necessary, or desirable, to use them when fetching strings.)

When processing a VLAN TLV, check the length of the TLV, so we don't end
up running past the end of the TLV and getting a negative remaining
length.  Append to the protocol tree item for the TLV, and the Info
column, as we dissect the VLAN ID and VLAN name fields.

svn path=/trunk/; revision=15515
2005-08-23 08:34:19 +00:00
Guy Harris 9fa5d5fd9e Fix the parenthesization of an expression.
svn path=/trunk/; revision=15514
2005-08-23 08:01:46 +00:00
Luis Ontanon 9362605183 Two fixes to tektronix k12 import:
- it appears that there are more packet record types other than 0x00010020.
     accept anything matching 0x00010020/28 as a packet record.

- make the stack filename lowercase before comparing it so that capitalization is not an issue.


svn path=/trunk/; revision=15513
2005-08-22 23:11:48 +00:00
Jörg Mayer 412ae3d09d Length of string == lengt of element - headerlength
svn path=/trunk/; revision=15512
2005-08-22 17:48:17 +00:00
Anders Broman bdec656b1a From Timo Metsala:
Updates the  PoC floor control parsing to comply to the latest version of the 
specification. 

svn path=/trunk/; revision=15511
2005-08-22 16:26:29 +00:00
Anders Broman 1f0b3d1d38 Fix decoding of sendIdentificationArg/Res and ProvideSubscriberLocation
svn path=/trunk/; revision=15510
2005-08-22 16:19:31 +00:00
Guy Harris 86ea8b88f3 Add a "time_stat_init()" routine to initialize the fields of a
"timestat_t".

Move "nstime_to_msec()" to "epan/nstime.c", as it has nothing to do with
a "timestat_t".

Use structure assignment when possible.

Fix the "addtime()" macro and use it in "time_stat_update()".

Use "timestat_t"s, and the routines to manipulate them, in the service
response time table code.

svn path=/trunk/; revision=15509
2005-08-22 07:12:20 +00:00
Anders Broman 6d52a0369a From Graeme Lunt:
Zero length elements (e.g. an empty SET) the logic is slightly wrong in get_ber_length().

Make SET work.


svn path=/trunk/; revision=15508
2005-08-22 05:49:09 +00:00
Guy Harris d742f07d5c Export get_timesum().
svn path=/trunk/; revision=15507
2005-08-21 23:24:20 +00:00
Jörg Mayer 81b9fa64b5 - Make it possible to filter on eap.null, eap.info, eap.unknown etc
- Display "Info" instead of "System" in packet summary
- Make the Null element look like the other elements.
- Small element summary formatting changes

svn path=/trunk/; revision=15505
2005-08-21 21:32:19 +00:00
Jörg Mayer 547efe8ee3 - In the info summary, port# and slot# were exchanged
- In the Display element, the length of the display string
  was 4 too long
- Display the Vlan id in the packet summary, not just "Vlan"
- Remove trailing whitespace


svn path=/trunk/; revision=15502
2005-08-21 19:25:45 +00:00
Anders Broman 78e0a2b458 From Mike Duigou:
A patch to the JXTA dissector. It's purpose is to improve 
the behaviour of the dissector when dissecting captures that do not 
include the whole conversation.

The dissector is now more capable of isolating a conversation without 
seeing the beginning of the conversation. It's still not always able to 
pick up all conversations (suggestions, patches and hints welcome).

improved some of the doxygen docs and comments.

svn path=/trunk/; revision=15500
2005-08-21 18:42:54 +00:00
Ulf Lamping 06c86303e7 The protocol item in the protocol tree will have a gray background now, which makes it much better visible.
Add some more optional flags to the protocol items, so more "special cases" can be marked in the protocol tree.

New flags:
/** The protocol field has a bad checksum */
FI_CHECKSUM_ERROR
/** The protocol field has an unusual sequence (e.g. TCP window is zero) */
FI_SEQUENCE_WARNING
/** The protocol field has a bad sequence (e.g. TCP segment is lost) */
FI_SEQUENCE_ERROR

svn path=/trunk/; revision=15499
2005-08-21 15:23:48 +00:00
Ulf Lamping 808b6d48d0 as discussed some time ago: don't add bad checksum fields conditionally but use a subtree and use boolean flags instead
svn path=/trunk/; revision=15498
2005-08-21 15:13:47 +00:00
Guy Harris a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Ronnie Sahlberg e88b3ccb32 remove sprintf from gsm_a
svn path=/trunk/; revision=15492
2005-08-21 01:52:09 +00:00
Ronnie Sahlberg bc3abb6ace remove gmalloc and sprintf
svn path=/trunk/; revision=15491
2005-08-21 01:14:43 +00:00
Ronnie Sahlberg 73d84924b5 remove sprintf
svn path=/trunk/; revision=15490
2005-08-21 00:55:46 +00:00
Ronnie Sahlberg 91c1db961b remove sprintf
svn path=/trunk/; revision=15486
2005-08-20 22:15:39 +00:00
Ulf Lamping 03ea549ecc radius_dict.l(216) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(216) : warning C4022: 'g_hash_table_insert' : pointer mismatch for actual parameter 2
radius_dict.l(268) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(268) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

svn path=/trunk/; revision=15485
2005-08-20 22:08:35 +00:00
Ronnie Sahlberg b0476bbe19 removal of sprintf
svn path=/trunk/; revision=15484
2005-08-20 22:06:31 +00:00
Guy Harris 50d77b113c Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
implementing the "-z" command-line arguments, it doesn't deal with *all*
issues for stats.

svn path=/trunk/; revision=15483
2005-08-20 20:06:05 +00:00
Guy Harris eadcfd642a There's no longer a need to individually remove items from
acse_ctx_oid_table - destroying the hash table will destroy the hash
table items, and the destroy function no longer has any work to do
because the OID strings are now allocated with se_strdup() (and thus get
freed when the capture is closed).

Regenerate packet-acse.c, which also regenerates acse-exp.cnf.

svn path=/trunk/; revision=15480
2005-08-20 18:17:36 +00:00
Guy Harris a749379d3c Flag the "add_string" parameter as unused if it is - and don't flag it
as such if it *is* used. Get rid of the "add_string" parameter to
"param_digits_basic", as that function *isn't* called through a pointer.

Don't flag arguments in declarations as unused; you only do that in
definitions.

Clean up indentation.

svn path=/trunk/; revision=15479
2005-08-20 18:01:07 +00:00
Jörg Mayer f296a84150 If we delete a file, don't forget to remove it from Makefile.common
svn path=/trunk/; revision=15476
2005-08-20 16:24:35 +00:00
Jörg Mayer 96adc5f4a1 - Include the .h files in their .c files.
- Remove epan/dissectors/packet-sna.h, it isn't used anywhere.

svn path=/trunk/; revision=15475
2005-08-20 16:19:22 +00:00
Ulf Lamping 925489be0b removed MSVC warnings:
packet-camel.c(6829) : warning C4101: 'version_str' : unreferenced local variable
packet-quakeworld.c(172) : warning C4090: 'return' : different 'const' qualifiers
packet-smb.c(10859) : warning C4101: 'target_name_len' : unreferenced local variable
packet-smb.c(10860) : warning C4101: 'fn_len' : unreferenced local variable
packet-smb.c(10858) : warning C4101: 'fn' : unreferenced local variable

svn path=/trunk/; revision=15474
2005-08-20 15:58:42 +00:00
Ulf Lamping c597abee57 Win32: exported DATA must be declared with ETH_VAR_IMPORT to be available from outside the lib
fixes current Win32 buildbot problem

svn path=/trunk/; revision=15473
2005-08-20 15:19:31 +00:00
Ronnie Sahlberg e6dd3c8b22 more sprintf updates
svn path=/trunk/; revision=15469
2005-08-20 13:02:08 +00:00
Ronnie Sahlberg e1dad35f95 remove sprintf
svn path=/trunk/; revision=15467
2005-08-20 12:38:45 +00:00
Ronnie Sahlberg a51ba4011d get rid of a whole chunk of sprintfs
svn path=/trunk/; revision=15466
2005-08-20 12:28:16 +00:00
Guy Harris 5adc2b6bf1 From Gisle Vanem: export get_timedelta() for use by AFP and SMB taps.
svn path=/trunk/; revision=15464
2005-08-20 10:03:07 +00:00
Guy Harris 393366d5dd The order in which arguments to a function are evaluated isn't defined
by C.  Do decrements of arguments before passing them to a function.

svn path=/trunk/; revision=15463
2005-08-20 09:35:55 +00:00
Guy Harris c58cbeba92 Export AFP's CommandCode_vals for use by the AFP taps.
svn path=/trunk/; revision=15461
2005-08-20 08:15:21 +00:00
Ronnie Sahlberg 401c07b4dd sprintf elimination
svn path=/trunk/; revision=15460
2005-08-20 05:37:08 +00:00
Ronnie Sahlberg 54b6bc0e32 sprintf removals
svn path=/trunk/; revision=15459
2005-08-20 05:31:36 +00:00
Ronnie Sahlberg 6657ebb4c9 remove some more sprintf
svn path=/trunk/; revision=15458
2005-08-20 02:51:13 +00:00
Ronnie Sahlberg a34e7e3d03 removal of even more sprintf
svn path=/trunk/; revision=15457
2005-08-20 02:33:33 +00:00
Guy Harris 2028488827 For AFP requests, add in the frame with the (last part of the) reply, if
possible, and, for AFP replies, add in the frame with the request and
the time between those two frames.

Have AFP per-request-type RTT statistics, similar to SMB's statistics.

svn path=/trunk/; revision=15456
2005-08-20 02:19:37 +00:00
Guy Harris e5c09b21aa Use get_timedelta() to get the difference between two times.
svn path=/trunk/; revision=15455
2005-08-20 02:15:02 +00:00
Jörg Mayer 4c19ac79de Trivial warning fixes
svn path=/trunk/; revision=15452
2005-08-20 02:03:40 +00:00