Commit Graph

127 Commits

Author SHA1 Message Date
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier 67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier 391a3ebe36 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warning.
svn path=/trunk/; revision=38298
2011-08-01 01:09:04 +00:00
Anders Broman 2fb3c1a4c3 from T. Loebner:
Dissector for XR IDMS from ETSI TS 182 063 v3.5.2 Annex W 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6163

svn path=/trunk/; revision=38225
2011-07-27 12:27:39 +00:00
Bill Meier 3f7e7672c9 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38095
2011-07-18 19:11:32 +00:00
Chris Maynard 025f9ee4db From Olivier Crete via bug 5761: Compute the FCI size correctly for RTCP RTPFB.
svn path=/trunk/; revision=37052
2011-05-10 18:52:37 +00:00
Jakub Zawadzki ed59c450f4 Cleanup: replace se_alloc+memcpy combo with single se_memdup().
svn path=/trunk/; revision=36996
2011-05-05 06:55:12 +00:00
Jakub Zawadzki 38c2f2a151 Cleanup: replace sizeof(arr)/sizeof(arr[0]) with shorter array_length(arr)
svn path=/trunk/; revision=36986
2011-05-04 19:32:35 +00:00
Martin Mathieson 04e746250e Simplify the test in a loop.
This was in response to a VS Code Analysis warning.  Not sure if it was confused by lack of parenthesis, or if it detected that we had an && where both sides would always have the same value, but it was confusing.

svn path=/trunk/; revision=36743
2011-04-20 21:25:38 +00:00
Jeff Morriss 92cd49b4c2 Rename ntp_fmt_ts() to tvb_ntp_fmt_ts() and make it take a pointer to a TVB and
an offset instead of (generally) a pointer into the TVB. Then use the standard
accessor functions to get data out of the TVB.


svn path=/trunk/; revision=35886
2011-02-09 03:00:51 +00:00
Jeff Morriss a527fa4b49 Add NTP times using proto_tree_add_item().
Replace a couple not-very-descriptive blurbs with NULL.

svn path=/trunk/; revision=35883
2011-02-09 02:27:41 +00:00
Stephen Fisher fc7b0c019b Fix the dead initialization warnings found by clang's static analysis
("Value stored to 'xxx' during its initialization is never read")


svn path=/trunk/; revision=35598
2011-01-20 18:56:11 +00:00
Anders Broman d5d1e51d90 Fix indentation.
svn path=/trunk/; revision=34842
2010-11-11 07:37:43 +00:00
Jaap Keuter fc1cf15ea4 Let the protocol column show we're having Secure RTCP when we do.
svn path=/trunk/; revision=34278
2010-09-28 21:22:35 +00:00
Bill Meier 4bf6168df7 Do some constifying (based upon gcc -Wwrite-strings warnings)
svn path=/trunk/; revision=33199
2010-06-09 18:32:35 +00:00
Jaap Keuter 305277d132 From Matteo Valdina
There are two typos in the RTCP TMMBR packets:
1. In the dissector of RTCP TMMBR is written "messured" instead of measured.
2. In the text title field is written TMMBN instead on TMMBR and vice-versa.

svn path=/trunk/; revision=33022
2010-05-30 10:51:44 +00:00
Anders Broman 8fc17fa447 Change som proto_tree_add_text() regarding protocoll errors to
expert info's.

svn path=/trunk/; revision=32219
2010-03-17 17:13:55 +00:00
Jaap Keuter 70168234a1 Update according to IANA registery.
svn path=/trunk/; revision=32216
2010-03-17 06:27:34 +00:00
Anders Broman ee1fca6a19 Fix unused parameter 'num_fci' warning.
svn path=/trunk/; revision=32212
2010-03-16 21:09:47 +00:00
Anders Broman 43dc0d1157 From Matteo Valdina:
Support for RTCP RFC-5104.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4582

svn path=/trunk/; revision=32210
2010-03-16 20:38:34 +00:00
Anders Broman 71fae79030 From Alex Lindberg:
A fix to pass the entire RTCP APP payload to dissector.  The subtype field may be required by the registered dissector.
Added by hand.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4559

svn path=/trunk/; revision=32131
2010-03-06 20:40:15 +00:00
Anders Broman f9ee74b4f6 From Alex Lindberg:
Permit registration of sub-dissectors for RTPC type APP messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4559

svn path=/trunk/; revision=32123
2010-03-05 18:35:44 +00:00
Stig Bjørlykke c198fc6546 From Didier Gautheron via bug 4419:
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Bill Meier 1a4283ccf8 Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Jaap Keuter 5cd74a536c Handle padded RTCP packets ending with SDES correctly as well.
svn path=/trunk/; revision=30764
2009-10-29 22:14:54 +00:00
Jeff Morriss 1daf990897 From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2815
but (since the patch no longer applied cleanly) essentially manually
re-implemented by me:

Rename "stun" to "classic stun" and "stun2" to "stun", to follow the usage
defined in draft-ietf-behave-rfc3489bis-18 section 2.

svn path=/trunk/; revision=29884
2009-09-13 23:03:38 +00:00
Guy Harris b75a84dd4f Get rid of trailing space in string.
svn path=/trunk/; revision=29853
2009-09-11 00:00:45 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Bill Meier d53a1eaf73 Replace "" by NULL in blurbs; Cleanup indentation.
svn path=/trunk/; revision=29605
2009-08-29 02:22:28 +00:00
Anders Broman 988a595e79 From Neil Piercy:
Add new protocol for 3GPP 29.414 (Nb interface RTP Mux).

- Don't use C++-style comments (comments beginning with "//")
- Don't declare variables in the middle of executable code; not all C
compilers support that. 
- Dont register preferences when none present.
- Removed CHECK_COL

svn path=/trunk/; revision=29602
2009-08-28 21:34:59 +00:00
Bill Meier 94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd.
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Jaap Keuter 18478a63bc Fix for bug 3800:
Correctly track the size of Feedback Control Information in Payload specific RTCP feedback packet.

svn path=/trunk/; revision=29259
2009-08-02 12:11:38 +00:00
Stig Bjørlykke 49cb1d37ee Cummulative number of packets lost is a signed 24 bits value.
This fixes bug 3763.

Cleanup some proto_tree_add_uint() -> proto_tree_add_item().

svn path=/trunk/; revision=29160
2009-07-21 22:09:31 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jaap Keuter ed96f30553 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28221
2009-05-01 07:17:35 +00:00
Guy Harris e99e0bc9bb Section 11 of RFC 3550, "RTP over Network and Transport Protocols",
speaks only of destination ports; in the heuristic dissectors, don't
check whether the source port is even or odd.

The total length of an RTCP packet is in tvb_reported_length(), not
tvb_length() - the latter includes only the actual captured data, which
might be cut short by a snapshot length.

svn path=/trunk/; revision=28041
2009-04-13 22:37:35 +00:00
Guy Harris 88b214d11e Get the offset of the padding count correct (it has nothing to do with
the amount of captured packet data, so calculating it must not involve
tvb_length_remaining()), and, when processing the padding, count the
padding count octet in the offset, so that the length check is correct.

svn path=/trunk/; revision=28031
2009-04-11 03:56:14 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Bill Meier 33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Stig Bjørlykke e6a22e689e Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26648
2008-10-31 15:34:00 +00:00
Jaap Keuter 7acc2762e3 Fix for bug 2778:
Bye string is "null padded", not "null terminated". Change code to test for that fact.

svn path=/trunk/; revision=25964
2008-08-08 21:22:33 +00:00
Anders Broman 47aca4c30f From stéphane bryant:
STUN, STUN2 and TURN dissection enhancements.

svn path=/trunk/; revision=25895
2008-08-01 15:11:06 +00:00
Bill Meier b3aa52f573 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25307
2008-05-15 12:54:27 +00:00
Martin Mathieson 693291377e Stop using deprecated functions identified by checkAPIs script.
svn path=/trunk/; revision=25258
2008-05-08 14:01:31 +00:00
Stig Bjørlykke 5d7dee8953 From Mike Davies (bug 2454):
Include support for RTCP extended reports containing block type 8
as defined in RFC5093.

svn path=/trunk/; revision=24963
2008-04-12 22:20:23 +00:00