Commit Graph

48628 Commits

Author SHA1 Message Date
Evan Huus 8552f0df64 The length field is retrieved from the packet in bytes, not bits, so stop
adjusting it by 8 everywhere.

Seems to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9087 though
someone more familiar with the protocol will have to verify it's actually
correct now.

svn path=/trunk/; revision=51784
2013-09-05 13:15:04 +00:00
Martin Mathieson e67292ff14 Move where timing reference for DRX timers will be set
svn path=/trunk/; revision=51783
2013-09-05 13:11:54 +00:00
Evan Huus 47e241f6c4 Make checkAPI notify (warnings only, for now) about deprecated emem functions.
svn path=/trunk/; revision=51782
2013-09-05 12:50:24 +00:00
Evan Huus 3b6f55c579 Convert atn-* dissectors to wmem. No emem in new code please!
svn path=/trunk/; revision=51780
2013-09-05 12:13:00 +00:00
Jörg Mayer c248e3c5b2 Add modelines to avoid using tabs in the code
svn path=/trunk/; revision=51779
2013-09-05 09:23:50 +00:00
Jörg Mayer a5e2a30fc7 Change the regexp syntax a bit.
svn path=/trunk/; revision=51778
2013-09-05 08:55:09 +00:00
Stig Bjørlykke 06c27f8749 Use intended regex modification for absolute paths.
svn path=/trunk/; revision=51777
2013-09-05 08:32:00 +00:00
Stig Bjørlykke fadd2ae1c8 Removed TAB as indent.
Fixed regex for modifying absolute paths in header.

svn path=/trunk/; revision=51776
2013-09-05 08:22:44 +00:00
Jörg Mayer 8b842aeb02 Adapt generated output to always print paths relative to
the asn1/<proto>/ subdir. This makes cmake generated builds
look identical to autotools generated builds.

svn path=/trunk/; revision=51775
2013-09-05 07:38:32 +00:00
Jörg Mayer 854363611c Generated file differs in whitespace output
svn path=/trunk/; revision=51774
2013-09-05 07:36:16 +00:00
Jörg Mayer 39bff3218a Missed 50% of the updates in last commit
svn path=/trunk/; revision=51773
2013-09-05 07:33:05 +00:00
Jörg Mayer d4f2865595 CMakeLists was no longer in sync with Makefile.common
svn path=/trunk/; revision=51772
2013-09-05 07:28:47 +00:00
Jörg Mayer 022706764b Add missing CMakeLists.txt files
svn path=/trunk/; revision=51771
2013-09-05 06:05:15 +00:00
Jörg Mayer 02a61b07e4 Fix cmake syntax - so now it "only" warns about missing
CMakeLists.txt in the subdirectories.

svn path=/trunk/; revision=51770
2013-09-05 05:48:22 +00:00
Anders Broman 7e2efe9e6b From Christoph Viethen:
Typo in the name of a PPPoE tag name.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9102

svn path=/trunk/; revision=51769
2013-09-05 05:39:15 +00:00
Anders Broman dd12400161 From Chris Bontje:
Changes include:
- Detect previously-unknown object types.  No dissection is attempted of response messages, but at least the types are documented and labelled.  As Graham notes, if some examples are provided we can attempt a little more here.
- Change up info_column object label handling to add some of the new objects.  Also added in a few that would be present in 'write' messages.
- Add expert info field for abnormal IIN bits.  This will help me in my job of detecting unknown objects and unsupported function codes and will easily flag to the user that 'something is up' due to the color changes.
- Only detect Application Layer if we are on the Final Transport Layer frame.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9056

svn path=/trunk/; revision=51768
2013-09-05 05:34:40 +00:00
Anders Broman 436a6d2e99 From Mathias Guettler:
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903

svn path=/trunk/; revision=51767
2013-09-05 05:26:34 +00:00
Anders Broman 80cd0dca1d From Mathias Guettler:
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903

svn path=/trunk/; revision=51766
2013-09-05 05:26:04 +00:00
Anders Broman edbade8458 3GPP-MS-TimeZone value is not decoded in RADIUS and DIAMETER messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9099

svn path=/trunk/; revision=51765
2013-09-05 05:03:42 +00:00
Anders Broman b422c4892d From Dirk:
fix NTLMSSP Target Info Attribute dissection

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9098

svn path=/trunk/; revision=51764
2013-09-05 04:57:33 +00:00
Michael Mann 239971eca9 Fix some expert filter field names (one of which was illegal)
svn path=/trunk/; revision=51763
2013-09-05 02:52:08 +00:00
Michael Mann dd4b03512f Remove commented out expert_add_info_format
svn path=/trunk/; revision=51762
2013-09-05 01:42:11 +00:00
Michael Mann 0c49b4d872 Add filterable expert info to dissect_802_3() and clean up the shrapnel.
svn path=/trunk/; revision=51761
2013-09-05 01:39:35 +00:00
Michael Mann e65df7f453 Batch of filterable expert info.
Some of the FT_NONE hf_ variables were removed in favor of proto_tree_add_expert. It may also be possible to remove some of the booleans surrounding the expert info.

New expert display filters may need to be double-checked to make sure they make sense.

svn path=/trunk/; revision=51760
2013-09-05 01:05:16 +00:00
Gerald Combs 03fd39d7f0 Throughput graph updates.
GTK+: Fix what appears to be an off-by-one error in the MA period (21
segments instead of 20). Throw away our initial segment length instead
of subtracting it from the moving sum, which skews the sum.

Qt: Add the througput graph. Use bits/s for the throughput y axis. Let
the user switch between graph types. The dialog hangs when doing this. I
haven't been able to track down the cause. Remove some unused code.

Both: Tell the user that we're using a 20 segment moving average. Move
more routines to tap-tcp-stream.[ch].

svn path=/trunk/; revision=51759
2013-09-04 23:15:59 +00:00
Martin Kaiser 1abd5a5965 dissect some more items of the smart card descriptor
svn path=/trunk/; revision=51758
2013-09-04 22:00:41 +00:00
Evan Huus 14d589a0a7 Remove some emem functions that have now been completely replaced by wmem.
Finally...

svn path=/trunk/; revision=51757
2013-09-04 21:24:51 +00:00
Evan Huus cad50146e3 Remove what appear to be the last two instances of pe_tree. Could this be the
first emem API to die?

svn path=/trunk/; revision=51756
2013-09-04 21:14:55 +00:00
Michael Tüxen 90ac3f129f Improve the display of AUTH related parameters.
Only use IANA registered values for HMAC ids.

svn path=/trunk/; revision=51755
2013-09-04 21:07:09 +00:00
Evan Huus 48089ba4ca Use epan-scoped memory for building more of the diameter table stuff.
svn path=/trunk/; revision=51754
2013-09-04 21:06:56 +00:00
Evan Huus 4fade3bc2d Convert GCP to wmem. It is only called from dissectors in the proper scope
already (yay!).

svn path=/trunk/; revision=51753
2013-09-04 20:42:12 +00:00
Anders Broman f5b85d81d0 From Katrina Zhang:
Fix QoS dissection.

svn path=/trunk/; revision=51752
2013-09-04 18:11:21 +00:00
Anders Broman 3813c0b72d From Katrina Zhang:
Add Grouped AVP:s

svn path=/trunk/; revision=51751
2013-09-04 18:10:33 +00:00
Anders Broman a53b483969 From Katrina Zhang:
Change to tfs_enabled_disabled.

svn path=/trunk/; revision=51750
2013-09-04 18:10:00 +00:00
Anders Broman 10f7f95d09 From Katrina Zhang:
637 UAR-Flags dissection.

svn path=/trunk/; revision=51749
2013-09-04 18:08:08 +00:00
Martin Mathieson 86656b31d2 Another small step towards modelling and reporting upon DRX state in
MAC.

svn path=/trunk/; revision=51748
2013-09-04 16:56:37 +00:00
Evan Huus 8eb0bfdc5b Fix one small memory leak.
svn path=/trunk/; revision=51747
2013-09-04 12:01:09 +00:00
Evan Huus d11c7d5480 Always initialize the hash when dissecting nfsv3 file handle. Fixes the recent
valgrind fuzz failure.

svn path=/trunk/; revision=51746
2013-09-04 11:46:01 +00:00
Anders Broman 55f7519fc2 From Tyson Key:
Update the InListPassiveTarget Response handler to dissect the ISO 14443-A ATQA, and UID values from InnoVision/Broadcom Topaz cards/tags.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9096

svn path=/trunk/; revision=51745
2013-09-04 04:47:38 +00:00
Pascal Quantin a59b5388a9 From Andreas Urke via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9091 :
Add support for CFM R-APS/G.8032 version 2

From me: convert a few value_string to true_false_string

svn path=/trunk/; revision=51744
2013-09-03 22:05:22 +00:00
Pascal Quantin 69dfcffbc0 Remove obsolete code
svn path=/trunk/; revision=51743
2013-09-03 21:25:16 +00:00
Chris Maynard 6fc009baac Similar to the IPv4 dissector's hf_ip_dst_host, hf_ip_src_host and hf_ip_host fields, add to the Ethernet dissector:
hf_eth_dst_resolved
hf_eth_src_resolved
hf_eth_addr_resolved

and add to the IEEE802.11 dissector:

hf_ieee80211_addr_da_resolved
hf_ieee80211_addr_sa_resolved
hf_ieee80211_addr_ra_resolved
hf_ieee80211_addr_ta_resolved
hf_ieee80211_addr_bssid_resolved
hf_ieee80211_addr_resolved

Change motivated by:
http://ask.wireshark.org/questions/24314/possible-to-use-the-mac-info-in-the-wireshark-manuf-file-as-part-of-display-filter

svn path=/trunk/; revision=51742
2013-09-03 21:20:59 +00:00
Pascal Quantin a65045ec3f Code cleanup:
- remove some useless trees
- prettify the dissection of a few IEs
- use ELEM_MAND_VV_SHORT macro where applicable

svn path=/trunk/; revision=51741
2013-09-03 21:10:05 +00:00
Anders Broman 79352919a6 Fix "malformed packet" and tidy up a bit.
svn path=/trunk/; revision=51740
2013-09-03 19:04:13 +00:00
Gerald Combs b5e4fd5a01 Document the current state of naming in ui/qt. Say it's OK to use C++
comments in C++ code.

svn path=/trunk/; revision=51739
2013-09-03 18:50:17 +00:00
Anders Broman 4a226911da Protect agains infinite loop.
svn path=/trunk/; revision=51738
2013-09-03 18:47:44 +00:00
Alexis La Goutte dc1477b79b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51737
2013-09-03 18:44:42 +00:00
Alexis La Goutte 5098965030 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51736
2013-09-03 18:44:16 +00:00
Alexis La Goutte 6ac93da7f9 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51735
2013-09-03 18:43:50 +00:00
Alexis La Goutte b4a4a768dc Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51734
2013-09-03 18:43:29 +00:00