When enumerating port-to-name entries, the callback to
wmem_map_foreach() gets passed:
- a key, which is the port number for the entry;
- a value, which is a pointer to a structure containing pointers to port
names for various transport protocols;
- a user data pointer.
That's sufficient (if you work around some C++ annoyances) to append a
row to a PortsModel, if the user data pointer is a pointer to the
PortsModel.
The existing code, instead, appended to a QStringList of lines (in
effect, undoing the effort of the code that read the services file and
filled in the wmem_map, re-generating a set of lines) in the callback,
and then iterated over all the lines, splitting them with blanks and
appending rows.
Looking at that made my eyeballs bleed so badly that I decided not to
spend any time figuring out why it wasn't working.
So I just make the callback just append rows, avoiding all the
string-pushing.
Fixes#17395.
0af60377b4 added an heuristic to detect (unencrypted) padding data;
it is based on the fact that all coalesced QUIC packets must have the
same CID.
Unfortunately it doesn't work when the CID length is 0.
Treat decryption error of SH packets as a non fatal error, report them
as possible padding data misdetectd as coalesced packets and try
decrypting next traffic.
Close#17383
Add a new MNC/MCC field type to packet-e212 for the GUMMEI
(Globally Unique MME Identity), and use it where appropriate
in S1AP and X2AP. See 3GPP TS 23.003.
It's *not* part of the exported API, but epan/epan.h is, and everything
that needs it either includes it or includes someething else that
includes it.
See issue #17390.
Use the specific MCC/MNC fields for the E-CGI and NR-CGI IEs,
and the 5GSTAI IEs. Continue to use E212_NONE for all others
(including GlobalNG-RANCell-ID, which has a PLMN-Identity and
then a choice of EUTRA or NR cell identity in a way that makes
it difficult to determine if it is a ECGI or NRCGI when the
ASN.1 is processed in sequence.)
As of Debian bullseye and Ubuntu 21.04, `qt5-default` is no longer
available. This patch removes it and adds its dependencies instead
as suggested in <https://askubuntu.com/a/1335187/580576>.
It looks like multi-configuration generators (notably MSBuild) need
Qt autogen properties set on the wireshark target as well as qtui. Do
so unconditionally in both cases. (We were doing so conditionally for
qtui before.)
This patch splits the SOME/IP-SD configuration string according to
the specification into smaller key-value-pairs or keys. This makes
analysis involving the configuration options much easier since it
allows filtering on these elements of the configuration string.
This patch adds suppport for 64bit elements in the user data. With
CAN-FD and Ethernet replacing traditional CANs, NM is not limited
to 8 Byte messages anymore; therefore, the limitation of uint32
elements needed to change.
The upcoming TRXDv2 brings significant changes, not only adding
new fields but also changing order and presence of those that
were considered common so far. Let's rename this function to
reflect that it's TRXDv0/v1 specific, and call it directly
from the corresponding dissection functions.
Anders Broman
Vadim Yanitskiy