4debda5779
Note in a comment that with Gtk 3.4.4 reselecting UE+channel doesn't work as other UEs seem to get selected while list is being repopulated during retapping
...
svn path=/trunk/; revision=54690
2014-01-10 12:36:17 +00:00
9979ebf12d
Coverity 280335, 280336
...
check the return value of gtk_tree_selection_get_selected()
svn path=/trunk/; revision=54657
2014-01-08 12:38:27 +00:00
0b4aeb3b63
Coverity 280334
...
check the return value of gtk_tree_selection_get_selected()
if there was no selected item, wireshark would crash
but this is very unlikely in practice
svn path=/trunk/; revision=54656
2014-01-08 11:06:31 +00:00
f27990cfbb
Fix indent (use 4 spaces)
...
svn path=/trunk/; revision=54609
2014-01-05 18:39:43 +00:00
88dcc80aad
Enhance NSIS Windows installer (Wireshark Qt support)
...
* Add Radiobox to choose File Association (Wireshark GTK or Qt)
* Add Checkbox to choose Wireshark Qt icon will be installed (Startup, Desktop...)
* Fix unistaller (don't remove all icons...)
* ...
svn path=/trunk/; revision=54605
2014-01-05 18:16:14 +00:00
58346b6327
Move tcap and camel "persistent data" functionality to the dissectors themselves instead of being part of epan directory.
...
svn path=/trunk/; revision=54499
2013-12-30 22:07:38 +00:00
ce68b8db87
Make arrow down/ up work in gtk again.
...
Broken by r54328 g_ascii_isprint() can test only char type and event->keyval is unsigned int.
svn path=/trunk/; revision=54492
2013-12-29 23:29:03 +00:00
fba61a31be
add ssl detection to proto_get_frame_protocols()
...
svn path=/trunk/; revision=54439
2013-12-24 13:44:00 +00:00
8ab9c55618
From Ville Skyttä: Spelling Fixes
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9591
svn path=/trunk/; revision=54387
2013-12-23 15:53:13 +00:00
7ec4582b4f
Add FT_SYSTEM_ID type and convert the dissectors that use print_system_id with FT_BYTES to now use FT_SYSTEM_ID type.
...
svn path=/trunk/; revision=54383
2013-12-23 15:18:48 +00:00
4cf7cdd387
fix some warnings.
...
svn path=/trunk/; revision=54334
2013-12-21 17:34:41 +00:00
deb2b236f2
Add missing includes
...
svn path=/trunk/; revision=54332
2013-12-21 17:23:17 +00:00
aa4b08e2ca
ui/gtk/follow_stream.c was using isprint.h hack, change all isprint()
...
svn path=/trunk/; revision=54329
2013-12-21 15:25:06 +00:00
33ef0c2600
isascii(x) && isprint(x) -> g_ascii_isprint(x)
...
svn path=/trunk/; revision=54328
2013-12-21 15:12:11 +00:00
746ee39329
Drop isprint.h use g_ascii_isprint() when this include hack was enabled.
...
svn path=/trunk/; revision=54327
2013-12-21 15:01:45 +00:00
064082e68a
Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)
...
svn path=/trunk/; revision=54314
2013-12-20 22:39:32 +00:00
2ae8edccea
Rename more to_str functions to have ep_ in the name if they return ephemeral
...
buffers. Remove two unused functions.
svn path=/trunk/; revision=54250
2013-12-19 16:28:39 +00:00
a6415ece0a
Rename a couple of to_str functions to have ep_ in the name. This makes it
...
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).
svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
fe7e1783f7
Remove unneeded #include epan/dissectors/packet-scsi.h
...
svn path=/trunk/; revision=54234
2013-12-18 21:21:08 +00:00
30447ecd8f
Fix preprocessor macro and indentation.
...
svn path=/trunk/; revision=54178
2013-12-17 13:21:26 +00:00
3d6c71e906
Fix indent (use 4 spaces) and add modelines
...
svn path=/trunk/; revision=54176
2013-12-17 13:06:11 +00:00
d2e947f442
Fix alignment issue in GTK2 flowgraph "packet choice" window.
...
(Issue reported by Alexis Lagoutte).
##Backport 1.10
svn path=/trunk/; revision=54148
2013-12-16 18:44:04 +00:00
c00a12652f
Fix warning found by doxygen
...
svn path=/trunk/; revision=54130
2013-12-15 19:07:26 +00:00
2c015bb386
Fix some const/ not const warnings.
...
svn path=/trunk/; revision=54114
2013-12-15 12:35:00 +00:00
3ddb2011f9
Create/use several extended value-strings;
...
(Sort & remove dups from underlying value_string arrays);
Reformat a few long lines;
Add editor modelines;
svn path=/trunk/; revision=54103
2013-12-14 18:33:55 +00:00
e0e86bab5a
Fix const warnings.
...
svn path=/trunk/; revision=54092
2013-12-14 14:33:46 +00:00
1053e722ed
Fix warnings
...
svn path=/trunk/; revision=54089
2013-12-14 12:45:57 +00:00
5c79cbf152
Fix some trivial warnings.
...
svn path=/trunk/; revision=54085
2013-12-14 10:29:26 +00:00
dafe3d02ce
Address more Windows errors.
...
svn path=/trunk/; revision=54032
2013-12-13 09:52:41 +00:00
2c6d94bec3
Take sctp_stat.c off the list because it has been removed.
...
svn path=/trunk/; revision=54027
2013-12-13 08:01:24 +00:00
796bf409b0
Add dialogs and graphs to analyse SCTP behavior similar to the GTK version.
...
svn path=/trunk/; revision=54026
2013-12-13 07:25:30 +00:00
1de89438f2
Create/use a number of extended value-strings;
...
Remove or comment out dups from several value-string arrays;
Sort a number of value-string arrays;
Reformat many hf[] entries;
Remove some unneeded initializers;
Add editor-modelines;
Use consistent indentation;
Reformat whitespace.
svn path=/trunk/; revision=53968
2013-12-12 19:26:55 +00:00
67912bf798
Trivial: The file name is prefs_capture.c, not capture_prefs.c
...
svn path=/trunk/; revision=53926
2013-12-10 22:06:22 +00:00
17a67c3b5c
Get the "Decode As" dialog working, albeit with a few warts. It differs
...
from the GTK flavor in two major ways:
- The "Decode As" and "User Specified Decodes" dialog have been unified.
- You can modify the decode as behavior at any time, not just when you
have a packet selected.
Revert part of 53498 so that we can move items marked
/*** THE FOLLOWING SHOULD NOT BE USED BY ANY DISSECTORS!!! ***/
from epan/decode_as.h to ui/decode_as_utils.h.
Move "save" code from decode_as_dlg.c to decode_as_utils.c as well.
In packet-dcerpc.c don't register a table named "ethertype". We might
want to add checks for duplicate table names.
To do:
- Add support for ranges?
- Either add support for DCERPC or make DCERPC use a regular dissector
table.
- Fix string selectors (i.e. BER).
svn path=/trunk/; revision=53910
2013-12-10 19:23:26 +00:00
85d84776b8
Use PT_TXTMOD_NONE for columns that should not be editable.
...
svn path=/trunk/; revision=53906
2013-12-10 15:33:07 +00:00
7eb15db51c
Do not show uat preferences if not registered for the gui.
...
svn path=/trunk/; revision=53904
2013-12-10 15:29:43 +00:00
0d31c840ae
Removed debug output.
...
svn path=/trunk/; revision=53903
2013-12-10 14:43:15 +00:00
3ae2e5ece2
Fix warnings
...
svn path=/trunk/; revision=53885
2013-12-09 20:15:47 +00:00
f91eba752b
Fix some warnings: cast discards `__attribute__((const))' qualifier from pointer target type
...
svn path=/trunk/; revision=53875
2013-12-08 23:16:06 +00:00
006f84a565
From Deon van der Westhuysen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452
...
Patch: Stats_tree enhancements for sorting, averages and burst rate
Add sort, save-as and new columns to Qt ui, remove old functions
stats_tree.c / stats_tree_priv.h: Make all columns sortable. Remove unneeded functions stats_tree_get_strs_from_node, stats_tree_branch_to_str and stats_tree_is_sortable_column.
stats_tree_stat.c: Set all columns sortable.
stats_tree_dialog.cpp / stats_tree_dialog.h: Add new stats_tree columns. Make columns sortable. Remove copy to csv and copy to yaml buttons. Add copy to clipboard as plain text and save as buttons.
stats_tree_dialog.ui: Remove copy to csv and copy to yaml buttons. Add copy to clipboard as plain text and save as buttons. Only define one column in ui, rest are added dynmically.
From me : fix trailing whitespace
svn path=/trunk/; revision=53848
2013-12-08 11:09:54 +00:00
c67d38cf15
Rename base_display_* to field_display
...
This is preparation to support ->display for FT_STRING values.
svn path=/trunk/; revision=53820
2013-12-07 10:41:42 +00:00
f251011478
Include epan/conv_id.h - some of the buildbot machines have errors without it
...
svn path=/trunk/; revision=53798
2013-12-05 15:06:21 +00:00
eb85d08557
Make launching TCP graphs from conversations window work again, by supplying stream and direction when graph is first created
...
svn path=/trunk/; revision=53797
2013-12-05 14:45:03 +00:00
125a17f8e5
Initialize the error-reporting routines before scanning for plugins, as
...
the code to scan for them uses those routines.
This means epan_init() no longer takes those routines as arguments -
which is just as well, given that the mechanism in question is no longer
part of libwireshark, but is part of libwsutil.
This should fix bug 9508.
svn path=/trunk/; revision=53796
2013-12-05 09:30:22 +00:00
b75354ebe8
Avoid including <epan/epan.h> in dissectors.
...
svn path=/trunk/; revision=53774
2013-12-03 23:49:51 +00:00
65db82872c
When including <epan/prefs.h> don't force inclusion of <epan/uat.h>
...
svn path=/trunk/; revision=53769
2013-12-03 22:16:49 +00:00
cedb73c7f7
Dissectors should not use dfilter.h, don't include it.
...
XXX ncp2222 dissector is using dfilter_compile(), why?
svn path=/trunk/; revision=53766
2013-12-03 21:31:04 +00:00
30d0d8ff51
Move stats_tree_stat.c back to clean files.
...
svn path=/trunk/; revision=53745
2013-12-03 13:18:37 +00:00
fb289aedf6
Explicitly convert an int to an enum.
...
svn path=/trunk/; revision=53729
2013-12-02 19:20:35 +00:00
93f15d640c
Specify SI units for the max filesize autostop condition. For now, keep the capture buffer size in IEC units, but document it as such.
...
#BACKPORT(1.10, 1.8(?))
svn path=/trunk/; revision=53728
2013-12-02 19:17:12 +00:00
Martin Mathieson