Commit Graph

42 Commits

Author SHA1 Message Date
João Valverde 19dcb725b6 epan: Remove STR_ASCII and STR_UNICODE
These display bases work to replace unprintable characters so the
name is a misnomer. In addition they are the same option and this
display behaviour is not something that is configurable.

This does not affect encodings because all our internal text strings
need to be valid UTF-8 and the source encoding is specified using
ENC_*.

Remove the assertion for valid UTF-8 in proto.c because
tvb_get_*_string() must return a valid UTF-8 string, always, and we
don't need to assert that, it is expensive.
2021-12-03 04:35:56 +00:00
Pascal Quantin b403255234 X2AP: upgrade dissector to v16.6.0 2021-07-02 08:46:29 +00:00
John Thacker c571e0a5d5 S1AP, X2AP: Add GUMMEI MNC/MCC fields
Add a new MNC/MCC field type to packet-e212 for the GUMMEI
(Globally Unique MME Identity), and use it where appropriate
in S1AP and X2AP. See 3GPP TS 23.003.
2021-05-16 15:59:35 -04:00
John Thacker 0a0f090f74 X2AP: Use specific MCC/MNC fields
Use the specific fields for ECGI, NRCGI, and TAI, and E212_NONE
as before for all other IEs.
2021-05-12 22:52:46 -04:00
Pascal Quantin 9f3822ad7b X2AP: upgrade dissector to v16.5.0 2021-04-09 17:08:30 +00:00
Pascal Quantin 098dc4843a X2AP: upgrade dissector to v16.4.0 2021-01-05 15:06:41 +01:00
Pascal Quantin aeb68eb68c X2AP: upgrade dissector to v16.3.0 2020-10-05 13:25:02 +02:00
Tom Yan 6387fd7729 X2AP : fix id-Target-SgNB-ID registered to wrong type 2020-09-23 05:55:21 +00:00
Pascal Quantin 291c836392 F1AP: upgrade dissector to v16.2.0 2020-09-05 13:32:33 +02:00
Pascal Quantin 986ead744d NGAP: upgrade dissector to v16.2.0 2020-08-26 18:37:12 +02:00
Pascal Quantin 4707c16add X2AP: upgrade dissector to v16.2.0
Change-Id: I6fc049e0ce07d3938e486c4e6075d70340b3e3e2
Reviewed-on: https://code.wireshark.org/review/38208
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-20 21:39:50 +00:00
Guy Harris e1d9a226a2 Fix the type of arrays of pointers to hf_ values for bitfield routines.
The static arrays are supposed to be arrays of const pointers to int,
not arrays of non-const pointers to const int.

Fixing that means some bugs (scribbling on what's *supposed* to be a
const array) will be caught (see packet-ieee80211-radiotap.c for
examples, the first of which inspired this change and the second of
which was discovered while testing compiles with this change), and
removes the need for some annoying casts.

Also make some of those arrays static while we're at it.

Update documentation and dissector-generator tools.

Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc
Reviewed-on: https://code.wireshark.org/review/37517
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19 11:32:26 +00:00
Pascal Quantin a3cf955113 X2AP: upgrade dissector to v15.9.0
Change-Id: I3a3c73eac9a576f4c494986b19332330523a9883
Reviewed-on: https://code.wireshark.org/review/36698
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-04-04 17:30:10 +00:00
Pascal Quantin 5b861d84f8 X2AP: upgrade dissector to v15.8.0
Change-Id: I9fe9b4ce1f993857b290a8679761647052fb6bcd
Reviewed-on: https://code.wireshark.org/review/35807
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-14 15:47:50 +00:00
Pascal Quantin db68ece980 X2AP: upgrade dissector to v15.7.0
Change-Id: Ia904700abea688f8376a28dcb0147eae62d3d12d
Reviewed-on: https://code.wireshark.org/review/34700
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-03 16:15:45 +00:00
Pascal Quantin a754879c7d X2AP: upgrade dissector to v15.6.0
Change-Id: Iffa23a10350ad8ef765401b50373a7d6aaf5d2bf
Reviewed-on: https://code.wireshark.org/review/33971
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-16 22:27:50 +00:00
Pascal Quantin a6dac6240f X2AP: use the right tree for EndcSONConfigurationTransfer IE
Change-Id: I44739870524af86c9b590fdc995d7b93490f9296
Reviewed-on: https://code.wireshark.org/review/32816
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-10 21:03:31 +00:00
Pascal Quantin fe50824bb4 X2AP: upgrade dissector to v15.5.0
Change-Id: I43f96e8ea5acb3cd94b8b3b4e08e0d10a5e8d951
Reviewed-on: https://code.wireshark.org/review/32800
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-09 11:31:21 +00:00
Anders Broman ca694eb078 PER: Use proto_tree_add_bitmask... () for named bits.
Change-Id: I2f4258e2f4fd11c26bdc101e1375d0b5708610b7
Reviewed-on: https://code.wireshark.org/review/32713
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04 12:28:11 +00:00
Pascal Quantin e5f7f15b1f X2AP: upgrade dissector to v15.4.0
Change-Id: I67d26dd142ffdb79bc304d44f9cfb5bc8e0acd1f
Reviewed-on: https://code.wireshark.org/review/31543
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-14 18:07:12 +00:00
Pascal Quantin d6b187e42f XnAP: upgrade dissector to v15.2.0
Change-Id: Ie26f8918aff20ade21eda611950795a320a417f2
Reviewed-on: https://code.wireshark.org/review/31483
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-11 12:02:40 +00:00
Pascal Quantin eb4bf22de3 X2AP: fix dissection of MeNBtoSgNBContainer in SgNBModificationConfirm message
Bug: 15368
Change-Id: I99307f6af961e91059111e699c7d43fa364f28f0
Reviewed-on: https://code.wireshark.org/review/31080
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-18 05:19:04 +00:00
Pascal Quantin 3d77c3fc2c X2AP: fix dissection of SeNB to MeNB Container
Change-Id: I4f5af9d52646d74dfa264583b6f0a79e097527e7
Reviewed-on: https://code.wireshark.org/review/30032
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-05 16:38:22 +00:00
Pascal Quantin c785e16cda X2AP: upgrade dissector to v15.3.0
Change-Id: Ia2d0778c56eab2bbcd38904e3393353eba1aad44
Reviewed-on: https://code.wireshark.org/review/29856
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-26 14:05:09 +00:00
Pascal Quantin d052974332 X2AP: fix dissection of SgNB to MeNB Container
Bug: 14940
Change-Id: I42706789cd073fab1a0a7283f009c2f30751579d
Reviewed-on: https://code.wireshark.org/review/28590
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-04 05:58:36 +00:00
Pascal Quantin 2865453fc2 X2AP: display 5GS TAC as DEC_HEX
Change-Id: Ic8d0baf39851a8f0ae260f55ffab1bec218ed79a
Reviewed-on: https://code.wireshark.org/review/28513
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-28 18:58:41 +00:00
Pascal Quantin 5736125e3b F1AP: dissect more OCTET STRING from X2AP ASN.1 description
Change-Id: If438ebe1053ed5f64763f079c17e293589944dde
Reviewed-on: https://code.wireshark.org/review/28439
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-25 23:49:51 +00:00
Pascal Quantin c6fc452c95 X2AP: upgrade dissector to v15.2.0
Change-Id: Ic85c1124456b841fefe54c92166add81599e4d85
Reviewed-on: https://code.wireshark.org/review/28437
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-25 23:25:13 +00:00
Pascal Quantin 1839a43f25 X2AP: upgrade dissector to v15.1.0
Change-Id: I61867f0bcd8cff1d7469e3344b2fb21f5ed3bd77
Reviewed-on: https://code.wireshark.org/review/26787
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-07 14:12:17 +00:00
Pascal Quantin 64d6a7b846 NR RRC: upgrade dissector to v15.1.0
Change-Id: If34d8627e8dee0e9dd7c1dc72701aec57df68853
Reviewed-on: https://code.wireshark.org/review/26774
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06 11:29:02 +00:00
Pascal Quantin 6280c153bb F1AP: initial dissector submission based on v15.0.0
Change-Id: Icf5c128119afa86efddb87e744f7aecb8bf71e09
Reviewed-on: https://code.wireshark.org/review/26506
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-16 19:10:25 +00:00
Pascal Quantin be958a7116 X2AP: upgrade dissector to v15.0.0
Change-Id: Ib2e01a19f5b4f37fcee7bdf3b2ed231c5606162a
Reviewed-on: https://code.wireshark.org/review/25357
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-18 07:16:36 +00:00
Pascal Quantin 8fd97bdecb X2AP: upgrade dissector to v14.3.0
Change-Id: Idee26dcdfad15d9fb23e3fb8aeb8ad8afed747d5
Reviewed-on: https://code.wireshark.org/review/22607
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-13 12:45:01 +00:00
Pascal Quantin 7460e6c9ec X2AP: upgrade dissector to v13.7.0
Change-Id: I1580bf4da1a31a6e0f77080e0835eb0dd5b3936c
Reviewed-on: https://code.wireshark.org/review/22450
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-29 00:42:09 +00:00
Pascal Quantin 01c8028add X2AP: upgrade dissector to v13.6.0
Change-Id: Ie312d354cadadba693ea5320c5bbc0957bde6514
Reviewed-on: https://code.wireshark.org/review/19613
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-12 05:46:31 +00:00
Pascal Quantin 5696b842b1 X2AP: use unit strings
Change-Id: Icac054fda0b1e1b8d79c33fc967345a7497e812b
Reviewed-on: https://code.wireshark.org/review/19322
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-18 03:04:43 +00:00
Pascal Quantin 470086f059 X2AP: upgrade dissector to v13.5.0
Also get rid of two global variables

Change-Id: I8c20decb76f5c1773f58efd24d2e1e7d1177d358
Reviewed-on: https://code.wireshark.org/review/18029
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-10-02 19:44:53 +00:00
Pascal Quantin 0dc96da1b9 X2AP: remove Procedure Code from info column
Change-Id: I8d4632ef3b338063e96f4a417f0e3280489968a4
Reviewed-on: https://code.wireshark.org/review/17692
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-13 22:09:22 +00:00
Pascal Quantin 5c505e7d43 X2AP: add dissection of X2AP-Message information element
Change-Id: I2993e1a9ebad1660573bce8a61b44962af08bbb3
Reviewed-on: https://code.wireshark.org/review/17652
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-11 22:08:47 +00:00
Pascal Quantin 9fb9e9f5a9 X2AP: prettify info column
Change-Id: I1630199383e0b83bf14e8d9850870268d7db777c
Reviewed-on: https://code.wireshark.org/review/17542
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-06 21:04:27 +00:00
Pascal Quantin 9be89dd8e8 X2AP: upgrade dissector to v13.4.0
Change-Id: I97250d022a40ac888522f885968e7cd3c86e3485
Reviewed-on: https://code.wireshark.org/review/17540
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-06 20:30:46 +00:00
João Valverde 54a520d4a1 Move /asn1 to /epan/dissectors
Change-Id: I1208fe3c2ba428995526f561e8f792b8d871e9a9
Reviewed-on: https://code.wireshark.org/review/14388
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: João Valverde <j@v6e.pt>
2016-03-13 21:30:24 +00:00