Commit Graph

37 Commits

Author SHA1 Message Date
João Valverde 19dcb725b6 epan: Remove STR_ASCII and STR_UNICODE
These display bases work to replace unprintable characters so the
name is a misnomer. In addition they are the same option and this
display behaviour is not something that is configurable.

This does not affect encodings because all our internal text strings
need to be valid UTF-8 and the source encoding is specified using
ENC_*.

Remove the assertion for valid UTF-8 in proto.c because
tvb_get_*_string() must return a valid UTF-8 string, always, and we
don't need to assert that, it is expensive.
2021-12-03 04:35:56 +00:00
Anders Broman 767115558f NR-RRC: Access more messages trough dissector handles. 2021-11-03 14:04:57 +01:00
Anders Broman d2dff29c83 NR RRC: Make more PDUs set col and proto. 2021-10-06 03:08:22 +00:00
Anders Broman b4cd8c0a8e NR RRC: Register protocols which sets proto and info columns. 2021-10-05 03:48:51 +00:00
Pascal Quantin 728061fa17 NR RRC: upgrade dissector to v16.6.0 2021-10-01 14:36:49 +00:00
Evan Huus d09fb571fe asn1: convert most dissectors to pinfo->pool
Part 2/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 14:00:09 -04:00
Pascal Quantin 204642089a NR RRC: upgrade dissector to v16.5.0 2021-07-07 17:37:07 +00:00
Pascal Quantin aa5df68171 NR RRC: fix dissection of MeasTriggerQuantityOffset element 2021-07-04 12:03:45 +02:00
Pascal Quantin 348daa8d50 NR RRC: upgrade dissector to v16.4.1 2021-04-01 21:20:48 +02:00
Pascal Quantin 46c44e0785 NR RRC: add preference to put NAS in the root tree 2021-02-10 14:46:27 +00:00
Pascal Quantin 102a53c852 NR RRC: upgrade dissector to v16.3.0 2021-01-07 15:07:56 +01:00
Martin Mathieson 41a6457ff3 PDCP-NR: Set 'cipheringDisabled' from RRC 2021-01-03 12:21:17 +00:00
Martin Mathieson 9164d7f9ce PDCP-NR: add ciphering and integrity checking
There may be some scope to share some code with PDCP-LTE,
but it may make the code harder to read.
2020-12-31 13:59:46 +00:00
Pascal Quantin 59efc252dc LPP: upgrade dissector to v16.2.0 2020-11-29 22:48:08 +01:00
Pascal Quantin 21c3bdff06 NR RRC: upgrade dissector to v16.2.0 2020-10-08 10:24:28 +02:00
Pascal Quantin 291c836392 F1AP: upgrade dissector to v16.2.0 2020-09-05 13:32:33 +02:00
Pascal Quantin 986ead744d NGAP: upgrade dissector to v16.2.0 2020-08-26 18:37:12 +02:00
Pascal Quantin 1b88c72776 NR RRC: upgrade dissector to v16.1.0
Change-Id: I961820125dca0f6b72dc84658d3010ca94a563ac
Reviewed-on: https://code.wireshark.org/review/38180
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-17 15:12:48 +00:00
Pascal Quantin 78329eb938 NR RRC: fix dissection of MobilityFromNRCommand IEs
Change-Id: I2cd4fd2d5af359bd4a432c02284da78548416dd3
Reviewed-on: https://code.wireshark.org/review/37686
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-07-03 21:30:41 +00:00
Pascal Quantin b72e53731d NR RRC: upgrade dissector to v15.9.0
Change-Id: I1f12cacd94bbd857824267a9c01ed7ab61f3ef9b
Reviewed-on: https://code.wireshark.org/review/36713
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-04-05 11:30:45 +00:00
Pascal Quantin dd41259548 NR RRC: fix dissection of q-RxLevMin parameter
Change-Id: Ia8aa965e19d7ad55d7197cb636b203140abfba5b
Reviewed-on: https://code.wireshark.org/review/36501
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-19 14:34:31 +00:00
Guy Harris a152e041fa Put various epoch time deltas into wsutil/epochs.h.
There are some deltas between the UN*X epoch and other epochs that are
used in a number of places; put them into a header.

Change-Id: Ia2d9d69b9d91352d730d97d9e4897518635b4861
Reviewed-on: https://code.wireshark.org/review/35895
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-21 23:37:05 +00:00
Pascal Quantin 35cdf00669 NR RRC: upgrade dissector to v15.8.0
Change-Id: I2001239b765ab766c31c0e4181e25e43d8d9c761
Reviewed-on: https://code.wireshark.org/review/35723
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-09 19:49:58 +00:00
Pascal Quantin 27b297f07a NR RRC: fix dissection of NAS container field
It is directly the S1 mode to N1 mode container and not a 5GS message header.

Change-Id: I5d8045065977083d3e5e59692166615afb429e41
Reviewed-on: https://code.wireshark.org/review/35285
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-02 19:23:00 +00:00
Pascal Quantin ef671dd085 NR RRC: upgrade dissector to v15.7.0
Change-Id: I6d455f93405718b26abfcda6bac756b0874450f0
Reviewed-on: https://code.wireshark.org/review/34658
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-30 15:59:50 +00:00
Pascal Quantin 376d4c3595 NR RRC: upgrade dissector to v15.6.0
Change-Id: I07eb698fa7ec0ce74953844667590e72368f9456
Reviewed-on: https://code.wireshark.org/review/33803
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-01 16:52:56 +00:00
Martin Mathieson dd708676d3 NR: Configure LCID -> RLC Bearer config from RRC
Change-Id: Ida6af4ccd2157f967b9d2340e6f12319e4dbe688
Reviewed-on: https://code.wireshark.org/review/32998
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-04-29 23:39:58 +00:00
Pascal Quantin 6636fa3416 NR RRC: upgrade dissector to v15.5.0
Change-Id: If396f597a2c3c9d6558d6607faa4d0a054c9966d
Reviewed-on: https://code.wireshark.org/review/32760
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-06 21:30:00 +00:00
Pascal Quantin 3ba1c7ff77 LTE RRC: upgrade dissector to v15.5.0
Change-Id: I227db32a59a16c31d7712cb9c48b55fa4aaf28ca
Reviewed-on: https://code.wireshark.org/review/32759
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-06 18:59:11 +00:00
Pascal Quantin 8348b7bf5b NR-RRC: upgrade dissector to v15.4.0
Change-Id: I6a50623a485796a12f01ca1352ba31caa0d96eee
Reviewed-on: https://code.wireshark.org/review/31558
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-15 18:37:39 +00:00
Pascal Quantin a3e18c1807 NR RRC: upgrade dissector to v15.3.0
Change-Id: Ie43e784b3bcfe391e2c8fca898ac20ec111f3484
Reviewed-on: https://code.wireshark.org/review/30019
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-05 13:31:31 +00:00
Pascal Quantin 7f77259e55 NR RRC: upgrade dissector to v15.2.0
Change-Id: Ie7509984d17bf761e96a1d0d079720e91a6a75cf
Reviewed-on: https://code.wireshark.org/review/28355
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21 03:31:31 +00:00
Pascal Quantin 64d6a7b846 NR RRC: upgrade dissector to v15.1.0
Change-Id: If34d8627e8dee0e9dd7c1dc72701aec57df68853
Reviewed-on: https://code.wireshark.org/review/26774
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06 11:29:02 +00:00
Pascal Quantin 2e02b438cc NR-RRC: remove a redundant declaration
Change-Id: Iddc49443ea4534314ef39bae749ddafb135143ff
Reviewed-on: https://code.wireshark.org/review/26591
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-22 13:38:58 +00:00
Dario Lombardo 8cd389e161 replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.
The first is deprecated, as per https://spdx.org/licenses/.

Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed
Reviewed-on: https://code.wireshark.org/review/25661
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-08 14:57:36 +00:00
Pascal Quantin c634a73c95 LTE RRC: upgrade dissector to v15.0.1
Change-Id: If0b6fe029b5f852250fde36ead5dc5bb03d44e28
Reviewed-on: https://code.wireshark.org/review/25304
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-01-13 19:36:06 +00:00
Pascal Quantin 88abff68df NR RRC: add initial dissector based on v15.0.0
ASN.1 prose imported from the specification and heavily modified
manually to workaround its poor quality.
Some of them are marked with -- WS modification comment, some are not.
Probably useless as-is, but it is an initial start until an updated
version is available.

Change-Id: I19ab6cedb6aa23c8ed57bae525ee4a3391494e32
Reviewed-on: https://code.wireshark.org/review/25235
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-10 05:31:33 +00:00