osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
82,795 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

81 Commits

Author SHA1 Message Date
João Valverde 19dcb725b6 epan: Remove STR_ASCII and STR_UNICODE 
These display bases work to replace unprintable characters so the
name is a misnomer. In addition they are the same option and this
display behaviour is not something that is configurable.

This does not affect encodings because all our internal text strings
need to be valid UTF-8 and the source encoding is specified using
ENC_*.

Remove the assertion for valid UTF-8 in proto.c because
tvb_get_*_string() must return a valid UTF-8 string, always, and we
don't need to assert that, it is expensive.
 2021-12-03 04:35:56 +00:00
Pascal Quantin 35826bbb95 LTE RRC: upgrade dissector to v16.6.0 2021-10-01 15:05:02 +02:00
Evan Huus cdfab0d6e9 tvbuff: convert helper methods to pinfo->pool 
A few of them just needed scratch memory, so allocate and free it
manually after doing any exception-raising checks.

A few others were returning memory, and needed conversion to accept a
wmem scope argument.
 2021-09-01 03:54:52 +00:00
Evan Huus e69446aa55 asn1: convert most dissectors to pinfo->pool 
Part 1/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
 2021-07-26 15:30:11 +00:00
Pascal Quantin ce9b01f059 LTE RRC: upgrade dissector to v16.5.0 2021-07-07 17:34:28 +02:00
Pascal Quantin c5c6a5a9cc LTE RRC: use _ instead of - in filter names 
Like what asn2wrs.py does
 2021-03-21 18:46:53 +00:00
Anders Broman 1910e416a9 LTE-RRC: Rename some duplicated fields names. 2021-03-08 17:16:44 +00:00
Pascal Quantin 879a33f158 LTE RRC: add dissection of NAS 5GS PDUs 
A ng-eNB connects to a 5GC, not an EPC, and thus transports 5GS NAS PDUs
 2021-03-08 13:02:19 +01:00
Stig Bjørlykke cb3d463a38 lte-rrc: Add preference to put NAS in the root tree 
Add a preference to put DedicatedInfoNAS in the root packet
details tree.
 2021-02-10 10:08:21 +00:00
Pascal Quantin 102a53c852 NR RRC: upgrade dissector to v16.3.0 2021-01-07 15:07:56 +01:00
Pascal Quantin 3551dfe56e LTE RRC: upgrade dissector to v16.3.0 2021-01-07 12:22:46 +00:00
Anders Broman d139fe3bc7 LTE-RRC: Fix duplicated filter names. 2021-01-05 15:13:12 +00:00
Martin Mathieson 9164d7f9ce PDCP-NR: add ciphering and integrity checking 
There may be some scope to share some code with PDCP-LTE,
but it may make the code harder to read.
 2020-12-31 13:59:46 +00:00
Pascal Quantin 59efc252dc LPP: upgrade dissector to v16.2.0 2020-11-29 22:48:08 +01:00
Stig Bjørlykke edd71daa90 lte-rrc: Pluralize PagingRecord(s) 2020-10-27 15:51:11 +01:00
Pascal Quantin 21c3bdff06 NR RRC: upgrade dissector to v16.2.0 2020-10-08 10:24:28 +02:00
Pascal Quantin 1fd6a542fe LTE RRC: upgrade dissector to v16.2.0 2020-10-07 17:17:02 +00:00
Pascal Quantin aeb68eb68c X2AP: upgrade dissector to v16.3.0 2020-10-05 13:25:02 +02:00
Pascal Quantin 4707c16add X2AP: upgrade dissector to v16.2.0 
Change-Id: I6fc049e0ce07d3938e486c4e6075d70340b3e3e2
Reviewed-on: https://code.wireshark.org/review/38208
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-08-20 21:39:50 +00:00
Pascal Quantin abd6f143c7 S1AP: upgrade dissector to v16.2.0 
Change-Id: Ifa71f952f5aca11f99ae751d1c1404a2af95e3a5
Reviewed-on: https://code.wireshark.org/review/38204
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Tomáš Kukosa <keksa@email.cz>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-08-20 12:14:30 +00:00
Pascal Quantin 1b88c72776 NR RRC: upgrade dissector to v16.1.0 
Change-Id: I961820125dca0f6b72dc84658d3010ca94a563ac
Reviewed-on: https://code.wireshark.org/review/38180
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-08-17 15:12:48 +00:00
Pascal Quantin 057d50bfdf NR LTE: add dissection of capabilityRequestFilter for EUTRA and EUTRA-NR RATs 
Change-Id: I4c21885a43110228379d684aa739817d473506ae
Reviewed-on: https://code.wireshark.org/review/38139
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-08-12 11:29:56 +00:00
Pascal Quantin c3dbba350c LTE RRC: upgrade dissector to v16.1.1 
Change-Id: I52534b6a5dab43ee10501383f3fb76f47255b9a5
Reviewed-on: https://code.wireshark.org/review/38102
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-08-10 04:48:34 +00:00
Guy Harris e1d9a226a2 Fix the type of arrays of pointers to hf_ values for bitfield routines. 
The static arrays are supposed to be arrays of const pointers to int,
not arrays of non-const pointers to const int.

Fixing that means some bugs (scribbling on what's *supposed* to be a
const array) will be caught (see packet-ieee80211-radiotap.c for
examples, the first of which inspired this change and the second of
which was discovered while testing compiles with this change), and
removes the need for some annoying casts.

Also make some of those arrays static while we're at it.

Update documentation and dissector-generator tools.

Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc
Reviewed-on: https://code.wireshark.org/review/37517
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2020-06-19 11:32:26 +00:00
Pascal Quantin c97076b7d7 MAC LTE: add support for extended LCID 
This feature introduced in V15.5.0 allows to have up to 15 DRBs by
adding LCID 32 to 38

Change-Id: I4442e26d115efe484eda4f2d8921483cf4278b99
Reviewed-on: https://code.wireshark.org/review/37462
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-06-12 04:13:25 +00:00
Pascal Quantin 3d9b2807aa LTE RRC: dissect nas-SecurityParamFromEUTRA for the 5GS to EPS handover case 
Change-Id: I3bc14209ad1be8d4f8bdac710baf04a29b521c93
Reviewed-on: https://code.wireshark.org/review/37457
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-06-11 15:18:29 +00:00
Pascal Quantin adeeb7f2da LTE RRC: fix a memory leak in composite TVB handling 
Bug: 16341
Change-Id: Ib6c020ea3df8b39a02f742f0684fca7db96f1fc3
Reviewed-on: https://code.wireshark.org/review/35899
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-01-22 11:26:11 +00:00
Guy Harris a152e041fa Put various epoch time deltas into wsutil/epochs.h. 
There are some deltas between the UN*X epoch and other epochs that are
used in a number of places; put them into a header.

Change-Id: Ia2d9d69b9d91352d730d97d9e4897518635b4861
Reviewed-on: https://code.wireshark.org/review/35895
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2020-01-21 23:37:05 +00:00
Pascal Quantin b4e37280c5 LTE RRC: upgrade dissector to v15.8.0 
Change-Id: Ib480626891c1796623902c6dfe24183ead59112e
Reviewed-on: https://code.wireshark.org/review/35722
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-01-09 16:56:13 +00:00
Anders Broman b71ae7471b lte-rrc: Register dissector for UEPagingCoverageInformation and -NB 
Change-Id: I42cd7a917e3a79d61a6ae5dc80765814ad0650a7
Reviewed-on: https://code.wireshark.org/review/34849
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2019-10-24 10:17:48 +00:00
Pascal Quantin 770db76439 LTE RRC: upgrade dissector to v15.7.0 
Change-Id: Icf3df4f82f43df51b6ce416f3a159229cbe80351
Reviewed-on: https://code.wireshark.org/review/34656
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-09-30 13:34:32 +00:00
Pascal Quantin c7884e2170 XnAP: upgrade dissector to v15.4.0 
Change-Id: Ia26593e7895709671a7a9d4a51bb6788e4059c94
Reviewed-on: https://code.wireshark.org/review/34015
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-07-19 12:46:44 +00:00
Pascal Quantin 7af35b68bd LTE RRC: dissect requestedCapabilityCommon / appliedCapabilityFilterCommon IEs 
Change-Id: I39198df9a048510d040d56a53183669bda176cdc
Reviewed-on: https://code.wireshark.org/review/33804
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-07-01 16:53:03 +00:00
Pascal Quantin 376d4c3595 NR RRC: upgrade dissector to v15.6.0 
Change-Id: I07eb698fa7ec0ce74953844667590e72368f9456
Reviewed-on: https://code.wireshark.org/review/33803
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-07-01 16:52:56 +00:00
Pascal Quantin 2a80a9b80a LTE RRC: upgrade dissector to v15.6.0 
Change-Id: I05417ad4425e301af9d307a1c20fd3c16091c80c
Reviewed-on: https://code.wireshark.org/review/33784
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-06-30 19:23:48 +00:00
Pascal Quantin 3ba1c7ff77 LTE RRC: upgrade dissector to v15.5.0 
Change-Id: I227db32a59a16c31d7712cb9c48b55fa4aaf28ca
Reviewed-on: https://code.wireshark.org/review/32759
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-04-06 18:59:11 +00:00
Pascal Quantin 24ef409900 ETSI CAT: add dissection of Network Measurement Results 
Bug: 15665
Change-Id: Iaff2432bf87d1c9d237709b651005518c89bff18
Reviewed-on: https://code.wireshark.org/review/32707
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2019-04-04 10:59:12 +00:00
Gerald Combs 8d3ac3af86 epan: Convert our PROTO_ITEM_ macros to inline functions. 
Convert our various PROTO_ITEM_ macros to inline functions and document
them.

Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c
Reviewed-on: https://code.wireshark.org/review/32706
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2019-04-04 04:03:38 +00:00
Martin Mathieson d3c583aa67 Add protocol filter for exported parts of 3G and LTE RRC. 
Change-Id: Ib5ed8eaecafe9f07eec2ee10f0f2684d81dec1b7
Reviewed-on: https://code.wireshark.org/review/32085
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
 2019-02-18 12:39:07 +00:00
Pascal Quantin bf4fe342e3 LTE RRC: add dissection of NR RSRP/RSRQ/SINR fields 
Change-Id: I56f44fd4dc6aa6358be54e200ddc7b27d51778aa
Reviewed-on: https://code.wireshark.org/review/32008
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-02-13 16:46:22 +00:00
Pascal Quantin 592248c2fc LTE RRC: dissect 2 InterNode IEs 
Change-Id: I17424675a7b60f468e94134f17533cd891d135f7
Reviewed-on: https://code.wireshark.org/review/31606
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2019-01-19 12:51:36 +00:00
Pascal Quantin 94daef786a LTE RRC: upgrade dissector to v15.4.0 
Change-Id: I90b3a5afe782992eac98b37336cc9267ba73dbc0
Reviewed-on: https://code.wireshark.org/review/31595
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2019-01-18 19:30:05 +00:00
Pascal Quantin 67783962cf LTE RRC: fix dissection of measResultSCG-r15 IE 
Change-Id: I68bdc75fc1fb270f815004f2cb6eafbb7bfc2329
Reviewed-on: https://code.wireshark.org/review/31572
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2019-01-17 10:24:17 +00:00
Pascal Quantin d6b187e42f XnAP: upgrade dissector to v15.2.0 
Change-Id: Ie26f8918aff20ade21eda611950795a320a417f2
Reviewed-on: https://code.wireshark.org/review/31483
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2019-01-11 12:02:40 +00:00
Guy Harris 7eb3e47fa4 Try to squeeze some bytes out of the frame_data structure. 
Make the time stamp precision a 4-bit bitfield, so, when combined with
the other bitfields, we have 32 bits.  That means we put the flags at
the same structure level as the time stamp precision, so they can be
combined; that gets rid of an extra "flags." for references to the flags.

Put the two pointers next to each other, and after a multiple of 8 bytes
worth of other fields, so that there's no padding before or between them.

It's still not down to 64 bytes, which is the next lower power of 2, so
there's more work to do.

Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe
Reviewed-on: https://code.wireshark.org/review/31213
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2018-12-27 04:34:29 +00:00
Pascal Quantin f0b822f731 LTE RRC: add direction to UL-CCCH and DL-CCCH PDUs 
This will be useful for the RRC Early Data procedure.

Change-Id: Idcf4251315ee171aa15e650682d7e686a05a9e0a
Reviewed-on: https://code.wireshark.org/review/30185
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-10-13 05:17:13 +00:00
Pascal Quantin 0443cd2c95 XnAP: upgrade dissector to v15.1.0 
Change-Id: I2e15944580043774176956e896f360eb5a5711c8
Reviewed-on: https://code.wireshark.org/review/30045
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-10-07 15:47:23 +00:00
Pascal Quantin 5c878100b1 NGAP: prettify dissection 
Change-Id: I7da88236143e573fe5ff3e1d39df4643de43129c
Reviewed-on: https://code.wireshark.org/review/30035
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-10-05 18:56:25 +00:00
Pascal Quantin 3d77c3fc2c X2AP: fix dissection of SeNB to MeNB Container 
Change-Id: I4f5af9d52646d74dfa264583b6f0a79e097527e7
Reviewed-on: https://code.wireshark.org/review/30032
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-10-05 16:38:22 +00:00
Pascal Quantin 3887162e95 LTE RRC: fix RLC configuration for NB-IoT UE 
R15 introduced UM mode for DRBs.

Change-Id: Ifd9030a46bcb237d6e6c1909f2dbad3be3a4eb86
Reviewed-on: https://code.wireshark.org/review/30014
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-10-04 12:49:46 +00:00