packet_panes.c(304) : error C2220: warning treated as error - no 'object' file generated
packet_panes.c(304) : warning C4244: 'function' : conversion from 'gdouble' to 'int', possible loss of data
packet_panes.c(304) : warning C4244: 'function' : conversion from 'gdouble' to 'int', possible loss of data
Add casts, old code did the same casts so this should be OK.
svn path=/trunk/; revision=43730
object for each line - rather create one and use it for the entire list,
then destroy it.
Simplify the allocation of segments, by no longer messing around with a
static that may or may not be used. Also, there was a good chance the
last one would be leaked (if it was not part of the stream we are
interested in).
Note that both of these improvements would also apply to tcp_graph.c -
will wait a couple of days to be sure the changes are good.
svn path=/trunk/; revision=43654
When showing the TCP (and UDP and other protocols) port numbers in the
framelist columns, they are left aligned. This is sub-optimal if you are
scanning the list for a certain port.
This patch, very small, will properly right justify these numbers:
UNRESOLVED DST PORT
UNRESOLVED SRC PORT
DST PORT
SRC PORT
svn path=/trunk/; revision=43642
Fix an uninitialized-variable error that was breaking compile with gcc.
Also remove some cruft that looks like it was copy-pasted from
ui/gtk/tcp_graph.c
Fixes bug 7460.
svn path=/trunk/; revision=43635
disable hide checkboxes with error messages
Updated preference dialog to include text if hide checkbox is disabled.
Used error message for "Local Interfaces" dialog.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2598
svn path=/trunk/; revision=43622
IO Graph Fixes
- Allow counting *any* type of field, FT_NONE, FT_PROTOCOL, whatever, by moving
FT_NONE case to default case per Jakub's suggestion.
- Fix get_it_value() for FT_PROTOCOL fields by breaking CALC_TYPE_COUNT_FRAMES
and CALC_TYPE_COUNT_FIELDS out of the adv_type switch statement just like
COUNT_TYPE_FRAMES.
- Avoid an overflow in pixmap_clicked_event() that was causing crashes when
clicking outside the data portion of the graph (when the capture hasn't enough
files to fill the entire graph window),
svn path=/trunk/; revision=43621
Fix leaks
- don't g_strdup a string just to use it in a g_strdup_printf
- clean up properly in error cases in lua bindings
- misc. other missing g_free() calls
- one missing fclose() in the new 80211_utils
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7454
svn path=/trunk/; revision=43617
Add a new name resolution option: whether or not use the configured (in the OS)
name resolver (e.g., DNS) to resolve network names. When this option is disabled
but network name resolution is enabled then Wireshark will resolve only those
names that it can from local sources. This includes (at least, AFAIK):
- name resolutions that Wireshark picks up on from DNS packets it decodes
- the "user hosts file" (~/.wireshark/hosts on *NIX)
- what Wireshark reads out of capture file (the PCAPNG name resolution block)
This new preference defaults to "use external resolvers" for backward
compatibility (so people turning on network name resolution will get the old
behavior).
This option can be set via Edit->Preferences and on the command line; there
remain several UIs (e.g., the "open capture file" dialog, the
View->Name Resolution menu, etc.) that don't have the new option yet.
Also expand on the "description" for the name resolution preferences: these
are used not only in the tooltips but are also written to the preferences
file. The previous text didn't include enough context when written do the
preferences file.
svn path=/trunk/; revision=43605
implicitly by the #define name and string they were defined to; not all
UATs neatly fit into any of the categories, so some of them were put
into categories that weren't obviously correct for them, and one - the
display filter macro UAT - wasn't put into any category at all (which
caused crashes when editing them, as the GUI code that handled UAT
changes from a dialog assumed the category field was non-null).
The category was, in practice, used only to decide, in the
aforementioned GUI code, whether the packet summary pane needed to be
updated or not. It also offered no option of "don't update the packet
summary pane *and* don't redissect anything", which is what would be
appropriate for the display filter macro UAT.
Replace the category with a set of fields indicating what the UAT
affects; we currently offer "dissection", which applies to most UATs
(any UAT in libwireshark presumably affects dissection at a minimum) and
"the set of named fields that exist". Changing any UAT that affects
dissection requires a redissection; changing any UAT that affects the
set of named fields that exist requires a redissection *and* rebuilding
the packet summary pane.
Perhaps we also need "filtering", so that if you change a display filter
macro, we re-filter, in case the display is currently filtered with a
display filter that uses a macro that changed.
svn path=/trunk/; revision=43603
There is no guarantee that uat->category is non-null, so check whether
it's null before checking whether it's UAT_CAT_FIELDS or not.
Fixes bug 7444.
#BACKPORT
svn path=/trunk/; revision=43602
"Find Next Mark" was duplicated in the Edit menu and "Find Previous Mark" was
missing (the 2nd "Find Next Mark" would, if selected, find the previous mark).
svn path=/trunk/; revision=43600
some warnings from GTK+.
For interior nodes in the preference module tree, we create a page even
if the module itself has no preferences, so there's *something* we can
show if the user clicks on it. (Showing the top-level protocols page is
a bit weird, and requires us to keep track of it.)
svn path=/trunk/; revision=43596
Yes, the following files can now be deleted:
\wireshark\ui\gtk\prefs_nameres.c
\wireshark\ui\gtk\prefs_nameres.h
\wireshark\ui\gtk\prefs_print.c
\wireshark\ui\gtk\prefs_print.h
\wireshark\ui\gtk\prefs_protocols.c
\wireshark\ui\gtk\prefs_protocols.h
\wireshark\ui\gtk\prefs_taps.c
\wireshark\ui\gtk\prefs_taps.h
I thought removing them was part of the patch for bug 7402, but
they still show up in the SVN (perhaps I didn't create the patch
correctly).
Make it so.
svn path=/trunk/; revision=43591
Remove refresh button from wireless toolbar
With a "refresh interfaces" menu option and device hotplug
notification in place there is no longer need for a refresh
button in the toolbar.
svn path=/trunk/; revision=43570
Refresh wireless toolbar too
The recently improved refresh interfaces code forgot the wireless
toolbar. Make sure to refresh it too.
svn path=/trunk/; revision=43568
proto_tree_draw() from r43189 is lazy, and it don't fills tree with all item labels.
To fix it, move 'gbl_resolv_flags' hack to proto_tree_model_get_value().
XXX could we pass resolving flags to proto_item_fill_label()?
svn path=/trunk/; revision=43550
Jakub Zawadzki