Commit Graph

20886 Commits

Author SHA1 Message Date
Evan Huus 1931018a58 Check for overflow in the websocket dissector payload.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8448

svn path=/trunk/; revision=48336
2013-03-16 02:56:17 +00:00
Anders Broman 43e8a22781 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48334
2013-03-15 22:40:15 +00:00
Anders Broman f5a5b3d0fe From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48333
2013-03-15 22:39:37 +00:00
Evan Huus 7bd686fafb Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8481
Trivially wrong format string being passed to val_to_str().

svn path=/trunk/; revision=48332
2013-03-15 22:09:51 +00:00
Evan Huus 32799db42c Fix the leaking of packet comments, i.e. the rest of
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7530

The frame_data_cleanup function was ambiguous; it was being used for two
different purposes, and did neither of them quite properly. Split it instead
into frame_data_reset and frame_data_destroy, and call the correct one depending
on why we were originally calling frame_data_cleanup.

svn path=/trunk/; revision=48324
2013-03-15 18:04:50 +00:00
Evan Huus 574d1ceec3 Revert warning that seems to have been accidentally included in r48319.
svn path=/trunk/; revision=48323
2013-03-15 17:56:27 +00:00
Anders Broman 54eb4a6cec [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48319
2013-03-15 16:39:30 +00:00
Anders Broman 94d102adb4 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48318
2013-03-15 16:36:31 +00:00
Anders Broman ec4701ae72 Make the default port zero.
svn path=/trunk/; revision=48317
2013-03-15 16:35:54 +00:00
Stig Bjørlykke 187a884cea Update Lua BitOp to version 1.0.2
svn path=/trunk/; revision=48316
2013-03-15 15:15:00 +00:00
Anders Broman ef249623e6 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48313
2013-03-15 06:26:47 +00:00
Anders Broman aa3ebebefe From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48312
2013-03-15 05:42:50 +00:00
Anders Broman 39b85839b1 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48311
2013-03-15 05:42:24 +00:00
Anders Broman 4f1f9903f4 [-Wmissing-prototypes]
explicit casts.

svn path=/trunk/; revision=48310
2013-03-15 04:52:42 +00:00
Michael Mann 3a48e7e1e2 Bugfix Decryption Key Management dialog, bug 8446 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8446)
Needed to convert use of old IEEE802.11 preference strings to UAT.  Since UAT is self-contained within its own file, the entire preference file doesn't need to be rewritten/saved when UAT values are changed.

svn path=/trunk/; revision=48308
2013-03-15 01:31:53 +00:00
Jaap Keuter 930deed11d From Tyson Key:
I have just finished slightly refactoring part of the PN532 dissector's  
with InListPassiveTarget Response handler, to resolve some issues where 
ISO 14443-A UIDs of various lengths in the aforementioned packet types 
are incorrectly dissected.

The patch also introduces basic support for identifying, and dissecting 
InListPassiveTarget Responses from cards/tokens with variable-length 
Answer To Select (ATS) payloads, such as contactless EMV payment smartcards. 

svn path=/trunk/; revision=48306
2013-03-14 23:09:58 +00:00
Anders Broman 5970ee5a65 From beroset:
remove C++ incompatibilities from packet-catapult-dct2000.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48305
2013-03-14 22:10:59 +00:00
Anders Broman f2266d87f5 [-Wmissing-prototypes]
explicit casts.

svn path=/trunk/; revision=48302
2013-03-14 19:01:06 +00:00
Anders Broman ffaf67b615 from Katrina Zhang:
According to the latest TS29.274 -- adding 4 IE support: H(e)NB Information Reporting[165]; IPv4 Configuration Parameters (IP4CP)[166]; Change to Report Flags[167]; Action Indication[168]

 -- cause values of IE(Cause)

svn path=/trunk/; revision=48301
2013-03-14 19:00:40 +00:00
Anders Broman fe5848271f from Katrina Zhang:
Adding Bit 5 support of AVP(IDR-Flags)

svn path=/trunk/; revision=48300
2013-03-14 18:59:56 +00:00
Anders Broman 96e7b183fb From beroset:
patch to remove C++ incompatibilities from packet-lmp.c
renamed class to lmp_class

remove C++ incompatibilities from packet-rcpap.c
renamed class to inst_class (instruction class).

remove C++ incompatibilities from emem.c and oids.c

remove C++ incompatibilities from packet-radius.c

remove C++ incompatibilities from packet-enip.c


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48299
2013-03-14 18:58:42 +00:00
Bill Meier 77376a2363 Change "4 space tabs" indentation to use "4 spaces" indentation.
Also:
- remove some unneeded initializers;
- remove several unneeded 'col_clear()' calls;
- guint8 --> guint to prevent a possible overflow;
- reformat for style in some cases.


svn path=/trunk/; revision=48297
2013-03-14 14:42:12 +00:00
Stig Bjørlykke 8dfa2eac7e Set correct item lengths. They cannot all be until end of buffer.
svn path=/trunk/; revision=48296
2013-03-14 12:23:05 +00:00
Stig Bjørlykke d9aff2d872 Fixed an indent to avoid a warning: for loop has empty body [-Wempty-body]
svn path=/trunk/; revision=48294
2013-03-14 08:41:11 +00:00
Anders Broman b539916835 [-Wmissing-prototypes]
explicit casts.

svn path=/trunk/; revision=48293
2013-03-14 07:37:13 +00:00
Martin Kaiser 3fa84d8af5 From Weston Schmidt
fix DSM-CC CRC calculation
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8466

svn path=/trunk/; revision=48292
2013-03-14 07:01:37 +00:00
Anders Broman 14613716ea From beroset:
remove C++ incompatibilities from gcp.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48291
2013-03-14 06:47:05 +00:00
Anders Broman 1d16d95443 From beroset:
changed implicit casts to explicit casts and changed name of field from new to new_d (new dissector)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48290
2013-03-14 06:46:29 +00:00
Anders Broman e022d129bd From beroset:
made implicit casts explicit and changed a number of fields and function return values from base_display_e to unsigned because the enum was not a comprehensive list of all possible values

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48289
2013-03-14 06:45:55 +00:00
Anders Broman 44be81ba93 From beroset:
changed implicit casts to explicit and substituted se_new for se_alloc

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48288
2013-03-14 06:45:23 +00:00
Anders Broman 672a54c156 From beroset:
converted implicit casts to explicit casts, moved nested structure definition outside, and changed se_alloc to se_new.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48287
2013-03-14 06:31:31 +00:00
Anders Broman fad318ad44 From beroset:
changed implicit casts to explicit casts and corrected one erroneous cast (from void* to void**)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48286
2013-03-14 06:26:55 +00:00
Martin Kaiser 455139f4be dissect more descriptors in the AIT
svn path=/trunk/; revision=48285
2013-03-13 23:26:09 +00:00
Martin Kaiser 8772db463a actx is used, remove _U_
svn path=/trunk/; revision=48284
2013-03-13 22:54:46 +00:00
Anders Broman 04766017df - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48282
2013-03-13 21:14:20 +00:00
Alexis La Goutte 1d74daaec3 Remove unused bgp_route_refresh struct
svn path=/trunk/; revision=48278
2013-03-13 15:02:17 +00:00
Alexis La Goutte e22e3eeb0e From chaitanya via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8354 Add support for WAPI parameter set IE dissection
Need to add support for WAPI parameter set IE in management frames.
We already have WAI frames dissection support in place.

From me:
Small changes...
- Add links to WAPI specs
- Replace tabs by space
- Remove whitespaces

svn path=/trunk/; revision=48276
2013-03-13 14:49:46 +00:00
Irene Rüngeler 44e6a88b13 Add interface options preferences.
svn path=/trunk/; revision=48275
2013-03-13 12:38:08 +00:00
Anders Broman 27fc641a79 - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48274
2013-03-12 23:09:37 +00:00
Martin Kaiser f58e2cc90a dissect Application Signalling Descriptor
svn path=/trunk/; revision=48273
2013-03-12 22:04:09 +00:00
Anders Broman 221b249acd svn path=/trunk/; revision=48272 2013-03-12 21:58:04 +00:00
Martin Kaiser 7c10fd2724 use correct data type in the cast
this fixes
packet-afs.c: In function 'dissect_afs':
packet-afs.c:1539:35: error: expected expression before ')' token


svn path=/trunk/; revision=48266
2013-03-12 20:14:45 +00:00
Anders Broman 455f5c8243 - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48265
2013-03-12 20:00:50 +00:00
Anders Broman 97bb558394 Introduce a preference to select how Websocket text should be dissected.
svn path=/trunk/; revision=48264
2013-03-12 19:16:35 +00:00
Anders Broman 30a9b4855d Detect HTTP/1.1 heuristically.
svn path=/trunk/; revision=48263
2013-03-12 19:15:39 +00:00
Jaap Keuter 827eb58b04 From David Arnold:
Replace use of INCLUDES with AM_CPPFLAGS in all Makefiles to placate recent autotools.

svn path=/trunk/; revision=48261
2013-03-12 06:53:39 +00:00
Anders Broman 2cc00294c7 Use explicit casts.
svn path=/trunk/; revision=48260
2013-03-12 06:41:00 +00:00
Anders Broman d0efafbcb1 From beroset:
remove C++ incompatibilities from UAT_VS_DEF macro and all uses

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48259
2013-03-12 06:40:13 +00:00
Ronnie Sahlberg d249e6111a SPC-3 and later has a 16-bit allocation length for the INQUIRY allocation
length.

While SPC-2 only has one byte for allocation length

Change this to treat allocation length as a 16 bit quantity starting one byte prior to the current single byte that wireshark dissects.
This makes it correct for SPC-3 and later  and still works for SPC-2 since that first byte is reserverd, == must be 0, in SPC-2 and prior.
  

svn path=/trunk/; revision=48258
2013-03-12 01:25:06 +00:00
Chris Maynard 756824e919 Fix Coverity CID 989732: Structurally dead code.
Also, change a few tabs -> spaces.  Add modelines.

svn path=/trunk/; revision=48257
2013-03-11 20:50:19 +00:00