Commit Graph

39518 Commits

Author SHA1 Message Date
Jeff Morriss 18f0ab61cb From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6946 :
Support for DCCP Simultaneous-Open for NAT Traversal, RFC 5596.  A new packet
format is supported.  I did a little code cleanup too.

svn path=/trunk/; revision=41543
2012-03-14 01:39:24 +00:00
Jeff Morriss 603b4d4348 Don't free idb_inf in wtap_dump_open_ng(): free it in the callers. This fixes the double-free editcap crashes that the buildbot's been seeing lately.
svn path=/trunk/; revision=41542
2012-03-14 01:08:09 +00:00
Gerald Combs e60c1286b2 Add a "fileformats" suite (copied from the I/O suite) to check file
format conversion. So far we check nanosecond pcap, microsecond pcap-ng
and nanosecond pcap-ng against standard pcap.

Fix color output on OS X.

svn path=/trunk/; revision=41541
2012-03-13 19:58:19 +00:00
Bill Meier f2590414a3 Use tvb_new_subset_remaining(...) instead of tvb_new_subset(..., -1, -1);
Use value_string_ext to reference a value_string;
Use global tfs_set_notset instead of a local version displaying the values incorrectly;
Slightly enhance display of the LWAPP Control Message.

svn path=/trunk/; revision=41540
2012-03-13 18:35:09 +00:00
Bill Meier 8caed06a76 Use tvb_new_subset_remaining(...) in place of tvb_new_subset(..., -1, -1);
Use value_string_ext to reference a few value_strings;
Use val_to_str_const() in place of val_to_str() in a few cases;
Use BASE_NONE for a few hf[] FT_BOOLEAN entries with 0x0 bitmask.

svn path=/trunk/; revision=41539
2012-03-13 17:21:46 +00:00
Jeff Morriss 27b7fa96af Remove a couple trailing commas
svn path=/trunk/; revision=41538
2012-03-13 16:49:43 +00:00
Jeff Morriss d0c997bc0b Fix up indentation/white space. Use global tfs_yes_no instead of local version.
svn path=/trunk/; revision=41537
2012-03-13 16:47:11 +00:00
Jeff Morriss 7ca19c7df7 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6947 :
Don't leave a space at the end of the MSISDN string.

svn path=/trunk/; revision=41536
2012-03-13 15:43:41 +00:00
Anders Broman ba7c0cb1b9 From Jose Pedro Oliveira:
dumpcap.c: code cleaning 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718

svn path=/trunk/; revision=41535
2012-03-13 15:27:22 +00:00
Anders Broman 0e4998190f From Jose Pedro Oliveira:
Remove a printf line in wiretap/pcapng.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718

svn path=/trunk/; revision=41534
2012-03-13 15:26:36 +00:00
Jeff Morriss 570165def8 Remove if(tree) to address https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6940#c3
svn path=/trunk/; revision=41533
2012-03-13 15:19:29 +00:00
Jeff Morriss e043774143 Add detailed decoding for Framed-IPv6-Prefix.
svn path=/trunk/; revision=41532
2012-03-13 15:06:40 +00:00
Jeff Morriss 55634ab2e3 Don't mark a couple of unused parameters are unused.
svn path=/trunk/; revision=41531
2012-03-13 14:43:45 +00:00
Anders Broman 7605b01482 From Jose Pedro Oliveira:
the shb_userappl value wasn't being changed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6937

svn path=/trunk/; revision=41530
2012-03-13 14:11:08 +00:00
Jeff Morriss 9e1c8e6b34 (sigh) Take out the whole if(tree) as Chris suggested. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6903#c14
svn path=/trunk/; revision=41529
2012-03-13 13:53:01 +00:00
Jeff Morriss a63bb0db38 Move the col_set_str() outside the if(tree) to address https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6903#c7
svn path=/trunk/; revision=41528
2012-03-13 13:43:19 +00:00
Anders Broman 9e2c39d167 H248 package updates from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 applied by hand.
svn path=/trunk/; revision=41527
2012-03-13 13:41:28 +00:00
Anders Broman fd19aa7c89 H.248 Annex E dissector does not properly dissect event parameters
(Update the h.248 dissector's package registration to support v1 packets.)

Applying part of the patch from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 by hand.
Fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842

svn path=/trunk/; revision=41526
2012-03-13 13:26:13 +00:00
Anders Broman 16a7f0db08 From Weston Schmidt:
Make mpeg-sect CRC checking a preference defaulting to off.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6944

svn path=/trunk/; revision=41525
2012-03-13 11:26:37 +00:00
Anders Broman ead0764cd9 A modified version of "pcapng: shd_userappl in newly created files"
to only add the name if no name if there yet. Original patch from
Jose Pedro Oliveira. 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6937

svn path=/trunk/; revision=41524
2012-03-13 09:13:27 +00:00
Anders Broman 45c342dfdb From Weston Schmidt:
Update packet-mpeg-sect to support CRCs & simpler header processing for subdissectors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6941

svn path=/trunk/; revision=41523
2012-03-13 08:57:04 +00:00
Anders Broman bb611755e9 Add data structure to hold information from ISB:s
svn path=/trunk/; revision=41522
2012-03-13 08:36:52 +00:00
Guy Harris cd1debf183 Add an explicit capture_cb_capture_failed indication for the case where
we weren't even able to start a capture, rather than delivering a fake
"capture start" indication and relying on a later "capture file closed"
indication - for a capture that was never opened in the first place - to
handle GUI cleanups.

Don't deliver any GUI indications in cf_close() if we didn't have a
capture file open in the first place.

Clear the status bar and welcome header if that indication is delivered.

If we start a capture from the command line with the -k flag, don't show
the captured packet information unless the capture actually starts.

svn path=/trunk/; revision=41521
2012-03-13 08:36:25 +00:00
Anders Broman fd4894c8f8 From Tyson Key: Support for dissection of PN532 payloads in USB CCID packets. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6940
svn path=/trunk/; revision=41520
2012-03-13 06:34:32 +00:00
Guy Harris dce6f88487 SystemConfiguration framework, not IOKit?
svn path=/trunk/; revision=41519
2012-03-13 05:02:48 +00:00
Guy Harris b85eebdd7e Suggest a better way of getting the interface type on OS X.
svn path=/trunk/; revision=41518
2012-03-13 05:02:16 +00:00
Guy Harris fa64659e93 Closing a capture file has nothing to do with the list of interfaces on
which to do a live capture; don't clear the latter list when closing the
capture file.

collect_ifaces() should clear out the existing list of interfaces before
filling that list up with the interfaces selected by the user.  In
addition, when it frees up interfaces in that list, it should free up
the strings attached to those interfaces.

svn path=/trunk/; revision=41517
2012-03-13 03:48:27 +00:00
Jeff Morriss 07e797272e From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6938 :
Don't limit CSeq to 2**31-1 (2147483647): use stroul() instead of atoi() in
several places.

svn path=/trunk/; revision=41516
2012-03-13 01:40:18 +00:00
Jeff Morriss 9a376de135 From Stephen Donnelly via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6943 :
The ERF extension header 'New BFS' is poorly named, it is not descriptive.

Rename the ERF 'New BFS' extension header to 'Signature' which is more
descriptive, more easily distinguished, and consistent with the internal
naming.

svn path=/trunk/; revision=41515
2012-03-13 01:22:36 +00:00
Jeff Morriss 9c3bbf44c1 From Peter Harris:
An enum name collision was recently added to the upstream XCB/proto.
Avoid the collision by putting enum names into their proper namespace.


After applying that, regenerate the X11 dissector.

svn path=/trunk/; revision=41514
2012-03-13 00:07:34 +00:00
Alexis La Goutte 20a52095aa Enhance and update IPv6 Option of Extension Header
* Make field filterable...
* Display unknown option payload 

svn path=/trunk/; revision=41513
2012-03-12 23:13:03 +00:00
Jeff Morriss 9e39f85451 Code=100 is Framed-IPv6-Pool, not (another copy of) Framed-IPv6-Prefix
svn path=/trunk/; revision=41512
2012-03-12 19:31:26 +00:00
Bill Meier 2a85938450 Use tvb_new_subset_remaining(...) instead of tvb_new_subset(..., -1, -1);
expert_add_info_format() must be called even when 'tree == NULL' so that MALDORMED
  will appear in the INFO column.
Do various whitespace & formatting changes.

svn path=/trunk/; revision=41511
2012-03-12 19:25:20 +00:00
Bill Meier caa377a99f Use tvb_new_subset_remaining(...) in place of tvb_new_subset(..., -1, -1);
Remove unneeded calls to col_clear();
Define dissect_dvb_data_mpe() to be static;
Do some minor whitespace changes.

svn path=/trunk/; revision=41510
2012-03-12 17:53:58 +00:00
Jeff Morriss 2df50d5269 Fix a typo in a function name and some indentation.
svn path=/trunk/; revision=41509
2012-03-12 17:30:38 +00:00
Stig Bjørlykke 377ea887bb Improved a if-check to avoid a analyzis warning.
svn path=/trunk/; revision=41508
2012-03-12 17:18:54 +00:00
Stig Bjørlykke da8cd5d5bd Value can't be negative if no_of_bits == 0
svn path=/trunk/; revision=41507
2012-03-12 17:18:04 +00:00
Anders Broman 35bf2e9619 From Jose Pedro Oliveira:
Enforce the modelines in wiretap/pcapng.c

svn path=/trunk/; revision=41506
2012-03-12 15:43:59 +00:00
Anders Broman cbde63643e From Jose Pedro Oliveira:
Enforce the modelines in dumpcap.c and in pcapio.c

svn path=/trunk/; revision=41505
2012-03-12 15:40:57 +00:00
Bill Meier 0400088936 Minor reformatting, whitespace and style changes.
svn path=/trunk/; revision=41504
2012-03-12 15:15:39 +00:00
Bill Meier 3dd8ed0279 Use consistent indentation;
Do minor reformatting.

svn path=/trunk/; revision=41503
2012-03-12 14:40:09 +00:00
Bill Meier ba2cda4ef0 Cleanup & minor bug fixes:
- Don't put a value_string array in a .h file (included in several .c files);
- 'if ((a!=NULL) && !b) {fail}' should be 'if ((a==NULL) || !b) {fail}' in a few cases;
- Use value_string_ext as appropriate;
- Use val_to_str_const() in place of val_to_str() as appropriate;
- Use tvb_new_subset_remaining(...) instead of tvb_new_subset(..., -1, -1);
- Use tvb_reported_length_remaining() in place of tvb_length_remaining() in some cases;
- tvb_reported_length_remaining() can return -1;
- Use of TFS(&true_false) not req'd since "True"/"False" is the default if no TFS provided;
- Reformat various (long lines, etc);
- Use consistent indentation.

svn path=/trunk/; revision=41502
2012-03-12 14:38:59 +00:00
Anders Broman 3394b453af Free idb_inf and shb_hdr when done.
svn path=/trunk/; revision=41501
2012-03-12 14:18:04 +00:00
Martin Mathieson d772d2acd2 Add checkboxes to filter for RACH attempts and SRs.
svn path=/trunk/; revision=41500
2012-03-12 13:19:28 +00:00
Martin Mathieson 9560aab8c2 Add a checkbox to filter for RACH attempts.
svn path=/trunk/; revision=41499
2012-03-12 13:18:56 +00:00
Anders Broman b2515852f9 Add doxygen tags.
svn path=/trunk/; revision=41498
2012-03-12 12:18:02 +00:00
Anders Broman 755f8dc98d From Tyson Key:
Dissector for the NXP PN532 protocol

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6903

svn path=/trunk/; revision=41497
2012-03-12 08:55:14 +00:00
Anders Broman 8fa5ef33f9 From Jose Pedro Oliveira: Add Modlines
svn path=/trunk/; revision=41496
2012-03-12 06:42:47 +00:00
Anders Broman 1a8f3eddc7 From Jose Pedro Oliveira: Add Modlines
svn path=/trunk/; revision=41495
2012-03-12 06:39:45 +00:00
Guy Harris 3af7f28931 capture_opts_add_iface_opt() is not used outside capture_opts.c; make it
static.

svn path=/trunk/; revision=41494
2012-03-12 02:53:21 +00:00