Commit Graph

35 Commits

Author SHA1 Message Date
Bill Meier ceebccced4 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25607
2008-06-26 00:16:58 +00:00
Jeff Morriss a215dadd21 pol_value->name was g_malloc()'d which meant we needed to go through the hash table to free them all. But, like in http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1113 the pol_value's themselves are se_ allocated so they have already been freed when we want to traverse them. So, make pol_value->name se_ allocated so we don't have to do any cleanup on the hash table.
svn path=/trunk/; revision=24668
2008-03-17 17:40:54 +00:00
Bill Meier bad9f18d33 Fix (Sun) compiler warnings as reported by David Kirkby: Part 1
svn path=/trunk/; revision=24295
2008-02-09 23:35:28 +00:00
Stig Bjørlykke d5d2e97b47 Fixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.
svn path=/trunk/; revision=24180
2008-01-24 19:30:43 +00:00
Richard van der Hoff e704e4c8c4 From Chris Maynard <christopher.maynard@gtech.com> / Bug 1798: packet-d*.c display filter fields incorrectly named.
svn path=/trunk/; revision=23090
2007-10-08 00:32:03 +00:00
Ronnie Sahlberg 8fde3b7561 rename dcerpc_smb_store_pol_name to dcerpc_store_polhnd_name
rename dcerpc_smb_fetch_pol  to dcerpc_fetch_polhnd_data and also make 
it take an additional parameter to return the "type" of the policy 
handle, if such a type was stored.

extend the pol_value structure used to track policy handles to also 
store a type to represent what created the policy handle
types could be USER/ALIAS/CONNECT/... etc handles returned from the 
SAMR interface

add a new helper function  dcerpc_store_polhnd_type()

track policy handles between request/responses for dcerpc

update the samr.cnf file to make the samr dissectors for
SetSecurity/QuerySecurity dissect the specific bits for the security 
descriptor correctly based on whether the policy handle refers to a 
CONNECT/DOMAIN/USER/ALIAS or GROUP



svn path=/trunk/; revision=22703
2007-08-28 11:45:08 +00:00
Ronnie Sahlberg 50a23f1970 when creating a policy handle, use the string stored in dcv if
available as the name of the handle

This means we can show policy handles like
OpenKey(/a/b/c/d)
instead of 
OpenKey(<...>)




svn path=/trunk/; revision=21719
2007-05-07 19:21:37 +00:00
Jeff Morriss 62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Ronnie Sahlberg 8ed1260c2c add a field in pinfo where dcerpc/pidl can store the name of the current dcerpc procedure
use this field in the policy handle helper to indicate not only which frames the handle was opened/close in but also the name of the function that opened it.
eventually, when other pidl support infrastructure is developed it would be nice if this could be expanded to also contain the name of the object/handle opened.



svn path=/trunk/; revision=20895
2007-02-21 20:21:11 +00:00
Ronnie Sahlberg 83c66c05e9 add a PIDL specific helper for managing dissection of policy handles.
let this helper take a parameter to describe how the policy handle should be
managed (is this an open, close ?) to improve policy handle tracking.
(centralizing to a single function of code makes other changes easier)

create defines to indicate OPEN/CLOSE and use them as a start/test in the winreg conformance file.



svn path=/trunk/; revision=20872
2007-02-20 09:01:50 +00:00
Ronnie Sahlberg ff901e2b0e strings we pass up to the caller through private_data are now of ep scope
this closes a few memory leaks


svn path=/trunk/; revision=19242
2006-09-16 09:10:23 +00:00
Ulf Lamping f17222a893 FT_STRING -> FT_GUID
svn path=/trunk/; revision=18931
2006-08-16 20:55:21 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Guy Harris f1a5571448 Turn the handle types into an enum, so that they're more likely to be
displayed by name in debuggers and so that switch statements can check
whether all types are handled.

Add a check for an unknown handle type, to squelch compiler warnings
(and to catch missing handle type code at run-time, if new handle types
are added).

svn path=/trunk/; revision=17671
2006-03-19 20:21:56 +00:00
Ronnie Sahlberg 60590c0163 fix a potential assignment of a wild pointer
fixes coverity cid 128


svn path=/trunk/; revision=17511
2006-03-07 20:52:23 +00:00
Jörg Mayer eff40f65db Trivial warning fixes
svn path=/trunk/; revision=16561
2005-11-22 12:51:14 +00:00
Ronnie Sahlberg 9f6c2b3ed5 a guid is only 16 bytes so dont highlight 20 bytes in the hexpane
svn path=/trunk/; revision=16481
2005-11-12 01:21:43 +00:00
Ronnie Sahlberg ebcdb60414 in smb2 the file handles are not normal context handles they are just a guid
make them a guid in smb2 dissector and make tim pottesr excellent conmtext handle tracking also able to do the same thing for GUIDs


( a context handle is just a 32 biut attribute field followed by a uuid anyway)




svn path=/trunk/; revision=16477
2005-11-11 22:12:10 +00:00
Gerald Combs 93b99abf30 In packet-dcerpc-nt.c, make sure we call init_pol_hash() each time we load
a capture file.  This should fix bug #536.

Make sure we initialize our hash tables in packet-dcerpc-nt.c and several 
other files.  Fix up whitespace while we're at it.

svn path=/trunk/; revision=16255
2005-10-17 18:56:27 +00:00
Ronnie Sahlberg c30eeef7d8 some more gmemchunk -> se_alloc() updates
there are only 5 gmemchunks left   but they have different litetime for their allocations   than the 100+   ones that have been removed.

The remaining 5 should be converted some other way.




svn path=/trunk/; revision=15328
2005-08-13 01:29:31 +00:00
Ronnie Sahlberg efa1f43005 convert some tvb_fake_unicode() to tvb_get_ephemeral_faked_unicode()
svn path=/trunk/; revision=15272
2005-08-10 14:17:27 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Jörg Mayer 7b2ff03d8c Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15169
2005-08-02 04:31:42 +00:00
Ronnie Sahlberg df2d1d3f22 ememify some more calls to tvb_get_string()
this fixes an obvious memleak in ms-mms


svn path=/trunk/; revision=15132
2005-07-28 09:56:19 +00:00
Jörg Mayer 7949c7f31c char -> const char warning fixes
svn path=/trunk/; revision=15079
2005-07-26 08:01:16 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Ronnie Sahlberg d525ccb6f9 preparations for autogenerated ms dcerpc interfaces
make it possible to prettify SIDs and control how and where their string representation should be shown in the summary line and the tree
similar to how counted_strings prettification can be controlled


svn path=/trunk/; revision=13413
2005-02-16 11:31:56 +00:00
Ronnie Sahlberg 8851ebc541 mark the frame opened/closed fields for policy handles as GENERATED fields
svn path=/trunk/; revision=13412
2005-02-16 10:25:00 +00:00
Guy Harris 17e0d15df3 Move "dissect_nt_GUID()" into "packet-dcerpc-nt.c", as it's used by the
LSA dissector as well, and declare it in "packet-dcerpc-nt.h".

svn path=/trunk/; revision=13223
2005-02-01 05:21:08 +00:00
Ronnie Sahlberg 95b0d123ba add a new dissect_ndr_counted_ascii_string() that mimics dissect_ndr_counted_string() but handles an ASCII string instead of a Unicode one.
svn path=/trunk/; revision=13204
2005-01-30 11:56:37 +00:00
Guy Harris cdaf516b8b Byte arrays are byte arrays, not strings.
svn path=/trunk/; revision=13203
2005-01-30 03:43:03 +00:00
Ronnie Sahlberg 0431c0c49f change dissect_ndr_counted_byte_array to be more consistent with dissect_ndr_counted_string
svn path=/trunk/; revision=13202
2005-01-30 02:52:25 +00:00
Guy Harris 13bb12c4f1 Move a bunch of stuff that's more Windows-related than SMB-related to
"packet-windows-common.[ch]".

svn path=/trunk/; revision=11592
2004-08-03 02:28:49 +00:00
Guy Harris 135dd00b14 Don't drag in a huge pile of headers in "packet-smb-common.h"; rely on
the files including it to include what they need.

svn path=/trunk/; revision=11588
2004-08-02 23:40:09 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00