Commit Graph

756 Commits

Author SHA1 Message Date
Guy Harris 7ddca7ecaf From Lars Roland:
Add Response-Time statistics for each known mgcp message-type.

	Fix a few bugs and remove trailing whitespace.

	Use "gdouble" for printing time-values and calculating the
	average.  It is easier to use and shouldn't overflow on big
	trace files like "guint32".

	Move some functions for time statistics into the new file
	timestats.c in the main directory.  This code may be useful in
	the rpc and smb rtt-taps as well.

svn path=/trunk/; revision=7469
2003-04-16 07:25:12 +00:00
Guy Harris 2678786425 Pull the stuff done in "dissect_packet()" to initialize a column_info
structure into its own routine; rename "col_init()" to "col_setup()",
and call the new routine "col_init()".

svn path=/trunk/; revision=7467
2003-04-16 05:55:41 +00:00
Guy Harris 24ec2110d1 Add the notion of a "fence" to columns. A dissector can set the fence
to "protect" what's currently in the column, so that attempts to clear
the column will only clear stuff after the fence and attempts to
overwrite the column will append stuff after the fence.  This, for
example, allows a dissector to arrange that the Info column contain
information for its protocol and for protocols running atop it.

svn path=/trunk/; revision=7466
2003-04-16 04:52:55 +00:00
Guy Harris d9cc10f2f5 From emre: add a "Filter out this stream" button to the "Follow TCP
Stream" window, which adds "and !(<filter for the stream>)" to the
display filter in effect before the stream was followed, removing that
stream from the display.

svn path=/trunk/; revision=7408
2003-04-06 22:41:34 +00:00
Guy Harris ab84d8be6e Change the version messages to put the "compiled with" stuff on a
separate line, and to put the "running with" info on a separate line
from that, to make the output narrower.

svn path=/trunk/; revision=7344
2003-03-12 00:07:46 +00:00
Guy Harris 50899dad38 When registering a string preference, if the value of the preference is
NULL, convert it to a copy of a null string, otherwise replace it with a
copy of the string, so that we know that the variable for the preference
always points to a string that can be freed.

That also obviates the need to worry about a null-pointer value for a
preference variable when checking to see whether a preference has changed.

When checking for a string preference not being set, check for an empty
string, not a null pointer - the above code turns null pointers into
pointers to empty strings, *and* the GUI code does (and always did!) the
same.

svn path=/trunk/; revision=7343
2003-03-11 23:14:42 +00:00
Ronnie Sahlberg 88959c985c Fixed two small bugs in tap_rtp.c
1, specify a tap filter that ignores all ICMP packets
2, specify a tap filter that only matches the same conversation ip/udp
as the selected packet.

svn path=/trunk/; revision=7341
2003-03-11 08:46:26 +00:00
Guy Harris 2a848c34ad Have the "Save voice data as..." button in the RTP analysis dialog box
pop up a file selection box with the save options, rather than a dialog
box with the save options, a file name, and a button to click to get the
file selection box.

svn path=/trunk/; revision=7331
2003-03-10 02:09:29 +00:00
Jörg Mayer 9281a04064 Pointer <--> int converions cause warnings on ia64.
Modified a patch originally contained in the SuSE distro
to do the conversions via glib macros.

svn path=/trunk/; revision=7330
2003-03-10 02:06:33 +00:00
Guy Harris 170b5028e9 Put the code to get version numbers of various libraries with which
Ethereal/Tethereal was linked into a common routine, and use that in
both Ethereal and Tethereal.

Add to that routine code to get OS version information.

svn path=/trunk/; revision=7320
2003-03-08 07:00:48 +00:00
Gerald Combs 40606a6ed2 Add an average packet size, as suggested by Daniel Jackson.
svn path=/trunk/; revision=7313
2003-03-07 20:27:02 +00:00
Guy Harris fb65eca073 Include <io.h>, if present, to get "_open()", "_close()", etc. declared.
svn path=/trunk/; revision=7312
2003-03-07 19:47:07 +00:00
Jörg Mayer d7bcd8e261 Declare f_tempname and r_tempname static
svn path=/trunk/; revision=7307
2003-03-07 01:18:21 +00:00
Guy Harris a7d60117c4 NO_DATA is apparently #defined by some header file when building with
MSVC++ on Windows - stick TAP_RTP_ in front of all the error enum
values, to avoid name collisions.

Do *NOT* allocate a zero-length array as an automatic variable,
especially if you're going to assign to the first element of that
array....

svn path=/trunk/; revision=7304
2003-03-07 00:03:47 +00:00
Guy Harris 60ab93fa97 Get rid of CRs.
Get rid of comments about the format string to use with guint16 and
guint32 - we're using the right string, which is neither "%lu" (as that
requires a 64-bit argument on platforms with 64-bit longs) nor "%d" (as
that expects a *signed* quantity, not an *unsigned* quantity), but "%u".

Protect the include of <unistd.h> with "#ifdef HAVE_UNISTD_H", as it's
not present on Windows if you're not building with a UNIXalike wrapper
library.

Use "wb", not "w", when creating binary files with "fopen()"; the "b" is
required on Windows.

Use O_BINARY when opening binary files, and #define it as 0 if it's not
defined; O_BINARY is required on Windows.

svn path=/trunk/; revision=7303
2003-03-06 23:09:09 +00:00
Guy Harris 4af8b71f79 Get rid of CRs.
svn path=/trunk/; revision=7301
2003-03-06 22:36:43 +00:00
Laurent Deniel 58a4a837e0 Move RTP Analysis to Statistics menu
(all taps should be located here especially
 very protocol specific ones)

svn path=/trunk/; revision=7299
2003-03-06 21:21:43 +00:00
Laurent Deniel d17a08f9cd - Protect tap_rtp.h against multiple inclusions
- Add $Id$ to tap_rtp.[hc]

svn path=/trunk/; revision=7298
2003-03-06 21:15:59 +00:00
Ronnie Sahlberg 05dad0c310 From Miha Jemec :
Functionality to reassemble a RTP stream and save it as a file.
Support for G.711 coded

svn path=/trunk/; revision=7297
2003-03-06 20:35:12 +00:00
Guy Harris 60de380663 From Devin Heitmueller: follow TCP Stream support for showing stream
data as C byte arrays.

svn path=/trunk/; revision=7291
2003-03-06 04:23:51 +00:00
Guy Harris ff1c297602 "gtk_box_pack_end()" expects a GtkBox, not a GtkContainer, as its first
argument.

svn path=/trunk/; revision=7289
2003-03-05 20:12:04 +00:00
Gerald Combs c0333e2784 Eliminate vertical padding in the IO Stat window.
svn path=/trunk/; revision=7286
2003-03-05 15:54:31 +00:00
Laurent Deniel 60c415087a - fix FAQ display (faq_help[] was not initialised before strcat
so random characters at first line display if not worst,
  finally remove this strcat stuff and directly call insert_text
  with each faq_part)

- add missing FAQ redraw in help_redraw

- put FAQ after Capture Filters to restore original order
  (i.e. Display near Capture Filters)

- udpate overview according to manual page

svn path=/trunk/; revision=7263
2003-03-03 21:59:42 +00:00
Guy Harris 300aa657cc Get rid of unneeded includes of "../ui_util.h".
svn path=/trunk/; revision=7257
2003-03-02 22:31:25 +00:00
Guy Harris f0a746497a Use "goto_frame()" to go to a given frame number, not
"packet_list_set_selected_row()" - frame N isn't necessarily being
displayed as row N-1.

svn path=/trunk/; revision=7256
2003-03-02 22:25:49 +00:00
Guy Harris 6c9deead35 Have "goto_frame()" put up error dialog boxes itself, rather than having
its callers put up the same error dialog boxes.  Have it just return a
success vs. failure Boolean.

svn path=/trunk/; revision=7254
2003-03-02 22:07:25 +00:00
Jörg Mayer adbb66a68c Remove wip comments
svn path=/trunk/; revision=7250
2003-03-02 19:21:31 +00:00
Jörg Mayer 4f8247dc2b Split FAQ into shorter lines before including it into the gtk help dialog.
Ignore tmp files generated by make-faq.
Update FAQ.

svn path=/trunk/; revision=7249
2003-03-02 17:42:37 +00:00
Laurent Deniel a539d5616e Change some plugin window geometry aspects.
svn path=/trunk/; revision=7248
2003-03-02 17:14:08 +00:00
Laurent Deniel 3aa593f0d5 Add type of filter in capture/display filter windows.
svn path=/trunk/; revision=7246
2003-03-02 13:46:01 +00:00
Olivier Abad f0f7ae0280 Replace gdk_string_width and gdk_string_height with
pango_layout_get_pixel_size in gtk2 code.

svn path=/trunk/; revision=7245
2003-03-01 17:39:53 +00:00
Laurent Deniel 9c27b912d6 Add an "Apply" button to "Decode As" window.
svn path=/trunk/; revision=7243
2003-03-01 13:08:59 +00:00
Guy Harris cc90efa654 The correct way to go to a frame with a given number is to use
"goto_frame()", not to assume that all frames are being displayed and to
go to the row whose number is the frame number - 1.

svn path=/trunk/; revision=7242
2003-03-01 10:18:54 +00:00
Guy Harris bedd818b3f From Pavel Roskin: in the GTK+ 2 code, associate the "Print Detail"
button with the correct group.

svn path=/trunk/; revision=7183
2003-02-21 21:06:27 +00:00
Olivier Abad c4ec808aad In gtk2, the "changed" signal is sent by the GtkTreeSelection, not the
GtkTreeView.

svn path=/trunk/; revision=7161
2003-02-17 21:08:37 +00:00
Olivier Abad abe08df6d7 In gtk2 code, replace gdk_string_width() with the "Pango" way of
computing strings width and height.

svn path=/trunk/; revision=7159
2003-02-17 07:50:49 +00:00
Guy Harris ba6bb6d97d From Didier Gautheron:
further fixes to the TCP graph code's cross handling;

	fix to sequence number overflow problems.

svn path=/trunk/; revision=7145
2003-02-14 05:00:05 +00:00
Guy Harris a79c12635f From Didier Gautheron: fix up the handling of the cross.
svn path=/trunk/; revision=7138
2003-02-13 22:17:18 +00:00
Guy Harris 772e801525 Boost the memory allocation so we can compile "help_dlg.c" which
includes "FAQ.include" as a giant string containing the entire FAQ.

svn path=/trunk/; revision=7117
2003-02-10 23:34:49 +00:00
Guy Harris ab552d3746 Get rid of BASE_BIN - it's just the same as BASE_DEC, but people seemed
to be using it for stuff that should be hex, and for stuff that should
be Boolean.  Use BASE_DEC if it should be decimal, BASE_HEX if it should
be hex, and make it Boolean if it should be Boolean.

svn path=/trunk/; revision=7053
2003-01-31 03:17:56 +00:00
Jörg Mayer fb2884ff99 Add the FAQ to the help menu
svn path=/trunk/; revision=7033
2003-01-29 12:58:48 +00:00
Laurent Deniel 1a66f9aec9 Update my email address in various places since my old one no longer works
svn path=/trunk/; revision=7003
2003-01-26 19:35:31 +00:00
Ronnie Sahlberg 87c67ddce1 New files for the SMB RTT statistics feature
svn path=/trunk/; revision=6967
2003-01-22 00:42:05 +00:00
Ronnie Sahlberg 48d3d8eb26 SMB RTT statistics for tethereal and ethereal.
SMB RTT statistics are similar to the RTT statistics already supported by ONC-RPC and DCE-RPC.
It will present a table with all seen SMB commands and present the Min/Max and Avg response time in ms.

Transaction2 and NT-Transaction commands are broken out and presented in its own subtables.

tethereal feature is activated with -z smb,rtt    switch
and in ethereal it is activated either through -0z smb,rtt switch or through the Menu.

svn path=/trunk/; revision=6966
2003-01-22 00:40:36 +00:00
Guy Harris f71d13b16e Move the code that associates buttons with filter dialogs, and vice
versa, into "filter_dialog_new()", rather than replicating it in a
couple of routines.

The return value of "display_filter_construct_cb()" isn't used for
anything, it's ignored by most callers and stored but subsequently
ignored by io_stat.c; get rid of the return value, and don't bother
storing it in io_stat.c.

Before destroying a filter dialog box associated with a button being
destroyed, break the association.

Get rid of an unused variable in io_stat.c.

svn path=/trunk/; revision=6931
2003-01-15 05:58:50 +00:00
Guy Harris a2f01014c1 Add a new routine "filter_button_destroy_cb()", and make it the
"destroy" signal handler for any button that pops up a filter; if the
button has a filter dialog box associated with it, it destroys that
dialog box.

Have the routines that create filter dialog boxes asociate the dialog
box with the button that created it, so that if the button is destroyed
the filter dialog box can be destroyed as well, and associate the button
with the dialog box.

This means that if a dialog box has a button to create a filter, we no
longer have to have the destroy handler for the dialog box destroy any
filters - that'll happen when the button in the dialog box is destroyed
as part of the process of destroying the dialog box.

Don't make the "Filter" buttons in the io_stat dialog box insensitive if
there's already a filter dialog box open - we can have more than one
open per dialog box.

svn path=/trunk/; revision=6930
2003-01-15 05:20:19 +00:00
Ronnie Sahlberg 07bcd090fc From Ronald Henderson, when closing IO-Stat window, also close any open Filter dialogs
svn path=/trunk/; revision=6916
2003-01-11 11:10:33 +00:00
Olivier Abad 5429cf9b3f Replace :
popup_menu_object = gtk_widget_new(GTK_TYPE_WIDGET, NULL);
with
popup_menu_object = gtk_menu_new();

so that ethereal runs with Gtk+ v2.2

svn path=/trunk/; revision=6879
2003-01-08 23:33:38 +00:00
Guy Harris 910517512f Add some checks to make sure "gdk_color_parse()" and
"gdk_colormap_alloc_color()" succeed.  (We drive on anyway, but at least
we let the user know.)

svn path=/trunk/; revision=6874
2003-01-08 02:19:51 +00:00
Guy Harris 2ae1db18b3 Sort the filenames a bit more.
svn path=/trunk/; revision=6873
2003-01-08 02:00:51 +00:00