osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
83,616 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

83616 Commits

Author SHA1 Message Date
John Thacker 1799627b14 DVB-S2-BB: Get correct ACM byte for L.4 
The L.4 adaptation header does not include a sync byte. Use the
current offset to get the ACM byte instead of hardcoding in the
value that is correct for L.2 and L.3.
 2022-02-22 05:56:37 -05:00
John Thacker a98aca3838 DVB-S2-BB: Add pref to try all Adaptation layer headers (or only one) 
There are four supported types of DVB Base Band Frame Adaptation Layer
headers, and they all can have false positives. Add a preference that
so that a user can either look for all four possible types, or can
only look for a packets that match the preferred type.

Fix #17950.
 2022-02-22 10:28:55 +00:00
Developer Alexander 3eec649ddc SIGNAL PDU: Dissect payload by default 
Dissection of payload is enabled by default. If it is disabled the user gets a
hint.

Corrected some typos.
 2022-02-22 10:05:49 +00:00
Trond Norbye e5783d8549 Couchbase: Shorten prefixes 
Replace the log PROTOCOL_BINARY_RESPONSE_ prefix to STATUS_ and
PROTOCOL_BINARY_CMD_ prefix to CLIENT_OPCODE_.

Couchbase do not support the memcached textual protocol so we'll
_always_ be using the binary protocol framing. In the couchbase
source code all of the PROTOCOL_BINARY_* constants was refactored
to enum classes and these two are called Status and ClientOpcode.
"Unfortuantely" this file is still in C so we can't reuse the
C++ enum classes directly so we'll need a prefix.
 2022-02-22 09:55:17 +00:00
Zoran Bošnjak ced9e51c20 asterix: Sync with asterix-specs #808fb7b68c 2022-02-22 09:30:19 +00:00
Zoran Bošnjak 8993d69335 asterix: python to generated C string fix 
Some characters (in particular double quotation mark) require escaping
during automatic dissector generation.

Fixes problem from merge request 6256.
 2022-02-22 09:30:19 +00:00
Chuck Craft 2990d624f9 Qt: Show Packet Bytes - first byte is 0 so end byte is length-1 
Closes  #17804
 2022-02-21 16:57:31 +00:00
Anders Broman 4a1dc2e9f3 NAS-5GS: Update decoding of Route selection descriptor component (CR) 2022-02-21 13:43:11 +01:00
Martin Mathieson 55d3a9db9e tools/check_*.py: allow multiple --file entries 2022-02-20 23:12:10 +00:00
Roman Volkov 581f3142bb mpeg descriptor: add TVA ID Descriptor (0x75) 2022-02-20 20:06:21 +00:00
David Perry 70d432c357 Remove editor modelines and .editorconfig exceptions from root files 2022-02-20 19:39:37 +00:00
Gerald Combs 695ce22b0d [Automatic update for 2022-02-20] 
Update manuf, services enterprise numbers, translations, and other items.

[ Reverted packet-asterix.c by hand. ]
 2022-02-20 18:58:53 +00:00
Guy Harris c7f84156c0 pcap/pcapng: byte-swap the CAN ID field in CAN pseudo-headers for SLL2. 
As for LINUX_SLL, so for LINUX_SLL2.
 2022-02-20 10:38:55 -08:00
João Valverde b5d74c69a7 dfilter: Fix error message with non printable ASCII 
Before:
    Filter: http.user_agent == açaí
    dftest: "�" was unexpected in this context.

After:
    Filter: http.user_agent == açaí
    dftest: Non-printable ASCII characters may only appear inside double-quotes.

Related with #17770.
 2022-02-19 17:49:29 +00:00
Roman Volkov 30b9474aaa mpeg descriptor: fix Content Identifier Descriptor (0x76) 
There is a wrong tag (0x77 instead of 0x76) in a description
comment in packet-mpeg-descriptor.c.
 2022-02-19 16:40:19 +00:00
Roman Volkov 6bbddaa9c8 mpeg descriptor: add PDC Descriptor (0x69) 2022-02-19 15:20:48 +02:00
Uli Heilmeier 0824558af1 QT Proto Tree: Fix link to wiki for protocol ref 
The wiki pages for protocols are currently reachable via
https://gitlab.com/wireshark/wireshark/-/wikis/<proto_abbrev>

Fixes #17944
 2022-02-19 11:59:56 +00:00
Chuck Craft 0396c65d60 Qt: "Decode As..." tooltips misassigned 2022-02-19 11:48:21 +00:00
diego dupin 62bf6422b1 MySQL / MariaDB length encoded integer correction 2022-02-19 11:47:42 +00:00
John Thacker f7d8dd4938 DVB-S2-BB: Fix detection of adaptation field type 
Fix the check of which adaptation field type is found before a
Base Band Frame. Related to #17950.
 2022-02-18 23:00:29 -05:00
Gerald Combs fbf403de00 epan: Always set our proto_item_fill_label label. 
Make sure label_str is valid, and print a warning if it's NULL. Try to
fix

```
/builds/wireshark/wireshark/epan/dissectors/packet-diameter.c: 1174 in integer32_avp()
1168     	gint length = tvb_reported_length(tvb);
1169     	if (length == 4) {
1170     		if (c->tree) {
1171     			pi= proto_tree_add_item(c->tree, a->hf_value, tvb, 0, length, ENC_BIG_ENDIAN);
1172     			label = (char *)wmem_alloc(wmem_packet_scope(), ITEM_LABEL_LENGTH+1);
1173     			proto_item_fill_label(PITEM_FINFO(pi), label);
>>>     CID 1499506:  Memory - illegal accesses  (STRING_NULL)
>>>     Passing unterminated string "label" to "strstr", which expects a null-terminated string.
1174     			label = strstr(label,": ")+2;
1175     		}
1176     	}
1177     	else {
1178     		pi = proto_tree_add_bytes_format(c->tree, hf_diameter_avp_data_wrong_length,
1179     						 tvb, 0, length, NULL,

```
 2022-02-18 17:26:40 +00:00
John Thacker 4c90ca7ad2 file: Eliminate pointer subtraction 
Change some comparisons around so that comparisons are done without
subtraction, which should fix the 32 bit Windows build.
 2022-02-18 06:47:35 -05:00
Uli Heilmeier b3f8c10542 PFCP: Fix offset for hf_pfcp_flow_desc 
Fixes: #17951
 2022-02-18 08:43:19 +00:00
Martin Mathieson c9f8a427d7 RLC-NR: some trivial edits. 2022-02-18 00:26:40 +00:00
João Valverde 8608a432ee Epan: Add some missing reserved keywords 2022-02-17 20:50:30 +00:00
Alexis La Goutte 3a620f6f87 ieee802211: Add Model and Serial Fortinet Specific Vendor 2022-02-17 14:56:52 +00:00
John Thacker 9308f760a6 file: Optimize Find Packet 
Split the match functions in twain, one for case-sensitive and
one for case-insensitive, so we can use memchr to search for the
first byte in the case-sensitive version and ws_mempbrk for the
case-insensitive version. They are highly optimized on most systems
and considerably faster on large files.

Also fix a few issues regarding wide strings, such as false positives
and the length to highlight when matching. Fix #12908
 2022-02-17 12:06:57 +00:00
Martin Mathieson 4633621c3e Some spelling fixes 2022-02-17 10:28:45 +00:00
Anders Broman 58adcf1e7d RTPproxy: Handle preference range change. 2022-02-17 10:16:08 +01:00
Anders Broman 9ef6eaa539 RTPProxy: Make it possible to configure a range of UDP/TCP ports. 2022-02-16 14:59:41 +01:00
Uli Heilmeier 03afef0a56 TLS: Ignore GREASE values for JA3 
According to https://engineering.salesforce.com/tls-fingerprinting-with-ja3-and-ja3s-247362855967
JA3 ignores GREASE values completely.

Fixes #17942
 2022-02-16 11:27:50 +00:00
Trond Norbye 8cb519153c Couchbase: Print VBucket as vb:<num> 
This is the same format as Couchbase use in the log files.
 2022-02-15 17:17:34 +01:00
Trond Norbye bc168ca376 Couchbase: Add ifconfig command 
And move some commands so they all appear in in numerical order
to make it easier to see if we're missing commands
 2022-02-15 17:17:28 +01:00
Trond Norbye 1a83f3c43a Couchbase: Add missing status codes 
Update the list of status codes with the new status codes
in Couchbase
 2022-02-15 17:16:17 +01:00
João Valverde 8efad466c4 Tools: Fix fix-encoding-args.pl ASCII string validation 
Do not require a useless ENC_NA parameter for string encodings.
FT_STRING and FT_STRINGZ types don't have any ndianness.

Follow-up to 6ec429622c.
 2022-02-15 11:38:16 +00:00
João Valverde 8198dd51cd pre-commit: Add an exception to duplicate filter name check 2022-02-15 11:38:16 +00:00
Gerald Combs 8b526c61cb Tools: Improve update-tools-help's version handling. 2022-02-14 23:13:36 +00:00
Jim Young 371f98aec4 make-manuf.py: Remove HTML double quote entities 2022-02-14 23:12:56 +00:00
Chuck Craft f07ff72f90 WSDG/WSUG: add missing asciidoc admonition icons 
Closes #17474
 2022-02-14 18:24:17 +00:00
Jim Young 59b5c83e4c Qt: Refactor to avoid deprecation warning on Windows 2022-02-14 09:24:02 +00:00
Gerald Combs 79da670bd1 Packaging+GitLab CI: Move debian to the packaging directory. 
We keep our various packaging assets in the "packaging" directory. Move
the Debian assets there. dpkg-buildpackage doesn't seem appear to have a
"debian directory path" option, but symlinking worked in my test
container.
 2022-02-13 13:21:58 -08:00
Gerald Combs 4e3b2ec007 [Automatic update for 2022-02-13] 
Update manuf, services enterprise numbers, translations, and other items.
 2022-02-13 16:39:57 +00:00
Roman Volkov 7d171d3782 mpeg descriptor: add Short Smoothing Buffer Descriptor (0x61) 2022-02-13 11:01:08 +00:00
Alexis La Goutte 1212ec9d56 msrcp: Fix warnings about -Wmissing-prototypes 2022-02-13 10:47:45 +00:00
Alexis La Goutte 26d48b9464 ppp: Fix Dead Store found by Clang Analyzer 
packet-ppp.c:4901:13: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte c115a2ae60 signal-pdu: fix DeadStore found by Clang Analyzer 
packet-signal-pdu.c:2265:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2268:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2271:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte 3dee67b2a2 msrcp: Fix DeadStore found by Clang Analyzer 
packet-msrcp.c:135:17: warning: Value stored to 'msrcp_trans' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte a1be626264 text2pcap: Fix DeadStore found by Clang Analyzer 
text2pcap.c:476:13: warning: Value stored to 'pcap_link_type' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte 6d063e0190 EAP: fix Argument with 'nonnull' attribute passed null 2022-02-13 10:34:30 +00:00
Alexis La Goutte 38d5d79d74 bt-dht: Fix Argument with 'nonnull' attribute passed null 2022-02-13 10:34:29 +00:00