Commit Graph

8510 Commits

Author SHA1 Message Date
Jaap Keuter 04e6c9f1dc From Dick Gooris:
The protocol is called Xcsl a TCP based and ASCII based protocol that is used
to control call generators. The Xcsl dissector decodes the Call Specification
Language.

svn path=/trunk/; revision=24601
2008-03-10 19:28:03 +00:00
Jaap Keuter 1987d5e3af Update comments.
svn path=/trunk/; revision=24600
2008-03-10 17:33:53 +00:00
Gerald Combs 9d2533aa25 Change the BSD-licensed written by CACE to BSD+GPL.
svn path=/trunk/; revision=24599
2008-03-10 17:20:15 +00:00
Martin Mathieson 8605cec511 Fix for bug 2328.
I can see this function is used in limited places.
I'm not sure if BASE_RANGE_STRING needs to masked out
of hfinfo->display in various other functions in proto.c.

svn path=/trunk/; revision=24598
2008-03-10 15:36:44 +00:00
Jaap Keuter e1f488293a From Sami Farin:
Reads EMEM_CANARY_DATA_SIZE (15) bytes, compares return value to EMEM_CANARY_SIZE (8).
Also, I also added setbuf call in patch so it reads 15 bytes instead of 4096 or 8192.

svn path=/trunk/; revision=24596
2008-03-10 07:53:46 +00:00
Jeff Morriss 5ca9e9cbe8 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2009 : if the dissector told us how to format the representation of an item then indicate if we truncated it (we were already doing this if we formatted the representation). Do the same for FT_BYTES.
svn path=/trunk/; revision=24593
2008-03-09 14:50:14 +00:00
Stig Bjørlykke aa9b4bf541 Add a const.
svn path=/trunk/; revision=24592
2008-03-09 14:20:28 +00:00
Stig Bjørlykke 9f412a5a8a Show VarBind OIDs and trap enterprise OID in info column.
Initialize pdu_type in dissect_snmp_PDUs() and param_tvb in
dissect_snmp_SnmpEngineID() to avoid potential crashes.

svn path=/trunk/; revision=24591
2008-03-09 13:58:58 +00:00
Jaap Keuter dcc26d20dc Update almost year out of date file, with over 150 changes and over 1800 additions.
svn path=/trunk/; revision=24590
2008-03-09 12:33:43 +00:00
Stig Bjørlykke 3c6ecbf54b Corrected a typo: octestring -> octetstring.
svn path=/trunk/; revision=24589
2008-03-09 11:24:37 +00:00
Stig Bjørlykke 293e337c2b Display agent-addr as IPv4 address.
svn path=/trunk/; revision=24588
2008-03-09 10:54:55 +00:00
Jeff Morriss 0bb7de356a Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=383 : show multiple (pipelined) HTTP packets in the Info column.
svn path=/trunk/; revision=24586
2008-03-08 21:17:43 +00:00
Jeff Morriss 9c28399930 Add Id tag
svn path=/trunk/; revision=24584
2008-03-07 23:12:05 +00:00
Martin Mathieson 524f4c1611 Adjust the RTP heuristic dissector:
- loosen by accpepting dynamic payload type range
- tighten by only accepting even-numbered ports

svn path=/trunk/; revision=24583
2008-03-07 18:15:46 +00:00
Stig Bjørlykke c714042d2f Updated to Version 2.0 Draft 6.
Removed unofficial port numbers.

svn path=/trunk/; revision=24582
2008-03-07 12:22:20 +00:00
Stig Bjørlykke fdc980e79d Added an option to uat_new() to set if configuration shall be saved in the
selected profile.

Don't save SMI Paths and SMI Modules in the profiles because reloading
currently doesn't work (bug 2309).

svn path=/trunk/; revision=24580
2008-03-06 22:13:24 +00:00
Jeff Morriss bde6848d5a From Florian Lohoff via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2320 : A new (heuristic) dissector for the RedBack Lawful Intercept Packet header.
svn path=/trunk/; revision=24579
2008-03-06 20:09:34 +00:00
Jeff Morriss 4bb245bf3d Make this dissector (which runs on a non-IANA-assigned port) a new-style dissector. Change some fprintf's to expert infos. Also reindent.
svn path=/trunk/; revision=24578
2008-03-06 19:39:26 +00:00
Stig Bjørlykke 752408e466 Added yet another free().
svn path=/trunk/; revision=24576
2008-03-06 17:54:53 +00:00
Jörg Mayer c3a10dd79c Small fix for heuristic: it missed a tapa packet
svn path=/trunk/; revision=24574
2008-03-06 14:05:22 +00:00
Stephen Fisher 9ba003e8b6 Mark a couple of variables volatile
Remove two unused dissector handles
Comment out a function declaration labeled as "TODO" 


svn path=/trunk/; revision=24571
2008-03-05 22:28:29 +00:00
Anders Broman a4798caa7b Fix typos.
svn path=/trunk/; revision=24570
2008-03-05 21:04:42 +00:00
Stig Bjørlykke 4e1d1942e7 Free return value from smiRenderType, smiRenderOID, smiGetPath,
get_datafile_path and get_persconffile_path.

This was reported by Valgrind.

svn path=/trunk/; revision=24569
2008-03-05 20:55:56 +00:00
Anders Broman e4edda69af From Peter Johansson :
Support for EtherCAT subdissectors.

svn path=/trunk/; revision=24567
2008-03-05 20:44:02 +00:00
Anders Broman 7a5b90df34 From Peter Johansson :
Support for EtherCAT subdissectors.

svn path=/trunk/; revision=24566
2008-03-05 20:42:58 +00:00
Anders Broman 2cd5211e95 From Andrew Feren :
Decoding extended gateway information not implemented for sFlow

svn path=/trunk/; revision=24565
2008-03-05 20:33:19 +00:00
Anders Broman f9ad87dd7c From Owen Kirby :
IEEE 802.15.4 dissector and DLT_ type.

svn path=/trunk/; revision=24564
2008-03-05 20:30:03 +00:00
Gerald Combs 2cc71b9b66 Move the contents of AirPDcapCleanKeys() into AirPDcapInitContext()
and call AirPDcapInitContext() where we were previously calling
AirPDcapCleanKeys(). If we're resetting our keys, we should reset our
SA list and other associated data as well.

svn path=/trunk/; revision=24562
2008-03-05 00:57:30 +00:00
Stig Bjørlykke d9eba4345b Free the allocated range if not using it.
svn path=/trunk/; revision=24560
2008-03-04 23:15:11 +00:00
Stig Bjørlykke 6193d9d3c2 Add a inflateEnd() call to free up the stream in the re-init block.
svn path=/trunk/; revision=24559
2008-03-04 22:56:26 +00:00
Jeff Morriss bb323055b2 match_strval() may return NULL so don't blindly pass its return value into col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead.
svn path=/trunk/; revision=24557
2008-03-04 21:05:21 +00:00
Jeff Morriss fc7b16d9df Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2331 : Replace match_strval() with val_to_str() returning "Unknown" if no match was found. This prevents us from passing a NULL pointer (which should replace a %s in the format string) which was causing g_vsnprintf() to core (at least on Solaris and, apparently, Windows).
svn path=/trunk/; revision=24555
2008-03-04 20:11:50 +00:00
Jeff Morriss ce40f3ba64 From Sven Meier: update the PRP dissector to the newest version of the standard. There is also now a Wiki page for this protocol: http://wiki.wireshark.org/PRP
svn path=/trunk/; revision=24554
2008-03-04 19:13:06 +00:00
Stig Bjørlykke 1b4857ee33 Initialize ipv6_addr before we use it.
svn path=/trunk/; revision=24553
2008-03-04 18:55:36 +00:00
Stig Bjørlykke 7647ca258b Ups, this free was not so smart...
svn path=/trunk/; revision=24552
2008-03-04 12:47:36 +00:00
Stig Bjørlykke 8c0e88cb8d Free allocated data.
svn path=/trunk/; revision=24550
2008-03-04 12:13:25 +00:00
Stig Bjørlykke fd906bb33a Free compiled dfilter after usage.
svn path=/trunk/; revision=24549
2008-03-04 12:12:41 +00:00
Guy Harris c2bd9290b0 Fix fields that are passed to proto_tree_add_uint64_format_value() to be
FT_UINT64 fields.

Partially clean up indentation (it is *NOT* guaranteed that tabs will be
set every 4 spaces!).

svn path=/trunk/; revision=24548
2008-03-04 09:27:14 +00:00
Guy Harris 1924881e9e For the "cigi.3_2_los_ext_response" field, use the variable that was
intended for it.

svn path=/trunk/; revision=24547
2008-03-04 08:58:08 +00:00
Anders Broman 5459fefbad Spoted by ChrisMaynard:
Duplicated names.

svn path=/trunk/; revision=24546
2008-03-04 05:55:11 +00:00
Anders Broman 781ed2c45e From ChrisMaynard:
packet-ptp.c(2183) : error C2220: warning treated as error - no object file generated
packet-ptp.c(2183) : warning C4244: 'function' : conversion from
'__int64 ' to 'double ', possible loss of data

patch to correct the problem.

svn path=/trunk/; revision=24545
2008-03-04 05:39:21 +00:00
Gerald Combs 7f097fdc9b Make sure we initialize a TVB. Fixes bug 2329.
svn path=/trunk/; revision=24543
2008-03-03 22:28:35 +00:00
Gerald Combs 86b4477470 Add missing parts of the PCAP dissector.
svn path=/trunk/; revision=24541
2008-03-03 22:03:05 +00:00
Gerald Combs 356f8271c4 Fix compilation under gcc.
svn path=/trunk/; revision=24540
2008-03-03 22:01:29 +00:00
Anders Broman bc455661e2 From Markus Seehofer :
Updated the PTP Packet Dissector to the current Draft Version IEEE1588v2.2

svn path=/trunk/; revision=24539
2008-03-03 20:26:37 +00:00
Gerald Combs 8e0bae388f Cite the source of frequency allocation information.
svn path=/trunk/; revision=24538
2008-03-03 20:17:53 +00:00
Anders Broman 2c4c5a086b From Alan McBride :
BACnet handling of readPropertyMultiple request / response.

svn path=/trunk/; revision=24537
2008-03-03 20:15:05 +00:00
Anders Broman 76c146ee97 From Jason Seeliger:
Added support for CIGI 3.2 protocol to packet-cigi.c

svn path=/trunk/; revision=24536
2008-03-03 20:08:19 +00:00
Anders Broman b0e745eedf From Kai Blin:
Properly dissect all DirectPlay messages observed on the wire so far.

svn path=/trunk/; revision=24535
2008-03-03 19:57:09 +00:00
Anders Broman 74c27d330c Include the "UTRAN Iupc interface Positioning Calculation Application Part (PCAP)" dissector.
svn path=/trunk/; revision=24534
2008-03-03 19:56:01 +00:00
Jörg Mayer a9e61881b9 Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2257
svn path=/trunk/; revision=24533
2008-03-03 18:07:47 +00:00
Stephen Fisher ea297f369f Convert strcpy() calls to g_strlcpy()
svn path=/trunk/; revision=24532
2008-03-02 23:45:24 +00:00
Stig Bjørlykke 280d579242 Added missing array for hf_jxta_element2_encodingid.
svn path=/trunk/; revision=24530
2008-03-02 20:29:11 +00:00
Stig Bjørlykke f14a19d8b4 Added missing array for hf_h248_pkg_bcg_sig_bcr.
svn path=/trunk/; revision=24529
2008-03-02 20:19:32 +00:00
Stig Bjørlykke dcf73d5d79 Added missing array for hf_h248_pkg_annexc_encrypt_key,
hf_h248_pkg_annexc_flowconttx, hf_h248_pkg_annexc_dialingn and 
hf_h248_pkg_annexc_sdp_i.

svn path=/trunk/; revision=24528
2008-03-02 20:11:50 +00:00
Stig Bjørlykke 86e9711d4d Added missing array for hf_printer_priority, hf_printer_default_priority,
hf_printer_averageppm and hf_printer_jobs.

svn path=/trunk/; revision=24527
2008-03-02 19:47:04 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Jeff Morriss 346d46b8d0 From Steve via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2278 : decoding of SSCOP ERAK was incorrect.
svn path=/trunk/; revision=24524
2008-03-01 16:29:18 +00:00
Jeff Morriss d970b9f59d Initialize asn1_ctx before using it. Fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2317
svn path=/trunk/; revision=24523
2008-03-01 16:23:14 +00:00
Stig Bjørlykke 9cb03a761c Rewrote to use g_strlcat and g_strlcpy.
svn path=/trunk/; revision=24522
2008-03-01 13:58:15 +00:00
Stig Bjørlykke b20a8b1791 Rewrote to use g_strlcat and g_strlcpy.
svn path=/trunk/; revision=24521
2008-03-01 13:54:42 +00:00
Jeff Morriss 08183dae43 Reindent libwireshark's LIBADD and DEPENDENCIES for readability
svn path=/trunk/; revision=24519
2008-03-01 12:15:19 +00:00
Jeff Morriss bc580e1aa0 All our programs link against glib so don't there's no need to link our libraries against it too. This should allow us to build Wireshark (with dynamic libs) with static glib (read: it should fix the OS X buildbot building with glib-1.2).
svn path=/trunk/; revision=24518
2008-03-01 12:14:38 +00:00
Stig Bjørlykke 6b59696fd7 Added missing array for hf_snmp_big_counter_value.
svn path=/trunk/; revision=24516
2008-03-01 11:43:04 +00:00
Stig Bjørlykke 4c7d9c8de3 Added missing array for hf_alcap_pssiae_max_len and hf_alcap_ssiae_max_len.
svn path=/trunk/; revision=24515
2008-03-01 10:44:00 +00:00
Stig Bjørlykke a13c710c5c Added missing array for hf_afs_fs_ipaddr.
svn path=/trunk/; revision=24514
2008-03-01 10:43:04 +00:00
Stephen Fisher 56226b49b8 Custom column updates:
- Change apply / prepare / ... as filter to use the field's value, which
   is now stored in fdata as well as cinfo.  Now we don't have to reprocess
   the entire packet list when using these features.  This also prevents
   the use of these features from overwriting custom column information.
   (custom columns can now be used in apply / prepare ... as filter)
 - Break col_expr and col_expr_val out into a struct that is included not only
   in cinfo, but now also fdata.
 - Have col_custom_set_fstr() quote FT_STRING & FT_STRINGZ when storing the
   col_expr_val value (for filter creation).


svn path=/trunk/; revision=24511
2008-03-01 05:16:45 +00:00
Greg Morris 438c96dabb Error code 0x89a9 updated error message to be:
"Invalid Path With Junction Present"

Fix get extended volume info to register correct name with NDS EID value. (added data type of 20 to extract string value)

Fix expert data for file handles to report file handle in expert data. (Added data type of 22 to extract bytes value)

svn path=/trunk/; revision=24505
2008-02-29 15:36:51 +00:00
Jaap Keuter 4562744a64 Properly attribute the FOUNDATION Fieldbus dissector to Yukiyo Akisada.
Correct protocol name.

svn path=/trunk/; revision=24503
2008-02-29 07:53:15 +00:00
Guy Harris 6d61024a55 Don't peek inside the column information and manually wrap "GTP < ... >"
around the protocol field, use the standard routines for prepending to
and appending to a column.  That should fix bug 2311, as the standard
routines use g_strlcat(), and should also keep that code robust in the
face of changes to the way columns are implemented.

svn path=/trunk/; revision=24502
2008-02-29 03:32:58 +00:00
Bill Meier bef5e5c9fc One more g_free ....
svn path=/trunk/; revision=24501
2008-02-29 02:09:22 +00:00
Bill Meier 030c8c6f3e Fix wireshark/tshark crash when initializing lua (using init.lua, etc).
Essentially: A small cleanup of SVN 24479.
(Fortunately the 0.99.8 release does not have this issue).
Also: add some lines of (what appears to be) missing code.

svn path=/trunk/; revision=24500
2008-02-29 01:49:31 +00:00
Martin Mathieson 4a925e9cd9 Fix bitmasks for feedback message type fields.
Fixes bug 2312.

svn path=/trunk/; revision=24498
2008-02-28 16:11:55 +00:00
Guy Harris 913cb16c9a Don't use capital letters in protocol abbreviation names - that obliges
people to type capital letters in filter expressions, which is a bit
rude.  Furthermore, we're not using "Hilscher" in field names, we're
using "hilscher".  This should fix bug 2310 - we check for various
illegal characters in filter names, including capital letters, and crash
if they're found.

svn path=/trunk/; revision=24496
2008-02-28 08:33:36 +00:00
Jeff Morriss f5f636db9e From Holger Pfrommer via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2205
This is a new dissector plugin for Hilscher analyzer frames.
These frames are generated by Hilscher analyzer products and are identified via
their unique source MAC address (this is a reserved MAC from Hilscher-range and
will never be used by another network device). Most likely these frames are
only generated on a virtual network interface or the generating device is
attached directly via patch cable to a real network interface, but not routed
through a network. The Ethernet-header (destination MAC, source MAC and
Length/Type) is not displayed in the protocol tree for these frames as this is
overhead-information which has no practical use in this case.

Note:

This is a heuristic Ethernet dissector which means it gets called for every
Ethernet frame.  So as to not cause a performance hit for most Wireshark users
it has a preference which, by default, disables the dissector.

svn path=/trunk/; revision=24495
2008-02-27 23:39:25 +00:00
Jeff Morriss 6e0297dc86 Rather than always disabling the protocol at startup, just add a preference that decides if the dissector should be enabled or not. Still not perfect but it makes it more usable.
svn path=/trunk/; revision=24494
2008-02-27 23:24:40 +00:00
Jeff Morriss 31d705e32f From Sven Meier (on -dev in 6/2007):
This is a dissector for the Parallel Redundancy Protocol (PRP) defined in chapter
6 of the IEC 62439.

PRP uses two independent networks in parallel and allows redundancy without
switchovers.

The protocol is sending Mac multicast messages with Ethertype 0x88fb. In
addition to that it adds to every Ethernet frame a 4 byte trailer before
the FCS. The trailer is detected by checking a size field and an identifier
which are part of the trailer. Therefore, if the last 4 bytes of a frame
match a correct trailer they get interpreted as a trailer, although it was
probably not a real one.

Note:

This is a post-dissector which means it gets called for every frame.  So as
to not cause a performance hit for every Wireshark user (who may not even be
looking at Ethernet frames) it currently disables itself every time Wireshark
starts up.  (There should be a better way to do this--maybe different Profiles
(as discussed on -dev recently) is the way to go.)

From me:

Put ETHERTYPE_PRP (not IANA registered) in etypes.h and packet-ethertype.c

svn path=/trunk/; revision=24493
2008-02-27 21:52:17 +00:00
Anders Broman dd971ab222 From Kai Blin:
Dissect SuperPackedPlayer struct and packet type 29 and
 Correctly dissect type 02, 05 and 07 packets.

svn path=/trunk/; revision=24491
2008-02-27 17:22:31 +00:00
Stig Bjørlykke a6958ba14b Quote argument to test in epan/dissectors/Makefile.am
svn path=/trunk/; revision=24489
2008-02-27 16:27:42 +00:00
Anders Broman 3a3c255a30 Dissect IPAddressFamily
svn path=/trunk/; revision=24487
2008-02-27 16:13:57 +00:00
Stephen Fisher 96ade54c54 Fix a comment that was pointing readers to the wrong file to look for info
svn path=/trunk/; revision=24486
2008-02-27 04:44:33 +00:00
Jeff Morriss 1e65f5b562 A couple more const fixes.
svn path=/trunk/; revision=24483
2008-02-26 23:30:40 +00:00
Jeff Morriss 7ffc01c6ce Oops, freeing a const char* doesn't always work. Make it not a const.
svn path=/trunk/; revision=24482
2008-02-26 23:05:05 +00:00
Jeff Morriss 1d6df91a9d get_datafile_path() and get_persconffile_path() return malloc'd memory,
free it when we're done with the file name.

svn path=/trunk/; revision=24479
2008-02-26 19:52:21 +00:00
Jeff Morriss 1c319c4e2c get_datafile_path() and get_persconffile_path() return malloc'd memory,
free it when we're done with the file name.

svn path=/trunk/; revision=24477
2008-02-26 19:03:01 +00:00
Jeff Morriss 9fdc3e961d get_datafile_path() and get_persconffile_path() return malloc'd memory. Note that in the comments.
svn path=/trunk/; revision=24476
2008-02-26 18:58:12 +00:00
Anders Broman c5e560d530 From Kai Blin:
Update parsing of the DirectPlay header and
Correctly dissect the SessionDesc structure of DirectPlay
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2304

svn path=/trunk/; revision=24474
2008-02-26 18:08:24 +00:00
Jeff Morriss 6aed8c4c60 Initialize a 'next' pointer so we don't crash if/when we try to follow it.
svn path=/trunk/; revision=24471
2008-02-26 17:05:37 +00:00
Tomas Kukosa 60c8859857 Allow UDP heuristic for XML
svn path=/trunk/; revision=24468
2008-02-26 08:10:46 +00:00
Gerald Combs 2ed9d7d43e Make sure we don't dereference a NULL pointer. Fixes bug 2277.
svn path=/trunk/; revision=24467
2008-02-26 01:17:18 +00:00
Gerald Combs 2d92baa2d1 Add files to the tarball that are necessary to compile and create
packages under Windows.

svn path=/trunk/; revision=24466
2008-02-26 00:52:12 +00:00
Gerald Combs 366863a763 Check for setres[gu]id and define HAVE_SETRESUID and HAVE_SETREGUID
accordingly. Also define _GNU_SOURCE to appease glibc.

svn path=/trunk/; revision=24465
2008-02-25 23:18:53 +00:00
Anders Broman c927060138 Dissect Name and Certificate and add some extensions pkix1explicit.
svn path=/trunk/; revision=24464
2008-02-25 22:17:24 +00:00
Jaap Keuter 81aaf4a8b1 Avoid misreporting of cryto state of RTP payload.
svn path=/trunk/; revision=24461
2008-02-25 19:08:13 +00:00
Stephen Fisher 1efbef8ef4 From Chris Maynard: Alphabetize the list of column types to choose from in
the column preferences dialog.


svn path=/trunk/; revision=24458
2008-02-25 05:13:45 +00:00
Gerald Combs 1997308ac1 Handle unsigned SMI types. This should fix bug 2292.
svn path=/trunk/; revision=24457
2008-02-25 00:00:41 +00:00
Anders Broman 32ae9c1d7f Dissect Type: 149 (Certification Path Advertisement).
svn path=/trunk/; revision=24456
2008-02-24 21:04:42 +00:00
Stig Bjørlykke 545fdf0586 Added support for FT_IPv4, FT_GUID and FT_OID in custom columns.
svn path=/trunk/; revision=24455
2008-02-24 20:57:34 +00:00
Anders Broman b10481a009 Fix bug No support for Secure Neighbor Discovery ICMPv6 options.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2284

svn path=/trunk/; revision=24454
2008-02-24 17:14:47 +00:00
Anders Broman e6837f14d4 Correct a typo and at least print the name of type 148 and 149.
svn path=/trunk/; revision=24445
2008-02-23 19:57:09 +00:00
Anders Broman 48c58e1b63 Put names on some more options solves part of bug
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2284

svn path=/trunk/; revision=24444
2008-02-23 19:17:23 +00:00
Stig Bjørlykke 51b26f95f3 Improved custom columns with custom title.
Fixed a crash when adding an empty custom field.

svn path=/trunk/; revision=24438
2008-02-22 22:47:19 +00:00
Jeff Morriss 1b71f5f0ff From Evan via bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2293 : In
epan/dissectors/packet-bacapp.c the BACnetErrorCode array contains incorrect
enumeration mappings for BACnet error codes.  Attached is a version of the file
with the mappings straightened out.

svn path=/trunk/; revision=24435
2008-02-22 21:39:40 +00:00
Jeff Morriss 146d642ebe From Balint Reczey via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2264 : fix IPv4 handling
svn path=/trunk/; revision=24433
2008-02-22 21:02:10 +00:00
Stig Bjørlykke 3ebc2a4d00 Check for existing cinfo in have_custom_cols().
This fixes the latest buildbot fuzz failures.

svn path=/trunk/; revision=24421
2008-02-22 13:41:25 +00:00
Stig Bjørlykke a50f232cac Print integer values according to hfinfo->display.
svn path=/trunk/; revision=24420
2008-02-22 13:27:46 +00:00
Stig Bjørlykke 20ed60cf1f Added FT_ABSOLUTE_TIME and FT_RELATIVE_TIME to custom columns.
svn path=/trunk/; revision=24419
2008-02-22 12:28:41 +00:00
Stig Bjørlykke 33524cdd48 Some custom column enhancements:
Use the value_string if defined for integer and boolean values.

svn path=/trunk/; revision=24418
2008-02-22 12:06:29 +00:00
Stig Bjørlykke 67aa6856de Some custom column fixes:
- In proto_tree_set_uint and proto_tree_set_int use value adjusted for bitmask.
- Removed col_custom_set_fstr in proto_tree_set_boolean to get a correct
  adjusted value in proto_tree_set_uint.
- Set a default column width shorter than COL_INFO. 

svn path=/trunk/; revision=24417
2008-02-22 11:32:36 +00:00
Stephen Fisher 2a8e74cedc Add ability to make more field types into custom columns: FT_ETHER & FT_BYTES.
Also change display of FT_STRING(Z) to turn non-printable characters into
backslash + number values. 


svn path=/trunk/; revision=24415
2008-02-22 03:44:08 +00:00
Stephen Fisher c7d656555a Use custom column check function for custom columns to make sure the dfilter
is always primed when needed.  This ensures more than just the first row
has a custom column's information in it.


svn path=/trunk/; revision=24413
2008-02-22 01:25:45 +00:00
Anders Broman 1c5dddbd68 Unkomment the now fixed value string...
svn path=/trunk/; revision=24412
2008-02-21 23:08:19 +00:00
Guy Harris 63c7c6d476 Put back the use of g_ascii_strcasecmp(), so we don't get rudely
surprised by, for example, "i" not comparing equal to "I" in Turkish
locales.

Make gMessageType local - it's not used as a global variable.  Also,
make it a pointer to const, so that we don't have to cast away the
constness.

dissect_giop_fragment() doesn't use the "header" argument, so get rid of
it.

Clean up indentation a bit.

The first element of a value_string is the value, and the second
argument is the string; fix up the initialization of the table of code
set values.

Fix a proto_tree_add_text() call to match the format and the arguments.

svn path=/trunk/; revision=24411
2008-02-21 22:11:08 +00:00
Anders Broman 39f12ecc1d From Wolf Neumann:
GIOP reassembly fails when first packet of a PDU is received Out-of-Order

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1453

The patch changed to use value_string but not all values included in the current value_string.

svn path=/trunk/; revision=24410
2008-02-21 20:45:09 +00:00
Anders Broman 85c51a72a0 Fix Bug Enable int64, uint64 and ipv4 type fields for the Lua dissectors
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2264

svn path=/trunk/; revision=24408
2008-02-21 19:58:09 +00:00
Jaap Keuter 89d7589f60 From Karl Heinz Wolf:
This patch decodes the Civic Address Types (CATypes) for Civic Addresses
Configuration Information. This GEOCONF_CIVIC DHCP option number 99 is defined
in RFC 4776.

svn path=/trunk/; revision=24406
2008-02-21 07:05:44 +00:00
Jörg Mayer 9bd9942aab Fix some unused warnings
svn path=/trunk/; revision=24397
2008-02-19 22:13:53 +00:00
Jörg Mayer 317605de9a Use the right 4 bits and avoid the overflow of an 8 bit value
svn path=/trunk/; revision=24396
2008-02-19 22:09:38 +00:00
Jörg Mayer 0fbcd0e4d1 Update todo section
svn path=/trunk/; revision=24395
2008-02-19 22:08:11 +00:00
Bill Meier 936381623d Add 'executable' property to a few .pl and .py files
svn path=/trunk/; revision=24390
2008-02-19 13:44:02 +00:00
Bill Meier 1cd76ad66a Remove svn:executable property
svn path=/trunk/; revision=24384
2008-02-18 23:58:45 +00:00
Bill Meier 5b8da491d7 Add $Id$
svn path=/trunk/; revision=24382
2008-02-18 22:39:03 +00:00
Bill Meier 2f9f8d7df8 Fix some some properties
svn path=/trunk/; revision=24380
2008-02-18 21:01:11 +00:00
Anders Broman fe620c9d12 Add an expert item about AVP:s without "data".
svn path=/trunk/; revision=24377
2008-02-18 19:10:50 +00:00
Stig Bjørlykke 43272f9435 Added an option to Conversations and Endpoints to limit the list to match
the current display filter.

Some Hosts -> Endpoints cleanup.

svn path=/trunk/; revision=24368
2008-02-17 00:35:55 +00:00
Anders Broman 3a130af51b Add map operation 49.
svn path=/trunk/; revision=24360
2008-02-16 17:04:59 +00:00
Gerald Combs ba7aec84a8 Format our text before displaying it. This keeps Wireshark from crashing on
Ubuntu 7.10 and possibly other platforms.

svn path=/trunk/; revision=24341
2008-02-16 01:33:48 +00:00
Gerald Combs 6537c76fb6 Extend the UAT and preferences code so that you can use the "-o" flag
to override UAT entries from the command line, e.g.

  -o "uat:user_dlts:\"User 0 (DLT=147)\",\"http\",\"0\",\"\",\"0\",\"\""
  
Fix up white space.

svn path=/trunk/; revision=24338
2008-02-15 22:36:24 +00:00
Gerald Combs eba80d5c38 Add fvalue_string_repr_len.
svn path=/trunk/; revision=24337
2008-02-15 22:35:09 +00:00
Ashok Narayanan 51c90d25e6 Added RTCP Feedback NAK PLI dissectors.
svn path=/trunk/; revision=24336
2008-02-15 17:18:29 +00:00
Gerald Combs 5b522888dd Initialize a tvb, so that we don't crash. Fix up whitespace.
svn path=/trunk/; revision=24332
2008-02-14 23:10:29 +00:00
Bill Meier 718b14c7ce Glib >= 2.14.5 does not require iconv
svn path=/trunk/; revision=24330
2008-02-14 17:16:12 +00:00
Stephen Fisher b0a09b3c8b Add/fix a few calls to col_custom_set_fstr() for custom columns.
svn path=/trunk/; revision=24328
2008-02-14 06:10:54 +00:00
Ronnie Sahlberg d426498171 fixup and improve create
svn path=/trunk/; revision=24327
2008-02-14 06:08:11 +00:00
Ronnie Sahlberg 2d63ba2674 fixum tree disconnect
svn path=/trunk/; revision=24326
2008-02-14 05:15:20 +00:00
Ronnie Sahlberg f8660c6806 fixup tree connect
svn path=/trunk/; revision=24325
2008-02-14 05:13:29 +00:00
Ronnie Sahlberg eb2f7475f2 fixup sessionlogoff
svn path=/trunk/; revision=24324
2008-02-14 04:19:51 +00:00
Ronnie Sahlberg 0d97477e6d fixup sessionsetup
svn path=/trunk/; revision=24323
2008-02-14 04:16:11 +00:00
Ronnie Sahlberg bb9f7a373e update dissection of negprot
svn path=/trunk/; revision=24322
2008-02-14 03:38:29 +00:00
Ronnie Sahlberg d399fc0a1f fixup SMB2 header and decode async commands correctly
svn path=/trunk/; revision=24321
2008-02-14 02:36:43 +00:00
Jaap Keuter bd83d8a864 Add SERCOS ethertype for upcoming dissector.
svn path=/trunk/; revision=24320
2008-02-13 17:34:05 +00:00
Stephen Fisher 8f3a1b0d16 Check in changes originally checked in as SVN revision 24308 (new column
type: Custom) that were backed out in SVN revision 24309.

Changes since that revision include a reworking of the handling of the
cfile/cinfo variables in epan/column-utils.c, addition of three new
functions to libwireshark.def and a bug fix to prevent a crash when no
custom columns were not in use.

Compilation verified locally on MacOS X, Linux and Windows.


svn path=/trunk/; revision=24317
2008-02-13 05:05:33 +00:00
Gerald Combs 7a6d8d7955 Replace a g_snprintf() with a strncpy(). Fixes bugs 2260 to 2262.
svn path=/trunk/; revision=24316
2008-02-13 04:10:20 +00:00
Stig Bjørlykke a356f552b4 Added WLAN Traffic Statistics dialog.
svn path=/trunk/; revision=24310
2008-02-12 14:17:18 +00:00
Stephen Fisher 5e893a8b1c Revert commit 24308 until I can get it to compile on Windows/Linux/Solaris
(strangely, it compiled fine on my MacOS X machine).


svn path=/trunk/; revision=24309
2008-02-12 08:09:22 +00:00
Stephen Fisher 0a85a9e4c6 Introduce a new column type called custom, which lets you put any display
filter name in the description field and it will display that field in the
packet list if it occurs in that packet.  Note that the more common fields
are implemented, but a number of them remain to be implemented in
epan/proto.c.  I will work on these other fields as I have time.


svn path=/trunk/; revision=24308
2008-02-12 03:16:09 +00:00
Gerald Combs 152b28477a Windows (confirmed with Vista, XP, and 98) sends the "secs" value as a
little-endian value. Add a check and format the value accordingly. Fix up
whitespace.

svn path=/trunk/; revision=24303
2008-02-11 19:18:02 +00:00
Bill Meier 980b393d0d A few more pedantic fixes ...
svn path=/trunk/; revision=24302
2008-02-11 18:43:15 +00:00
Bill Meier b25aa005c1 A few minor pedantic fixes ....
svn path=/trunk/; revision=24301
2008-02-11 17:04:51 +00:00
Bill Meier 2078ed4a5f Fix one add'tl warning as reported by David Kirkby
svn path=/trunk/; revision=24298
2008-02-11 01:41:49 +00:00
Guy Harris 6dd81aa615 The type field of an mtp3_addr_pc_t is a "which SS7 standard is this?"
type, not a "how do I format addresses?" type; declare it as such, and
remove the comment that pointed out that the type field had the wrong
(C) type.

svn path=/trunk/; revision=24297
2008-02-10 21:38:52 +00:00
Bill Meier bad9f18d33 Fix (Sun) compiler warnings as reported by David Kirkby: Part 1
svn path=/trunk/; revision=24295
2008-02-09 23:35:28 +00:00
Anders Broman d6aea2d0a1 - Add application Id:s to Diameter
- Further dissect 3GPP Radius AVP:s.

svn path=/trunk/; revision=24293
2008-02-08 16:32:12 +00:00
Stig Bjørlykke 71ad1e38f8 Add get_sctp_port to libwireshark.def
svn path=/trunk/; revision=24292
2008-02-08 14:47:21 +00:00
Stig Bjørlykke 42fe2398b9 Added missing "svn:keywords Id" and "svn:eol-style native" for some
c and h files.

svn path=/trunk/; revision=24290
2008-02-08 09:45:36 +00:00
Ronnie Sahlberg 4284906aba based on the novell idllib sources :
add dissection of the 16 byte header prior to the NDR data when NDR is 
transported as a blob ontop of !dcerpc
like the LOGON_INFO in the PAC in kerberos


svn path=/trunk/; revision=24289
2008-02-08 09:20:02 +00:00
Stephen Fisher a97304bd26 Fix typo in comment
svn path=/trunk/; revision=24288
2008-02-08 05:45:46 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Stig Bjørlykke 36431783b7 Removed a break which disabled some code.
svn path=/trunk/; revision=24285
2008-02-07 15:12:50 +00:00
Stig Bjørlykke 64d9306f29 Rewrote some "if(tree)" code inside a switch-case to avoid unused code
(which did not work as expected).

switch(type) {
  case 1:
    ...
    break;
  if(tree) {
    case 2:
      ...
      break;
  }
}

svn path=/trunk/; revision=24284
2008-02-07 15:05:42 +00:00
Stig Bjørlykke c6af1bfdd4 Removed some "statement not reached" warnings.
svn path=/trunk/; revision=24282
2008-02-07 12:14:40 +00:00
Stig Bjørlykke 609bb57097 Corrected some types.
svn path=/trunk/; revision=24280
2008-02-07 11:42:11 +00:00
Stig Bjørlykke 138381e214 From Thomas Dreibholz (bug 2248):
Add a dissector for the Scripting Service Protocol provided as part of the
RSPLIB package.  RSPLIB is an Open Source implementation of the upcoming
Reliable Server Pooling standard.  The scripting service is an application
for load distribution, based on Reliable Server Pooling.

From me:
Shorten the protocol name to SSP.

svn path=/trunk/; revision=24276
2008-02-06 14:28:30 +00:00
Anders Broman d1c0ab9ab0 Update gsm map asn1 files to latest version.
svn path=/trunk/; revision=24270
2008-02-05 06:10:34 +00:00
Stig Bjørlykke ceca9ab2e9 From Shane Kearns (bug 2242):
1) update SDP dissector with new IDs from assigned numbers document
   https://www.bluetooth.org/apps/content/default.aspx?doc_id=49709
2) decode attribute IDs in an "attribute ID list" parameter (previously it
   showed raw number only)
3) removed some duplicate entries in vs_service_classes

svn path=/trunk/; revision=24267
2008-02-04 11:56:30 +00:00
Martin Mathieson 0c700edaba Add mapping for s1ap_r8.
svn path=/trunk/; revision=24264
2008-02-03 23:04:04 +00:00
Stig Bjørlykke ef625890aa From Shane Kearns (bug 2237):
Added support for Symbian OS btsnoop.

The bluetooth HCI layer in Symbian OS can be configured to log all packets to a
file.  The log format, "btsnoop" is based on the RFC1761 "snoop" format - but
differences in the header make it incompatible.

The btsnoop format supports logging of these formats:
"H1" (raw HCI packets without framing)
"H4" (HCI UART packets including packet type header)
"H5" (HCI 3 wire UART packets including framing)
"BCSP" (HCI bluecore serial protocol including framing)

"H1" and "H4" are section numbers in the original v1 bluetooth specifications,
but still used colloquially - wireshark's existing support for Linux bluez HCI
logs uses the "H4" name.

In practice, the "H1" format is used for H5,BCSP and USB HCI logs, as the HCI
packet logs are mainly useful for debugging higher layers, bluetooth profiles
and bluetooth applications.

From me:
Deleted some unused prototypes.
Mark an unused parameter.

svn path=/trunk/; revision=24263
2008-02-03 21:11:53 +00:00
Stig Bjørlykke a341198859 From Shane Kearns (bug 2239):
L2CAP dissector is missing retransmission & flow control modes (these were
introduces in BT 1.2 specification)
Configuration commands were not fully decoded because of a bigend/littleend
issue
L2CAP commands had the wrong length set to the protocol tree by reading from
the wrong buffer offset
Also the dissect_options() function consumes all remaining data in the L2CAP
packet, which prevents decoding of other commands which follow a config
request/config response in the same packet.

From me:
Mark an unused parameter.

svn path=/trunk/; revision=24262
2008-02-03 21:04:01 +00:00
Stig Bjørlykke b715bd28d2 Ups, fix a typo from last checkin.
svn path=/trunk/; revision=24259
2008-02-03 15:49:22 +00:00
Stig Bjørlykke 47d744b59d More rewrite of prohibited APIs (sprintf, strcpy, strcat).
svn path=/trunk/; revision=24258
2008-02-03 15:38:20 +00:00
Anders Broman 2ab56c11e8 Update asn1 files to 3GPP TS 25.433 V7.7.0 (2007-12)
svn path=/trunk/; revision=24256
2008-02-03 13:47:50 +00:00
Anders Broman 2942ff4d5b Get rid of some warnings.
svn path=/trunk/; revision=24251
2008-02-03 10:07:42 +00:00
Anders Broman 3ead3cd279 Update asn1 files to GPP TS 25.413 V7.8.0 (2008-01).
svn path=/trunk/; revision=24250
2008-02-03 09:51:57 +00:00
Stig Bjørlykke 677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Stig Bjørlykke f4871e6269 Fixed a possible buffer overflow in dissect_fmp_flushCmd() when cmd has
all bits set.

svn path=/trunk/; revision=24248
2008-02-02 17:17:16 +00:00
Stig Bjørlykke dc1f6dc424 Rewrote strcat -> strncat, and fixed to show more than the last remaining
Cmd_Argv value for Remote Command.

svn path=/trunk/; revision=24247
2008-02-02 17:13:30 +00:00
Jaap Keuter 1c2f043913 From Peter Kjellerstedt:
I was capturing an RTP stream the other day which contained JPEG images
streamed according to RFC 2435. However, Wireshark reported them as malformed.
After some debugging of the Wireshark code it turned out that the decoding of
JPEG images which contain a quantization table was incorrect. I have attached a
patch to correct the decoding.

svn path=/trunk/; revision=24246
2008-02-02 16:41:12 +00:00
Jaap Keuter 1a9aa1ae62 From Alan McBride:
The decoding of a SubscribeCOVProperty packet is not properly decoding the
Monitored Property Identifier field. It leaves a number of decoded bytes at the
end as data.

svn path=/trunk/; revision=24245
2008-02-02 16:30:46 +00:00
Sake Blok 0446fc0d94 Fix for bug 2202, when an ethernet frame with padding is encountered, the
reported length is 46, so there was a one-off error in the code.


svn path=/trunk/; revision=24244
2008-02-02 09:21:09 +00:00
Stig Bjørlykke ee8b8b0ad7 Hmmm. Second try to fix the const problems.
svn path=/trunk/; revision=24238
2008-01-31 23:10:09 +00:00
Stig Bjørlykke dc5b4a8239 Removed a const to make it compile.
svn path=/trunk/; revision=24237
2008-01-31 22:31:01 +00:00
Gerald Combs a4a1f2a69e Make the "!="/"ne" change compile under Windows.
svn path=/trunk/; revision=24234
2008-01-31 20:18:07 +00:00
Gerald Combs 9703c2bb75 If "!=" or "ne" are used in a display filter, warn the user that the results
may be unexpected.

svn path=/trunk/; revision=24232
2008-01-31 19:50:38 +00:00
Stig Bjørlykke f3747bf637 Hide hidden devices in "Capture Interfaces" dialog.
Added a function to check for hidden devices, which also work correctly
for plumbed devices on solaris.

svn path=/trunk/; revision=24231
2008-01-31 16:47:05 +00:00
Stig Bjørlykke 1efb7e3627 Add Luis' uat_get_table_by_name() to fetch SMI uat tables.
svn path=/trunk/; revision=24229
2008-01-30 22:50:55 +00:00
Anders Broman df0e82fa10 Dissect the FLUTE "data".
svn path=/trunk/; revision=24228
2008-01-30 22:34:17 +00:00
Jeff Morriss 8ba9f2d3a4 Move glib-2 specific code out of gsmmap.cnf (where we can't #ifdef around
it--asn2wrs doesn't understand #ifdef's) to packet-gsm-template.c

svn path=/trunk/; revision=24227
2008-01-30 17:11:06 +00:00
Mike Duigou 136e5c2e1f cleanup initial comment. fix urls and email addresses.
svn path=/trunk/; revision=24224
2008-01-29 23:28:10 +00:00
Bill Meier fcff7d7613 Add missing 'static int' for dissect_diameter_3gpp_tmgi(...)
svn path=/trunk/; revision=24223
2008-01-29 20:33:43 +00:00
Anders Broman 9e03164d14 Dissect 3GPP AVP Code: 900 TMGI
svn path=/trunk/; revision=24222
2008-01-29 20:05:02 +00:00
Stig Bjørlykke 70d1699bb2 SSI dBm signal is signed.
svn path=/trunk/; revision=24218
2008-01-29 09:56:11 +00:00
Anders Broman dd1ae8f4f7 Dissect Vendor id and Auth-application Id.
svn path=/trunk/; revision=24216
2008-01-28 19:55:20 +00:00
Stig Bjørlykke dc3900dc00 Make use of an unused value.
svn path=/trunk/; revision=24213
2008-01-27 23:33:09 +00:00
Anders Broman 39b64a4d6c Add the forgotten file.
svn path=/trunk/; revision=24212
2008-01-27 23:18:57 +00:00
Anders Broman ce40fc22a4 Make it possible to do subdissection of Diameter AVP:s and add dissection
of some 3GPP AVP:s.

svn path=/trunk/; revision=24211
2008-01-27 21:06:33 +00:00
Stig Bjørlykke 45572b611c Do not change profile if directory creation failed, and change to default
profile if existing profile was deleted.

svn path=/trunk/; revision=24208
2008-01-27 14:45:31 +00:00
Anders Broman c3fa6a267c Uncomplete code change.
svn path=/trunk/; revision=24207
2008-01-27 14:27:11 +00:00
Anders Broman 1144c36b11 Fix reassembly.
svn path=/trunk/; revision=24205
2008-01-27 11:03:56 +00:00
Stig Bjørlykke 8d512b51d2 From Peter (bug 2224):
Patch to fix compile with glib-1.2.

svn path=/trunk/; revision=24199
2008-01-26 15:28:37 +00:00
Graeme Lunt bf8ce12ca3 Use the standard X.402 module as a separate file rather than as cut/paste into the ACP133 module.
svn path=/trunk/; revision=24197
2008-01-26 10:18:10 +00:00