Commit graph

87 commits

Author SHA1 Message Date
Martin Mathieson
af89565907 Allow Page Up and Page Down to be used when zoomed in.
svn path=/trunk/; revision=44443
2012-08-11 14:41:24 +00:00
Martin Mathieson
a90f6b4069 Also place a limit on how far we can zoom in horizonally (no point in
making on subframe (1ms) be really big).

svn path=/trunk/; revision=44442
2012-08-11 14:06:17 +00:00
Martin Mathieson
6f6ef84c5d When a graph is launched based upon an AM status PDU, make it for the
opposite direction.

svn path=/trunk/; revision=44440
2012-08-11 03:53:13 +00:00
Martin Mathieson
1586d80a77 RLC: when zooming, use shift and control keys to lock vertical or
horizontal scaling respectively.

RLC+TCP: when already fully zoomed out, don't multiply zoom by 1.0 and redraw.
When holding down the key to zoom out, waiting to several redraws of the
whole graph to complete could take a while...

svn path=/trunk/; revision=44374
2012-08-09 04:02:35 +00:00
Anders Broman
f463e9de51 It handles GDK_DISABLE_DEPRECATED
svn path=/trunk/; revision=44326
2012-08-08 07:02:57 +00:00
Martin Mathieson
f8b3e7c317 Fix a test to avoid the cross leaving a line behind at the top of the
graph.

svn path=/trunk/; revision=44315
2012-08-07 23:03:07 +00:00
Martin Mathieson
5c1c9d2244 Don't add 0.5 to coordinates used for drawing the cross. Was going
beyond the area and leaving artifacts.

svn path=/trunk/; revision=44313
2012-08-07 21:42:53 +00:00
Martin Mathieson
41d9e15025 Redo the cross drawing/erasing.
Draw in black, erase by just redrawing the current pixmap.

Will apply to tcp_graph.c if/when this gets through the buildbots.

svn path=/trunk/; revision=44308
2012-08-07 19:11:43 +00:00
Martin Mathieson
463917942d Add right mouse button grab/moving feature (from tcp_graph.c).
svn path=/trunk/; revision=44276
2012-08-05 14:20:23 +00:00
Martin Mathieson
a67e77adea Add cross-hairs here too. Draw lines, but don't change mouse cursor.
svn path=/trunk/; revision=44272
2012-08-05 01:03:33 +00:00
Martin Mathieson
3e09bb9bf1 Cast event->x and event->y to int to avoid warnings seen on Windows
buildbots. 

svn path=/trunk/; revision=44201
2012-08-02 03:53:18 +00:00
Martin Mathieson
a5a1aebc43 The keyboard and mouse zoom functions were almost identical - use a
common routine instead.

svn path=/trunk/; revision=44200
2012-08-02 03:18:35 +00:00
Martin Mathieson
4563416c93 Zoom in/out more slowly, and don't redefine zoom struct.
svn path=/trunk/; revision=44144
2012-07-30 21:40:30 +00:00
Martin Mathieson
4417fa263a Put back the configure_event() handler - it is needed for handling
resizing.

svn path=/trunk/; revision=44139
2012-07-30 14:42:14 +00:00
Martin Mathieson
c58f4f28c4 Try to unbreak the build.
Apologies, I changed the clock time on my computer and so the file
didn't get rebuilt with the last of my changes...

svn path=/trunk/; revision=44127
2012-07-30 01:54:49 +00:00
Martin Mathieson
1f7e43bdb0 Remove yet more unneeded remnants from tcp_graph.c
svn path=/trunk/; revision=44126
2012-07-30 01:19:27 +00:00
Martin Mathieson
4944c79982 Just let cairo clip lines to the edge of the visible graph area.
tcp_graph.c needlessly does this itself, but it only has to deal with horizonal
and vertical lines....

When have returned to original, unzoomed state, set zoom to be 'in' for
the middle mouse button, as thats all that makes sense.

svn path=/trunk/; revision=44124
2012-07-29 22:53:13 +00:00
Martin Mathieson
ca69ea72a8 Tidy up help window, and get rid of a compile-time option to preserve
the 'old' button settings (used by tcp_graph.c).

svn path=/trunk/; revision=44100
2012-07-29 02:57:37 +00:00
Martin Mathieson
f83953e465 Set maximum zoom on Y axis based upon bounds, so works better if there
isn't an SN=1023 for the channel.

Now I understand the time origin toggle - make it show the capture time
by default now.

svn path=/trunk/; revision=44099
2012-07-29 02:09:37 +00:00
Evan Huus
98bbc5a3d9 Simply #ifdefs slightly in the graph code.
Makes cppcheck happier.

svn path=/trunk/; revision=44092
2012-07-28 15:16:41 +00:00
Martin Mathieson
0a63212cc1 More cleaning up of unused remnants from tcp_graph.c.
svn path=/trunk/; revision=44081
2012-07-27 21:45:21 +00:00
Martin Mathieson
348f79931d Limit zoom vertically to around 90 pixels / sequence number.
svn path=/trunk/; revision=44057
2012-07-26 21:16:23 +00:00
Martin Mathieson
e1258c6e15 Remove handlers for a couple of events we're not interested in.
svn path=/trunk/; revision=44002
2012-07-25 17:18:36 +00:00
Martin Mathieson
4b4eb03153 Only call cairo_stroke() when the colour changes, and at the end of the
long list of elements.  Now the graph is like greased lightening!

I will look later to see if I can apply the same change to the TCP
graphs.

svn path=/trunk/; revision=44001
2012-07-25 15:34:31 +00:00
Martin Mathieson
8fcbfe6022 When drawing the line elements, only call gdk_cairo_set_source_color()
when the element colour changes.

svn path=/trunk/; revision=43998
2012-07-25 15:11:14 +00:00
Martin Mathieson
d14fa0eb0f When zooming in, never subdivide whole numbers on the Y axis (they are
sequence numbers).

svn path=/trunk/; revision=43980
2012-07-25 02:56:51 +00:00
Martin Mathieson
b342ac680d Don't leak the graph (or skip a graph refnum) if single RLC channel not
found in selected frame in the packet list.

svn path=/trunk/; revision=43972
2012-07-24 22:43:10 +00:00
Martin Mathieson
21f096d984 Fix horizontal line that gets drawn from the last ACK to the r.h. edge
of the graph (when the last SN hasn't been acknowledged).

svn path=/trunk/; revision=43910
2012-07-22 05:13:49 +00:00
Martin Mathieson
c86f69801f Delete stray debug printf() call left in last commit.
svn path=/trunk/; revision=43909
2012-07-22 04:45:14 +00:00
Martin Mathieson
7b7ab4c70e Don't scale sequence numbers back to 0 (like TCP does). I want to see
the real sequence number.  TODO: show the absolute time...

svn path=/trunk/; revision=43900
2012-07-21 17:21:19 +00:00
Jakub Zawadzki
98c2390515 Fix some clang warnings: implicit conversion from enumeration type 'GtkStateType' to different enumeration type 'GtkStateFlags' [-Werror,-Wconversion]
GTK_STATE_NORMAL and GTK_STATE_FLAG_NORMAL are both 0.

svn path=/trunk/; revision=43854
2012-07-20 11:10:29 +00:00
Pascal Quantin
5ca89cfed3 Sanity checks to avoid a crash if no file is open
svn path=/trunk/; revision=43717
2012-07-14 19:59:13 +00:00
Martin Mathieson
b92733dc39 Add some comments, remove more left-overs from tcp_graph.c.
svn path=/trunk/; revision=43687
2012-07-13 00:35:18 +00:00
Martin Mathieson
5ad8cf408a Speed up line drawing by no longer creating and destroying a cairo_t
object for each line - rather create one and use it for the entire list,
then destroy it.

Simplify the allocation of segments, by no longer messing around with a
static that may or may not be used.  Also, there was a good chance the
last one would be leaked (if it was not part of the stream we are
interested in).

Note that both of these improvements would also apply to tcp_graph.c -
will wait a couple of days to be sure the changes are good.

svn path=/trunk/; revision=43654
2012-07-11 02:43:00 +00:00
Martin Mathieson
3658990eb5 Trivial indentation fixes.
svn path=/trunk/; revision=43636
2012-07-10 02:19:34 +00:00
Guy Harris
4fad38dbd2 From Evan Huus:
Fix an uninitialized-variable error that was breaking compile with gcc.

Also remove some cruft that looks like it was copy-pasted from
ui/gtk/tcp_graph.c

Fixes bug 7460.

svn path=/trunk/; revision=43635
2012-07-10 01:57:55 +00:00
Martin Mathieson
3599fe0daf Add a sequence graph for LTE RLC channels under Telephony | LTE.
svn path=/trunk/; revision=43634
2012-07-10 01:32:54 +00:00