Commit graph

12125 commits

Author SHA1 Message Date
Jakub Zawadzki
a723874490 - Replace jpeg_jfif decoder, with more generic mime_file (no more 64KB limit!).
- Add new dissector packet-mime-encap which understands mime_file fragmentation.

svn path=/trunk/; revision=37636
2011-06-09 21:21:06 +00:00
Alexis La Goutte
08dcc37848 From Colin O'Flynn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5980
Add draft-ietf-6man-rpl-routing-header-03 Support (RH4 RPL Routing Header)

From me :
* Display Bytes of Address and Full Address (Generated)
* Fix some Whitespace and minor enhance...




svn path=/trunk/; revision=37632
2011-06-09 18:02:13 +00:00
Gerald Combs
0abba34b6a Only count an ACK if it's part of an existing conversation, otherwise we
get a lot of false positives.

svn path=/trunk/; revision=37631
2011-06-09 17:30:13 +00:00
Alexis La Goutte
5bcc2dc2f7 * Add Keep Going bit flag in insert command
* Replace tab by space

svn path=/trunk/; revision=37624
2011-06-08 18:26:50 +00:00
Martin Mathieson
5d78458e4b Fix a typo (spotted by Pascal Quantin).
svn path=/trunk/; revision=37622
2011-06-08 17:10:40 +00:00
Anders Broman
30a3988111 Move the warning "...SercosIII heuristic dissector cannot be registered.." to the handoff routine as sercosIII most probably will
not have registered it's name when opensafty's register routine is executed e.g the warning will always be printed.

svn path=/trunk/; revision=37615
2011-06-08 12:02:38 +00:00
Anders Broman
afb0e8b434 From Michael Mann:
Make interlink built-in dissector (from plugin).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6005

svn path=/trunk/; revision=37610
2011-06-08 05:20:43 +00:00
Bill Meier
6399940fd8 From Daniel Willmann: Lontalk protocol (EIA-709.1)
Attached is a dissector for the Lontalk protocol (EIA-709.1). This dissector
registers as a subdissector of the CN/IP protocol.

Some code (mostly definitions) were taken from Bug #2252
(http://bugs.wireshark.org/bugzilla/attachment.cgi?id=4562)

From me: minor mostly cosmetic changes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5909


svn path=/trunk/; revision=37599
2011-06-07 21:10:44 +00:00
Anders Broman
d8e1b0d3d5 Move packet-sercosiii.c to be a builtin dissector.
svn path=/trunk/; revision=37597
2011-06-07 20:33:26 +00:00
Bill Meier
c8475f0b89 From Daniel Willmann: dissector for EIA-852 protocol (Component Network over IP)
Attached is a dissector for CN/IP protocol described in EIA-852. It is mainly
used to encapsulate and send Lontalk (EIA-709.1) or EIA-600 frames over UDP (or
TCP).

This dissector can only decode the common header and data frames can be decoded
by further dissectors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5907


svn path=/trunk/; revision=37596
2011-06-07 18:56:24 +00:00
Anders Broman
fba66f7f7b Delete no longer used .h file
svn path=/trunk/; revision=37590
2011-06-07 14:16:40 +00:00
Graham Bloice
13743add73 Added code to distinguish conversations between different RTUs that happen to use the same address\port pair.
Based on patch supplied by Kelvin Proctor.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3626

svn path=/trunk/; revision=37584
2011-06-06 22:32:37 +00:00
Anders Broman
318e86e2d7 From Pascal Quantin:
Add the following enhancements to the UMTS RLC dissector
(as specified in 3GPP 25.322 v9.2.0):
- UDP framing protocol to allow dissection of RLC PDUs over UDP (like what is
done for LTE MAC/RLC/PDCP protocols)
- 15 bits Length Indicator support (both with variable and fixed LI size)
- Poll type SUFI
- enhanced dissection of LIST, Relative List and Bitmap SUFI
- dissection of Reset and Reset Ack Control PDU
- an option to decode RLC headers only
- an option to skip SDU reassembly

svn path=/trunk/; revision=37576
2011-06-06 20:01:53 +00:00
Stephen Fisher
af0e8c25d0 Fix Unix compilation error...
packet-3g-a11.c:135: warning: 'hf_a11_fqi_granted_qos' defined but not used

... by removing definition


svn path=/trunk/; revision=37575
2011-06-06 19:49:31 +00:00
Anders Broman
c56d401c35 On behalf of Ericsson - enhance A11 dissection.
svn path=/trunk/; revision=37573
2011-06-06 19:17:32 +00:00
Martin Mathieson
b3cbce492a Warn if there are > 2 padding subheaders at the beginning of a frame.
svn path=/trunk/; revision=37570
2011-06-06 16:07:09 +00:00
Anders Broman
5bb09a0c10 From Roland Knall:
Modbus/TCP: Calculating the drop-out criteria for special data dissection fails.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5997

svn path=/trunk/; revision=37566
2011-06-06 10:32:19 +00:00
Martin Mathieson
4295086a6f Avoid no-newline-at-end-of-file warning.
svn path=/trunk/; revision=37565
2011-06-06 09:40:30 +00:00
Anders Broman
2477298026 From Sean Van Gorder:
When Wireshark attempts to read an SNMP packet with a variable-bindings item
with an OID containing an index string which includes an entry of type
"Unsigned32", Wireshark will stop dissecting the packet at this index entry and
end with the error:

[Dissector bug, protocol SNMP: proto.c:2761: failed assertion
"DISSECTOR_ASSERT_NOT_REACHED"]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5883

svn path=/trunk/; revision=37558
2011-06-05 20:12:44 +00:00
Anders Broman
70f488cea7 From Ivan Kluchnikov:
GSMTAP carries payload in various formats of WiMAX interfaces.
It uses the wimax plugin to decode the WiMAX bursts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5964

svn path=/trunk/; revision=37557
2011-06-05 19:58:02 +00:00
Anders Broman
7cd35baaaf From Aamer Akhter:
This patch adds support for a number of performance related metric in NetFlow.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5986

svn path=/trunk/; revision=37556
2011-06-05 19:45:22 +00:00
Guy Harris
0082437631 Clean up indentation.
svn path=/trunk/; revision=37547
2011-06-05 02:48:03 +00:00
Anders Broman
7b75e66774 Try to pacify the OSX build bot.
svn path=/trunk/; revision=37542
2011-06-04 20:14:06 +00:00
Anders Broman
a8a69c6111 Try to fix part of the build bot errors.
svn path=/trunk/; revision=37541
2011-06-04 19:17:28 +00:00
Anders Broman
3821038f94 From Michael Mann:
I made the following improvements to the Modbus/TCP dissector:

1. Implemented protocol to the latest specification (v1.1b).  See
http://www.modbus.org/specs.php.
2. Upgraded to "tcp_dissect_pdus" instead of having the dissector do it
manually.  This also provides TCP packet reassembly support.
3. Removed support for UDP port 502 because it's not supported by the protocol
specification.  I believe "Decode As..." could be used in its place.
4. Added dissector support for the following function codes:
  a) 8 - Diagnostics
  b) 11 - Event Counter
  c) 12 - Event Log
  d) 43 - Encapsulation Transport (mostly for 43/14)
5. Removed support for function codes not in the protocol specification. None
of them were really being parsed, they just offered a "name" for the function
code.
6. Moved protocol #defines to header file for access from other dissectors.  I
plan to have other dissectors use this, but one patch at a time.
7. Created "modbus" dissector that is accessible to other dissectors.
8. Renamed base "display filter name" to reflect PROTOABBREV.

I removed defines for value_strings, I think it's better to export the vaöue strings if needed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5923

svn path=/trunk/; revision=37539
2011-06-04 15:45:50 +00:00
Anders Broman
82d885013c From Michael Mann:
UATification of vcdu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5989

svn path=/trunk/; revision=37537
2011-06-04 13:50:38 +00:00
Anders Broman
b471c4a807 From Michael Mann:
UATification of isakmp dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5989

svn path=/trunk/; revision=37536
2011-06-04 13:47:19 +00:00
Gerald Combs
051ff221fe From Roland Knall via bug 5977:
Handling of SercosIII if the plugin can not be loaded.

Changed the behaviour - if the SercosIII plugin is not available, the
openSAFETY dissector registers itself for ETHERTYPE_SERCOS. SercosIII
packages can not be dissected anyway in such a case and currently no
other dissector will handle those packages.

The following steps will be taken to display the situation to the user:

The message "SercosIII dissector not available, openSAFETY/SercosIII
native dissection." will be added to the tree. Additionally a similar
warning will be presented on the console during startup of wireshark.

All openSAFETY packages will be dissected, displaying the normal
openSAFETY information.

This will be more transparent for the customer.

svn path=/trunk/; revision=37533
2011-06-03 16:56:09 +00:00
Alexis La Goutte
7f2b76ad4c From Mark Phillips via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5830
Fix a minor typo about bitmask of a reserved field.

svn path=/trunk/; revision=37530
2011-06-03 06:47:23 +00:00
Guy Harris
41738f3aa8 Add some notes about attributes with a special format.
svn path=/trunk/; revision=37529
2011-06-03 01:26:08 +00:00
Chris Maynard
4541cfe5d8 From Michael Chen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5983:
Use offset instead of fragment_offset for boundary check. 

svn path=/trunk/; revision=37524
2011-06-02 17:12:13 +00:00
Bill Meier
ce0d6a52b5 Fix Bug #5984: Infinite loop caused by fcn call arg conversion: guint->guint8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5984

svn path=/trunk/; revision=37521
2011-06-02 14:22:19 +00:00
Anders Broman
a9bbcb4a05 Remove extra space at end of IMSI.
svn path=/trunk/; revision=37519
2011-06-02 11:06:26 +00:00
Jörg Mayer
05befd7537 Add Id to info column. Makes detecting duplicates and
matching answers so much easier.

svn path=/trunk/; revision=37518
2011-06-02 07:59:36 +00:00
Jörg Mayer
99e1b372f0 Commit 37516 broke compilation for me in 3 places (with -Werror):
- get_full_XXX functions are unused in the code
- A case statement which handles only 2 of the many enum elements
  creates another warning promoted to error
- The patch removed usage of a variable but not the variable declaration
  itself.

svn path=/trunk/; revision=37517
2011-06-02 07:46:08 +00:00
Anders Broman
d5e45b5cce From Michael Mann:
UATification of ESP

UATification of ESP SA keys.  Some notes:
1. Trimmed a lot of fat removing the code that parsed (and reparsed) ESP SA
keys, since UATs can take care of all that. 
2. There was no validation on the src/dest, so that was carried through (ie
there is still no validation of src/dest fields)
3. Formatting of the source was a little off, so I attempted to fix the
functions I needed to deal with.  I know that's frowned upon, but the braces
were such that I couldn't tell if/else blocks to understand the code.  If
somebody wanted to run an indent program on the file, that would be
appreciated.

Added some casts to make it compile on win64.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1123

svn path=/trunk/; revision=37516
2011-06-02 07:11:26 +00:00
Bill Meier
bfa6690f20 Allow filtering on docsis-capability-type field;
Rename docs_cm_... to docsis_cm_cap_....
Do whitespace & indentation cleanup.

svn path=/trunk/; revision=37514
2011-06-02 00:56:41 +00:00
Chris Maynard
a02b8fb247 From Michael Chen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5863, with some additional enhancements by me: Add dtls heuristics.
svn path=/trunk/; revision=37511
2011-06-01 18:34:41 +00:00
Stig Bjørlykke
e96930f38b Yet another cast to uint.
svn path=/trunk/; revision=37508
2011-06-01 13:58:19 +00:00
Stig Bjørlykke
9334eee893 Corrected usage of uint/pointer conversion.
svn path=/trunk/; revision=37507
2011-06-01 13:57:13 +00:00
Stig Bjørlykke
d368f9325b Added support for DMP version 2 and some national variants.
svn path=/trunk/; revision=37506
2011-06-01 13:31:48 +00:00
Alexis La Goutte
96215c08a9 From Mark Phillips via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5830
802.11 Tag WME Qos Info field is not decoded

From me :
* Update from Trunk
* Make item fiterable


svn path=/trunk/; revision=37497
2011-05-31 21:41:43 +00:00
Anders Broman
4c93ff1b8a REmove the check for HAVE_AIRPDCAP
svn path=/trunk/; revision=37494
2011-05-31 21:34:23 +00:00
Guy Harris
c681f0434e From Roland Knall: openSAFETY dissector.
svn path=/trunk/; revision=37487
2011-05-31 19:31:45 +00:00
Alexis La Goutte
aa966d3186 Enhance Vendor Specific IE (227)
Specifically WPA/WME sub dissector 
* Rework from scratch VS WPA/WME dissector
* Replace proto_tree_add_text/string (ugly hf_ieee80211_tag_interpretation header field...) by proto_tree_add_item
* Make item filterable
* and other stuff...

Based on WMM_Specification_1-1

svn path=/trunk/; revision=37486
2011-05-31 19:30:53 +00:00
Anders Broman
b520ff3a1d From Michael Mann:
Dissect DVB-CI host control resource
according to section 8.5.1 of the DVB-CI specification (EN50221). 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5951

svn path=/trunk/; revision=37472
2011-05-31 06:01:09 +00:00
Stig Bjørlykke
26ba5d5714 Renamed reassembled snmp bytes buffer to "Reassembled SMTP".
svn path=/trunk/; revision=37470
2011-05-30 12:43:35 +00:00
Anders Broman
ccd2833ad8 From Michael Mann:
UATification of 802.11 decryption keys.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1123

svn path=/trunk/; revision=37468
2011-05-30 06:10:25 +00:00
Alexis La Goutte
144a684bd4 Add some comments about RSN IE
Fix some Clang Warnings

svn path=/trunk/; revision=37460
2011-05-29 13:04:06 +00:00
Alexis La Goutte
cf3a4ec432 Don't return offset when it is the end of Extended Capability IE (Only use break)
svn path=/trunk/; revision=37459
2011-05-29 12:51:10 +00:00
Alexis La Goutte
b89d2d8f42 Fix a wrong length when there is unknown Atheros IE Data
svn path=/trunk/; revision=37458
2011-05-29 12:16:53 +00:00
Anders Broman
3c0b5a41fe From Martin Kaiser:
allows filtering
of the event in the pseudo header and removes the pointless filter for
version_number+current_next_indicator.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5832

svn path=/trunk/; revision=37456
2011-05-29 06:59:54 +00:00
Anders Broman
06e2b1ae51 From Martin Kaiser:
DVB-CI dissector: exception in close_session_request apdus (wrong offset)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5955

svn path=/trunk/; revision=37455
2011-05-29 06:43:27 +00:00
Anders Broman
62c7cdacea From Martin Kaiser:
checks the address of the Configuration
Option Register that is used for switching a PC-Card in DVB-CI mode.

The address must be <= 0xffe..

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5940

svn path=/trunk/; revision=37454
2011-05-29 06:34:05 +00:00
Anders Broman
bb31fde9fe From Martin Kaiser:
implements the DVB-CI date-time resource
according to section 8.5.2 of the DVB-CI specification (EN50221).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5936

svn path=/trunk/; revision=37453
2011-05-29 06:29:48 +00:00
Anders Broman
1a768b36b4 - Added new SignatureIdentity values.
From Marc Petit-Huguenin:
- Removed directResponseForwarding.
- The certificate_type enum is now defined as RFC 6091's CertificateType
  so moved the definition to packet-ssl-utils.[ch].
- Fixed invalid values for CERTIFICATE_BY_NODE and CERTIFICATE_BY_USER
  Kinds.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5967

svn path=/trunk/; revision=37452
2011-05-29 06:16:19 +00:00
Anders Broman
ed1bfad981 From Pascal Quantin:
Update 3GPP NAS MS Radio Access Capability dissection to Release 9.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5970

From me change all enc type to ENC_BIG_ENDIAN.

svn path=/trunk/; revision=37451
2011-05-29 06:06:22 +00:00
Sake Blok
ba086053c7 Add "File -> Export -> SSL Session Keys..." to be able to save the keyring info for each session in the trace file. This makes it possible to give someone the trace and the exported keys so that they can decrypt the traffic in the trace, but not new sessions to the same server.
(See also: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3444)


svn path=/trunk/; revision=37446
2011-05-28 18:17:50 +00:00
Chris Maynard
521b65f257 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5959
Use _U_ for unused function parameter.

svn path=/trunk/; revision=37442
2011-05-27 18:18:28 +00:00
Chris Maynard
0a3319cbc6 Use a non-volatile temporary variable as a parameter to DISSECTOR_ASSERT().
This avoids an "assert with side effects" warning and resolves Coverity CID322.

svn path=/trunk/; revision=37441
2011-05-27 18:08:46 +00:00
Bill Meier
e3dff872d0 Put proto_reg_handoff_...() at the end of the file as per the usual Wireshark convention.
svn path=/trunk/; revision=37440
2011-05-27 15:51:21 +00:00
Chris Maynard
955008c4b0 When parsing OPTION_REMOTE_ID, don't modify optlen or we'll return the wrong
number of bytes consumed.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5962

svn path=/trunk/; revision=37439
2011-05-27 14:38:42 +00:00
Bill Meier
8ad97b46ca Fix a gcc 4.6 error: "variable might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]"
svn path=/trunk/; revision=37438
2011-05-27 13:23:54 +00:00
Stig Bjørlykke
0b154761fa One more still dirty.
svn path=/trunk/; revision=37436
2011-05-27 12:46:35 +00:00
Stig Bjørlykke
8a8ff7f03d Moved nbap and pcap back as dirty dissectors.
svn path=/trunk/; revision=37434
2011-05-27 11:58:47 +00:00
Stig Bjørlykke
51864807b3 Corrected "old-style function definition".
svn path=/trunk/; revision=37433
2011-05-27 11:03:04 +00:00
Stig Bjørlykke
21432aa5b0 Try building some ASN.1 dissectors as clean.
svn path=/trunk/; revision=37432
2011-05-27 10:52:25 +00:00
Stig Bjørlykke
7b5896a179 Corrected "old-style function definition".
svn path=/trunk/; revision=37429
2011-05-27 10:18:17 +00:00
Jaap Keuter
8e30d1990e From Colin O'Flynn:
Avoid processing tvb when fragment dissection didn't create one.

svn path=/trunk/; revision=37426
2011-05-27 07:02:26 +00:00
Jeff Morriss
f3f9f2697f Make TVBs opaque for most users.
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
2011-05-27 03:06:50 +00:00
Jeff Morriss
7ad71a2d78 Treat TVBs as opaque: use the accessor functions instead of accessing the fields
directly.

svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
Jeff Morriss
8ce306faa0 Inspired by one of the changes from r37406 and bug 2794: detect hf abbreviations
with two or more periods in a row.  Fix one case of that.

svn path=/trunk/; revision=37407
2011-05-26 13:32:04 +00:00
Anders Broman
6a4ed4f4c3 From Michael Mann.
Part of "display filters with redundancies of PROTABBREV in them."
The ones left outs should be fixed differently I think.
Rename som ndps hf variables while at it.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794

svn path=/trunk/; revision=37406
2011-05-26 06:32:51 +00:00
Jeff Morriss
b2120849b1 From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5749 :
Added support for the following services of the Connection Manager object:
LargeForwardOpen
GetConnectionOwner

Added support for the following services of the Connection Configuration
Object:
GetAttributeAll
SetAttributeAll

From me:
Replace tabs with spaces; adjust modelines for 8-space tabs instead of 3.

svn path=/trunk/; revision=37404
2011-05-26 02:20:23 +00:00
Jeff Morriss
28bae657ae From Florian Fainelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5943 :
The two patches attached allow the dissection of the Homeplug AV Ethernet MAC
management frames between a controlling device and a Homeplug AV Ethernet to
PLC adapter. This protocol is pretty similar to the previous generation
Homeplug protocol (dissected by packet-homeplug.c) but a couple of noticeable
differences make it require its own dissector handler.

This dissector is based on the work done by Nicolas Thill, Xavier Carcelle and
myself in the Faifa project (https://dev.open-plc.org).

The dissector handles the standard Homeplug AV Ethernet MAC management frames
(called public) as well as the Intellon specific management frames (vendor).

From me:
Remove unnecessary global variables.
Add to COL_INFO even when !tree.
Remove gotos.
Remove unnecessary includes.

svn path=/trunk/; revision=37403
2011-05-26 01:55:04 +00:00
Sake Blok
8f5742c5ad Extended the SSL key log import routine to be able to read the following format:
RSA Session-ID:xxxx Master-Key:xxxx

This makes it easy to use the "openssl s_client" output for decryption
(see: http://ask.wireshark.org/questions/4229/follow-ssl-stream-using-master-key-and-session-id)

It also paves the way for exporting SSL keyring material. See also the enhancement request in:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3444


svn path=/trunk/; revision=37401
2011-05-25 21:49:29 +00:00
Jeff Morriss
db372d0ad2 Add some expert infos for unusual messages:
- routing on SSN but the SSN is not present or is unspecified (zero)
 - message handling has an unexpected value
 - message class is incorrect for the message type

Also clean up some indentation and other white space.

svn path=/trunk/; revision=37400
2011-05-25 21:47:35 +00:00
Alexis La Goutte
0524b9f8d6 From tschardt via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5949
802.11 IE tag number 61/62 still decoded to "Unknown"/Reserved tag Number

Remove inadvertently by me in rev36120

svn path=/trunk/; revision=37389
2011-05-25 07:15:05 +00:00
Anders Broman
570ffe5f7d From Florian Fainelli:
Patch adding the Homeplug AV ethertype.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5943

svn path=/trunk/; revision=37388
2011-05-25 05:33:00 +00:00
Bill Meier
058fc19f45 Fix various benign cases of Coverity [UNUSED]: 996,995,956,936,899,1133,1000
svn path=/trunk/; revision=37371
2011-05-23 18:04:45 +00:00
Chris Maynard
d6fb7f50df From Romain Fliedel via bug 5947: Fix the mask for extracting FMID.
svn path=/trunk/; revision=37370
2011-05-23 17:53:51 +00:00
Bill Meier
dbf57a4dea Use the 'proto_tree *' (not the 'proto_item *') for a proto_tree_add_item(): Coverity 963 {UNUSED]
svn path=/trunk/; revision=37369
2011-05-23 17:51:33 +00:00
Martin Mathieson
cb78939ede Pass tap info into sequence analysis function.
svn path=/trunk/; revision=37368
2011-05-23 17:15:00 +00:00
Martin Mathieson
9c0ba9fc85 Detect when padding non-final padding comes after other control subheaders.
svn path=/trunk/; revision=37367
2011-05-23 16:11:32 +00:00
Michael Tüxen
9a661e4967 Fix compilation.
svn path=/trunk/; revision=37365
2011-05-23 14:41:04 +00:00
Bill Meier
1396fd4783 Remove an unneeded redundant line of code: Fixes Coverity 1001.
Also:
 Use a separate ett variable for a subtree;
 Convert what appears to be '4 space tabs' to '4 spaces'.

svn path=/trunk/; revision=37364
2011-05-23 14:34:59 +00:00
Bill Meier
0c08ae45c2 Use correct subtree in two cases: Fixes Coverity 920;
Also:
  Remove a number of unneeded #include statements;
  Do some whitespace cleanup.

svn path=/trunk/; revision=37363
2011-05-23 14:30:00 +00:00
Michael Tüxen
b6111d3c9f Fix compilation.
svn path=/trunk/; revision=37362
2011-05-23 14:28:02 +00:00
Bill Meier
8889f829c0 Use correct subtree in a few cases: Fixes Coverity 921,894,878 & 1136;
svn path=/trunk/; revision=37361
2011-05-23 14:26:43 +00:00
Bill Meier
33fe1d803a Use correct subtree in several 'proto_tree_add_text(...)' statements: Fixes Coverity 938 [UNUSED].
svn path=/trunk/; revision=37360
2011-05-23 14:17:30 +00:00
Bill Meier
0d03e86f6b Use correct subtree in 'call dissector(...)': Fixes Coverity 962 [UNUSED].
svn path=/trunk/; revision=37359
2011-05-23 14:14:43 +00:00
Bill Meier
14b997e8b5 Add a missing line of code: Fixes Coverity 967 [UNUSED].
svn path=/trunk/; revision=37358
2011-05-23 14:13:03 +00:00
Bill Meier
a9652ea66e Use correct subtree for proto_tree_add_item in several places: Coverity 1130 [UNUSED];
Also: Reformat a few lines and do some whitespace cleanup.

svn path=/trunk/; revision=37357
2011-05-23 14:11:14 +00:00
Martin Mathieson
c13f268e8b Add missing braces.
svn path=/trunk/; revision=37356
2011-05-23 10:09:08 +00:00
Jörg Mayer
5f28f55229 7.3.2.25 or 802.11-2007 gives an example of length 20, so it is unclear where the 24 came from (unintentionally fixes bug 5942)
svn path=/trunk/; revision=37355
2011-05-23 08:54:47 +00:00
Chris Maynard
f6a11de61f Delete unused header field entries found by running checkhf.pl.
svn path=/trunk/; revision=37353
2011-05-23 00:32:40 +00:00
Chris Maynard
609c3dd0d4 From Micheal Mann via bug 2794: Fix some display filter field names.
svn path=/trunk/; revision=37351
2011-05-23 00:00:53 +00:00
Bill Meier
9851df836c From Yaniv Kaul: Some 'set but not used' compilation fixes;
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5858

From me: 2 corrections to the patch and sevral other minor changes.

svn path=/trunk/; revision=37350
2011-05-22 22:04:24 +00:00
Bill Meier
c0922b93b6 Don't assign to a variable which is then not referenced: Coverity 998 [UNUSED].
svn path=/trunk/; revision=37340
2011-05-20 20:41:23 +00:00
Bill Meier
d99149b1d6 Don't assign to an unused variable: Fixes Coverity 874 [UNUSED].
svn path=/trunk/; revision=37339
2011-05-20 20:29:19 +00:00