Chris Maynard
568fdf18a7
All ELEM_MAND_* macros ensure curr_len > 0; no need to check again afterwards.
...
Resolves Coverity CIDs 381-382.
svn path=/trunk/; revision=37200
2011-05-17 14:41:01 +00:00
Anders Broman
7dce5861cc
From Pascal Quantin:
...
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866
svn path=/trunk/; revision=36918
2011-04-27 22:18:00 +00:00
Anders Broman
aaf0d277b8
Get rid of gsm_a_dtap_pinfo.
...
svn path=/trunk/; revision=36444
2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc
Change the signature of elem_fcn():ns to include pinfo.
...
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5
Change the msg_fcn() signature to include pinfo.
...
svn path=/trunk/; revision=36441
2011-04-04 07:45:34 +00:00
Anders Broman
a469849210
From Pascal Quantin:
...
[3GPP protocols] Prettify the display of Mandatory Value information elements
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711
svn path=/trunk/; revision=36026
2011-02-22 11:56:10 +00:00
Anders Broman
60297df554
- Add message name to info col in case of SERVICE REQUEST.
...
- Get rid of check_col
- proto_tree_add_item -> ENC_BIG_ENDIAN
svn path=/trunk/; revision=35893
2011-02-10 08:28:18 +00:00
Anders Broman
82497afee7
Export de_emm_trac_area_id.
...
svn path=/trunk/; revision=35646
2011-01-25 13:57:59 +00:00
Anders Broman
757bc6a6ff
Set gsm_a_dtap_pinfo->link_dir to get proper dissection of PCO.
...
svn path=/trunk/; revision=35510
2011-01-12 21:36:11 +00:00
Anders Broman
6a49803d2c
Update a value_string.
...
svn path=/trunk/; revision=35502
2011-01-12 07:39:54 +00:00
Anders Broman
863e3f80a6
Add dissection of more IE:s
...
svn path=/trunk/; revision=35417
2011-01-07 15:21:23 +00:00
Anders Broman
259061a26b
Try to apiece the Ubuntu buildbot.
...
svn path=/trunk/; revision=35270
2010-12-27 08:23:55 +00:00
Anders Broman
790ba15666
move the enum to packet-gsm_a_common to
...
make it possible to use element dissecton from this dissector
in other dissectors.
It is left in packet-nas_EPS.c as a comment for easier reference.
svn path=/trunk/; revision=35269
2010-12-27 05:33:58 +00:00
Anders Broman
4b5a8bff9e
From Vincent Helfre:
...
Make it possible to dissect NAS EPS messages without security header.
svn path=/trunk/; revision=35062
2010-11-29 13:27:00 +00:00
Anders Broman
2bb0b3fa19
The IPv6 "element" in PDN address information element is a 8 byte
...
IPv6 interface identifier.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5408
svn path=/trunk/; revision=34914
2010-11-16 20:46:21 +00:00
Anders Broman
fdb2192631
From Pascal Quantin:
...
[NAS EPS] Enhance dissection of APN-AMBR IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5304
svn path=/trunk/; revision=34535
2010-10-17 14:04:59 +00:00
Bill Meier
209109c2fd
Define some fcns & vars as static ...
...
svn path=/trunk/; revision=34458
2010-10-10 20:07:06 +00:00
Anders Broman
c522f01e2b
From Pascal Quantin:
...
[NAS EPS] Add dissection of special conformance testing functions
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5278
svn path=/trunk/; revision=34394
2010-10-06 14:33:27 +00:00
Anders Broman
72ac77046f
From Pascal Quantin:
...
[NAS EPS] Add dissection of EPS network feature support IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5264
svn path=/trunk/; revision=34279
2010-09-29 15:41:27 +00:00
Anders Broman
1252ff8350
From Pascal Quantin:
...
NAS EPS] Wrong dissection of Non-current native NAS key set identifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5253
svn path=/trunk/; revision=34210
2010-09-23 14:07:32 +00:00
Anders Broman
b596b69f66
From Pascal Quantin:
...
[NAS EPS] Use Request Type IE defined in 3GPP 24.008
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5246
svn path=/trunk/; revision=34179
2010-09-22 10:38:45 +00:00
Stig Bjørlykke
ca111463e7
From Pascal Quantin via bug 5186:
...
Fix the decoding of the maximum/guaranteed bit rates for uplink/downlink.
svn path=/trunk/; revision=34069
2010-09-06 17:31:17 +00:00
Anders Broman
9da9ac87d3
Typo - wrong IE code for APN aggregate maximum bit rate in message
...
Activate default EPS bearer context request.
svn path=/trunk/; revision=33813
2010-08-16 15:31:13 +00:00
Anders Broman
02738f27b6
From Pascal Quantin:
...
The attached patch fixes the dissection of the PDN Disconnect Request message
in case the optional Protocol Configuration Options IE is not present.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5065
svn path=/trunk/; revision=33654
2010-07-28 21:13:05 +00:00
Anders Broman
c5ddd5a253
Add miising else handling a zero msg_auth_code.
...
svn path=/trunk/; revision=33455
2010-07-06 13:21:34 +00:00
Anders Broman
929e1c1d98
Allow dissection if not ciphered.
...
svn path=/trunk/; revision=33371
2010-06-29 14:50:40 +00:00
Jaap Keuter
a712e58a94
From KATAOKA Toshihiro:
...
The sequence number in 3GPP NAS EPS(TS24.301) cyphered PDU is outside of ciphered text.
svn path=/trunk/; revision=33258
2010-06-20 12:21:45 +00:00
Bill Meier
bfce3e6670
Do some constifying (based upon gcc -Wwrite-strings warnings);
...
Replace "4 space tabs" by 4 spaces.
svn path=/trunk/; revision=33194
2010-06-09 17:40:03 +00:00
Anders Broman
9ea0a509b5
From Pascal Quantin:
...
Avoid triggering a malformed packet error when decoding a simple UE terminated Detach Request when the EMM cause IE is not present:
svn path=/trunk/; revision=33071
2010-06-03 07:47:07 +00:00
Stig Bjørlykke
0100633d63
Fixed a comment.
...
svn path=/trunk/; revision=33031
2010-06-01 07:31:10 +00:00
Anders Broman
9b9aaed177
From Pascal Quantin:
...
Decode the EIA0 (null integrity algorithm) bit in EMM messages. This was introduced in 3GPP 24.301 CR-0422 (Release 9.2) and is also used by the LTSI (LTE/SAE Trial Initiative) for interoperability tests between constructors (with Release 8 equipments). I also updated the description of EEA0 as stated in 24.302 release 9.2.
svn path=/trunk/; revision=33030
2010-06-01 07:26:08 +00:00
Anders Broman
1b49f4e316
From Pascal Quantin:
...
Prettify decoding of EPS NAS messages.
svn path=/trunk/; revision=32993
2010-05-27 14:05:20 +00:00
Anders Broman
ac8e44a6a5
From Pascal Quantin:
...
Try to decode the message when the direction is unknown (I dissect it as DL first as fake UL dissection could trigger a malformed packet error). Moreover the patch fixes a shift in the EMM IE strings list, leading to incorrect decoding.
svn path=/trunk/; revision=32930
2010-05-24 09:01:22 +00:00
Anders Broman
b4eaaf4aff
More updates towards V9.2.0 (2010-04).
...
svn path=/trunk/; revision=32518
2010-04-19 20:12:26 +00:00
Anders Broman
6b96494a3d
From KATAOKA Toshihiro:
...
NAS EPC dissector correction.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4696
svn path=/trunk/; revision=32515
2010-04-19 14:06:12 +00:00
Gerasimos Dimitriadis
dfde72f247
Fix for Bug 4588:
...
RANAP and friends want the MNC encoded in big endian form.
svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Anders Broman
016530ba0f
From Pascal Quantin:
...
[NAS EPS] Various small bug fixes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4562
svn path=/trunk/; revision=32130
2010-03-06 20:32:27 +00:00
Anders Broman
8a39d11aa1
Activate dedicated EPS bearer context accept may have no IE's.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4432
svn path=/trunk/; revision=31718
2010-01-28 17:01:54 +00:00
Bill Meier
c5614625ee
Fix some gcc -Wshadow warnings ....
...
svn path=/trunk/; revision=31559
2010-01-18 23:16:10 +00:00
Gerasimos Dimitriadis
99155acdee
From Pascal Quantin:
...
[NAS EPS] Fix Attach Reject message decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4362
svn path=/trunk/; revision=31380
2009-12-29 14:56:53 +00:00
Anders Broman
571e210c76
From Pascal Quantin:
...
[NAS EPS] various small fixes for message decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4290
svn path=/trunk/; revision=31166
2009-12-03 20:12:13 +00:00
Gerasimos Dimitriadis
b7261fe2e4
Expert info when E.212 MCC/MNC contain non-decimal digits
...
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Anders Broman
83231fe94a
From Pascal Quantin:
...
[NAS EPS] Expert Info error triggered when decoding a Security Mode Complete message
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4203
svn path=/trunk/; revision=30820
2009-11-04 13:49:19 +00:00
Anders Broman
64416202c6
From Pascal Quantin:
...
I just realized that I forgot to change one line to get a proper decoding of IMEI
svn path=/trunk/; revision=30805
2009-11-03 12:44:17 +00:00
Anders Broman
242db04e6b
From Pascal Quantin:
...
Small fixes for Attach Request message decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4198
svn path=/trunk/; revision=30803
2009-11-03 12:16:25 +00:00
Anders Broman
62ae894451
From Pascal Quantin :
...
[NAS EPS] Incorrect decoding of UE Network Capability IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4196
svn path=/trunk/; revision=30802
2009-11-02 22:37:34 +00:00
Anders Broman
d2f6aaa4d1
Change a refrerence.
...
svn path=/trunk/; revision=30326
2009-10-05 08:33:55 +00:00
Anders Broman
801f0458e4
Update to 3GPP TS 24.301 V9.0.0 (2009-09)
...
svn path=/trunk/; revision=30246
2009-10-02 09:23:46 +00:00
Kovarththanan Rajaratnam
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Anders Broman
a90865ff66
Fix bug in IE decoding.
...
svn path=/trunk/; revision=29969
2009-09-17 13:53:52 +00:00