Commit Graph

20620 Commits

Author SHA1 Message Date
Jeff Morriss 13942d6fa3 Don't #define bzero and bcopy to be memset and memcpy on Windows, just use memset and memcpy instead.
svn path=/trunk/; revision=21201
2007-03-26 03:59:09 +00:00
Jeff Morriss a0086f5098 Also try to set -Wdeclaration-after-statement in wiretap
svn path=/trunk/; revision=21200
2007-03-26 02:05:54 +00:00
Ronnie Sahlberg 80fe723473 From Jon Smirl
add a whole bunch of new descriptor types


svn path=/trunk/; revision=21199
2007-03-26 01:59:02 +00:00
Jeff Morriss 5a0cd55e15 Remove references to the megaco plugin from the top level Makefiles.
svn path=/trunk/; revision=21198
2007-03-26 01:56:51 +00:00
Ronnie Sahlberg f88aa196a0 From
Charles Lepple


This patch enables packet-usb.c to display all descriptors in the GET
CONFIGURATION request, regardless of whether we know how to decode
them. (All descriptors in that request share the same first two
bytes.)

It also adds the HID descriptor type (not the report descriptor,
though - that is buried in a class request, not a device request). I
am still working on actually decoding this descriptor.



svn path=/trunk/; revision=21197
2007-03-26 01:41:50 +00:00
Ronnie Sahlberg d3283d23ea From
Martin Sustrik

additions to AMQP dissector and prettifications to the information column



svn path=/trunk/; revision=21196
2007-03-26 01:34:06 +00:00
Jeff Morriss d14c5ba107 If we're using gcc, try to use -Wdeclaration-after-statement to catch more non-portable commits. I'm not sure if this is the Right Way to test to see if the compiler can handle a specific option but it's simple and efficient enough.
svn path=/trunk/; revision=21195
2007-03-26 00:32:13 +00:00
Ronnie Sahlberg 09814fac51 From a Jon Smirl patch
rename the conversation field "class" to "interfaceClass"


svn path=/trunk/; revision=21194
2007-03-25 23:51:40 +00:00
Ronnie Sahlberg 747b009566 From Jon Smirl
change the private data pointer name from  masstorage to class_data
since there will be future class specific dissectors that will also want to hang
some extra data off these structures



svn path=/trunk/; revision=21193
2007-03-25 22:53:35 +00:00
Guy Harris 07d6794bea All private data for a capture in a Wiretap module must be per-file, not
static to the module.

Add the older(?) ID tag for MPEG audio.

Just use the ID at the beginning to identify MPEG audio files; don't
check the file any further.

If the read of the magic number doesn't work, get the error, and, if
there is no error (i.e., it's a short read), just return 0 (meaning "no
error, but this isn't that type of file).

Similarly, if the magic number doesn't match, just return 0, so other
types of file are tried.

svn path=/trunk/; revision=21192
2007-03-25 22:07:40 +00:00
Luis Ontanon 296a77efdc migrate packet-megaco.c from plugins/megaco to epan/dissectors
svn path=/trunk/; revision=21191
2007-03-25 21:59:16 +00:00
Luis Ontanon 7233064c5a rename h248_* to gcp_* according to changes in epan.
svn path=/trunk/; revision=21190
2007-03-25 21:56:08 +00:00
Luis Ontanon 0b3d2a90ff Migrate context tracing code from packet-h248.[ch] to gcp.[ch], so that the same code can be used by megaco (upcoming).
svn path=/trunk/; revision=21189
2007-03-25 21:42:26 +00:00
Luis Ontanon 753ac01760 Remove the context tracing from packet-h248.c ( migrated to <epan/gcp.c> )
svn path=/trunk/; revision=21188
2007-03-25 21:39:40 +00:00
Guy Harris fecd335762 Before accepting a packet in a heuristic dissector, don't fetch any data
without first checking to make sure it's available.

Clear the Info column as soon as we've accepted a packet.

In the "MPEG" dissector, if no subdissector accepts the packet, dissect
it as just "MPEG" data.

svn path=/trunk/; revision=21187
2007-03-25 21:10:10 +00:00
Guy Harris 79561053bb Before we've decided to dissect a frame, don't fetch any data before
checking to make sure it's available.

Don't dissect an audio frame if it doesn't have a valid version or layer
value.

Don't do anything with the columns until we've decided to accept a
frame.

The register routines are only called once; we don't have to check
whether they've already been called.

svn path=/trunk/; revision=21186
2007-03-25 21:07:24 +00:00
Luis Ontanon 4e7a4e0b06 make the mpeg_open() more conservative checking whether there's ssome magic bytes at the beginning of the file.
I added just one type of mpeg magic ("ID3") there's probably more, please add.

svn path=/trunk/; revision=21185
2007-03-25 19:00:59 +00:00
Ulf Lamping 27f97a1dfc all warnings removed in the meantime, "treat warnings as errors" :-)
svn path=/trunk/; revision=21184
2007-03-25 17:07:36 +00:00
Ulf Lamping 3575d95342 set "treat warnings as errors" CFLAGS, no warning were in this dir :-)
svn path=/trunk/; revision=21183
2007-03-25 15:39:06 +00:00
Ulf Lamping f6c01787b3 remove unused CFLAGS
svn path=/trunk/; revision=21182
2007-03-25 15:37:03 +00:00
Ulf Lamping 5aa4b3cecd remove remaining warnings in epan dir and set the "treat warning as error" barrier
(epan/dissectors still waiting for a cleanup)

svn path=/trunk/; revision=21181
2007-03-25 15:13:03 +00:00
Ronnie Sahlberg 62353b8044 From Jon Smirl
support for usb host/endpoint lists


svn path=/trunk/; revision=21180
2007-03-25 11:37:13 +00:00
Ronnie Sahlberg 17b4ee556b From Jon Smirl
support for USB conversations



svn path=/trunk/; revision=21179
2007-03-25 11:27:29 +00:00
Ronnie Sahlberg 58b174de83 take the address to the structure and not the address to the first element of the structure when doing a SET_ADDRESS
svn path=/trunk/; revision=21178
2007-03-25 11:20:09 +00:00
Ronnie Sahlberg ab407b08cf Change USB address structure back to 8 bytes in length.
It is suboptimal to have the endpoint both being the "port" and also 4 bytes out of the address.
But it looks better to have addresses as <device>.<endpoint> .


svn path=/trunk/; revision=21177
2007-03-25 11:15:09 +00:00
Ronnie Sahlberg 1053745b1c create a tap for usb so that we can do conversation/host lists
svn path=/trunk/; revision=21176
2007-03-25 09:55:49 +00:00
Ronnie Sahlberg ab2e40bcb5 Add a small example on how to prettify the AMQP dissector
svn path=/trunk/; revision=21175
2007-03-25 08:49:47 +00:00
Ronnie Sahlberg 0e6e4b0795 From Martin Sustrik
New protocol: AMQP


svn path=/trunk/; revision=21174
2007-03-25 08:26:44 +00:00
Ronnie Sahlberg 3689e6f460 unbreaking the usb dissector
since dlt189 was introduced   the dissector has been suboptimal


assuming the capture   usb_memory_stick.pcap on the wiki shows what this linktype
should look like, this patch
- adds request in/response in/time  generated fields to the dissect pane
- fixes the tracking of what is a request and what is a response (the old code just can not have worked!)
- fixes conversation tracking to work (dont add the port/endpoint into the length of the address)
- handles some mysterious extra 8 bytes prepended to a lot of different packets.



svn path=/trunk/; revision=21173
2007-03-25 05:20:56 +00:00
Ulf Lamping 132ef2725b fix validation
svn path=/trunk/; revision=21172
2007-03-25 00:47:53 +00:00
Ulf Lamping b6369d2dc0 edit some things about source code (update)
svn path=/trunk/; revision=21171
2007-03-25 00:46:04 +00:00
Ulf Lamping 2467660c44 add a section about the buildbot
some other minor editing

svn path=/trunk/; revision=21170
2007-03-24 23:50:15 +00:00
Ronnie Sahlberg 8d8f94f1ae fix a bug (found by compiler warning) where we initialize the wrong variable.
svn path=/trunk/; revision=21169
2007-03-24 21:56:14 +00:00
Ulf Lamping c7ba9e25b3 hmmm, _WINSOCK2API_ is not the way to go, the PSDK that comes with MSVC 6.0 also defines this - but not sockaddr_storage :-(
Next try is to use the WINVER #define. AFAIK, this depends on the Platform SDK version used, which is actually our problem here. So this fix *might* work ...

svn path=/trunk/; revision=21168
2007-03-24 18:26:34 +00:00
Jeff Morriss 109388d263 Clean up some more warnings: unused variables, unitialized variables, wrong format (%ld instead of %d) in packet-sccp.c
svn path=/trunk/; revision=21167
2007-03-24 13:46:41 +00:00
Jeff Morriss 10e8a95401 Add brackets to extern of ssl_version_short_names[] to fix compiler warnings.
svn path=/trunk/; revision=21166
2007-03-24 13:21:08 +00:00
Jeff Morriss 59159fe03e Fix bug 1452: Don't pass a null pointer to g_strsplit().
svn path=/trunk/; revision=21165
2007-03-24 10:07:20 +00:00
Stephen Fisher aa4d4f727c From Sebastien Tandel:
Fixes for warnings


svn path=/trunk/; revision=21164
2007-03-24 07:33:25 +00:00
Jaap Keuter 39517d2dbb Make some more string conversions available to plugins
svn path=/trunk/; revision=21163
2007-03-24 07:05:39 +00:00
Ulf Lamping 473f4c3b64 as mentioned by Graham Bloice:
sockaddr_storage doesn't depend on the MSVC version used, but the version of the Winsock API, which might be updated by the Platform SDK even on MSVC 6 - so depending on the _MSC_VER is not the way to go

svn path=/trunk/; revision=21162
2007-03-24 02:45:45 +00:00
Stephen Fisher dfc2b16e29 Fix mess with ssl_version_short_names[] being defined multiple places
now that it is no longer a static variable in packet-ssl-utils.h.
Leaving it as static caused a warning turned error that it was unused
in the current file (packet-ssl-utils.h).  Resolution: Move the variable
to packet-ssl.c and declare as extern in packet-dtls.c - the only other
place that needs it.


svn path=/trunk/; revision=21161
2007-03-24 01:38:58 +00:00
Stephen Fisher 1909b97d4d Remove all warnings under Unix for the gtk/ directory.
svn path=/trunk/; revision=21160
2007-03-24 00:45:11 +00:00
Stephen Fisher 43a98f8fb8 From Sebastien Tandel:
fixes gcc warnings and get rid of declaration after statements


svn path=/trunk/; revision=21159
2007-03-23 23:47:41 +00:00
Stephen Fisher 2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Stephen Fisher 3288a39db2 From Sebastien Tandel:
copy paste hit again, here is a patch with the accurate declaration of
RVALS in proto.h
Thx gcc-4.1.2 for finding new ways of generating strict aliasing warnings :)

patch with accurate comment and declaration.


svn path=/trunk/; revision=21157
2007-03-23 18:48:57 +00:00
Stephen Fisher 64cc1b407c From Sebastien Tandel:
(Fixing warnings)

stripped away some unused variables/parameters
+ in prefs.c
    suggestion of parentheses makes gcc happy


svn path=/trunk/; revision=21156
2007-03-23 18:45:21 +00:00
Stephen Fisher 8973617e4b From Sebastien Tandel:
First patch fixes warning of profinet and megaco plugins to compile
again with gcc-4.1.2.


svn path=/trunk/; revision=21155
2007-03-23 18:16:53 +00:00
Stephen Fisher 6d8d2854c8 From Sake Blok:
Fix for bug #491: Unexpected frame.time_delta behavior

This patch ... fixes bug 491. It does this by changing the
behaviour of the frame.time_delta field so it reflects the delta
time between captured packets (tshark already did this).  To keep
the delta time between displayed packets, the field 
frame.time_delta_displayed is created.


svn path=/trunk/; revision=21154
2007-03-23 18:08:17 +00:00
Stephen Fisher 62f88a4a04 From Sebastien Tandel:
(Temporarily disable the warnings as errors default on Unix to get
to get the buildbots and people with gcc40 going again until those
additional warnings gcc40 generates can be fixed-I'm working on it
ASAP)

   Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by HAVE_WARNINGS_AS_ERRORS.
With this switch, people won't suffer from unexpected warnings when
downloading svn sources during the transition time ;)


svn path=/trunk/; revision=21153
2007-03-23 17:49:59 +00:00
Graeme Lunt 1f9eafa4fb Support for Microsoft-defined enhancedKeyUsage OIDs.
svn path=/trunk/; revision=21152
2007-03-23 16:52:22 +00:00