Commit graph

2469 commits

Author SHA1 Message Date
Ulf Lamping
d2233711d9 add get_manuf_name_if_known (returns NULL if unknown) in addition to get_manuf_name
svn path=/trunk/; revision=14405
2005-05-20 21:44:17 +00:00
Luis Ontanon
98d824e05b dup the filter string so that it can be freed without problems.
fixes bug 195


svn path=/trunk/; revision=14402
2005-05-20 19:40:10 +00:00
Luis Ontanon
bc1292ff1d some cosmetic fixes
svn path=/trunk/; revision=14401
2005-05-20 19:38:24 +00:00
Anders Broman
416c350db1 Use value_string for codec values/strings.
svn path=/trunk/; revision=14400
2005-05-19 20:35:30 +00:00
Anders Broman
b8cd3ff407 Display version number and product number as strings.
svn path=/trunk/; revision=14399
2005-05-19 20:34:35 +00:00
Anders Broman
59516e5f4f Add Sony and Nokia VendorID:s
svn path=/trunk/; revision=14398
2005-05-19 20:33:59 +00:00
Guy Harris
d444801e4a Clean up indentation.
Add some comments with questions.

Mark an unused argument as such, and get rid of an unused variable.

svn path=/trunk/; revision=14396
2005-05-19 09:26:15 +00:00
Luis Ontanon
3f36640526 - add an isup stats_tree with statistics regarding message types and the directions in which they flow.
svn path=/trunk/; revision=14393
2005-05-18 13:51:49 +00:00
Anders Broman
443d4bf1c1 Add a dissector for h221 nonstandard data which can easily be expanded with publically avalable data or
replaced by a propriatary one.

svn path=/trunk/; revision=14392
2005-05-18 05:44:12 +00:00
Anders Broman
399e571547 Make it possible to dissect h221nonstandard data and fix some compile warnings from asn2eth.
svn path=/trunk/; revision=14388
2005-05-17 20:32:30 +00:00
Anders Broman
dadf75a031 From Mark C Brown,:
Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records.

svn path=/trunk/; revision=14386
2005-05-17 19:51:09 +00:00
Anders Broman
4968c6f086 From Yuriy Sidelnikov:
A perfectly good tvb_bytes_to_str() has been used instead of string_to_hex. 

svn path=/trunk/; revision=14384
2005-05-17 19:21:45 +00:00
Anders Broman
090464f76e Add some more AVP:s.
svn path=/trunk/; revision=14383
2005-05-17 19:15:31 +00:00
Anders Broman
dc82444047 Add TCP port for "radan-http 8088/tcp Radan HTTP" from IANA.
svn path=/trunk/; revision=14378
2005-05-16 18:24:27 +00:00
Anders Broman
cd773d0e99 Add some more media types.
svn path=/trunk/; revision=14377
2005-05-16 18:15:33 +00:00
Anders Broman
a14646212b From Martin Mathieson:
new version of the RDT dissector.  It turns out that
specs are available for this protocol on www.helixcommunity.org  - this
version was written by myself and Tom Marshall of RealNetworks, Inc.

I Changed stream_id and asm_rule_number to be guint16 to fix compiler warnings.

svn path=/trunk/; revision=14372
2005-05-16 06:16:45 +00:00
Anders Broman
7263d93115 From Tim Endean:
Ss-code is Optional in some cases.

svn path=/trunk/; revision=14371
2005-05-15 21:17:29 +00:00
Ronnie Sahlberg
cb2fc4e58b from martin m
prettify dcerpc


svn path=/trunk/; revision=14369
2005-05-14 22:05:56 +00:00
Gerald Combs
f404b15be5 When we catch an exception, make sure we don't throw the same exception again
(and catch it again in the process).  Fixes bug 170.

svn path=/trunk/; revision=14368
2005-05-14 21:13:07 +00:00
Ronnie Sahlberg
4c29a93f64 from dinesh
fix to make Zone_Alias objects decode properly


svn path=/trunk/; revision=14367
2005-05-14 21:08:20 +00:00
Ronnie Sahlberg
c07f0f0a45 From Guillaume Chazarain
New protocol : ARMAGETRONAD    dissector for the protcol used by the game of the same name


svn path=/trunk/; revision=14366
2005-05-14 21:00:43 +00:00
Gerald Combs
7effa95f95 Throw an exception if AndXOffset is less than the current offset. Fixes bug
163.  I'm not sure if this fix is entirely correct, but it doesn't appear to
have affected any SMB captures here adversely.

svn path=/trunk/; revision=14365
2005-05-14 19:13:02 +00:00
Ronnie Sahlberg
432a015797 add decoding of teh REMOVABLE bit in inquiry data
svn path=/trunk/; revision=14364
2005-05-14 17:41:07 +00:00
Ronnie Sahlberg
ceb1c26871 add a missing field to the REPORT LUNS datain pdu
svn path=/trunk/; revision=14363
2005-05-14 17:12:45 +00:00
Luis Ontanon
1eeda6e946 - make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets
- set COL_INFO to something useful


svn path=/trunk/; revision=14361
2005-05-13 11:16:05 +00:00
Guy Harris
38c139dce3 Squelch a compiler warning (GCC 4.0's data flow analysis is
interprocedural, so it knows "sip_parse_line()" doesn't always set
"*token_1_len", but it doesn't know that if it doesn't return OTHER_LINE
it *does* always set it, so it's safe not to set it as long as it's
never used if the return value is OTHER_LINE).

svn path=/trunk/; revision=14355
2005-05-12 02:55:59 +00:00
Guy Harris
bd29cb1267 Fix a routine to return the value it's supposed to return.
svn path=/trunk/; revision=14354
2005-05-12 02:51:59 +00:00
Guy Harris
3a8d46d8e9 Always set "*success" in "ipxnet_addr_lookup()" before returning (thanks
and a tip of the hat to GCC 4.0's interprocedural data flow analysis for
catching this one!).

svn path=/trunk/; revision=14353
2005-05-12 02:50:27 +00:00
Anders Broman
92b1092937 Reinsert Gerards patch (r14342) which was lost.
svn path=/trunk/; revision=14352
2005-05-11 22:20:11 +00:00
Anders Broman
eac5e05d3a pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages.
svn path=/trunk/; revision=14350
2005-05-11 22:00:50 +00:00
Anders Broman
0232c81b91 From Viorel Suman:
Enable a proper deconding of an alphanumeric 7-bit encoded SMS TP-Originating-Address.

svn path=/trunk/; revision=14349
2005-05-11 21:59:44 +00:00
Ronnie Sahlberg
4e3c7cc716 From Hannes Gredler
support for Juniper PPPOE encapsulation


svn path=/trunk/; revision=14346
2005-05-11 11:24:17 +00:00
Ronnie Sahlberg
fcab322ada Some applications do very naughty things like reusing a port for a different protocol during different stages of an application cycle.
This is very naughty and will cause problems when we have assigned a dissector to a dynamic port using conversation_set_dissector().


To make ethereal handle this case I have changed the try_conversation_dissector() to allow it to fail and return 0,   meaning   yes there is indeed a protocol registered for this conversation but that protocol rejected this packet.
(which only happens for "new" style dissectors, "old" style dissectors will never reject a packet that way)

When this happens  the decode_udp_port() helper will still allow other dissectors to be tried, in the hope that the conversation is now used for some other protocol and thus someone else might be able to decode the packet.


Update SNMP and TFTP dissectors to  check that even if there already is a conversation but that conversation does NOT have snmp/tftp registered as the dissector for it, then create a new conversation anyway and attach the proper dissector.

Since ethereal keeps track of which frame number a conversation started in, this actually works really well.



svn path=/trunk/; revision=14345
2005-05-11 10:40:53 +00:00
Luis Ontanon
5535853bf2 - export Audio Codec modes from isup/bicc
- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0)
- use it for H.248


svn path=/trunk/; revision=14343
2005-05-10 21:54:37 +00:00
Anders Broman
88c39bc93b Fix dissection of mo-forwardSM
svn path=/trunk/; revision=14342
2005-05-10 20:09:09 +00:00
Ronnie Sahlberg
39e517a9b3 make SNMP over UDP a new style dissector and add some heuristics to check if this is SNMP or not,
svn path=/trunk/; revision=14339
2005-05-10 08:49:27 +00:00
Gerald Combs
c64e5e59f6 Make a field type check more strict. Remove some unnecessary code.
svn path=/trunk/; revision=14338
2005-05-10 03:10:09 +00:00
Gerald Combs
cd321f5958 Make sure we don't feed a null string to strncmp(). Fixes bug 161.
Make sure we don't free static memory.  Fix a small memory leak.

svn path=/trunk/; revision=14337
2005-05-10 03:08:36 +00:00
Jörg Mayer
78d0e8b33d I just found a packet with an option e. As the value looked very much
like the mac-address of the switch, I added decoding of option e as
mac address.


svn path=/trunk/; revision=14336
2005-05-09 11:21:16 +00:00
Lars Roland
9a47db0c3d Add another sanity check to the new SIP URI parser.
Just to be sure.

svn path=/trunk/; revision=14335
2005-05-09 01:21:41 +00:00
Lars Roland
74328742ed Some fixes for the new SIP contact header parser.
svn path=/trunk/; revision=14334
2005-05-09 01:15:45 +00:00
Lars Roland
20901fcedf only lower-case ASCII letters, numbers,
underscores, and dots are allowed in the
preference name. 

Fix it the camel dissector.

svn path=/trunk/; revision=14333
2005-05-09 00:11:03 +00:00
Lars Roland
5f092fe201 Mark a function parameter as unused
svn path=/trunk/; revision=14332
2005-05-08 23:29:55 +00:00
Lars Roland
01f10ccd00 When saying that I remove the trailing white spaces I should do it, too.
So I do it now and do some more reindentation, too.

svn path=/trunk/; revision=14331
2005-05-08 22:39:38 +00:00
Lars Roland
e5134e2f2d Improve dissection of SIP contact header and counting of bindings in REGISTER messages.
Introduce a function for disseting a sip uri in general

TODO: 
- add dissection of contact and uri parameters
- simplify the ugly code for dissecting "to" and "from" headers
      by using the new function for uri dissection

svn path=/trunk/; revision=14330
2005-05-08 22:19:18 +00:00
Lars Roland
429d72c457 Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c.
svn path=/trunk/; revision=14329
2005-05-08 21:17:37 +00:00
Anders Broman
fd075dadf0 From Javier Acuna:
Added some code to dissect DateAndTime.

svn path=/trunk/; revision=14328
2005-05-08 20:35:44 +00:00
Lars Roland
52d26f6eb8 Increase size of an integer to prevent an integer overflow
Fixes Bug 162

svn path=/trunk/; revision=14325
2005-05-07 00:14:11 +00:00
Ronnie Sahlberg
a456014e29 prettify YPSERV
svn path=/trunk/; revision=14324
2005-05-06 10:11:08 +00:00
Gilbert Ramirez
61e5a33ea2 A fix for the previous fix for the infinite loop in bootp, bug #160.
svn path=/trunk/; revision=14323
2005-05-06 02:08:30 +00:00