Commit Graph

11073 Commits

Author SHA1 Message Date
Chris Maynard 116d67e164 Add tvb_get_[n|le]toh[40|48|56]() accessors. Addresses bug 5082.
svn path=/trunk/; revision=35538
2011-01-14 19:02:38 +00:00
Graham Bloice 8e86e3dbbf Removed redundant comparison that caused compilation failure on OSX
svn path=/trunk/; revision=35536
2011-01-14 14:39:40 +00:00
Martin Mathieson 51170aa0fc When looking for previous frame for UL/DL retx, use harq-id + ndi bit.
svn path=/trunk/; revision=35535
2011-01-14 14:25:24 +00:00
Graham Bloice 1be12860e6 Updated dissector:
Additional function codes: Disable unsolicited messages, Open\Close\Delete file
Additional data objects: Analog output events, File objects and Octet string events.
Improved Info column display for reassembled fragments.
Changed all event timestamps to be UTC as per protocol spec.

svn path=/trunk/; revision=35533
2011-01-14 12:15:10 +00:00
Martin Mathieson b1dd79a122 Rather than repairing out-of-range subframe numbers, make sure error gets reported (and then are not used to access beyond subframe arrays).
svn path=/trunk/; revision=35531
2011-01-14 11:21:28 +00:00
Jaap Keuter cc3952ca4f From Hadar Shoham:
bootp option 123 has 2 chooses - coordinate based location RFC 3825 or
CableLabs DSS_ID. Add better support for having 2 DSS_ID with dynamic
size (up to 32 byte each)

svn path=/trunk/; revision=35530
2011-01-14 07:20:31 +00:00
Jeff Morriss 6cfdeed280 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().

svn path=/trunk/; revision=35529
2011-01-14 03:44:58 +00:00
Jeff Morriss 2df5275d87 Don't (blindly) pass the result of match_strval() into proto_tree_add_*():
some OS (like Solaris) don't like NULL pointers to strings in (s)printf
formats; use val_to_str() instead.

svn path=/trunk/; revision=35526
2011-01-13 22:18:30 +00:00
Jaap Keuter 2df51c6860 From Clemens Auer:
This patch adds support for the following fields in Meta protocol:
- Deciphered
- Local Device ID,
- Remote Device ID,
- Tap Group ID,
- TLLI,
- Calling Station ID,
- Called Station ID

svn path=/trunk/; revision=35524
2011-01-13 21:22:57 +00:00
Jeff Morriss a167206685 Introduce, and start using, tvb_ip_to_str() and tvb_ip6_to_str(). These
do the same as the non-tvb equivalents but take a TVB and an offset instead
of a pointer to an array of bytes.

Their purpose is to prevent (many) dissectors from doing:
ip_to_str(tvb_get_ptr(...)).

(About the names and the location: I like the names as they are but the names
imply that they should live in tvbuff.c.  That would make some sense but
I didn't want to pull to_str.h into tvbuff.c...)

svn path=/trunk/; revision=35519
2011-01-13 15:53:30 +00:00
Martin Mathieson d9520dc09c Getting ready for R9 versions of some LTE protocols.
svn path=/trunk/; revision=35518
2011-01-13 15:16:45 +00:00
Anders Broman 3abc24fdff Use value_string_ext.
svn path=/trunk/; revision=35517
2011-01-13 15:03:55 +00:00
Anders Broman 08145f0dff Remove an unused variable.
svn path=/trunk/; revision=35516
2011-01-13 14:36:40 +00:00
Anders Broman 7c7281d0b4 Make it possible to dissect the part pressent in short frames.
svn path=/trunk/; revision=35515
2011-01-13 14:07:34 +00:00
Anders Broman 0a95691b3d From Pascal Quantin:
Fix dissection of  protocol ID.

svn path=/trunk/; revision=35513
2011-01-13 06:32:23 +00:00
Anders Broman 757bc6a6ff Set gsm_a_dtap_pinfo->link_dir to get proper dissection of PCO.
svn path=/trunk/; revision=35510
2011-01-12 21:36:11 +00:00
Anders Broman 46f62f1b49 Mark a parameter as unused.
svn path=/trunk/; revision=35507
2011-01-12 17:05:58 +00:00
Anders Broman 93cbda72dd Enhance IE dissection.
svn path=/trunk/; revision=35506
2011-01-12 16:43:59 +00:00
Anders Broman a5683f7d48 Update dissection of Protocol configuration options.
svn path=/trunk/; revision=35505
2011-01-12 16:43:19 +00:00
Jaap Keuter 95cc16bbbc From Eliad:
Add dissector for P2P Group BSSID attribute (of p2p).

svn path=/trunk/; revision=35504
2011-01-12 07:46:46 +00:00
Jaap Keuter 889e3dbe54 From Steve Karg:
Added a display filter on BACnet WhoIs Low Limit and High Limit.

svn path=/trunk/; revision=35503
2011-01-12 07:42:18 +00:00
Anders Broman 6a49803d2c Update a value_string.
svn path=/trunk/; revision=35502
2011-01-12 07:39:54 +00:00
Anders Broman 8326aa2db7 Use value_string_ext in a couple of places.
svn path=/trunk/; revision=35501
2011-01-12 07:36:55 +00:00
Jaap Keuter 2afdc55cd0 From Fulko Hew:
Improved the decoding of OID search ranges in AgentX dissector:

1/ OID highlighting on first OID of a range was too long.
   The code incorrectly used the length of the printable string instead 
   of the length of the source data.
2/ Added bitwise dissection of the 'include' field of an OID decoding.
3/ Added corrected 'start/end' range information to SearchRange decoding to
   discriminate between an 'end' indicator (old way) and the new way that 
   shows both an inclusive/exclusive indicator as well as a start/end range 
   indicator. (applicable to getnext/getbulk requests).

svn path=/trunk/; revision=35500
2011-01-12 07:31:49 +00:00
Anders Broman 5ebd7cb133 TCAP- Application context name not been decoded correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5573

svn path=/trunk/; revision=35498
2011-01-12 07:18:57 +00:00
Jeff Morriss 2214faa7f3 There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_string(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

In a couple of places an hf variable was being used as the length in a call to
proto_tree_add_*().  Use the appropriate variable instead.

svn path=/trunk/; revision=35497
2011-01-12 03:35:14 +00:00
Jeff Morriss b6542d17d8 There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_string(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

In a couple of places an hf variable was being used as the length in a call to
proto_tree_add_*().  Use the appropriate variable instead.

svn path=/trunk/; revision=35496
2011-01-12 03:27:32 +00:00
Jeff Morriss fd0e521cbb There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_string(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

In a couple of places an hf variable was being used as the length in a call to
proto_tree_add_*().  Use the appropriate variable instead.


svn path=/trunk/; revision=35495
2011-01-12 03:19:07 +00:00
Jeff Morriss 848f067017 Replace some uses of tvb_get_ptr() with tvb_get_ephemeral_string().
svn path=/trunk/; revision=35494
2011-01-12 03:08:05 +00:00
Jeff Morriss 0c4e881911 Introduce, and start using, tvb_get_const_stringz(). This function returns a
pointer to a NULL-terminated string in the TVB.  It is no safer than dissectors
which call tvb_get_strsize() and then tvb_get_ptr() but it makes it clear that
this usage of tvb_get_ptr() is safe.

This function is slightly more efficient than tvb_get_ephemeral_stringz()--but
only as long as we're not using composite TVBs.

svn path=/trunk/; revision=35493
2011-01-12 02:25:08 +00:00
Jeff Morriss 1c5d75288c Don't attempt to reassemble short (reported_len > len) chunks.
svn path=/trunk/; revision=35486
2011-01-11 22:41:19 +00:00
Jeff Morriss 6e7d85a92c Don't store message fragments whose length is 0: there's no point. (Otherwise
fragment->len was left unitialized.)

Also (unrelated): save a couple of calls to tvb_reported_length() since the
value is already stored in a variable.

svn path=/trunk/; revision=35485
2011-01-11 22:36:31 +00:00
Anders Broman a78e5d7900 Use value_string_ext and friends.
svn path=/trunk/; revision=35484
2011-01-11 20:15:04 +00:00
Anders Broman f108c58805 Complement to
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477

svn path=/trunk/; revision=35483
2011-01-11 20:02:30 +00:00
Anders Broman 852c75636e Improve dissection of UE Time Zone.
svn path=/trunk/; revision=35477
2011-01-11 17:06:38 +00:00
Anders Broman b2992b2310 ldap.cnf:782: warning: ISO C90 forbids mixed declarations and code
svn path=/trunk/; revision=35476
2011-01-11 11:41:03 +00:00
Jaap Keuter 1ea96b1e30 From Slava K:
FCoIB – Fibre Channel over InfiniBand. The protocol enables transmission of
Fibre Channel frames over InfiniBand networks. It is based on encapsulation of
Fibre Channel frames over InfiniBand UD transport. The discovery protocol is
based on the FIP protocol (not supported by this patch).

This patch adds an FCoIB dissector to Wireshark. It is based in large part on
the existing FCoE dissection code.

This code is submitted on behalf of Mellanox Technologies Ltd.

svn path=/trunk/; revision=35475
2011-01-11 08:22:16 +00:00
Ronnie Sahlberg 3079c9c931 From Matthieu Patou <mat@samba.org>
Dissect LDAP DirSyncFlags to show the bits of this bitmap.



svn path=/trunk/; revision=35474
2011-01-11 02:27:41 +00:00
Ronnie Sahlberg 27f36858fd Add a missing procedure name for NFS-ACL
svn path=/trunk/; revision=35466
2011-01-10 22:31:05 +00:00
Stephen Fisher fe06217c35 Stop gcc warning about type-punned pointer breaks strict anti-aliasing
rules.  (Is this the right fix?  I had to remove a now meaningless
comparison of psm > 0x1000 (4096) since psm is now a guint8 not a guint16.)


svn path=/trunk/; revision=35463
2011-01-10 21:23:25 +00:00
Gerald Combs 1b4d847a90 Add 2869 to the list of HTTP ports: http://support.microsoft.com/kb/886257
svn path=/trunk/; revision=35461
2011-01-10 20:23:21 +00:00
Anders Broman 096e3737bc Add an expert item about not dissected IE's
svn path=/trunk/; revision=35460
2011-01-10 19:48:15 +00:00
Anders Broman 275c3c8818 Shorten long winded strings.
svn path=/trunk/; revision=35456
2011-01-10 17:34:00 +00:00
Bill Meier e0424dde5d Move some DISSECTOR_SRC & DISSECTOR_INCLUDES entries so they are (more or less) in alpha order.
svn path=/trunk/; revision=35454
2011-01-10 15:19:18 +00:00
Jeff Morriss 03c7b7093e Give a couple commented-out hf's abbreviations (to keep checkAPIs happy).
svn path=/trunk/; revision=35452
2011-01-10 14:40:10 +00:00
Anders Broman b321c5d5ea Add application/vnd.3gpp.cw+xml
svn path=/trunk/; revision=35450
2011-01-10 12:28:56 +00:00
Jaap Keuter a1ea8ad71b Clean up the blurbs indicated by checkAPIs.
svn path=/trunk/; revision=35449
2011-01-10 07:39:15 +00:00
Jeff Morriss dc22fbfc50 Give CSID an abbreviation.
svn path=/trunk/; revision=35446
2011-01-10 03:02:43 +00:00
Jaap Keuter 65ca06b9c6 Make comment a real comment, trying to fix the buildbot.
svn path=/trunk/; revision=35445
2011-01-09 22:34:20 +00:00
Anders Broman b9eddc7117 Update value_strings
svn path=/trunk/; revision=35442
2011-01-09 20:41:19 +00:00