Commit Graph

14917 Commits

Author SHA1 Message Date
Guy Harris 1106ac4105 Put in a comment asking about the music going over the connection - we
shouldn't try to parse it as DAAP.

svn path=/trunk/; revision=15231
2005-08-05 23:18:05 +00:00
Guy Harris b945c5bd2a Squelch a warning about "state" being used uninitialized.
svn path=/trunk/; revision=15230
2005-08-05 23:17:15 +00:00
Luis Ontanon 222cd82f4f have the definition of init_hostlist_table *ACTUALLY* match its declaration.
svn path=/trunk/; revision=15229
2005-08-05 22:36:28 +00:00
Luis Ontanon 90badc628d have the definition of init_hostlist_table match the declaration.
svn path=/trunk/; revision=15228
2005-08-05 22:34:45 +00:00
Jörg Mayer 4e1f4b18ab More char -> const char warning fixes.
Removed (very few) casts that only change the warning message
  but don't remove it (with gcc-4).

svn path=/trunk/; revision=15227
2005-08-05 20:59:08 +00:00
Anders Broman e6856b69f3 From David Richards:
here are the highlights of what's fixed:

1) Decoding of vendor-defined types
2) Decoding of some event notification parameters (not all)
3) Decoding of ABSTRACT-SYNTAX&Type
4) Decoding of BACnetTimeStamp
5) Some problems with context-tagged values (like booleans)
6) Continuation segments - don't try to decode them since you can't 
start mid-PDU
7) Removed some excessive levels of subtrees

svn path=/trunk/; revision=15226
2005-08-05 19:37:57 +00:00
Anders Broman 6f022ad796 From Thomas Steffen:
Fix a copy-paste error in the prefs. code

svn path=/trunk/; revision=15225
2005-08-05 19:32:26 +00:00
Anders Broman 6ced262fdf From THORNTON, MATT
Some changes that I made to flesh out GPRS message parsing.  More information is displayed about the various frame formats.  I have also added some code to parse XID parameters in the U frame.  I have also fixed a couple of display bugs in the GSM and GPRS LLC parser.

svn path=/trunk/; revision=15224
2005-08-05 19:16:29 +00:00
Jörg Mayer 74a75d72fe char -> const char warning fixes
svn path=/trunk/; revision=15223
2005-08-05 13:23:47 +00:00
Jörg Mayer 2b2506f0f6 More char -> const char warning fixes
svn path=/trunk/; revision=15222
2005-08-05 13:10:58 +00:00
Ulf Lamping ab8601b7fe note that calling distclean target should be done first
add the MSVC tools to the verify_tools target, add some explanation of common problems

svn path=/trunk/; revision=15221
2005-08-05 09:20:48 +00:00
Ulf Lamping 2a2e994cb1 verify_tools:
- not only look for the cygwin tools, but also check the MSVC tools required like cl.exe, link.exe and nmake.exe

- I don't know why we should use /usr/bin/find but simply find, check for it instead. If there's a reason to use /usr/bin/find, we should use $(FIND) instead but I currently don't see a reason for this

svn path=/trunk/; revision=15220
2005-08-05 08:34:47 +00:00
Jörg Mayer f378e9ec64 Add eol-style and keywords properties
svn path=/trunk/; revision=15219
2005-08-05 00:29:34 +00:00
Jörg Mayer 69dcb66cd9 More char -> const char warning fixes
svn path=/trunk/; revision=15218
2005-08-05 00:23:22 +00:00
Ronnie Sahlberg 63728d5770 Add unix makefile for work in progress GSM-SS dissector
svn path=/trunk/; revision=15217
2005-08-05 00:23:08 +00:00
Jörg Mayer 050b3b5a97 Separate declaration from initialization with non-static values
svn path=/trunk/; revision=15216
2005-08-04 22:54:04 +00:00
Guy Harris 0c0177091a Note that if you're building from a source tarball, before the first
build you must do "nmake -f makefile.make distclean".

svn path=/trunk/; revision=15215
2005-08-04 22:37:49 +00:00
Guy Harris 3d1dfa4f67 Put in comments explaining why we're removing some generated files with
"make distclean", even though they come with the distribution, and
make the one in plugins/xml/Makefile.nmake match the one in some other
files.

svn path=/trunk/; revision=15214
2005-08-04 22:22:53 +00:00
Guy Harris cf3b50f1ce Delete some new Flex-generated files, and put in a comment explaining
that we're doing that and explaining why we're doing it.

svn path=/trunk/; revision=15213
2005-08-04 22:13:33 +00:00
Jörg Mayer 444fd68eb8 Forgot to remove gdebug.h from Makefile.common too
svn path=/trunk/; revision=15212
2005-08-04 21:54:00 +00:00
Jörg Mayer 6f4033bc83 Don't initialize variables in their declaration with non-constant
values.

svn path=/trunk/; revision=15211
2005-08-04 21:40:58 +00:00
Jörg Mayer bfd9609da2 Albert Chin:
uses of some C99'isms which prevent compilation on
        IRIX 6.5 with the SGI C compiler.


svn path=/trunk/; revision=15210
2005-08-04 21:31:40 +00:00
Jörg Mayer 8433afe23b Albert Chin:
Don't include epan/gdebug.h

Now that epan/gdebug.h is unused: remove it

svn path=/trunk/; revision=15209
2005-08-04 21:09:08 +00:00
Jörg Mayer cee545d958 Albert Chin:
"config.h" should always be included first. However, lemon
        includes <stdio.h> first.


svn path=/trunk/; revision=15208
2005-08-04 20:41:52 +00:00
Gerald Combs ac8dcfc8ef Add items for the recent FC-FCS and RSVP bug fixes.
svn path=/trunk/; revision=15207
2005-08-04 17:14:19 +00:00
Gerald Combs 04e2d2d5e6 Increase the size of some variables, so that we don't overflow them. Fixes
the infinite loops in bugs 311 and 314.

svn path=/trunk/; revision=15206
2005-08-04 17:11:32 +00:00
Gilbert Ramirez c8cd8f21a4 Exception handling fixes, and a fix to packet-frame.c,
from Richard van der Hoff.

svn path=/trunk/; revision=15205
2005-08-04 13:54:46 +00:00
Guy Harris 2c65361b8a When processing records, advance the offset.
svn path=/trunk/; revision=15204
2005-08-04 10:24:33 +00:00
Anders Broman 7789e73a99 Use the new fn_par functions, fix of a bug and export functions used by gsm_ss.
svn path=/trunk/; revision=15203
2005-08-03 20:51:54 +00:00
Anders Broman 92588a098f First checkin of asn2eth generated gsm ss dissector - work in progress not ready to replace the existing
dissector yet.

svn path=/trunk/; revision=15202
2005-08-03 20:49:52 +00:00
Anders Broman 32f826a7ce From Richard van der Hoff:
Among the improvements are:
- fixes to call-tracking (it's now less likely to confuse two separate 
calls, for instance)
- improvements to Information Element dissection (clearer dissection, 
dissects more IE types, easier to extend)
- you can now filter on the content of DTMF packets
- Analysis of timestamps (calculation of absolute timestamp, and packet 
lateness).
- fixed a couple of assertion failures in subtle corner-cases.

negative relative times:
   - get_timedelta()
   - addtime()
   - ftype-time.c:relative_val_from_unparsed()

I've also moved get_timedelta() and addtime() out of calldata.c into a 
new file, epan/nstime.c, as I needed to use them in a dissector I'm 
working on (and they therefore needed to go into libethereal).

svn path=/trunk/; revision=15201
2005-08-03 20:37:28 +00:00
Gerald Combs d0811b3d35 Don't assume ints are 32 bits. Fixes a recent Buildbot error.
svn path=/trunk/; revision=15200
2005-08-03 17:32:00 +00:00
Anders Broman 49284d02cb Fix "tvb_fake_unicode takes the lengt in number of guint16's not guint8's" fix up indentation.
svn path=/trunk/; revision=15199
2005-08-02 21:16:56 +00:00
Gerald Combs 50525fca41 After reading through the code again, the LPD
dissector wasn't susceptible to a crash.  The patch at
http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/ is unneccessary.

svn path=/trunk/; revision=15198
2005-08-02 18:26:31 +00:00
Ronnie Sahlberg a156f46452 ememify the tvb_get_string call in mmse.
the strings mmse got from tvb_get_string were never released anyway
so this would resolve significant memory leakage in mmse.

there are still memleaks in mmse   but one step at a time


svn path=/trunk/; revision=15197
2005-08-02 17:34:14 +00:00
Ronnie Sahlberg 7bca1d5ef6 ememify packet-rpc call to tvb_get_string()
svn path=/trunk/; revision=15196
2005-08-02 17:24:26 +00:00
Ronnie Sahlberg 12f5bdb99f remove a pointless g_strdup
svn path=/trunk/; revision=15195
2005-08-02 17:15:56 +00:00
Gerald Combs c214405e41 Clean up after ourselves so that we pass "distcheck" again.
svn path=/trunk/; revision=15194
2005-08-02 15:25:41 +00:00
Guy Harris b9ba0508bc Explain the BoundsError and ReportedBoundsError errors a bit more, as
per Ulf Lamping's request.

svn path=/trunk/; revision=15193
2005-08-02 08:42:02 +00:00
Jörg Mayer a0f94c125f Last set of trivial fixes for "no previous declaration" warnings.
svn path=/trunk/; revision=15191
2005-08-02 08:30:33 +00:00
Ulf Lamping bcf080b837 add some comments, has to be extended
svn path=/trunk/; revision=15190
2005-08-02 07:30:38 +00:00
Ulf Lamping d788233d7c add some minor comments around the GTK main loop
svn path=/trunk/; revision=15189
2005-08-02 07:29:15 +00:00
Ulf Lamping 20c5d50269 bugfix: in an attepmt to fix a crash while doing reassemling of connection oriented packets, some weeks ago I've added some tvb_ensure_bytes_exist() calls to test the case that the alloc_hint value is bogus (found in private fuzz testing).
Unfortunately, this is *very* safe now as it will mark a lot of DCE/RPC packets as malformed, thus the reassembling code won't work with most packets :-(

I've replaced this with the correct check and used THROW(ReportedBoundsError) instead which is hopefully the right error in this case.

BTW: could someone please add a description of the ReportedBoundsError vs. BoundsError to the code as I still don't get it.

In addition: Use a toplevel tree item to display the DCE/RPC defragmentation just as it's done in the TCP desegmentation code.

svn path=/trunk/; revision=15188
2005-08-02 07:26:57 +00:00
Jörg Mayer 79eb0cfbad Make aclocal-flags executable again (hopefully fixes buildbot fc4)
svn path=/trunk/; revision=15187
2005-08-02 07:03:46 +00:00
Jörg Mayer 87e2c9d00a Fix svn properties where needed:
Add svn:eol-style
          Add svn:keywords


svn path=/trunk/; revision=15186
2005-08-02 06:44:18 +00:00
Jörg Mayer d135654fb5 Fix svn properties where needed:
Remove svn:executable
          Add svn:executable
          Add svn:eol-style
          Add svn:keywords
          Add mime-type

svn path=/trunk/; revision=15185
2005-08-02 06:39:04 +00:00
Jörg Mayer 9419229386 Fix svn properties where needed:
Remove svn:executable
          Add svn:executable
          Add svn:eol-style
          Add svn:keywords


svn path=/trunk/; revision=15184
2005-08-02 06:29:49 +00:00
Jörg Mayer d65168e9ec Fix svn properties where needed:
Remove svn:executable
         Add svn:executable
         Add svn:eol-style
         Add svn:keywords


svn path=/trunk/; revision=15183
2005-08-02 06:15:02 +00:00
Jörg Mayer c17d44e122 Fix svn properties where needed:
Remove svn:executable
         Add svn:executable
         Add svn:eol-style
         Add svn:keywords


svn path=/trunk/; revision=15182
2005-08-02 05:58:15 +00:00
Jörg Mayer 6a5b39d24d Fix svn properties where needed:
Remove svn:executable
         Add svn:eol-style
         Add svn:keywords


svn path=/trunk/; revision=15181
2005-08-02 05:51:38 +00:00