Commit Graph

61 Commits

Author SHA1 Message Date
Pascal Quantin b46f9bebe2 Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call
svn path=/trunk/; revision=51427
2013-08-19 14:55:41 +00:00
Michael Mann b0090fd046 Batch of filterable expert infos
svn path=/trunk/; revision=49600
2013-05-27 23:21:11 +00:00
Anders Broman ae747e4c4b From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48430
2013-03-19 22:03:00 +00:00
Bill Meier d3a7f4b817 Use '#if 0 ... #endif' rather than /** ... **/ to comment out
unused hf[] entries (which I should have done in the first place).

svn path=/trunk/; revision=47390
2013-01-31 18:31:28 +00:00
Bill Meier 0960e508e4 Comment out cases of unused hf array entries found by checkhf.
svn path=/trunk/; revision=47302
2013-01-26 18:54:53 +00:00
Jeff Morriss 0266cceef3 Make all enum_val_t's const.
svn path=/trunk/; revision=46292
2012-11-29 20:15:37 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Bill Meier 638d74d43f Use val_to_str_const() where appropriate;
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Gerald Combs 21b3256918 Assign some variables that scan-build was complaining about.
svn path=/trunk/; revision=42638
2012-05-15 21:56:02 +00:00
Bill Meier ec42a2bd1d Move proto_reg_handoff...(0 to the end of the file as per Wireshark convention.
Minor whitespace cleanup.

svn path=/trunk/; revision=40183
2011-12-13 19:58:47 +00:00
Bill Meier 6d3f5ff143 Fix: Execution Tracing High-Detail field selection highlighting seemingly wrong bytes in hex view pane.
Actual problem:
  A REAL_DATA tvbuff wasn't being added to the "data_sources"
  for a frame. When displaying the frame, when a field referencing the tvb was selected
  for display there was no 'hex bytes' tab for the field and so bytes ended up being
  highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane
  not related to the field).

  Consider: Add some code in field creation (proto_tree_add...) to at least warn if
            a field is being created using a tvb whose data_source is not in the
            data_sources list for the frame ?

svn path=/trunk/; revision=40182
2011-12-13 19:54:19 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman 14fbabcb26 Get rid of check_col() and use ENC.
svn path=/trunk/; revision=39153
2011-09-26 17:50:54 +00:00
Bill Meier 121c65c613 Remove unneeded #includes (stdio.h,stdlib.h);
Whitespace cleanup: trailing, indentation, "4-space tabs"

svn path=/trunk/; revision=35850
2011-02-07 18:49:29 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis c840cdd5a0 Remove the address operator from value_string arrays fed to VALS()
svn path=/trunk/; revision=30995
2009-11-17 18:35:27 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Bill Meier a3e6eb8071 Minor cleanup mostly related to proto_reg_handoff
svn path=/trunk/; revision=26236
2008-09-19 17:39:44 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Anders Broman 7badbc8eb6 From Daniel Rao:
Implement desegment for SIGCOMP over TCP, similar with HTTP desegment.

svn path=/trunk/; revision=22467
2007-08-08 12:44:28 +00:00
Martin Mathieson 7b8632f552 - Check NACK version is 1 before dissecting as NACK
- Add expert item when NACK found
- Give a couple of subtrees items to make them more filterable 

svn path=/trunk/; revision=22020
2007-06-01 18:29:23 +00:00
Martin Mathieson 750959bb3d - give NACK reason codes in hex rather than decimal
- minor prettifications

svn path=/trunk/; revision=21764
2007-05-14 14:23:52 +00:00
Martin Mathieson 6c310715bd - show NACK summary in info column
- calculated and show compression ratio achieved
- show some fields as being generated

svn path=/trunk/; revision=21742
2007-05-10 16:49:00 +00:00
Martin Mathieson b9f69234ad Check in trivial changes before generating a big diff...
svn path=/trunk/; revision=20304
2007-01-04 13:25:25 +00:00
Anders Broman 2f849c368a From Cristian Constantin:
As a workarond for the problem that accsessing a state with a state id > the stored
minimum access length fail,  only store and compare the state with the minimum access
lengt specified in the standard of 6 bytes.

svn path=/trunk/; revision=20041
2006-12-05 06:43:47 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 317c8e5f92 Fix Coverity CID: 8 dead code.
svn path=/trunk/; revision=17510
2006-03-07 20:51:05 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman 2a80fe283c Handle multiple messages in a TCP segment, reassembly still needed.
svn path=/trunk/; revision=16142
2005-10-06 16:00:26 +00:00
Anders Broman 96c01ad3c6 Fix a typo.
svn path=/trunk/; revision=16074
2005-10-03 05:59:17 +00:00
Guy Harris 7aa4b4ffe1 Make "top_tree" static; nobody else uses it, and if they're both not
static, they collide with one another in builds on at least some
platforms.

svn path=/trunk/; revision=16049
2005-09-29 01:31:19 +00:00
Anders Broman 399144a591 Handle sigcomp over TCP.
svn path=/trunk/; revision=16043
2005-09-28 19:57:45 +00:00
Anders Broman 59829053fb udvm: initialise a variable
sigcomp: implement RFC 4077

svn path=/trunk/; revision=15640
2005-08-31 19:51:24 +00:00
Anders Broman 557df81507 From Timo Metsala
Changes:

o Implemented CRC and SHA-1 (sort operations are still missing)

o After state acccess, the execution start is not necessarily the
  beginning of the bytecode; start IP is now a new parameter to
  decompress_sigcomp_message()

o Removed some hard-coded assumptions about bytecode starting at offset
   128

svn path=/trunk/; revision=15531
2005-08-25 19:23:15 +00:00
Ulf Lamping 0dc9fb3d4a various code cleanup:
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants

svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00
Jörg Mayer 7b2ff03d8c Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15169
2005-08-02 04:31:42 +00:00
Anders Broman 6b95a695cd From Paul Ollis:
epan/dissectors/packet-sigcomp.c
  --------------------------------

    Function dissect_sigcomp:

        1. Make sure the temporary buffer that is used to load byte-code from
           state is zeroed, since the function udvm_state_access implicitly
           relies on this.

        2. Pass the SigComp message header length, state length and partial
           state length to decompress_sigcomp_message.

        3. Removed the state_vars_valid parameter from calls to
           udvm_state_access.

svn path=/trunk/; revision=14667
2005-06-16 21:16:23 +00:00
Ulf Lamping 2f836c20a8 fix a typo: lenght -> length
This seems to be a "more common" typo, fixed it 13 times throughout the code ...

svn path=/trunk/; revision=13452
2005-02-20 22:36:34 +00:00