osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
48,544 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

29 Commits

Author SHA1 Message Date
Anders Broman ae747e4c4b From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48430
 2013-03-19 22:03:00 +00:00
Bill Meier d3a7f4b817 Use '#if 0 ... #endif' rather than /** ... **/ to comment out 
unused hf[] entries (which I should have done in the first place).

svn path=/trunk/; revision=47390
 2013-01-31 18:31:28 +00:00
Bill Meier 329f6e8cc0 Initialize some hf_... vars to -1; 
(Reduces the number of checkhf false positives)

svn path=/trunk/; revision=47310
 2013-01-26 21:42:36 +00:00
Bill Meier 0960e508e4 Comment out cases of unused hf array entries found by checkhf. 
svn path=/trunk/; revision=47302
 2013-01-26 18:54:53 +00:00
Bill Meier 6b97dfbfa7 Improve dissection; 
- Properly handle DataBlocks with optional fields at end;
- Fix a few field dissections;
General code cleanup;
- Remove almost all tests using tvb_length_remaining():
   If there's not enough data available, just let an
   exception be thrown.
- Fix a memory leak;
- Simplify code in various places.
- Add a reference to the (a ?) Microsoft spec for RDP.

Fixes Bug #7862 in a more complete manner than SVN #45566.

svn path=/trunk/; revision=46158
 2012-11-23 21:11:47 +00:00
Martin Kaiser be4c14ff77 (try to) fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7862 
tvb_length_remaining() may return -1
if that happens in dissect_rdp_fields(), return an error
the caller that calls dissect_rdp_fields() from a for loop detects the error
 and exits (others should handle the error as well, this is missing for now)

svn path=/trunk/; revision=45566
 2012-10-15 22:34:41 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Bill Meier 638d74d43f Use val_to_str_const() where appropriate; 
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
 2012-08-10 22:55:02 +00:00
Anders Broman 1ae38887b6 From Evan Huus: 
Grab-bag of unused variables.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452

svn path=/trunk/; revision=43616
 2012-07-09 01:49:02 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Bill Meier b8712813cc General cleanup: 
- Fix two minor bugs which resulted in missing entries in packet details pane;
- Remove packet-rdp.h: It's not used elsewhere;
- Define 3 global fcns as static: they're only referenced within packet-rdp.c;;
- Localize some variable definitions & remove uneeded variable initializations;
- ...
- Fix whitespace and indentation.


svn path=/trunk/; revision=42605
 2012-05-12 22:14:02 +00:00
Guy Harris 2298eeb691 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

This involves marking string fields as special.

XXX - we need ENC_UTF_16 so that we can make the Unicode strings just be
FT_STRING and add them with ENC_UTF_16|ENC_LITTLE_ENDIAN.

svn path=/trunk/; revision=42536
 2012-05-10 02:20:37 +00:00
Jeff Morriss df9a7a0b1c Fix CID 1287: rdp_info can't be NULL here so there's no need to check for it 
being NULL.

svn path=/trunk/; revision=41929
 2012-04-04 15:54:19 +00:00
Jakub Zawadzki 80445e5a99 Fix off by one shift errors introduced in r39530 where it seemed proper[1] 
[1] I'm unsure of packet-dtpt, so I haven't patch it.

svn path=/trunk/; revision=41873
 2012-03-31 20:57:15 +00:00
Chris Maynard ba47e1d521 min() -> MIN(). 
svn path=/trunk/; revision=40313
 2011-12-28 16:53:50 +00:00
Chris Maynard 5debb5c5e3 Fix memory leaks involving tvb_get_string[z](). 
svn path=/trunk/; revision=40312
 2011-12-28 16:36:57 +00:00
Bill Meier c4ace59928 Various Minor cleanup: 
- Remove unneeded #includes;
- Use val_to_str_const() in several places;
- Reformat long lines;
- Fix whitepace and indentation.

svn path=/trunk/; revision=40016
 2011-11-27 15:34:07 +00:00
Anders Broman 87eafedef0 Revert 39946 
svn path=/trunk/; revision=39947
 2011-11-19 16:24:19 +00:00
Anders Broman 3d13938fa4 See if this fixes "warning: initializer element is not computable at load time" 
svn path=/trunk/; revision=39946
 2011-11-19 16:15:07 +00:00
Guy Harris 7aa8340533 Clang Cat is watching you fail to check for a null pointer. 
svn path=/trunk/; revision=39668
 2011-10-30 06:47:27 +00:00
Bill Meier d7a1840204 Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string(); 
Fix encoding arg as needed.

svn path=/trunk/; revision=39530
 2011-10-23 22:58:45 +00:00
Bill Meier 2f9dfbce45 (Trivial) Whitespace cleanup. 
svn path=/trunk/; revision=39513
 2011-10-23 17:10:59 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Bill Meier 1d113b0dc8 Fix a compile error. 
svn path=/trunk/; revision=39130
 2011-09-25 15:25:33 +00:00
Bill Meier f740787546 Minor cleanup: 
- Fix two cases of "set but unused" as reported by GCC 4.6;
- remove _U_ from parameters which are actually used;
- printf --> REPORT_DISSECTOR_BUG;
- define a function as static;

svn path=/trunk/; revision=39129
 2011-09-25 15:09:44 +00:00
Graeme Lunt 0cdfb11c2f Bug 6369: 
Unprotected array write. 


svn path=/trunk/; revision=39125
 2011-09-25 07:02:57 +00:00
Bill Meier ad1efb6b9c (Trivial) Remove trailing whitespace from lines for a few files. 
svn path=/trunk/; revision=39084
 2011-09-21 23:42:55 +00:00
Graeme Lunt 9db6d40656 Basic RDP dissection, which can dissect the connection sequence. 
A work in progress.
Can be used with the SSL dissector to decrypt Enhanced RDP Security SSL.
With Standard RDP Security (e.g those on Wiki), the PDUs are all encrypted 
after the SecurityExchange PDU.
Wiki to be updated with an example SSL protected capture and associated
key material.

svn path=/trunk/; revision=39066
 2011-09-21 07:35:51 +00:00