Commit Graph

4679 Commits

Author SHA1 Message Date
Martin Mathieson f006198edd Don't refer to file-static variables as extern (my gcc didn't like it).
svn path=/trunk/; revision=33241
2010-06-17 05:03:08 +00:00
Guy Harris c81cbe1842 Go back to 64-bit sizes, but, before passing those sizes to
g_try_malloc() or g_try_realloc(), check whether they fit in a gsize
and:

	if not, just pretend the allocation failed;

	if so, cast them to gsize to squelch compiler warnings.

svn path=/trunk/; revision=33239
2010-06-16 18:28:28 +00:00
Stig Bjørlykke 791649f6d5 Use gsize for file sizes.
svn path=/trunk/; revision=33235
2010-06-16 15:26:47 +00:00
Guy Harris d3f0c70724 Cast bytes_left down to an int once we've established it will fit.
svn path=/trunk/; revision=33232
2010-06-16 03:09:16 +00:00
Guy Harris d4cc16d4a1 Handle WTAP_ERR_SHORT_WRITE in file_write_error_message().
In eo_save_entry(), don't assume you can write the entire object in a
single write call - if the object is big enough (which would require a
64-bit address space), and you're not lucky enough to be running on
UN*X (which means LP64, so size_t and ssize_t are big enough for the
entire object), you can't.

svn path=/trunk/; revision=33231
2010-06-16 01:30:29 +00:00
Stig Bjørlykke b940189f7a Cleanup header file define guards.
svn path=/trunk/; revision=33230
2010-06-15 21:18:31 +00:00
Stig Bjørlykke e915e93532 From David Perez & Jose Pico from Taddong S.L. via bug 4451:
This functionality keeps track of all SMB objects contained in a capture,
and is able to export to a file a full or partial captured file that has
been transfered through the SMB protocol. In a partial capture, the holes
produced by the non-captured information are filled out with zeros.
It includes the needed modifications of the SMB dissector in the way it keeps
track of the opened SMB files and also to feed the eo_smb tap listener.

svn path=/trunk/; revision=33227
2010-06-15 14:03:49 +00:00
Bill Meier 59af566844 Fix Bug #4871: Wrong Ack value in TCP flow graph when using relative sequence numbers.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4871  

svn path=/trunk/; revision=33223
2010-06-14 12:37:43 +00:00
Bill Meier 3493bad7e8 Add info to the "Enable OID resolution" tooltip that if 'True' then the 'SMI paths' and the 'SMI modules' preferences will be shown;
Fix a comment. 

svn path=/trunk/; revision=33219
2010-06-13 20:27:21 +00:00
Martin Mathieson d2087d514e Add Copy (to clipboard) to expert item popup menu.
svn path=/trunk/; revision=33214
2010-06-13 14:55:11 +00:00
Bill Meier d5140df7e1 Rename some variables; At least one ('end') seemed to confuse the Windows debugger;
Also: Udate some coments.

svn path=/trunk/; revision=33213
2010-06-13 14:31:11 +00:00
Stig Bjørlykke 372cdf09e4 From Jim Young via bug 4862:
GLIB 2.14 necessary to compile Wireshark with Protocol help.

svn path=/trunk/; revision=33204
2010-06-10 10:13:34 +00:00
Stig Bjørlykke 49330ef460 Avoid a crash when deleting the first character in the filter.
svn path=/trunk/; revision=33168
2010-06-08 21:36:31 +00:00
Jeff Morriss dd1de7cf83 NEW_FILTER_COMBO_BOX: Make the Expression... button work again.
svn path=/trunk/; revision=33163
2010-06-08 18:42:20 +00:00
Jeff Morriss 1728c1e4af NEW_FILTER_COMBO_BOX: dfilter_combo_add_empty() doesn't appear to be needed: the entry field is empty even after populating thelist of recent filters.
svn path=/trunk/; revision=33161
2010-06-08 16:01:50 +00:00
Jeff Morriss 3e2ab3e0bd dfilter_entry_match() (for NEW_FILTER_COMBO_BOX): unset value each time through the loop to avoid duplicate initialization warnings from glib.
svn path=/trunk/; revision=33160
2010-06-08 14:40:31 +00:00
Guy Harris 968fc63f3c Rename the NEW_FILTER_COMBO_BOX routine dfilter_entry_match_new() to
dfilter_entry_match(), as the old dfilter_entry_match() isn't defined or
used if NEW_FILTER_COMBO_BOX is defined.

Clean up indentation a bit.

svn path=/trunk/; revision=33154
2010-06-07 23:33:16 +00:00
Guy Harris 90a1fa7fe6 Don't define dfilter_entry_match() if we're using a combo box, as it's
not used.

Clean up indentation.

svn path=/trunk/; revision=33148
2010-06-07 19:17:12 +00:00
Guy Harris 6599fc59f0 Declare dfilter_list only if we're going to use it.
svn path=/trunk/; revision=33144
2010-06-07 18:49:37 +00:00
Anders Broman 52ecd9d44a Use NEW_FILTER_COMBO_BOX.
If there is no major problems the code can be cleaned up in a few days time.

svn path=/trunk/; revision=33141
2010-06-07 18:28:17 +00:00
Anders Broman 427dca65d0 Update the code for NEW_FILTER_COMBO_BOX.
svn path=/trunk/; revision=33140
2010-06-07 18:25:37 +00:00
Anders Broman 1b3be7a754 From Jim Young:
Remove unneeded "gtk_tree_path_free(path);" from case
"GDK_Return:" in tree_view_key_pressed_cb() that was reverted in r32957 to restore X11 functionality lost in refactored code from r32323.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4847

svn path=/trunk/; revision=33112
2010-06-06 16:25:41 +00:00
Gerald Combs 28d7c73588 From Chris Maynard via bug 1546:
Add units to the rate.

svn path=/trunk/; revision=33099
2010-06-04 23:16:31 +00:00
Stephen Fisher 217b344bd9 Per Jaap's suggestion on -dev list: remove "with new_packet_list" from
version output since it has been the default for a while now and show
"with old_packet_list" if compiled as such. 


svn path=/trunk/; revision=33035
2010-06-01 18:33:16 +00:00
Jeff Morriss 47e2d75820 Move some code (including the optional objects) into libwsutil
svn path=/trunk/; revision=33012
2010-05-28 20:19:55 +00:00
Gerald Combs 17807a6b21 From Jakub Zawadzki via bug 4273:
After appending new record set packet_list->columnized to FALSE.

From me:

Use g_ptr_array_sort_with_data instead of g_qsort_with_data in case the
GPtrArray internals ever change.

svn path=/trunk/; revision=33011
2010-05-28 18:04:56 +00:00
Jörg Mayer c160ddd1de Add proto_help.c to the list of files.
svn path=/trunk/; revision=33008
2010-05-28 11:18:04 +00:00
Bill Meier 64d6943ddf Add svn:keywords & svn:eol-style properties
svn path=/trunk/; revision=33007
2010-05-28 01:37:32 +00:00
Gerald Combs f5df768724 fopen -> ws_fopen
svn path=/trunk/; revision=33002
2010-05-27 21:17:55 +00:00
Gerald Combs 8bdb1bff8d Protocol Help requires GLib 2.6+. Add newlines. Fixup whitespace.
svn path=/trunk/; revision=33001
2010-05-27 19:54:02 +00:00
Gerald Combs fa5f6cced7 From Edgar Gladkich:
This is an extension to the Wireshark context sensitive protocol help. Rows in
TreeView window are analyzed and suitable help file (as HTML) is opened in a
browser.

The help part (large file, 23 MB) of the Protocol Help can be downloaded under
www.inacon.com/dowload/stuff/protocol_help.tar.gz

This protocol help "light" provides descriptive content for the most frequently
used standard protocols, including IP, TCP or SMTP.

From me:

Changes:

Rename "ph_" in some function names to "proto_help_". Move the protocol
help code to its own module.

Make a bunch of functions static. Remove unused code.

Use browser_open_url() instead of a custom function.

Increase the logging levels. Don't clobber the normal log handler.

Update some Doxygen comments to match the format in the rest of the code
base.

Removed GTK version checks. We've been 2.x only for a while.

Move ph_replace_string to string_replace() in epan/strutil.[ch].

Fix a bunch of memory leaks.

Add a NULL pointer check.

Reformat the overview menu label.

Document the file format and locations.

Add Edgar to AUTHORS.

svn path=/trunk/; revision=32995
2010-05-27 15:51:25 +00:00
Gerald Combs b3a83551a3 Make sure our prefix length is > 0 before lopping off the last
character.  Fixes bug 4797.

svn path=/trunk/; revision=32987
2010-05-27 00:49:01 +00:00
Anders Broman 9992de5a4a From Jakub Zawadzki:
One more change from wtap_seek_read to cf_read_frame.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4666

svn path=/trunk/; revision=32984
2010-05-26 21:39:24 +00:00
Gerald Combs 074b9660b6 Have new_packet_list_queue_draw() redraw the packet detail as well. Call
new_packet_list_queue_draw() whenever we mark/unmark frames. Fixes bug
4669.

svn path=/trunk/; revision=32981
2010-05-26 19:44:40 +00:00
Anders Broman 65ee4e797a From Jakub Zawadzki:
New functions: cf_read_frame_r, cf_read_frame

It's much easier to write:
 cf_read_frame (cf, fdata, &err, &err_info)
Than:
 wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)

svn path=/trunk/; revision=32980
2010-05-26 19:11:23 +00:00
Martin Mathieson 763a397ae3 Add a tooltip.
svn path=/trunk/; revision=32977
2010-05-26 15:51:47 +00:00
Martin Mathieson 13c9cf1d38 Add some tooltips.
svn path=/trunk/; revision=32976
2010-05-26 15:20:10 +00:00
Gerald Combs 237eef2ae7 r32323 broke packet detail tree expansion using the left/right keys on
X11. Add back the removed code and add checks for expandable items.

svn path=/trunk/; revision=32957
2010-05-25 23:55:33 +00:00
Martin Mathieson 892d3112ed Add a filter for DCT2000 error strings, and allow it be included in generated filters from RLC status window.
svn path=/trunk/; revision=32946
2010-05-25 14:02:17 +00:00
Guy Harris 36623bcb71 From H.sivank: GtkOSXApplication support.
Call the various flavors of OS X integration just "OS X integration",
not anything with "IGE" in it - it appears that, in some places,
"ige-mac-integration" refers only to the older Carbon-based functions,
although the library still appears to be called -ligemacintegration.

Update the URLs for the information about the OS X integration
libraries.

Clean up help message for --with-pcap-remote.

Clean up white space a bit.

Speaking of white space, it's "Mac OS X", not "MacOS X".

svn path=/trunk/; revision=32941
2010-05-25 00:35:44 +00:00
Bill Meier 4dcaf67f37 Fix regression: unable to enter values in Filter Expression window unless value list present.
(Regression introduced in SVN #30918).
Code reworked slightly for clarification.

svn path=/trunk/; revision=32912
2010-05-20 23:49:57 +00:00
Jaap Keuter 1a3fd99542 Fix for bug 4778:
Check that the widget pointer is still present.

svn path=/trunk/; revision=32911
2010-05-20 19:03:13 +00:00
Guy Harris 9d819eb925 Don't assume that certain address columns are always constant strings -
they're no more guaranteed to be constant strings than the columns we're
*not* assuming are constant strings.  Fixes bug 4771.

svn path=/trunk/; revision=32906
2010-05-20 07:15:27 +00:00
Guy Harris 15e546e65d If the user asks for the Capture -> Interfaces dialog, and there are no
network interfaces, pop up a dialog saying that, rather than popping up
an empty Interfaces dialog.

svn path=/trunk/; revision=32884
2010-05-19 03:05:40 +00:00
Guy Harris 991c5e9898 When dumpcap is run to get an interface list, interface capabilities, or
interface statistics, have its error messages come out as sync-pipe
errors, have it send a sync-pipe "success" message on success, and have
the callers get that message and display it.

svn path=/trunk/; revision=32843
2010-05-17 18:40:23 +00:00
Stig Bjørlykke 2bb480e70d Ensure we update default link-layer list when toggeling monitor mode.
svn path=/trunk/; revision=32835
2010-05-16 15:44:43 +00:00
Guy Harris 342d436705 If we don't know whether a device supports monitor mode, turn off
monitor mode in the checkbox before making the checkbox insensitive.

svn path=/trunk/; revision=32829
2010-05-16 08:14:29 +00:00
Stig Bjørlykke 01a135ef05 Also set sensitive on monitor and linktype label, as it's not clear that
the monitor mode is disabled when only the check box is disabled.

svn path=/trunk/; revision=32827
2010-05-15 23:25:53 +00:00
Stig Bjørlykke 5f58400065 Set the correct "monitor mode" button state.
svn path=/trunk/; revision=32826
2010-05-15 22:54:44 +00:00
Guy Harris e1e576c11b Support monitor mode in the capture preferences.
Use prefs_is_capture_device_hidden() to find out whether a device should
be hidden - don't scan the list of hidden devices ourselves.

svn path=/trunk/; revision=32820
2010-05-15 19:38:13 +00:00