102c452bcb
More emem -> wmem conversion:
...
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz()
- tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc()
- tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz()
- tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str()
- update docs accordingly
svn path=/trunk/; revision=52180
2013-09-22 20:04:35 +00:00
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
868b345eea
Convert a few more dissectors to wmem API
...
svn path=/trunk/; revision=52053
2013-09-15 10:29:49 +00:00
b38ee917b1
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
...
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
2013-09-15 01:48:30 +00:00
60aaa2d842
Change the default preference on how to dissect dunneled data to GTP_TPDU_AS_TPDU.
...
svn path=/trunk/; revision=51917
2013-09-10 05:47:28 +00:00
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
f5b85d81d0
From Katrina Zhang:
...
Fix QoS dissection.
svn path=/trunk/; revision=51752
2013-09-04 18:11:21 +00:00
5405b34469
Batch of filterable expert info.
...
svn path=/trunk/; revision=51688
2013-09-02 23:32:31 +00:00
519a7778aa
Fix copy/paste error introduced in r51541 and spotted by Joerg
...
svn path=/trunk/; revision=51564
2013-08-28 17:31:12 +00:00
57b9b11e40
Comment out a line that seems to do nothing.
...
** CID 1068812: Unused pointer value (UNUSED_VALUE)
svn path=/trunk/; revision=51560
2013-08-28 10:47:23 +00:00
22c5585547
Add a DRX subtree to GTP dissector now that the subtree (useless for NAS and EPS NAS dissectors) was removed from de_gmm_drx_param in r51537
...
svn path=/trunk/; revision=51541
2013-08-27 19:38:35 +00:00
266e577aee
Update to handle version 9.
...
svn path=/trunk/; revision=50981
2013-07-28 19:25:14 +00:00
c6af00a977
From jamie Neufeld:
...
Add an option to selct if payload is to be dissected as SYNC.
svn path=/trunk/; revision=49595
2013-05-27 16:27:50 +00:00
b8618947bd
Add missing element NSAP to IE Evolved Allocation/Retention Priority II.
...
svn path=/trunk/; revision=49474
2013-05-21 05:08:50 +00:00
68f0af8b03
Set pinfo->link_dir per message not in the IE dissection.
...
svn path=/trunk/; revision=48873
2013-04-16 05:42:17 +00:00
37600a157b
Rename value string (and similar) functions to use a consistent pattern. This
...
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
6bde918078
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48426
2013-03-19 20:00:52 +00:00
9bfeb4963f
Make the GTP and GTP' dissectors new-style dissectors, so that they can
...
reject packets that don't look enough like GTP/GTP' packets. This fixes
bug 1706, and fixes some other cases where non-GTP/GTP' packets are
being dissected as GTP/GTP'.
svn path=/trunk/; revision=48118
2013-03-06 00:02:18 +00:00
9b01892eca
Use hf_gtp_ext_hdr_next for all "next header" fields, and get rid of
...
hf_gtp_next.
Don't do "dummy" dissection of extension headers that we don't actually
dissect - we label them by next extension header type, and dissect them
in the default case, which should suffice (until somebody adds
dissection for those types).
svn path=/trunk/; revision=48075
2013-03-05 00:17:56 +00:00
958574da78
If the length value is bad, an exception will be thrown; we don't need
...
the item for the length, as we aren't explicitly checking it and
attaching expert info items to it.
svn path=/trunk/; revision=48070
2013-03-04 22:01:29 +00:00
029c5bdbac
Give 3GPP TS numbers for GTP v0, GTP v1, and GTP'.
...
Give URLs for the 3gpp.org pages for all those specs.
Add #defines for all the GTP v1 extension header types we handle.
"gtp_prime" is a Boolean; make it a gboolean.
Dissect the first 4 octets of the header one field at a time, so that if
the packet is cut short by a snapshot length we at least dissect what's
there.
32.295 isn't entirely clear on what the 20-byte header for GTP' v0 is;
assume it's the same as the header for GTP v0.
Once we've fetched the length field from the fixed-length portion of the
header, set the length of the tvbuff to the sum of the offset past the
fixed-length portion and the length field, to catch running past that
value.
Use GTP_E_MASK|GTP_S_MASK|GTP_PN_MASK as the mask for testing for the
presence of those fields, to make it a bit clearer what's being checked
for.
Don't actually add those fields to the protocol tree unless the flag for
the field is set.
We only need one chunk of code to handle extension headers.
Make that chunk a loop, and put the header in as an FT_NONE item, with
the length, header data, and next header under it. Put the initial next
header field in as well. (We treat this like IPv6 extension headers,
with the next header field being part of the previous header, rather
than like a set of TLVs, with the next header field being the type value
of its header.)
Fail if the extension header length is zero.
Use the reported length when processing IEs or T-PDU payload.
svn path=/trunk/; revision=48068
2013-03-04 21:40:36 +00:00
240af26981
Fix a copy/paste error and factorize dissection of extension header length and next extension header
...
svn path=/trunk/; revision=48007
2013-03-02 13:12:24 +00:00
599d2e8a9c
From Lakshmi Narayana Madala :
...
GTP dissector enhanced to support UDP Port extension header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8418
svn path=/trunk/; revision=48004
2013-03-02 11:33:46 +00:00
e2d3294617
From Katrina Zhang sligtly modified.
...
- Add dissection of Selected PLMN ID.
- Put enterpice id in the tree
- Filter for UTRAN Transparent Field.
svn path=/trunk/; revision=47252
2013-01-24 09:59:06 +00:00
ccbff26e80
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8196 :
...
Add dissection of IPv4v6 type to End User Address IE
svn path=/trunk/; revision=47047
2013-01-13 11:04:46 +00:00
d4cf9ce69a
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8193 :
...
Add dissection of Dual Address Bearer Flag bit in Common Flags IE
svn path=/trunk/; revision=47036
2013-01-11 20:18:32 +00:00
433d9c198d
Only the private extension IE value part should go in the tvb.
...
svn path=/trunk/; revision=46996
2013-01-08 09:57:10 +00:00
be1ff84f48
From Katrina Zhang:Pretify dissection if a dissector exists for the private extension
...
svn path=/trunk/; revision=46857
2012-12-30 09:35:27 +00:00
39c816931c
Copy-paste error.
...
svn path=/trunk/; revision=46538
2012-12-14 11:54:35 +00:00
eba8fb9328
From Martin Isaksson:
...
- Initiiate GTP header to zero.
- Dont' load TEID unconditionaly, it might not be present.
svn path=/trunk/; revision=46537
2012-12-14 11:27:38 +00:00
2f827154f8
Bug 3974 - wrong decoding of gtp.target identification.
...
Use the IE description from 3GPP TS 29.060 version 10.4.0 Release 10.
- Fix bugs with RAI and LAC in other parts of the code.
svn path=/trunk/; revision=46439
2012-12-07 12:06:40 +00:00
49307fcedc
High light bytes including the first lenght byte in the APN name.
...
svn path=/trunk/; revision=45856
2012-11-01 08:24:08 +00:00
0c24f376ca
The GTP dissector can't handle long APN names, max is 100.
...
Bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7932
svn path=/trunk/; revision=45852
2012-10-31 16:53:39 +00:00
d0c2bc2232
From Martin Isaksson:
...
Preparattions for GTP tap.
svn path=/trunk/; revision=45377
2012-10-08 08:41:34 +00:00
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
5a8783f5b1
Initial commit to support yet another method of passing data between dissectors.
...
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
1c2f498a82
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7697 :
...
Fix dissection of release 98 and release 99 QoS profiles (bug introduced in r43312)
svn path=/trunk/; revision=44792
2012-09-06 20:58:32 +00:00
c591c6dd56
Comment out all but first value_string array entries with dup values:
...
kept: first dup since that's the one which would
be found with a linear search.
svn path=/trunk/; revision=44642
2012-08-23 17:30:42 +00:00
1741731384
remove unnecessary underscores from display filters
...
svn path=/trunk/; revision=44181
2012-08-01 02:59:17 +00:00
f4e322cd56
Fix inverted dissection of Pre-emption Capability and Pre-emption Vulnerability
...
svn path=/trunk/; revision=44091
2012-07-28 13:40:11 +00:00
ba376235da
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7474 :
...
Dissect LTE RADIUS AVP 3GPP-User-Location-Info
svn path=/trunk/; revision=43700
2012-07-13 21:18:35 +00:00
859affc2bd
Don't call subdissectors / expert...() / col...() under 'if (tree)'
...
Also:
Remove some uneeded initializers;
Do some whitespace cleanup and re-formatting.
svn path=/trunk/; revision=43681
2012-07-12 17:22:47 +00:00
eedc186e94
Dissect Release 8 CDR:s
...
svn path=/trunk/; revision=43624
2012-07-09 14:09:59 +00:00
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
28e925a381
Allow future forward compatibility
...
svn path=/trunk/; revision=43312
2012-06-17 16:08:43 +00:00
d57552df5d
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 :
...
Add dissection of Release 8 or higher P-GW QoS profile
svn path=/trunk/; revision=43280
2012-06-16 13:09:51 +00:00
f400e647b8
From Pontus Andersson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 :
...
GTP Extension headers are dissected incorrectly
svn path=/trunk/; revision=42663
2012-05-16 20:59:56 +00:00
c055ca8c7e
General minor cleanup including:
...
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation
svn path=/trunk/; revision=42487
2012-05-07 22:11:34 +00:00
fbecf576d1
From David Wei:
...
Change GTP and GTPv2 dissectors for pre-Rel7 UEs that do not support bitrates higher than 16 Mbps.
svn path=/trunk/; revision=42381
2012-05-02 07:23:32 +00:00
4f415d93c5
Fix some clang warnings (dead assignment/increment, assigned value is garbage or undefined)
...
svn path=/trunk/; revision=42344
2012-04-30 09:00:05 +00:00
Pascal Quantin