07cb929d6b
dfilter_free() can handle a NULL pointer so don't guard against that before calling it
...
svn path=/trunk/; revision=30072
2009-09-22 16:49:26 +00:00
9398b679e8
Introduce cap_file_add_fdata() and start using it
...
svn path=/trunk/; revision=30071
2009-09-22 16:39:48 +00:00
627a7c1f47
Switch Wireshark GUI (file.c) over to using frame_data.c
...
svn path=/trunk/; revision=30067
2009-09-22 14:41:30 +00:00
054ef7aa0f
Make sure that the old packet list works with the changes introduced in r30047
...
svn path=/trunk/; revision=30060
2009-09-22 05:23:45 +00:00
1989aa700d
Bring frame_data_init() and add_packet_to_packet_list() more in sync by adding 'ref_time' handling to frame_data_init(). For tshark/rawshark this is unused because they only do a single pass through the capture file
...
svn path=/trunk/; revision=30055
2009-09-21 20:17:59 +00:00
aa4af67e1b
Only set cumulative bytes after passing the display filter test
...
svn path=/trunk/; revision=30053
2009-09-21 19:48:53 +00:00
c3647b4e3b
Move 'Delta timestamp to previous captured frame' calculation inside add_packet_to_packet_list(). This is done in order to streamline add_packet_to_packet_list() with frame_data_init(). Hopefully we can switch to frame_data_init() soon
...
svn path=/trunk/; revision=30052
2009-09-21 19:30:06 +00:00
7ca137e294
Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end
...
svn path=/trunk/; revision=30047
2009-09-21 18:09:19 +00:00
109875c775
Remove second (redundant) assignment to fdata->cum_bytes
...
svn path=/trunk/; revision=30046
2009-09-21 17:38:10 +00:00
9831d4c4e1
Reverse order of NEW_PACKET_LIST guard, i.e. #ifdef NEW_PACKET_LIST instead of #ifndef NEW_PACKET_LIST
...
svn path=/trunk/; revision=30045
2009-09-21 17:32:35 +00:00
d923139789
Fix typo in comment
...
svn path=/trunk/; revision=30043
2009-09-21 17:09:15 +00:00
3c9afabfe0
(cosmetic change) - reset cumulative bytes together with 'first_ts' and 'prev_dis_ts'
...
svn path=/trunk/; revision=30042
2009-09-21 15:50:15 +00:00
8527133db0
cf->dfilter is only set if it's valid so assert if that's not the case
...
svn path=/trunk/; revision=30041
2009-09-21 15:38:40 +00:00
112a677484
Reset cumulative bytes when we open the file
...
svn path=/trunk/; revision=30040
2009-09-21 15:29:32 +00:00
8dc906da00
Set fdata->num up front and roll back if necessary
...
svn path=/trunk/; revision=30039
2009-09-21 15:23:33 +00:00
03a9cfe84c
Shuffle NEW_PACKET_LIST guard
...
svn path=/trunk/; revision=30038
2009-09-21 14:13:46 +00:00
d86635a3d8
Introduce a NEW_PACKET_LIST specialized version of add_packet_to_packet_list(). The old one contained too many #ifdef NEW_PACKET_LIST which reduced readability
...
svn path=/trunk/; revision=30036
2009-09-21 12:14:11 +00:00
546014cdaf
cf_change_time_formats() is not needed with new packet list.
...
svn path=/trunk/; revision=30034
2009-09-21 11:58:36 +00:00
3b7a12dda0
Add NEW_PACKET_LIST guard wrt fdata->col_text
...
svn path=/trunk/; revision=30030
2009-09-21 04:29:25 +00:00
2e282e7567
Introduce frame_data_cleanup() and start using it
...
svn path=/trunk/; revision=30023
2009-09-20 18:18:29 +00:00
ad7f82f9ce
From Jakub Zawadzki:
...
Fix copy/paste error wrt. fdata->col_text_len
svn path=/trunk/; revision=29921
2009-09-15 14:01:40 +00:00
b0c3abfa79
Fix:
...
cleanup_dissection() calls se_free_all(); And after that fdata->col_text (which is allocated using se_alloc0()) no longer points to valid memory.
svn path=/trunk/; revision=29920
2009-09-15 13:18:13 +00:00
5dfeb86fb7
Fix warning that variable may be unused and then declare volatile so it
...
survives the TRY/CATCH code.
svn path=/trunk/; revision=29863
2009-09-11 15:38:33 +00:00
6edeb87ad7
Only move to last row if it's vissible.
...
svn path=/trunk/; revision=29861
2009-09-11 14:58:49 +00:00
0772dd06b4
New_packet_list
...
Select the correct frame in packet details when filtering.
svn path=/trunk/; revision=29857
2009-09-11 11:58:00 +00:00
a65f72e8f0
Allocate col_text and col_text_len when the fdata struct is allocated.
...
(complete the checkin).
svn path=/trunk/; revision=29818
2009-09-09 08:51:33 +00:00
de23d92163
Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter.
...
svn path=/trunk/; revision=29806
2009-09-08 19:00:54 +00:00
c6f96e4ec9
Make sure that reset the elapsed time to load a file before we reload/rescan the file
...
svn path=/trunk/; revision=29783
2009-09-07 21:07:51 +00:00
8d909ba79e
Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column()
...
svn path=/trunk/; revision=29782
2009-09-07 20:45:32 +00:00
a65d590002
Store the packet encapsulation type as gint8. Saves 3 bytes per packet
...
svn path=/trunk/; revision=29767
2009-09-07 13:54:46 +00:00
e55129063b
Fixed arguments to new_packet_list_set_time_width().
...
svn path=/trunk/; revision=29761
2009-09-07 12:01:19 +00:00
5cc8d3e71d
col_fmt not needed.
...
svn path=/trunk/; revision=29760
2009-09-07 11:50:08 +00:00
cd8831c72d
Track length of columns strings. We'll need this in order to resize columns quickly
...
svn path=/trunk/; revision=29759
2009-09-07 11:33:38 +00:00
7473e1e04c
Automatically adjust the time column width when time format changes.
...
svn path=/trunk/; revision=29758
2009-09-07 10:03:55 +00:00
0e5cef61be
Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown.
...
This is an initial step. There's still some work to do.
svn path=/trunk/; revision=29754
2009-09-06 18:25:23 +00:00
95ddec4d07
Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible.
...
svn path=/trunk/; revision=29705
2009-09-05 10:36:29 +00:00
6be0e11906
Remove superfluous assignment
...
svn path=/trunk/; revision=29686
2009-09-03 14:41:09 +00:00
bd69669e1d
Make sure that we stop auto scroll if we start scrolling manually.
...
Caveat: we jump to first frame when auto scroll is stopped
svn path=/trunk/; revision=29685
2009-09-03 14:32:11 +00:00
47b766a998
Only try and select the last row if not already selected. This fix doesn't seem to work. Any suggestions?
...
svn path=/trunk/; revision=29677
2009-09-02 19:31:56 +00:00
bc36849a9e
Add seperate new_packet_list_moveto_end() which scrolls to the end _without_ selecting the last packet.
...
svn path=/trunk/; revision=29670
2009-09-02 17:29:52 +00:00
6149d4be35
Make sure that we select the last row if autoscroll is enabled. The scrolling is still very jumpy. It seems that we always select the first packet before moving to the end.
...
svn path=/trunk/; revision=29668
2009-09-02 17:15:20 +00:00
e256fed975
Add volatile to avoid clobbered by longjmp warning.
...
svn path=/trunk/; revision=29651
2009-09-01 11:15:24 +00:00
2d001ec762
- Read a min number if packets before checking if the progress bar should be updated.
...
- Calculate the progess before checking if progress bar should be
created or not.
- Dont update the progress to often on small files.
- Use data_offset rather than reading file_pos.
svn path=/trunk/; revision=29648
2009-09-01 08:51:41 +00:00
2cd2eecd0a
Compute the loading time and show it in the main status bar.
...
(Modified code from Didier Gautheron).
svn path=/trunk/; revision=29592
2009-08-28 05:19:52 +00:00
27f7d88c84
Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
...
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
1108352f00
Use col_text in frame data.
...
- colum-utils needs more work, based on
Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=29489
2009-08-21 10:12:47 +00:00
82adb33a48
We shouldn't conditionalise on _filtering_ tap listerners to determine whether tapping should be performed or not. We also need to handle _normal_ tap listerners. This change backs out the regression introduced in r29435.
...
Thanks to Didier: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3916
svn path=/trunk/; revision=29475
2009-08-19 13:52:15 +00:00
d4ba2208ec
Inline a few checks in the add_packet_to_packet_list() function since it's called in tight loop. This will help us to avoid calling functions that simply returns. This is especially the case when we're dealing with the new packet list due to its dissect-on-demand nature where colour/column construction is delayed until the row becomes visible.
...
svn path=/trunk/; revision=29435
2009-08-15 14:13:36 +00:00
81c7e34905
Make display filtering work for NEW_PACKET_LIST. This didn't work previously because we would simply append the new filtered packets onto the existing ones.
...
svn path=/trunk/; revision=29409
2009-08-14 05:49:57 +00:00
68e75a961b
Always add packet to the new packet list regardless of whether the packet passed the display filter test or not. We do this because we do the filtering inside the new packet list.
...
svn path=/trunk/; revision=29408
2009-08-14 05:22:12 +00:00
Kovarththanan Rajaratnam