Commit Graph

32 Commits

Author SHA1 Message Date
Anders Broman 67900c23be Fix Unused varaiable warnings.
CID 1163 - 1166

svn path=/trunk/; revision=36675
2011-04-17 09:34:38 +00:00
Guy Harris 742915eca5 Fix some cut-and-pasteos and other typoes.
svn path=/trunk/; revision=35328
2011-01-02 19:39:24 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier e600394937 (Trivial) Use consistent indentation; Whitespace cleanup.
svn path=/trunk/; revision=33788
2010-08-12 16:27:16 +00:00
Bill Meier ead0425688 From Don Newton: Added dissection of Expansion Module (KEM,GEM) messages to Unistim plugin.
From me: Add expansion.h to list of .h files in Makefile.common;
         #include <stdio.h> not required.

svn path=/trunk/; revision=33786
2010-08-12 15:47:31 +00:00
Jaap Keuter ccf61ec3b2 From Don Newton:
Fails to decrement msg_len on 3 different message types which causes the
dissector to attempt to decode an addition or misplaced unistim cmd.

svn path=/trunk/; revision=33643
2010-07-27 06:46:00 +00:00
Guy Harris 75ffa6bb71 The only reason to escape "%" in a string is if you are, incorrectly,
passing a string directly to a routine that expects a format string. 
The correct way to handle that is to pass "%s" as the string.

As long as you're escaping non-printable characters, just let
tvb_format_string() handle that.

For null-terminated strings, get the length of the string with
tvb_strsize(), and then just put the string into the protocol tree as a
regular item.

svn path=/trunk/; revision=33482
2010-07-09 21:27:08 +00:00
Anders Broman 846eed1d9e Get rid of check_col
svn path=/trunk/; revision=32401
2010-04-06 16:13:09 +00:00
Guy Harris 5535f4a598 Fix some compiler warnings, clean up indentation a bit.
svn path=/trunk/; revision=32201
2010-03-16 03:31:44 +00:00
Bill Meier bb79476b22 Fix gcc -Wshadow warning;
Move proto_register... and proto_reg_handoff... to the end of the file.

svn path=/trunk/; revision=31723
2010-01-28 23:11:54 +00:00
Kovarththanan Rajaratnam ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam 24ca3c44c9 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29341
2009-08-09 06:47:24 +00:00
Stig Bjørlykke 7881d1ccd7 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28970
2009-07-07 09:00:33 +00:00
Stig Bjørlykke 3a6e56c25a From Kovarththanan Rajaratnam via bug 3548:
Move header_field.h into packet-unistim.c to align it with all other
dissectors.

svn path=/trunk/; revision=28967
2009-07-07 07:45:32 +00:00
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Gerald Combs 17f0d877fa Fix Win64 compilation problems in the plugins directory.
svn path=/trunk/; revision=28064
2009-04-16 03:38:23 +00:00
Bill Meier a0eee8c299 Replace some unnecessary use of g_snprintf and g_strdup_printf
svn path=/trunk/; revision=27864
2009-03-27 14:46:54 +00:00
Jörg Mayer b719d7ac35 Unistim still eats the TAPA packets :-(
svn path=/trunk/; revision=26910
2008-12-04 09:31:44 +00:00
Jaap Keuter f5b04f0124 From Don Newton:
Set default port of Unistim back to 5000; The Unistim dissector is made a heuristic dissector.

svn path=/trunk/; revision=26904
2008-12-02 23:02:32 +00:00
Jaap Keuter 7c65de9865 From Don Newton:
Flesh out call duration timer message.

svn path=/trunk/; revision=26898
2008-12-02 07:09:01 +00:00
Stig Bjørlykke 94e9e2b1ec Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Bill Meier 278b32d71f Minor cleanup related to proto_register/proto_reg_handoff ...
svn path=/trunk/; revision=26596
2008-10-28 00:29:15 +00:00
Jaap Keuter 81db026301 Fix for bug 2475:
Add a preference to the UNISTIM dissector so that you can set the default port back to 5000, even though this conflicts with other dissectors.

svn path=/trunk/; revision=25118
2008-04-19 10:41:45 +00:00
Jörg Mayer dc6789a84f Set default port of Unistim from 5000 to 0: It grabs the TAPA
packets that I need.
The Unistim dissector should be made a heuristic dissector that
is willing to coexist with other dissectors. Until such a time
the port should remain 0.

svn path=/trunk/; revision=24573
2008-03-06 12:54:08 +00:00
Jaap Keuter b5a733b0a8 Fix for bug 2098:
Test that message length is at least the minumum required, otherwise generate expert item..

svn path=/trunk/; revision=23854
2007-12-13 08:02:29 +00:00
Stig Bjørlykke 19aa309fea From Don Newton:
added null termination to uftp and cleaned comments in packet-unistim.c

svn path=/trunk/; revision=22940
2007-09-24 19:56:17 +00:00
Jaap Keuter f2c1b7e8f0 From Chad Singer:
I fixed a bug in packet_unistim.c which was causing a 'malformed packet' to
appear when an open stream command is read with no endpoint ip (as is sometimes
done) I added a simple msg_len check to avoid this. 
I also added UFTP to the unistim dissector and adjusted the unistim call-detection 
in voip-info.c to start on an open stream as well as keypresses..

svn path=/trunk/; revision=22929
2007-09-24 06:19:56 +00:00
Jaap Keuter 0503c37133 Add RT(C)P conversation setup.
svn path=/trunk/; revision=22862
2007-09-13 18:47:10 +00:00
Jaap Keuter f0d360a48a Implement dissect_message loop i.s.o. recursive calls.
svn path=/trunk/; revision=22857
2007-09-12 21:46:55 +00:00
Jaap Keuter e1541263e4 From Chad Singer:
UNISTIM Tap interface plus call grapher.

svn path=/trunk/; revision=22834
2007-09-10 07:21:27 +00:00
Jörg Mayer 659b175cd7 Disable unistim for now: it used port 5000 unconditionally
and that collied with tapa. Please add a check.

svn path=/trunk/; revision=22702
2007-08-28 10:37:21 +00:00
Jaap Keuter b65cc92385 Add the UNISTIM plugin to Wireshark.
svn path=/trunk/; revision=22558
2007-08-20 20:50:29 +00:00