Jeff Morriss
8c608e6e82
Remove $Id$ from the ASN.1 dissectors and regenerate them.
...
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-18 03:05:28 +00:00
Guy Harris
c12dc67752
Strings in LDAP are generally UTF-8, although if we treat something only
...
as a string if every byte in it is a printable ASCII character, it's
ASCII. Use tvb_get_string_enc() with an appropriate encoding.
svn path=/trunk/; revision=54889
2014-01-22 02:37:45 +00:00
Anders Broman
3a533ccc32
Omit assignment for not used types.
...
svn path=/trunk/; revision=54593
2014-01-04 12:03:02 +00:00
Michael Mann
d62f92b7f1
Make LDAP dissector use ASN.1 private_data instead of pinfo->private_data.
...
Cleanup a forgotten pinfo->private_data use in the H245 dissector.
svn path=/trunk/; revision=53160
2013-11-08 02:02:43 +00:00
Michael Mann
02a8391535
Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new.
...
svn path=/trunk/; revision=53049
2013-11-02 15:52:25 +00:00
Michael Mann
c0fcebb07a
Add a data parameter to call_ber_oid_callback to be able to pass data to subdissectors found with dissector_try_string_new.
...
The intention is to aid in the removal of pinfo->private_data use as well as static global variables in a dissector. For now, all calls to call_ber_oid_callback have the data parameter set to NULL.
svn path=/trunk/; revision=52994
2013-10-31 00:57:03 +00:00
Pascal Quantin
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Evan Huus
6df83e8078
Add _g_ to the names of functions that allocate glib memory. This is a bit more
...
explicit, and frees up the "generic" names (like tvb_memdup) for new signatures
that take the appropriate wmem pool.
Majority of the conversion done with sed.
svn path=/trunk/; revision=52164
2013-09-21 17:04:41 +00:00
Michael Mann
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
Evan Huus
8b0f1addd9
Apparently one of our major global headers must include emem.h, because I just
...
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.
svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
Michael Mann
7fe5422c4b
Convert ASN.1 dissectors to use filterable expert info.
...
NOTE: Kerberos ASN.1 template was updated, but not generated to source.
svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00
Anders Broman
10fe76d8a0
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43057
2012-06-04 08:56:48 +00:00
Alexis La Goutte
7e0c1e3a5a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=42514
2012-05-08 17:42:54 +00:00
Guy Harris
1fca484224
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
Update the RFC number for LDAP.
svn path=/trunk/; revision=42493
2012-05-08 00:15:53 +00:00
Stig Bjørlykke
adabb3d63e
Added support for configuring custom LDAP AttributeValue types.
...
svn path=/trunk/; revision=41841
2012-03-30 09:08:55 +00:00
Stig Bjørlykke
91f2f97f28
Don't try to convert AttributeValue to string if having a ldap_name dissector.
...
Prefix the converted printable string correctly with 'AttributeValue: '.
svn path=/trunk/; revision=41823
2012-03-29 12:03:49 +00:00
Alexis La Goutte
8e968adb2c
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41298
2012-03-02 11:00:24 +00:00
Anders Broman
42b44648c8
Get rid of Warnings.
...
svn path=/trunk/; revision=39954
2011-11-20 08:59:19 +00:00
Gerald Combs
670d38ec71
Properly initialize our filter counters.
...
svn path=/trunk/; revision=36190
2011-03-14 16:00:51 +00:00
Gerald Combs
91fe31c9b4
If we encounter an excessively long filter string or one with too many
...
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.
svn path=/trunk/; revision=36101
2011-03-01 00:50:17 +00:00
Anders Broman
b2992b2310
ldap.cnf:782: warning: ISO C90 forbids mixed declarations and code
...
svn path=/trunk/; revision=35476
2011-01-11 11:41:03 +00:00
Ronnie Sahlberg
3079c9c931
From Matthieu Patou <mat@samba.org>
...
Dissect LDAP DirSyncFlags to show the bits of this bitmap.
svn path=/trunk/; revision=35474
2011-01-11 02:27:41 +00:00
Anders Broman
6dc449e99c
The CLDAP attribute value on a CLDAP reply is no longer being decoded
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5239
It got broken in Revision 33390 I think, if attr_type is unset at this point it should be set in the calling function.
http://anonsvn.wireshark.org/viewvc/trunk/asn1/ldap/ldap.cnf?r1=33388&r2=33390
svn path=/trunk/; revision=34176
2010-09-21 14:56:55 +00:00
Gerald Combs
6aaa5874c6
Initialize more variables.
...
svn path=/trunk/; revision=33392
2010-07-01 00:11:14 +00:00
Gerald Combs
caff9b5513
Initialize a variable.
...
svn path=/trunk/; revision=33390
2010-06-30 23:45:24 +00:00
Gerald Combs
47c6bf912f
Initialize a variable.
...
svn path=/trunk/; revision=33388
2010-06-30 23:36:24 +00:00
Gerald Combs
6d60493b8a
Initialize attributedesc_string in a couple of places so that we
...
don't end up trying to use an invalid pointer.
svn path=/trunk/; revision=33341
2010-06-27 22:38:28 +00:00
Anders Broman
c1defb60a7
Try to fix compilation with MSVC.
...
Please review.
svn path=/trunk/; revision=31962
2010-02-23 06:28:34 +00:00
Guy Harris
b395a98305
Squelch a bunch of compiler warnings.
...
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman
9a030dda05
Get rid of check_col();
...
svn path=/trunk/; revision=31552
2010-01-17 18:16:06 +00:00
Gerald Combs
afc57e6fac
Add NULL pointer checks. Fixes the fuzz crash in bug 4351.
...
svn path=/trunk/; revision=31362
2009-12-24 21:23:38 +00:00
Jaap Keuter
e1ec979363
From Mathieu Parent:
...
As defined in rfc4511 [Lightweight Directory Access Protocol (LDAP): The Protocol],
see the attached patch that dissects IntermediateMessage.
svn path=/trunk/; revision=31251
2009-12-12 09:30:49 +00:00
Gerasimos Dimitriadis
142b31816c
From Mathieu Parent:
...
Dissector for LDAP Content Synchronization Operation
(Modified in order to remove the unneeded oid_add_from_string's)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4309
svn path=/trunk/; revision=31218
2009-12-09 20:59:20 +00:00
Kovarththanan Rajaratnam
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Graeme Lunt
05a3dca2bc
LDAP control support for Password policy for LDAP directories.
...
svn path=/trunk/; revision=28783
2009-06-21 09:13:11 +00:00
Bill Meier
cb3db511f6
As suggested by Jakob Zawadzki: (Bug #3311 ): g_free() is NULL safe, so we don't need check against it.
...
svn path=/trunk/; revision=27861
2009-03-27 12:16:02 +00:00
Stig Bjørlykke
37575374b8
Added one more string_or_null.
...
svn path=/trunk/; revision=27482
2009-02-18 10:07:29 +00:00
Gerald Combs
95ddd62076
Add a string utility function "string_or_null" which can be used to
...
guarantee a non-null string value. Use it in the LDAP dissector. Fixes
the crash on Windows (and other platforms) reported in bug 3262.
svn path=/trunk/; revision=27478
2009-02-17 23:15:35 +00:00
Anders Broman
201b5205df
Get rid of some unused code warnings and fix an Id marking and some indentation changes.
...
svn path=/trunk/; revision=25803
2008-07-23 12:45:24 +00:00
Jeff Morriss
a4436253ac
Fix LDAP crash (on certain platforms) from http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1613 : if the string is NULL pass "(null)" in instead (that's the behavior we get on Linux anyway).
...
svn path=/trunk/; revision=24660
2008-03-16 22:54:37 +00:00
Graeme Lunt
fcef5823db
1) Support for configurable LDAP over SSL port
...
2) Support for RFC 3909 - cancelRequest extendedOperation
3) Support for RFC 3062 - passwordModify extendedOperation
4) Column information for ExtendedRequest, SearchResultRef and AbandonRequest
5) Column information for multiple LDAP operations in the same packet (uses " | " separator)
svn path=/trunk/; revision=24195
2008-01-26 10:12:22 +00:00
Stig Bjørlykke
7629966a00
- Removed some unused variables in asn1 dissectors
...
- Fixed last parameter to cry_cipher_open() in pkcs12
svn path=/trunk/; revision=24116
2008-01-16 20:41:23 +00:00
Graeme Lunt
8563c02137
Basic support for the LDAP start_tls extended operation and fix to match up extended operation arguments and results.
...
svn path=/trunk/; revision=24076
2008-01-13 14:12:47 +00:00
Anders Broman
de16039c51
Get rid of dissect_ber_boolean_value() and change the signature of
...
dissect_ber_boolean() to return a value and update asn2wrs to generate the new signature.
Regenerate all BER dissectors.
svn path=/trunk/; revision=24015
2008-01-04 16:21:07 +00:00
Anders Broman
a6d82ae12e
Get rid of ber_last_created_item().
...
svn path=/trunk/; revision=24008
2008-01-04 12:39:52 +00:00
Ronnie Sahlberg
affd07f1e4
dissect_ber_choice() returns the index of the taken arm not the tag
...
value
svn path=/trunk/; revision=23458
2007-11-15 10:32:10 +00:00
Anders Broman
bec8475743
LDAP with -T
...
svn path=/trunk/; revision=23353
2007-11-04 17:16:01 +00:00
Anders Broman
dbcabb1938
Get rid of most of the legacy oid stuff.
...
svn path=/trunk/; revision=23333
2007-11-01 22:07:43 +00:00
Ronnie Sahlberg
84b28f1399
only set ldap_info->first_auth_frame to 0 first time we see the
...
authentication packet or else we will get inconsistent dissection when
clicking on packets.
(inconsistent as in : a certain packet might/might not be dissected as
LDAP/SASL depending on which packets we clicked on previously)
svn path=/trunk/; revision=22949
2007-09-25 08:05:17 +00:00
Ronnie Sahlberg
3acb5a0975
add support for yet another random combination of authentication
...
wrappers that can be used when connecting with sasl
svn path=/trunk/; revision=22945
2007-09-25 04:15:30 +00:00