- Replace the completely wrong Makefile.am (was a copy of makefile.nmake)
by the version the author sent. As I needed to retrieve it from the ML
archives, it may be different from the originally sent version. If
someone still has the original version in his inbox, please send it to
me.
svn path=/trunk/; revision=19107
dont link with libcodec.a
1, this should be a shared library not a static one?
2, its not built on unix so it is missing
making unix/linux build work again
svn path=/trunk/; revision=19101
- Change the "listen_rtp" to "rtp_player"
- Change from a plugin to be part of the core
- By default it will not compile with the rtp_player. In order to
compile it is necessary to:
+ For windows: uncomment the line
"PORTAUDIO_DIR=$(WIRESHARK_LIBS)\portaudio_v18_1" in config.nmake
+ For linux: using the "--with-portaudio=yes"
svn path=/trunk/; revision=19094
- Change the "listen_rtp" to "rtp_player"
- Change from a plugin to be part of the core
- By default it will not compile with the rtp_player. In order to
compile it is necessary to:
+ For windows: uncomment the line
"PORTAUDIO_DIR=$(WIRESHARK_LIBS)\portaudio_v18_1" in config.nmake
+ For linux: using the "--with-portaudio=yes"
svn path=/trunk/; revision=19093
- add help buttons to the dialogs
- the read filter fields are now working (the filter button still not)
- PDML export don't need "Packet Format" settings, grey them out
- fix a bug in the filter fields coloring function (g_alloc space was too small)
svn path=/trunk/; revision=19091
we might want the Unix/GTK version work the same way, as this is how other programs I know work as well ... and making the documentation easier by desribing only one way how it's working
svn path=/trunk/; revision=19090
that obviates the need to check for a null capture filter string, and
fixes bug 1055.
Keep track of whether it was set from the command line, though, so we
can catch attempts to set the filter more than once, and attempts to set
it when we're not capturing.
Clean up white space.
svn path=/trunk/; revision=19047
After experimenting a bit, this is a GTK bug IMHO, I don't see a better way to simply use the GTK1.x code for now, which is working ok.
GTK2.4 was working properly, GTK2.6 and 2.8 has this bug, hopefully GTK2.10 will fix it again.
svn path=/trunk/; revision=19025
Since version 18928, there is a GTK warning at wireshark startup.
I think a #ifdef HAVE_AIRPCAP is missing in ./gtk/menu.c
svn path=/trunk/; revision=18976
is disabled by default, and can be enabled by setting AIRPCAP_CONFIG
in config.nmake. The code is currently limited to Windows, but should
be adaptable to other platforms.
The official announcement won't come until next week, so you'll have to
read the source for details. :)
svn path=/trunk/; revision=18928
protocol has a lot of preference items. Change the number of
configurable ESP SAs to 16 (in case someone needs do decrypt many
sessions in a single trace file). Fix up whitespace.
svn path=/trunk/; revision=18903
Simply ignore the incoming values of -32000 by not calling gtk_window_move() / gtk_widget_set_uposition() in that case.
I don't know what the Unix GLib version will do in that case.
svn path=/trunk/; revision=18884
I believe this is a typo in the command line help for the -i option:
Usage: wireshark [options] ... [ <infile> ]
Capture interface:
-i <interface> name or idx of interface (def: first none
loopback)
Shouldn't that read "first non-loopback" ?
svn path=/trunk/; revision=18813
Below is a patch for a bug in rtp_analysis.c. The variable
statinfo->delta_timestamp was not initialized in all the
necessary cases. The function rtp_packet_save_payload uses this
variable and the for loop on line 935 could use an old value
and run an incorrect amount of times, e.g. a couple billion,
which gets ethereal stuck. I can supply an example capture
which causes it. The patch solves the problem.
svn path=/trunk/; revision=18798
I'm not sure if this will help with the problems that Keith French is
seeing, but when I loaded some of my old H.323 traces, one of them would
assert/abort. This patch fixes that assertion (looks like it was obviously
asserting on the wrong pointer variable).
svn path=/trunk/; revision=18791
sip_stats.c and tap_sipstat.c:
adds the code 429 ("Provide Referrer Identity", from RFC 3892) to
SIP stats.
chargecontrol.xml packet-diameter.c :
These patches
- add a few more chargecontrol AVPs, and add the vendor-id where needed
- report as expert info when AVPs' lengths don't match their type
svn path=/trunk/; revision=18743
IPv4+port rules are supported along with several syntaxes: IOS standard,
IOS extended, ipfilter, ipfw, pf, and netsh. IPv6 is currently not
supported, but shouldn't be too difficult to add.
All of the rules were created using the documentation for each product.
None of them have been tested. For the time being, use them with
caution.
svn path=/trunk/; revision=18737
Mike Oliveras has indicated that for MGCP voip calls, 2 seconds may be a
better timeout for still matching DLCX requests to a hung-up endpoint,
as in this patch.
svn path=/trunk/; revision=18662
remove "double combobox" from the save dialog
append the default file extension to the save file name, if the user didn't added one
svn path=/trunk/; revision=18563
i dont think this can trigger in the current code but better safe than sorry and it safeguards against future changes that might break this requirement.
dereferencing a nullpointer would cause crash of wireshark in case a new bug is introduced making it possible for this variuable to be null.
svn path=/trunk/; revision=18543
this is actually a false positive in coverity and can not trigger since htis pointer can not be null here
but verifying this before the varialbe is dereferenced does not hurt in case
the file is changed and this contract is broken.
checking the
svn path=/trunk/; revision=18542
Fix the part where the DeleteConnection messages and
responses were not being included in the graphs.
There is a test that allows messages such as these for 1 second after
the call has been hung up, but the time calculation was wrong.
svn path=/trunk/; revision=18479
Add missing "Find Next Mark" and "Find Previous Mark" functionality to the "Edit" menu.
"unify" the menu items of "Time Reference" and "Mark Frame" functionality (both main and packet list context menus)
... we need to update the User's Guide screenshots anyway because of the Wireshark changes :-)
svn path=/trunk/; revision=18438
From Cvetan Ivanov:
voip_calls.c
It seems to me that in gtk/voip_calls.c tmp_h323info->guid is pointer itself, therefore:
memcmp(&tmp_h323info->guid
should in fact read:
memcmp(tmp_h323info->guid
svn path=/trunk/; revision=18424
H225.cnf
I noticed is that the voip call flow graph does not have a label for the setupAck packet. I traced this to the empty frame_label.
voip_calls.c
It seems to me that in gtk/voip_calls.c tmp_h323info->guid is pointer itself, therefore:
memcmp(&tmp_h323info->guid
should in fact read:
memcmp(tmp_h323info->guid
svn path=/trunk/; revision=18304
Get rid of extra g_strdup_printf() arguments (the argument list is
terminated by running out of formats in the format string, not by a
terminating null pointer).
svn path=/trunk/; revision=18151
add copy functionality to the details window. Also includes a change in the copy function of the hex data window to allow copying just the text strings instead of all of the hex data.
svn path=/trunk/; revision=18129
Make teh msb of the cmdset variable indicate whether we detected the commandset from the trace or whether we used the default value from preferences.
indicate in the dissection of the packet whether the command set is "known" or whether we are using the default one.
make scsi srt stats work even for when we are using the "default" dommandset. Previously scsi srt would ignore all pdus for itl sessions where the "default" command set was used.
svn path=/trunk/; revision=18098
In summary these patches do the following:
1. GTK+ 2.x builds will now use Tree View to display the expert items, expanded items are the individual packet numbers.
2. GTK+ 1.x builds will continue to use the older clist functionality
3. Implements the equivilant of expert info (actually calls expert_dlg.c)
svn path=/trunk/; revision=18091
authesserre samuel <sauthess@gmail.com> kindly pointed out an issue with session renegotiation in the current ssl decryption code.
Encrypted handshake message are decrypted, but the dissector try to interpret the encrypted code. Renegotiation messages are therefore ignored. The attached pcap trace and key can be used to trigger the issue.
The attached patch fix the problem storing the decrypted version of encrypted handshake message and dissecting it when available. The patch also fix bad issue with des cipher (alike the issue fixed in my previous post)
svn path=/trunk/; revision=18081
programs, by reporting it with a dialog box that at least attempts to
indicate what the problem is, and by giving up early on running dumpcap.
svn path=/trunk/; revision=18051
it to capture_file_dlg.c, and rename its header file. We might want to
move the generic file dialog stuff to a file_dlg.c file (it's currently
in dlg_utils.c), and move the non-capture-file dialog stuff in
capture_file_dlg.c to another file.
svn path=/trunk/; revision=18034
mention informational URLs at the beginning and not at each element
replace some // by /**/
start to decode the informational elements in the BSSID list
add a privacy tab to the BSSID list (None, WEP, WPA, WPA2)
various minor label changes
svn path=/trunk/; revision=17988
With the new feature we can:
1. Measure how big the bursts are for a video streams (it uses sliding window algorithm) 2. Measure how big the output buffer should be that no packet drop will occur (it uses Leaky bucket algorithm)
3. Detect if we have loses inside the MPEG2 video stream (if there are already MPEG2 packets missing) - this part of code is not added yet, see Limitations
The addition is called Multicast streams and works as follows:
- it uses the TAP system
- the main "stream" logic is taken from rtp_strems.* files
- the TAP system checks for UDP packets where the destination MAC address starts with "01:00:5E" (ethernet multicast address)
- it creates an entry for every new multicast stream
- based on sliding window and leaky bucket algorithm it calculates for every stream average BW, max BW, burst size, max buffer needed, some alarms if the limits are exceeded,...
- the same calculation is done for all streams together
- inside the window dialog you can specify the burst interval, the alarm limits and output speeds
To do & limitations:
- Currently the analysis can be done only for multicast streams, it means that VoD (Video on demand) or PayTV streams, which are normally unicast can not be analysed.
- since the MPEG2 is patended I don't know if decoding of MPEG2 packets is allowed? Can we look inside this packets and calculate packets drops based on some counter information inside the payload? Can someone please answer this question? If we can do this, I will post this part of code too.
- some more flexibility will be added
svn path=/trunk/; revision=17980
and get rid of some breakage in the design
let the scsi transport keep track of itl (initiator, target, lun) matching
and let it pass a itl structure to scsi that is persistent across packets.
let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable.
update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter.
more to come.
svn path=/trunk/; revision=17942
even if doing a live capture; just print the packets without saving
them.
In dumpcap:
default to the capturing the entire packet;
don't do the "Press any key" stuff when debugging on UN*X;
do console logging (to the standard error) even when we're
running as the capture child (the sync pipe should only be the
standard output, not the standard error).
svn path=/trunk/; revision=17786
Jörg Mayer