Commit Graph

9 Commits

Author SHA1 Message Date
Guy Harris 2a8e47b11a Don't ensure all the bytes of a security descriptor exist before calling
"dissect_nt_sec_desc()".  Add a Boolean argument to
"dissect_nt_sec_desc()" to indicate whether a length was passed to it
(so we don't treat -1 as a special value; we want to stop treating -1 as
a special length value, and, in fact, want to stop treating *any*
negative length values specially, so that we don't have to worry about
passing arbitrary 32-bit values from packets as lengths), and have
"dissect_nt_sec_desc()" initially create the protocol tree item for the
security descriptor with a length of "go to the end of the tvbuff", and
set the length once we're done dissecting it - and, if the length was
specified, check at *that* point, *after* we've dissected the security
descriptor, whether we have the entire security descriptor in the
tvbuff.

That means that we don't have to worry about overflows after
"dissect_nt_sec_desc()" returns - if the length was so large that we
would have gotten an overflow, we'd have thrown an exception in the
"tvb_ensure_bytes_exist()" call at the end of "dissect_nt_sec_desc()".

Do sanity checks on offsets within the security descriptor, so we know
the item referred to by the offset is after the fixed-length portion of
the descriptor.

svn path=/trunk/; revision=16113
2005-10-04 10:23:40 +00:00
Ulf Lamping 6f98654a6a bugfix: don't simply use length field value from packet data, ensure the bytes really exist
svn path=/trunk/; revision=15963
2005-09-22 21:09:02 +00:00
Luis Ontanon 4dd73467de some ememification
svn path=/trunk/; revision=15431
2005-08-19 15:35:42 +00:00
Ronnie Sahlberg bb7160249d rename lsa_dissect_LSA_SECURITY_DESCRIPTOR to lsa_dissect_sec_desc_buf
change its signature to match the autogenerated signatures.

add a small wrapper function so tha tthe handwritten lsa can still call the
function through dissect_ndr_pointer()

no changes in functionality,  essentially just a rename of a function and signature change


svn path=/trunk/; revision=13207
2005-01-30 13:00:35 +00:00
Ronnie Sahlberg 7fc663c738 rename lsa_dissect_LSA_SECURITY_DESCRIPTOR_data to lsa_dissect_sec_desc_buf_data
to make the symbol compatible with an autogenerated LSA dissector.

no changes to the code, just a rename.


svn path=/trunk/; revision=13206
2005-01-30 12:38:38 +00:00
Ronnie Sahlberg ae9fe25e4f rename lsa_dissect_POLICY_DNS_DOMAIN_INFO to lsa_dissect_DnsDomainInfo and change the signature slightly.
the signature change is to make it compatilbe with the signatures the idl compiler generates.


svn path=/trunk/; revision=13205
2005-01-30 12:21:17 +00:00
Ronnie Sahlberg 610da77693 older MS DCE/RPC interfaces often use a construct that is to be treated as a 64 bit integer but in reality is a struct containing 2 32bit integers.
this construct is aligned on 4 byte boundaries in ndr and NOT
8 bytes as a real uint64 (== hyper) would be.


rename the existing dissect_ndr_uint64  ro  dissect_ndr_duint32  (double uint32) to make it reflect better the alignment of the type.



svn path=/trunk/; revision=13184
2005-01-28 09:29:49 +00:00
Guy Harris 13bb12c4f1 Move a bunch of stuff that's more Windows-related than SMB-related to
"packet-windows-common.[ch]".

svn path=/trunk/; revision=11592
2004-08-03 02:28:49 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00