Commit Graph

2335 Commits

Author SHA1 Message Date
Guy Harris bbed650915 Do some more length checking to avoid a dissector bug error. Should fix
bug 6564.

svn path=/trunk/; revision=39831
2011-11-14 18:42:11 +00:00
Anders Broman 34ea886454 [-Wunused-but-set-variable]
svn path=/trunk/; revision=39829
2011-11-14 17:35:04 +00:00
Anders Broman 75afa0bd3f Fix Id tag.
svn path=/trunk/; revision=39824
2011-11-14 08:24:47 +00:00
Anders Broman fa7ea2ea34 fix [-Wunused-but-set-variable]
svn path=/trunk/; revision=39803
2011-11-12 12:37:38 +00:00
Guy Harris c356d4f2c1 Get rid of an unused function (dissect_hnbap_AccessResult()).
svn path=/trunk/; revision=39789
2011-11-10 23:28:28 +00:00
Anders Broman ec8806bc8e Set info col for new messages.
svn path=/trunk/; revision=39787
2011-11-10 21:44:46 +00:00
Anders Broman 06419848af Update HNBAP to V10.1.0 (2011-06)
svn path=/trunk/; revision=39786
2011-11-10 21:38:15 +00:00
Anders Broman 1f9b1347d6 From Martin Kaiser:
RSASSA-PSS support for X.509 certificates.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6541

svn path=/trunk/; revision=39785
2011-11-10 20:52:44 +00:00
Anders Broman c4b976a98f Forgot part of commit 39766.
svn path=/trunk/; revision=39781
2011-11-10 06:14:03 +00:00
Anders Broman 8d28d1d8cb Try to fix defined but not used warnings.
svn path=/trunk/; revision=39766
2011-11-08 19:30:51 +00:00
Chris Maynard 647c5c0b27 packet_info's in_error_pkt is now a bitfield like in_gre_pkt.
svn path=/trunk/; revision=39764
2011-11-08 18:39:11 +00:00
Stephen Fisher 6de2561c69 Fix message_type defined but unused compiler warning/error. There are 3
more problems that I'll mail to -dev.


svn path=/trunk/; revision=39763
2011-11-08 18:15:39 +00:00
Anders Broman 999b8451cb packet-sbc-ap-template.c:138: warning: unused variable 'offset'
svn path=/trunk/; revision=39762
2011-11-08 18:06:18 +00:00
Anders Broman 0e57cff4dc Get rid of set-but-not-used warnings.
svn path=/trunk/; revision=39761
2011-11-08 17:39:01 +00:00
Anders Broman de5f417b99 Add SBc Application Part (SBc-AP) to build.
svn path=/trunk/; revision=39758
2011-11-08 17:28:55 +00:00
Anders Broman ea3cc6ae43 Add SBc Application Part (SBc-AP) dir
svn path=/trunk/; revision=39756
2011-11-08 17:17:05 +00:00
Anders Broman 42a3c77a9f Dissect RIMInformation.
svn path=/trunk/; revision=39733
2011-11-04 17:37:38 +00:00
Anders Broman d1c256002f Handle differences in Camel V2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3911
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6474

svn path=/trunk/; revision=39715
2011-11-02 18:10:34 +00:00
Anders Broman 7669c6affd Export NAEA-CIC to be used by Camel.
svn path=/trunk/; revision=39711
2011-11-02 06:38:46 +00:00
Anders Broman 201d4f3cab Try to fix warnings.
svn path=/trunk/; revision=39690
2011-10-31 17:04:58 +00:00
Stig Bjørlykke be353072dc Added support for big integer64 values.
This fixes bug 6295.

svn path=/trunk/; revision=39666
2011-10-29 18:26:57 +00:00
Anders Broman 32713e84c0 Try to get rid of defined but not used warnings.
svn path=/trunk/; revision=39600
2011-10-26 06:24:05 +00:00
Anders Broman 2d263d571f Try to get rid of "defined but not used" warnings.
svn path=/trunk/; revision=39554
2011-10-25 05:47:07 +00:00
Bill Meier 470032d5cc Fix encoding arg for a proto_tree_add_bitmask() function call.
svn path=/trunk/; revision=39540
2011-10-24 20:18:01 +00:00
Bill Meier b0e7a54741 Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string();
Fix encoding arg.


svn path=/trunk/; revision=39531
2011-10-23 23:13:57 +00:00
Anders Broman b21290e31c Try to get rid of "defined but not used" warnings.
svn path=/trunk/; revision=39523
2011-10-23 20:42:29 +00:00
Anders Broman 4c4b8bb5d2 Try to get rid of "defined but not used" warnings.
svn path=/trunk/; revision=39522
2011-10-23 20:24:23 +00:00
Anders Broman a18ab9b870 From Pascal Quantin.
The attached patch adds the LPPa (LTE Positioning Protocol A) dissector as
specified in 3GPP 36.455 release 9.4.1.
(Part 2)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6478

svn path=/trunk/; revision=39516
2011-10-23 18:05:07 +00:00
Anders Broman 4dcd0ff1e3 From Pascal Quantin.
The attached patch adds the LPPa (LTE Positioning Protocol A) dissector as
specified in 3GPP 36.455 release 9.4.1.
(Just adding the asn1 dir)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6478

svn path=/trunk/; revision=39515
2011-10-23 17:58:45 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 54716c768a Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.
svn path=/trunk/; revision=39491
2011-10-20 14:36:14 +00:00
Anders Broman 24a011d8db Let subdissectors have a stab at the packet even if it's cut short.
svn path=/trunk/; revision=39472
2011-10-19 17:59:47 +00:00
Bill Meier a6e35df202 Do some more conversions of proto_tree_add_item() 'encoding' arg
(previously missed).

svn path=/trunk/; revision=39451
2011-10-18 00:39:20 +00:00
Anders Broman 72beda4d09 From Pascal Quantin.
LTE Positioning Protocol dissector. Add missing file.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6460

svn path=/trunk/; revision=39437
2011-10-16 16:54:44 +00:00
Anders Broman 56c3bd0686 From Pascal Quantin.
LTE Positioning Protocol dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6460

svn path=/trunk/; revision=39436
2011-10-16 16:02:26 +00:00
Bill Meier 11df25e3f8 Windows: Fix and re-enable asn1\t124 build;
svn path=/trunk/; revision=39432
2011-10-15 21:43:46 +00:00
Bill Meier 31abdcb584 Convert asn1 template files proto_tree_add_item() 'encoding' arg for field types FT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. Always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).

svn path=/trunk/; revision=39428
2011-10-15 19:48:19 +00:00
Jeff Morriss 17f77e0597 Build generate_export when building 'all' on Windows too.
svn path=/trunk/; revision=39423
2011-10-14 13:26:32 +00:00
Jeff Morriss b21b495f9f Don't generate the conformance file for exported types when building the
dissector; instead built it only when the separate target (generate_export)
is built.

Built generate_export when building "all".

This prevents the exp_*.cnf files from being regenerated each time another one
of the exp_*.cnf files (which the current dissector depends on) has changed
(despite the fact that the exported types does not depe

Also fix the CLEANFILES definition so it actually cleans things.

svn path=/trunk/; revision=39421
2011-10-14 10:22:01 +00:00
Stig Bjørlykke df5adb7f3c Export MessageSecurityLabel_PDU.
svn path=/trunk/; revision=39414
2011-10-14 07:44:40 +00:00
Stig Bjørlykke 60edd8a0a8 Export ESSSecurityLabel_PDU.
svn path=/trunk/; revision=39413
2011-10-14 07:44:20 +00:00
Anders Broman c20e6b8a25 Dissect NSAP encoded transport layer address.
svn path=/trunk/; revision=39408
2011-10-13 19:41:34 +00:00
Anders Broman 59a363da40 Update the Camel and MAP ASN.1 files.
svn path=/trunk/; revision=39386
2011-10-12 16:41:42 +00:00
Guy Harris dd7e20d472 Update template to match generated dissector - dissector_try_port() is
dead, long live dissector_try_uint().

svn path=/trunk/; revision=39377
2011-10-11 20:19:46 +00:00
Anders Broman 9e1a19bf6f Build the LCS-AP dissector.
svn path=/trunk/; revision=39365
2011-10-11 18:16:53 +00:00
Anders Broman 747cd4100f From Spenser Sheng:
LCS-AP dissector.

svn path=/trunk/; revision=39362
2011-10-11 16:49:18 +00:00
Anders Broman 372a8191bf Make it possible to build custom ASN1 based dissectors on Windows.
svn path=/trunk/; revision=39340
2011-10-10 18:26:33 +00:00
Anders Broman b79dfbe405 Fix unused function warnings
svn path=/trunk/; revision=39338
2011-10-10 17:42:43 +00:00
Jeff Morriss 56a684a625 Fix ASN.1 dissector generation on Windows.
svn path=/trunk/; revision=39337
2011-10-10 14:54:12 +00:00
Jeff Morriss b9c974071c Fix a typo
svn path=/trunk/; revision=39336
2011-10-10 12:54:27 +00:00
Jeff Morriss 454555d42b Don't remove the ASN.1 dissectors when cleaning: we don't (re)build them during the make process yet.
svn path=/trunk/; revision=39335
2011-10-10 12:52:53 +00:00
Jeff Morriss cf012d27b1 Build the ASN.1 dissectors directly into epan/dissectors (rather than building
them and then copying them over).  The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").

asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.

Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.

Fix building of conformance files when doing out-of-source-tree builds.


Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.

svn path=/trunk/; revision=39333
2011-10-10 02:31:11 +00:00
Bill Meier 6142dd287b Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

 Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39332
2011-10-10 01:38:20 +00:00
Anders Broman 8b18a26764 Typo FT_IPv4 isf FT_IPv6.
Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6435

svn path=/trunk/; revision=39297
2011-10-06 19:07:26 +00:00
Anders Broman 83b98f5e2c Add exports
svn path=/trunk/; revision=39296
2011-10-06 18:46:47 +00:00
Bill Meier e2996ceabe Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39294
2011-10-06 16:50:13 +00:00
Bill Meier 594f1efcdd Add missing (presumably) entries for credssp,idmp,t124 & x721.
However: t124 & x721 fail to build on Windows so comment them out.

svn path=/trunk/; revision=39293
2011-10-06 16:43:24 +00:00
Anders Broman 121b7d772e Add a couple of OID strings.
svn path=/trunk/; revision=39274
2011-10-05 18:27:48 +00:00
Bill Meier e18e2694c6 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
     FT_BYTES
     FT_IPV6
     FT_IPXNET
     FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
 

svn path=/trunk/; revision=39263
2011-10-05 02:39:04 +00:00
Anders Broman a17fcee039 From Pascal Quantin:
Add dissection of GERAN related messages.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6427

svn path=/trunk/; revision=39246
2011-10-03 21:15:04 +00:00
Anders Broman 8a324e5737 From Pascal Quantin:
[LTE RRC] Enhance dissection of NeighCellConfig IE.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6412

svn path=/trunk/; revision=39219
2011-10-02 15:08:27 +00:00
Graeme Lunt 5ae8b96dbb Add credssp to subdirs list
svn path=/trunk/; revision=39197
2011-09-30 15:54:32 +00:00
Graeme Lunt 779206012c Microsoft Credential Security Support Provider (CredSSP) support.
Used by direct approach RDP for NTLMSSP authentication under SSL. 



svn path=/trunk/; revision=39196
2011-09-30 15:21:16 +00:00
Anders Broman 0007775464 Make it possible to dissect proprietarry Opcodes.
svn path=/trunk/; revision=39183
2011-09-29 15:23:23 +00:00
Anders Broman 0f2e6c6cc5 Get rid of check_col, while at it set ENC.
svn path=/trunk/; revision=39164
2011-09-27 12:05:32 +00:00
Anders Broman 5f76488f0a Move tvb_new_octet_aligned() to tvbuff.c and use it.
svn path=/trunk/; revision=39150
2011-09-26 15:11:14 +00:00
Gerald Combs 44332d7279 Change the case of "sNMPv2-Trap" to match RFC 3416. Reported by Qiyao.
svn path=/trunk/; revision=39114
2011-09-23 22:44:28 +00:00
Graeme Lunt dc75d97b91 Fix and suppress some warnings
svn path=/trunk/; revision=39072
2011-09-21 10:10:00 +00:00
Stig Bjørlykke 665de07254 Remove Makefile.in
Set default svn:ignore targets.

svn path=/trunk/; revision=39071
2011-09-21 08:44:49 +00:00
Graeme Lunt 947d3c9fa2 Add asn/t124/Makefile to configure.in and remove it from the repository.
svn path=/trunk/; revision=39069
2011-09-21 08:16:33 +00:00
Graeme Lunt 5f332e47e2 Fix for unary minus warning on Windows
svn path=/trunk/; revision=39068
2011-09-21 08:09:04 +00:00
Graeme Lunt 9db6d40656 Basic RDP dissection, which can dissect the connection sequence.
A work in progress.
Can be used with the SSL dissector to decrypt Enhanced RDP Security SSL.
With Standard RDP Security (e.g those on Wiki), the PDUs are all encrypted 
after the SecurityExchange PDU.
Wiki to be updated with an example SSL protected capture and associated
key material.

svn path=/trunk/; revision=39066
2011-09-21 07:35:51 +00:00
Anders Broman e12440d3d0 From Liam Sharp:
In VoIP calls flow/graph display replace GR/GI etc with presentationTokenRequest/Response etc

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6321

svn path=/trunk/; revision=39022
2011-09-16 04:55:58 +00:00
Anders Broman 4d33ad6f6d Fix a typo
svn path=/trunk/; revision=38978
2011-09-12 16:09:36 +00:00
Anders Broman 3aa4c91d03 Update to V10.2.0 (2011-06)
svn path=/trunk/; revision=38972
2011-09-12 13:00:11 +00:00
Anders Broman 98f5d79ee8 Update to V9.6.0 (2011-06)
svn path=/trunk/; revision=38971
2011-09-12 12:48:00 +00:00
Anders Broman 71fc5eca2a From Liam Sharp:
VoIP Calls->Graph TCS and OLC display corruption.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6318

svn path=/trunk/; revision=38970
2011-09-12 08:37:36 +00:00
Anders Broman 7a0cb7ea93 from Liam Sharp:
Info column to show subMessageIdentifier type strings for H245/H.239 packets

With a change to remove "subMessageIdentifer=" as I think that clutters up the Infocol.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6315

svn path=/trunk/; revision=38968
2011-09-12 06:02:43 +00:00
Anders Broman 900484d992 From Pascal Quantin:
Update of 3GPP RRC and LTE RRC dissectors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6333

svn path=/trunk/; revision=38964
2011-09-11 19:09:02 +00:00
Anders Broman fa889d6d78 From Liam Sharp:
(Standard)H.239 – subMessageIdentifier value strings missing from H245 dissector.
Modified to be filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6312

svn path=/trunk/; revision=38897
2011-09-06 15:05:26 +00:00
Anders Broman 780acd9931 From Fredrik Kuivinen:
Fix a problem with dissection of HandoverRequest.

svn path=/trunk/; revision=38776
2011-08-29 14:47:20 +00:00
Jeff Morriss 339136d1d0 Based on patch from Denis Ovsienko via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 :

Fix typo: s/unkown/unknown/

svn path=/trunk/; revision=38561
2011-08-16 13:16:33 +00:00
Chris Maynard 352cc7a410 Fix bug 5848, "https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848", which was apparently introduced with r27287 (http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-h225.c?r1=26698&r2=27287). Regenerate the packet-h225.c dissector. Patch from ericn1234@yahoo.com.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848

svn path=/trunk/; revision=38399
2011-08-07 20:50:31 +00:00
Anders Broman 4b0961fb7a Bug 6146 - Malformed RANAP packets when HandOver procedure on iuh
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6146

svn path=/trunk/; revision=38312
2011-08-02 16:47:37 +00:00
Chris Maynard b25c098e0c From Paul Stath via bug 5731: The check for engineID length should only occur if the engineID has a non-zero length.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5731

svn path=/trunk/; revision=38303
2011-08-02 01:54:03 +00:00
Anders Broman 7439bba9dc Try to do a more syntactically correct import.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6150

svn path=/trunk/; revision=38159
2011-07-21 22:46:07 +00:00
Martin Mathieson 7d7f7d870e Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP.
svn path=/trunk/; revision=38131
2011-07-20 12:19:22 +00:00
Stig Bjørlykke ba2aae0f8e Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.
svn path=/trunk/; revision=38122
2011-07-19 18:48:31 +00:00
Stig Bjørlykke f282154ab0 Use correct encoding for proto_tree_add_item().
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Graeme Lunt 9e4afbfd49 Update the algorithms in line with RFC 5912 including support for eliptic curve algorithms.
svn path=/trunk/; revision=38017
2011-07-14 13:47:13 +00:00
Graeme Lunt f8a7d85e1c Update to correct the definition of the clearance attribute used in certificates.
RFC3281 erroneously defined the Clearance attribute to be different to that defined in X.509. This has been recognised and corrected in RFC5755.
The RFC3281 syntax is retained and registered as the "RFC3281Clearance" syntax, which can be used to override the correct syntax in the BER oidtables if necessary.


svn path=/trunk/; revision=38014
2011-07-14 08:47:05 +00:00
Anders Broman a5839116d3 Pretyfy APN display and make it filterable as a string.
svn path=/trunk/; revision=37731
2011-06-20 10:29:46 +00:00
Anders Broman 2477298026 From Sean Van Gorder:
When Wireshark attempts to read an SNMP packet with a variable-bindings item
with an OID containing an index string which includes an entry of type
"Unsigned32", Wireshark will stop dissecting the packet at this index entry and
end with the error:

[Dissector bug, protocol SNMP: proto.c:2761: failed assertion
"DISSECTOR_ASSERT_NOT_REACHED"]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5883

svn path=/trunk/; revision=37558
2011-06-05 20:12:44 +00:00
Stig Bjørlykke 51864807b3 Corrected "old-style function definition".
svn path=/trunk/; revision=37433
2011-05-27 11:03:04 +00:00
Stig Bjørlykke 7b5896a179 Corrected "old-style function definition".
svn path=/trunk/; revision=37429
2011-05-27 10:18:17 +00:00
Jeff Morriss f3f9f2697f Make TVBs opaque for most users.
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
2011-05-27 03:06:50 +00:00
Jeff Morriss 7ad71a2d78 Treat TVBs as opaque: use the accessor functions instead of accessing the fields
directly.

svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
Gerald Combs d16058dd8c Remove a backslash.
svn path=/trunk/; revision=37395
2011-05-25 18:09:04 +00:00
Anders Broman 84a22ed17e Make it easier to add custom asn1 dissectors.
svn path=/trunk/; revision=37393
2011-05-25 14:21:42 +00:00
Jeff Morriss 80c1ef3811 Fix a couple (value) mistakes in value_strings. Found by Martin's patch on the -dev list.
svn path=/trunk/; revision=37259
2011-05-18 20:06:17 +00:00
Stig Bjørlykke a10ffa4ceb Build with S1AP-SonTransfer-IEs.asn
svn path=/trunk/; revision=37117
2011-05-13 07:51:27 +00:00
Stig Bjørlykke 624a041e6f Indicate Signed Receipt in info column.
svn path=/trunk/; revision=37074
2011-05-12 11:06:42 +00:00
Jeff Morriss a80a391b0e From Ed Day via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5890 :
ASN.1 files in trunk/asn1/qsig contain syntax errors that prevent them from
being compiled by a standard ASN.1 compiler.  A patch of modified files is
attached along with General-Error-List.asn which was missing completely.

From me: add the new asn file to the list of source files.  Add SVN Id tag to
the new file.

svn path=/trunk/; revision=37005
2011-05-06 01:47:16 +00:00
Anders Broman 16c0bcbdee From Pascal Quantin:
Add an expert check for the MS Classmark 2 decoding in UE EUTRA Capability message and a few missing message type display in the column text.

svn path=/trunk/; revision=36984
2011-05-04 17:24:48 +00:00
Anders Broman e0c80c4138 From Pascal Quantin:
the dissection of the UE capabilities when the RAT
type is set to geran-cs (the value part of Classmark 2 starts at the third byte). 
Moreover it adds a subtree to enhance the display of Mobile Station Classmark 2 and 3 and MS Radio Access Capability IEs.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5867

svn path=/trunk/; revision=36943
2011-04-28 19:59:14 +00:00
Jeff Morriss 9be16e49c4 From Stefan Metzmacher and Gregor Beck via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 :
The smallest LDAP PDU is 7 bytes, not 4.

svn path=/trunk/; revision=36777
2011-04-21 19:51:05 +00:00
Alexis La Goutte ec7709406e Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36771
2011-04-21 16:00:38 +00:00
Alexis La Goutte 7239db18ec Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36760
2011-04-21 13:34:22 +00:00
Stephen Fisher fcfcfa347c Rollback r36614 and change dissect_SMUX_PDUs_PDU() to use previously
unused smux_tree instead of tree.  Per suggestion from Stig on -dev.


svn path=/trunk/; revision=36624
2011-04-13 15:48:24 +00:00
Stephen Fisher 4b416d92d0 Fix Coverity 524: NEGATIVE_RETURNS
Coverity sees that two calls to tvb_length_remaining() with an offset
of 0 may return -1 (for an "out of bounds" condition), which would lead
to an assignment of -1 to an unsigned variable and then passing it
to functions further down that cannot accept negative values.

Use tvb_ensure_length_remaining() to throw an exception in a case of
out of bounds access (though unlikely with an offset of 0) instead of
tvb_length_remaining(), which would return -1.


svn path=/trunk/; revision=36615
2011-04-12 22:23:03 +00:00
Stephen Fisher ce2eea5b95 Fix Coverity 1047: UNUSED_VALUE in dissect_smux
svn path=/trunk/; revision=36614
2011-04-12 22:12:05 +00:00
Gerald Combs ca01b3a876 Add x509if_frame_end() which is passed to register_frame_end_routine()
and which resets our global variables. Remove a boolean which was used
to track a char *; just check if the pointer is NULL instead. Fixes bugs
5754 and 5793, hopefully without breaking anything.

svn path=/trunk/; revision=36608
2011-04-12 20:39:48 +00:00
Stig Bjørlykke b862371815 Removed some unused variables.
svn path=/trunk/; revision=36602
2011-04-12 19:06:51 +00:00
Stig Bjørlykke 42f41ddf0b Corrected switch-case flow.
Coverity 1184.

svn path=/trunk/; revision=36579
2011-04-12 09:05:43 +00:00
Guy Harris 4fdcc5c180 Rename ws_stat to ws_stat64, and make it take a pointer to a ws_statb64
as an argument, along the lines of ws_fstat64, and, on Windows, make it
use _wstati64, to handle 64-bit file sizes.

svn path=/trunk/; revision=36547
2011-04-10 20:59:10 +00:00
Anders Broman 842d4ff53e From Pascal Quantin:
A patch adding the missing hunks (it looks like extract_asn1_from_spec.pl script is mixing Windows and Linux line endings).

svn path=/trunk/; revision=36524
2011-04-08 19:54:07 +00:00
Anders Broman da3f7673db From Pascal Quantin:
Upgrade LTE RRC ASN.1 description to V9.6.0

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5815

svn path=/trunk/; revision=36520
2011-04-08 17:36:53 +00:00
Gerald Combs f989235a87 Use a unique variable name. Fixes Coverity CID 593.
svn path=/trunk/; revision=36512
2011-04-07 23:52:37 +00:00
Anders Broman c039f9f8a8 Add a comment
svn path=/trunk/; revision=36490
2011-04-06 06:24:19 +00:00
Anders Broman cb0e7f80da Missing decoding for CalledPartyBCD number in CAMEL
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5788

svn path=/trunk/; revision=36488
2011-04-06 06:20:32 +00:00
Stig Bjørlykke c13f84b345 Compile fix: camel_obj_id -> obj_id.
svn path=/trunk/; revision=36475
2011-04-05 15:49:56 +00:00
Anders Broman 909a166343 Actually get the oid string ...
svn path=/trunk/; revision=36474
2011-04-05 15:43:15 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman e645e3c4d0 -Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

svn path=/trunk/; revision=36435
2011-04-02 09:18:18 +00:00
Anders Broman 129f07a949 Added FALLTHRU comment to avoid a "missing break" warning.
svn path=/trunk/; revision=36365
2011-03-27 14:02:42 +00:00
Jeff Morriss cc6fc23812 From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)

A couple of the patches had to be manually applied.

From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)

svn path=/trunk/; revision=36332
2011-03-25 19:02:18 +00:00
Gerald Combs 670d38ec71 Properly initialize our filter counters.
svn path=/trunk/; revision=36190
2011-03-14 16:00:51 +00:00
Anders Broman 675d79871e Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID
svn path=/trunk/; revision=36130
2011-03-03 07:20:34 +00:00
Tomas Kukosa 16bdcb2fbe QSIG: decoding of PSS1InformationElement
svn path=/trunk/; revision=36108
2011-03-01 13:01:26 +00:00
Gerald Combs 91fe31c9b4 If we encounter an excessively long filter string or one with too many
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.

svn path=/trunk/; revision=36101
2011-03-01 00:50:17 +00:00
Anders Broman 8ec8d3fcc3 Export:
SONtransferRequestContainer
SONtransferResponseContainer
SONtransferCause

svn path=/trunk/; revision=36086
2011-02-27 21:55:35 +00:00
Anders Broman 23e6582724 Add miisng file from
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36079

svn path=/trunk/; revision=36085
2011-02-27 19:41:34 +00:00
Anders Broman da8918838e Add dissection of SonTransfer-IEs.
svn path=/trunk/; revision=36084
2011-02-27 19:40:30 +00:00
Anders Broman a1e94e7e68 Export SourceCellID.
svn path=/trunk/; revision=36083
2011-02-27 19:39:07 +00:00
Anders Broman 527942b05a Add exports.
svn path=/trunk/; revision=36049
2011-02-24 15:06:16 +00:00
Gerald Combs 4783795690 Split get_dns_name() into get_dns_name() and expand_dns_name().
In dissect_ms_compressed_string() dissect_mscldap_string() simply call
expand_dns_name() instead of using duplicate (and insecure) code. This
*might* break CLDAP and SMB dissection. If that's the case we should
probably revert get_dns_name() and simplify expand_dns_name().

Fixes infinite recursion errors found by joernchen of Phenoelit.

svn path=/trunk/; revision=36029
2011-02-23 00:51:02 +00:00
Stig Bjørlykke d9ef8f9ad1 Ensure we always have a valid top_tree for p1.content. This fixes a problem
with other dissectors using p1.content, such as p7.

Reset global content_type_id so this will be correct in more cases.
This is still not a good solution, because ContentType and Content are
generic objects which may occur individual in P7.

Indicate when to report invalid content-type.

svn path=/trunk/; revision=36025
2011-02-22 10:23:44 +00:00
Stig Bjørlykke 5868c7d026 Renamed x411 to p1, x420 to p22 and s4406 to p772 to be consistent
on the naming policy for X.400 protocols.

svn path=/trunk/; revision=36013
2011-02-20 17:03:29 +00:00
Stig Bjørlykke 2025f2e5f5 Add changes in r35546 to template and conformation file.
svn path=/trunk/; revision=36010
2011-02-20 15:05:21 +00:00
Stig Bjørlykke 632dcd0d77 Add changes in r35384 to template file.
svn path=/trunk/; revision=36009
2011-02-20 15:03:09 +00:00
Stig Bjørlykke d3051fa55d Generate correct type (FT_OID) for "x420.compression_algorithm_id".
I suspect this should have been fixed in asn2wrs...

svn path=/trunk/; revision=35965
2011-02-16 11:04:28 +00:00
Jeff Morriss 21cf6ff3ce Remove an unused ett_ variable.
svn path=/trunk/; revision=35927
2011-02-12 03:51:12 +00:00
Chris Maynard 8d47cebd00 Declare ett's as gint, not guint.
svn path=/trunk/; revision=35902
2011-02-10 20:55:26 +00:00
Stig Bjørlykke 1ba57f4c04 Added a dissector table for AttributeId localForm.
Use correct object identifier in ModificationList.

svn path=/trunk/; revision=35894
2011-02-10 10:11:38 +00:00
Anders Broman 553cf70a68 Dissect V1 version , found in trace from:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637

svn path=/trunk/; revision=35843
2011-02-07 17:44:34 +00:00
Anders Broman 55f45d5266 Add a missing IE found in trace from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637
svn path=/trunk/; revision=35842
2011-02-07 17:43:26 +00:00
Anders Broman 01ef9f73ef Remove debug printouts.
svn path=/trunk/; revision=35834
2011-02-05 14:37:52 +00:00
Anders Broman b723ccb30c Introduce preferences to set the strictness of Invoke/response
tracking.

svn path=/trunk/; revision=35822
2011-02-04 16:12:59 +00:00
Anders Broman 06e619bf42 If ENBname is text, append the text.
svn path=/trunk/; revision=35808
2011-02-04 09:38:36 +00:00
Anders Broman 6b38bce9c6 Hope fully this will be the correct set of files - finally.
svn path=/trunk/; revision=35781
2011-02-03 16:17:10 +00:00