Commit Graph

778 Commits

Author SHA1 Message Date
Anders Broman 54a76ee6d0 Complete clean targets
svn path=/trunk/; revision=18999
2006-08-22 20:39:20 +00:00
Anders Broman 4e72c1ca2f From Florent Drouin:
This patch introduce the decoding of the RP-Cause element in the Release SMS message for Camel.

svn path=/trunk/; revision=18986
2006-08-21 21:58:30 +00:00
Ronnie Sahlberg 93c3a4026b prettify the MMS dissector by at least putting the pdu name in the info column
svn path=/trunk/; revision=18975
2006-08-21 13:44:37 +00:00
Ronnie Sahlberg ce1ae65e12 from Angel de Juan
make mms bitstrings easier to read


--
Hi, this is my new mms with some changes in order to display some data in
binary instead of hex.

Excuse me because is not a diff from the repository, but I don't know how to
create a diff.

I also have the compiled packet-mms.c and packet-mms.h if you want it only
mail me.



svn path=/trunk/; revision=18974
2006-08-21 13:32:07 +00:00
Anders Broman 43d1b4c099 Dissect some more H.245 messages in MEGACO
svn path=/trunk/; revision=18966
2006-08-20 21:18:43 +00:00
Ronnie Sahlberg cf6d4692aa in LDAP over TCP
use tcp_dissect_pdus() which works    insterad of trying to do the pdu tracking and signalling for reassembly manually.
This makes ldap pdu tracking and reassembly work properly for cases when hosts are streaming lpad over tcp and there is little or none alignlemt of pdus to the start of a segment



svn path=/trunk/; revision=18965
2006-08-20 06:00:16 +00:00
Guy Harris 338f7ede99 Squelch a compiler warning.
svn path=/trunk/; revision=18954
2006-08-19 02:56:16 +00:00
Tomas Kukosa 5ff34d332b - add value_ptr into struct _asn1_ctx_t
- small changes in h225.cnf
- H.225 regenerated

svn path=/trunk/; revision=18923
2006-08-16 08:07:30 +00:00
Ronnie Sahlberg 8ce8e719e0 rename some structures and defines from the se_tree to the emem_tree prefix
svn path=/trunk/; revision=18894
2006-08-14 08:29:29 +00:00
Ronnie Sahlberg 5f8e067936 for sec descriptors found inside ldap
decode the specific bits of the accessmask as the ldap specific accessmask bits

bit definitions from samba4


svn path=/trunk/; revision=18881
2006-08-11 07:59:58 +00:00
Jörg Mayer c41a346570 Fix some typos the prevented make distdir from succeeding
svn path=/trunk/; revision=18873
2006-08-10 11:37:24 +00:00
Jörg Mayer 76b9953baa Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1014
provided by markdrago@mail.com.

Me: Patch template files instead and regenerate the dissector files.
    Fix Makefiles to use the correct asn filenames.

svn path=/trunk/; revision=18866
2006-08-10 09:02:24 +00:00
Anders Broman 94c402d671 Routines for Universal Mobile Telecommunications System (UMTS) Radio Resource Control (RRC) (umts_rrc) dissection.
svn path=/trunk/; revision=18855
2006-08-08 21:32:44 +00:00
Ronnie Sahlberg 8969e45027 marik the request_in/response_to/time as generated fields
svn path=/trunk/; revision=18846
2006-08-07 10:35:26 +00:00
Ronnie Sahlberg 5a5dcdc8ad dissect nTSecurityDescriptor attribute as a security descriptor
svn path=/trunk/; revision=18845
2006-08-07 10:29:39 +00:00
Ronnie Sahlberg 5823354433 objectSid attribute contains a sid so decode it nively as a sid
svn path=/trunk/; revision=18844
2006-08-07 10:19:37 +00:00
Ronnie Sahlberg 2d5ec44674 add some more oid's
svn path=/trunk/; revision=18843
2006-08-06 14:31:58 +00:00
Ronnie Sahlberg b446810939 the ldap values for supportedControl and supportedCapabilities is an oid in ascii format.
resolve it into a anme if possible and present it.




svn path=/trunk/; revision=18842
2006-08-06 14:04:07 +00:00
Ronnie Sahlberg 3ef9bcfa26 "objectGUID" should be dissected as a GUID
also change the name of one of the strings we keep around since it is more generic than just used for attributeassertions



svn path=/trunk/; revision=18841
2006-08-06 13:13:42 +00:00
Ronnie Sahlberg f01fcc9369 fropm martin m
fix for h450 to prevent an assertion for uninitialized hffields



Thanks for the capture, Keith.  The problem was with h450 hf fields that
weren't initialised sucessfully (at all in one case, or with non-unique
filter strings in several others) - it was hitting an assertion in proto.c
when an attempt was made to use those fields.

I was able to test by editing packet-h450.c directly, I couldn't regenerate
it from packet-h450-template.c.  I'm attaching a patch to
packet-h450-template.c that hopefully does the same thing.  If someone can
generate and check it packet-h450.c in for me I'll retest.



svn path=/trunk/; revision=18804
2006-07-28 07:50:05 +00:00
Tomas Kukosa 2b4d003c06 H.225.0 update to version 6 (05/2006)
H.245 updated to version 13 (05/2006)

svn path=/trunk/; revision=18779
2006-07-21 07:05:39 +00:00
Gerald Combs d4819d4690 Make sure our strings aren't null before we pass them to strncmp().
svn path=/trunk/; revision=18723
2006-07-12 18:12:15 +00:00
Ronnie Sahlberg ed3e02ed61 prettify dissection od ldap attributes
special case some common special attributes such as DomainSid and DomainGuid
and dissect them as SIDs and GUIDs

examples of these special attributes can be seen in Xiaoguang Liu's email to wireshark dev



svn path=/trunk/; revision=18719
2006-07-12 09:02:00 +00:00
Anders Broman 3094096ae4 Decode RANAP in LongSignalInfo and RadioResourceInformation.
svn path=/trunk/; revision=18718
2006-07-11 19:46:52 +00:00
Gerald Combs e212e73354 Reset ldm_tree in dissect_ldap_pdu(). Fixes a couple of the current fuzz
bugs.

svn path=/trunk/; revision=18697
2006-07-10 13:42:59 +00:00
Gerald Combs d55ec3bd66 Fix compilation on systems with Net-SNMP.
svn path=/trunk/; revision=18695
2006-07-10 01:05:24 +00:00
Gerald Combs 8b315480f1 In new_format_oid(), handle a zero-length OID.
Fix a bug introduced recently in packet-rpc.c.

Replace DISSECTOR_ASSERT() with THROW(ReportedBoundsError) in my recent 
checkins, since fuzz-test.sh sets WIRESHARK_ABORT_ON_DISSECTOR_BUG.

svn path=/trunk/; revision=18693
2006-07-09 22:12:02 +00:00
Jörg Mayer ba62d2e1b3 include packet-cdt.h to declare prototypes
svn path=/trunk/; revision=18689
2006-07-09 11:18:13 +00:00
Jörg Mayer 896cdfd261 propset ....
svn path=/trunk/; revision=18680
2006-07-07 10:47:18 +00:00
Gerald Combs 1f4873db0b Add the asn1 directory to the distribution.
svn path=/trunk/; revision=18676
2006-07-06 22:34:41 +00:00
Gerald Combs de826c3425 Don't pass an empty OID to sprint_realloc_variable(). This should fix a
recent fuzz error.

Fix up whitespace.

svn path=/trunk/; revision=18667
2006-07-05 21:30:25 +00:00
Gerald Combs 3ec4dc74e8 Fix a format string bug. This should fix some of the current fuzz
crashes.

svn path=/trunk/; revision=18666
2006-07-05 19:14:59 +00:00
Tomas Kukosa 956dcf3ca0 get rid of warning message
svn path=/trunk/; revision=18653
2006-07-04 09:02:26 +00:00
Tomas Kukosa c333c6b5bd few formal changes in PER dissector (rename asn_* types to asn1_* ones)
svn path=/trunk/; revision=18652
2006-07-04 06:49:53 +00:00
Ronnie Sahlberg b9ee7a9b4f replace the two remaining g_malloc with ep_alloc
this indirectly fixes a tiny memory leak with one of the g_mallocs



svn path=/trunk/; revision=18649
2006-07-04 03:27:14 +00:00
Ronnie Sahlberg 45cb7d3fab check_var_length can also return ewp allocated memory now
svn path=/trunk/; revision=18648
2006-07-04 03:15:58 +00:00
Ronnie Sahlberg 889fe1c6fe make new_format_oid return ep allocated data.
this also removes several small memory leaks through get_oid_name and get_oid_str_name where the callers nevber freed the data





svn path=/trunk/; revision=18647
2006-07-04 02:36:18 +00:00
Ronnie Sahlberg c27681ad4d make format_oid use ep allocated memory internally instead of malloced memory
svn path=/trunk/; revision=18645
2006-07-04 02:15:55 +00:00
Ronnie Sahlberg 69ccdaa778 make format_var return ep allocated memory
svn path=/trunk/; revision=18644
2006-07-04 01:56:52 +00:00
Tomas Kukosa 6ceb7937bc remove name field from per_sequence_t structure, it can be retrieved from field information
svn path=/trunk/; revision=18637
2006-07-03 07:03:57 +00:00
Guy Harris fa10d33734 Include <epan/oid_resolv.h> to declare get_oid_str_name().
svn path=/trunk/; revision=18627
2006-07-01 00:11:49 +00:00
Tomas Kukosa ba9d5cd625 fix wrong terminator record in per_sequence_t tables
svn path=/trunk/; revision=18621
2006-06-30 10:18:25 +00:00
Ronnie Sahlberg d0aae6dd3e from metze
prettify dissection of filters containing substring and extensiblematch



svn path=/trunk/; revision=18617
2006-06-29 21:04:37 +00:00
Anders Broman 18c69d17b0 Add a heuristic table to SUA (SUA and SCCP should share the same table) to heuristically
dissect RANAP ower SUA.

svn path=/trunk/; revision=18616
2006-06-29 20:39:53 +00:00
Tomas Kukosa 9be9eb8e14 use "type function" instead of "field function" in PER CHOICE and SEQUENCE tables
it matches asn2wrs approach and makes generated dissectors source shorter

svn path=/trunk/; revision=18612
2006-06-29 15:26:41 +00:00
Gerald Combs 835afe4a96 Reset ldm_tree to NULL each time we dissect an LDAP packet. This should
fix a current Buildbot crash.  Fix up whitespace.

svn path=/trunk/; revision=18601
2006-06-28 22:07:23 +00:00
Graeme Lunt 832136aee8 Support for the acp127-notification-request extension.
svn path=/trunk/; revision=18599
2006-06-28 19:31:49 +00:00
Graeme Lunt 5f1d7923bf Support for the message-token, proof-of-delivery and recipient-certificate p1 envelope extensions.
Patch for unknown built-in content type.


svn path=/trunk/; revision=18598
2006-06-28 19:07:10 +00:00
Tomas Kukosa 56d7db0c08 remove functions register_ber_oid_name() and get_ber_oid_name() from packet-ber.c, they were only OID but not BER related
use add_oid_str_name() and get_oid_str_name() instead of them

svn path=/trunk/; revision=18595
2006-06-28 14:19:08 +00:00
Tomas Kukosa 7d9564c459 few OID names
svn path=/trunk/; revision=18590
2006-06-28 06:50:39 +00:00
Ronnie Sahlberg 946a39d4fc the dissector for AssertionValue that is implemented in the template file
did not check the implicit_tag flag and caused extensiblematch filters to show up as malformed packets.




svn path=/trunk/; revision=18540
2006-06-22 10:29:49 +00:00
Tomas Kukosa 98d7d92661 - change ETH_VAR to WS_VAR
- preparation for tagged type support

svn path=/trunk/; revision=18525
2006-06-20 19:54:28 +00:00
Gerald Combs f7e38bd5e6 Change ETH_VAR_IMPORT to WS_VAR_IMPORT. Try to fix a duplicate variable
definition in the Catapult DCT2000 code.

svn path=/trunk/; revision=18524
2006-06-20 18:30:54 +00:00
Anders Broman c72d4e8f2e From Albert Chin:
Fix some C++ comments in C source files and fixes some non-constant initializations.

svn path=/trunk/; revision=18521
2006-06-20 05:57:29 +00:00
Anders Broman c213f73ab0 Port the ssn range setting stuff.
svn path=/trunk/; revision=18505
2006-06-17 16:19:23 +00:00
Guy Harris 2d20359c26 Include <epan/dissectors/packet-tcp.h> to declare tcp_dissect_pdus().
svn path=/trunk/; revision=18483
2006-06-16 07:18:25 +00:00
Anders Broman e803b5cefa Fix BUG 971 Facility IE dissection error in GSM_DTAP.
svn path=/trunk/; revision=18476
2006-06-15 21:12:47 +00:00
Tomas Kukosa f0f319acf1 - BER_MAX_OID_STR_LEN removed and replaced with MAX_OID_STR_LEN
- x411 and dop regenerated
- dissect_ber_tagged_type() prepared (support in asn2wrs will follow)

svn path=/trunk/; revision=18468
2006-06-15 07:46:07 +00:00
Anders Broman 012f0c5f73 RANAP:
Handle the case where length is two octets.

SS-Operations.asn - cosmetict change.

svn path=/trunk/; revision=18466
2006-06-15 05:40:21 +00:00
Ronnie Sahlberg 2f95f76a1e fix tcp reassembly to work again for
ldap   and ldap+sasl


remove a recent ber length validation in packet-ber.c that cant work and breaks reassembly  and also makes all ber pacvket sspanning multiple segments show up as malformed packets.



svn path=/trunk/; revision=18465
2006-06-14 11:51:25 +00:00
Jörg Mayer 392e584e1e Include <ctype.h> to fix some warnings. Regenerate the
dissector.

svn path=/trunk/; revision=18461
2006-06-14 08:08:51 +00:00
Tomas Kukosa a063a87af5 - "next tvb" list moved from h225 to new file next_tvb.[ch]
- h225 updated and regenerated
- restore calling subdissectors for SNMP variables which was broken with new SNMP

svn path=/trunk/; revision=18451
2006-06-13 13:21:12 +00:00
Ronnie Sahlberg f3c5f96124 from metze
make the display of the filters more similar to how the ldap c api represents
filters and how they are commonly represented in documentation and other texts.




svn path=/trunk/; revision=18449
2006-06-13 07:44:37 +00:00
Guy Harris 6d2e9ee5f7 Constify to fix compiler warnings.
Check for printable ASCII - 0x7F is >= 0x20, but it's not printable, and
0x80 through 0xFF aren't ASCII.

Note that we should perhaps be using RFC 2252-style schemas to figure
out which attribute and assertion values are text and which are binary.

svn path=/trunk/; revision=18447
2006-06-13 05:39:55 +00:00
Anders Broman f51e366267 Fix some warnings.
svn path=/trunk/; revision=18445
2006-06-12 21:48:51 +00:00
Ronnie Sahlberg b501e15fe9 prettify dissection of LDAP search filters.
svn path=/trunk/; revision=18431
2006-06-12 08:30:07 +00:00
Ronnie Sahlberg 452226586d rework the previous patch slightly since we really need to push a string upward to our callers to be able to generate and display nice filter expressions on the top line as the original ldap dissectopr did
svn path=/trunk/; revision=18421
2006-06-10 06:48:09 +00:00
Ronnie Sahlberg fcf198a69d add simple heuristics to the decoding of assertionvalues to make it display ascii strings as ascii and binary data as hex bytes
svn path=/trunk/; revision=18420
2006-06-10 05:07:42 +00:00
Ronnie Sahlberg 5e49882844 make CLDAP show up as CLDAP in the dissectyion tree and not as LDAP
this also makes the "cldap" filter work


svn path=/trunk/; revision=18419
2006-06-10 04:29:26 +00:00
Guy Harris 3d93d3f99c Mark "inap.tcap.itu_ssn" and "inap.tcap.itu_ssn1" as obsolete
preferences, so we don't warn about them, we just silently discard them.

svn path=/trunk/; revision=18418
2006-06-10 00:26:48 +00:00
Tomas Kukosa a12a5a7148 uncomment newly supported TYPE-IDENTIFIER usage and per regeneration
svn path=/trunk/; revision=18339
2006-06-05 06:52:50 +00:00
Anders Broman 770777bd17 dissect_geographical_description updates.
svn path=/trunk/; revision=18318
2006-06-02 16:58:22 +00:00
Anders Broman 2143fccee3 Correct dissect_geographical_description.
svn path=/trunk/; revision=18307
2006-06-02 05:02:54 +00:00
Anders Broman 6471c00a55 From Cvetan Ivanov:
H225.cnf
I noticed is that the voip call flow graph does not have a label for the setupAck packet. I traced this to the empty frame_label.

voip_calls.c
It seems to me that in gtk/voip_calls.c tmp_h323info->guid is pointer itself, therefore: 
memcmp(&tmp_h323info->guid 
should in fact read: 
memcmp(tmp_h323info->guid

svn path=/trunk/; revision=18304
2006-06-01 20:19:51 +00:00
Anders Broman ed5e8f550c Complete reasembly code.
svn path=/trunk/; revision=18279
2006-05-31 20:22:51 +00:00
Tomas Kukosa 9b2a95f2d4 H.245 update to version 12 (10/2005)
svn path=/trunk/; revision=18262
2006-05-31 07:33:47 +00:00
Anders Broman 16f57a74c6 Add some missing *-exp-cnf files
svn path=/trunk/; revision=18261
2006-05-31 04:52:33 +00:00
Anders Broman c510c6118e Preparations for reassembly. Currently there is a problem with the rrlp dissector...
svn path=/trunk/; revision=18258
2006-05-30 20:52:43 +00:00
Tomas Kukosa 667fed5915 - h225.asn renamed to H323-MESSAGES.asn
- h245.asn renamed to MULTIMEDIA-SYSTEM-CONTROL.asn
- rollback changes in .asn sources to keep them in original ITU-T form and put necessary changes into .cnf files
- PER dissectors regenerated

svn path=/trunk/; revision=18238
2006-05-29 13:06:44 +00:00
Anders Broman c20d559c91 Fix bug 973:
While in 3GPP spec, the last two (Down/up nextPDCP-PDU seq. no.) would be 2 
BYTES. So ethreal could not read the message correctly. We have to modify the 
log to make Ethreal analysis it.

Add disection of TargetID.

svn path=/trunk/; revision=18228
2006-05-27 22:09:07 +00:00
Tomas Kukosa 604000a6b3 - remove some #.MODULE_IMPORT from .cng files
- regenerate BER dissectors so as to change rest of Ethereal->Wireshark and asn2eth -> asn2wrs

svn path=/trunk/; revision=18217
2006-05-24 12:24:54 +00:00
Anders Broman d17dad9ead Atempt to fix bug 967 crash on fuzzed SNMP capture. I can't reproduce the Bug.
svn path=/trunk/; revision=18216
2006-05-23 20:36:49 +00:00
Tomas Kukosa 55600fb60a Ethereal -> Wireshark
asn2eth -> asn2wrs

svn path=/trunk/; revision=18214
2006-05-23 15:17:14 +00:00
Tomas Kukosa 8bb127d1c1 change rules so as not to have each dissector twice in 'all:' and 'per:'/'ber:'
svn path=/trunk/; revision=18213
2006-05-23 14:30:05 +00:00
Tomas Kukosa fbd2a3fe3e - fix bugs in dissect_per_octet_string() introduced with unaligned variant
- step to new ASN.1 API - pass asn_ctx_t* through PER dissectors instead of packet_info*
- PER ALIGNED/UNALIGNED flag moved to asn_ctx_t
- PER created tree item pointer moved to asn_ctx_t
- add nbap into PER dissectors in asn1/Makefile.nmake
- use add_oid_str_name() instead of register_ber_oid_name() in H.225 and H.245
- export asn_ctx_init from library
- PER dissectors regenerated

svn path=/trunk/; revision=18209
2006-05-22 11:49:50 +00:00
Ronnie Sahlberg 6075ec39fb ethereal->wireshark
svn path=/trunk/; revision=18207
2006-05-22 08:21:22 +00:00
Ronnie Sahlberg f0b33a4789 ethereal->wireshark updates
svn path=/trunk/; revision=18206
2006-05-22 08:14:01 +00:00
Tomas Kukosa 62da958bd9 - asn2eth renamed to asn2wrs
- remove obsolete -X option from makefiles
- not generate enumerated map table for BER

dissector will be regenerated later

svn path=/trunk/; revision=18199
2006-05-21 14:36:05 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Anders Broman 86d8177cc1 Decode Ext-GeographicalInformation.
svn path=/trunk/; revision=18182
2006-05-17 20:09:48 +00:00
Anders Broman aefbf4ab72 Fix decoding of Ext-GeographicalInformation.
svn path=/trunk/; revision=18181
2006-05-17 19:30:57 +00:00
Anders Broman 622f6d8922 PER:
Adapt dissect_per_octet_string to unaligned PER.
Call rrlp dissector from ulp dissector. 

svn path=/trunk/; revision=18176
2006-05-16 22:00:18 +00:00
Anders Broman 7f033bd485 PER Enumerated is working now.
svn path=/trunk/; revision=18165
2006-05-15 20:21:33 +00:00
Guy Harris aa4b59de6f Don't throw an exception in oid_to_subid_buf() if the generated OID is
zero-length - oid_to_subid_buf() can be called when we're not in the
middle of a dissection, and throwing a "dissector bug" assertion in that
case is itself a bug.

svn path=/trunk/; revision=18164
2006-05-15 17:58:39 +00:00
Tomas Kukosa 31547dee95 regenerated with new asn2eth
svn path=/trunk/; revision=18158
2006-05-15 06:36:17 +00:00
Tomas Kukosa 726820fd03 updated to H.235.0:09/2005 and H.235.8:09/2005
svn path=/trunk/; revision=18157
2006-05-15 06:32:01 +00:00
Tomas Kukosa aada0116b7 H.225, H.245, H.450 regenerated with new asn2eth
svn path=/trunk/; revision=18156
2006-05-15 06:27:53 +00:00
Anders Broman e49fe267e6 Remove stupid code.
svn path=/trunk/; revision=18148
2006-05-14 08:17:39 +00:00
Anders Broman 396a33dbee snmp: Hopfully fix bug Bug 925.
Add packet-ulp.c missing from last commit.

svn path=/trunk/; revision=18144
2006-05-13 22:18:08 +00:00
Anders Broman ecac136d4d Make dissect_per_constrained_integer handle unaligned PER.
Add ULP TCP port preference decode IPv4/IPv6 fields.

svn path=/trunk/; revision=18143
2006-05-13 12:06:56 +00:00
Graeme Lunt ab19b927c8 "Field Information" context menu item that will bring up a web page reference to a field type of FT_OID
svn path=/trunk/; revision=18125
2006-05-10 19:50:54 +00:00
Anders Broman 30fc91887c Add 3GPP Radio Resource LCS Protocol (RRLP) packet dissector
svn path=/trunk/; revision=18124
2006-05-10 16:51:41 +00:00
Anders Broman 102bb4be54 Preparations to be able to handle unaligned PER.
svn path=/trunk/; revision=18119
2006-05-10 05:58:06 +00:00
Anders Broman 956d317fb8 - Some minor asn1 corrections
- Dissect Enumerated correctly
- Add message to info col.

svn path=/trunk/; revision=18117
2006-05-09 19:01:20 +00:00
Graeme Lunt 146d22767c LDAP attribute type dissector framework including support for "netlogon" attribute and PKI attributes
svn path=/trunk/; revision=18109
2006-05-08 17:52:42 +00:00
Graeme Lunt e0f8325deb Better split between dissectors and fixes for s4406 SEQ OF defined extensions
svn path=/trunk/; revision=18108
2006-05-08 17:46:58 +00:00
Graeme Lunt c725ebe242 FT_STRING => FT_OID where applicable
svn path=/trunk/; revision=18107
2006-05-08 17:45:12 +00:00
Anders Broman 9740278a1d Fix bug 926 OID wrongly decoded.
svn path=/trunk/; revision=18106
2006-05-08 17:30:24 +00:00
Anders Broman 4e54a1a204 Fix an ASN1 error and use the IAANA registered ports.
svn path=/trunk/; revision=18102
2006-05-07 13:22:30 +00:00
Anders Broman 9aa7db0042 From LEGO fix "Dissector bug, Protocol H248"
svn path=/trunk/; revision=18093
2006-05-04 18:25:43 +00:00
Ronnie Sahlberg 5a8a9702fe force the AssertionValue type to be displayed as a STRING instead of as hex BYTES.
Most of the time  AssertionValue will contain an ascii string   so make it always display as a string to make the display "correct" most of the time insterad of being "wrong" most of the time.

There are situations when AssertionValue contains binary data though  and in those cases the display will be "wrong" (but not more wrong than the old dissector anyway)


What someone really should do (someone interested in ldap that is) to make it more correct would be to implement a dissector for AssertionValue in the template file and having the dissector check if any of the bytes of the octet string has a value <32   and if so display it in hex as   0x.....
It all bytes have values >=32   then it shoudlk display it as a string "...
instead.

Someone interested in ldap may spend time on this refinement.



svn path=/trunk/; revision=18089
2006-05-04 10:19:32 +00:00
Anders Broman abbbc2c4da Use the asn2eth generated snmp dissector.
svn path=/trunk/; revision=18086
2006-05-03 19:09:03 +00:00
Anders Broman 0a00782704 Add dissection of country code if number is in international format and Number plan is E164.
svn path=/trunk/; revision=18085
2006-05-03 18:57:32 +00:00
Anders Broman 2670be5859 Fix Bug 916 PurgeMS decoding error in GSM MAP.
Get rid of som unused ASN1 code and some asn2eth warnings. 

svn path=/trunk/; revision=18084
2006-05-03 18:49:37 +00:00
Ronnie Sahlberg c18467254d do some template magic to make ethereal dissect CLDAP RPC again.
i dont think it is the optimal way to solve this but it is better than nothing for the time being.


svn path=/trunk/; revision=18083
2006-05-03 10:59:15 +00:00
Anders Broman 437baee301 Fix Bug 913 DateAndTime dissection error in CAMEL CallInfoReportArg
svn path=/trunk/; revision=18079
2006-05-02 20:26:49 +00:00
Anders Broman b7f54f3e5a Makefiles for OMA UserPlane Location Protocol packet dissection..
svn path=/trunk/; revision=18077
2006-05-02 19:48:03 +00:00
Anders Broman 6cdc37b8b9 Add OMA UserPlane Location Protocol packet dissector
svn path=/trunk/; revision=18076
2006-05-02 19:44:12 +00:00
Anders Broman 051a12aa9a Preparations to restore CLDAP dissection, no need to regenerate the dissector yet.
svn path=/trunk/; revision=18067
2006-05-02 05:35:55 +00:00
Guy Harris 30820fa73e Include <epan/strutil.h> to define g_ascii_isprint() on systems with
GLib 1.2[.x].

svn path=/trunk/; revision=18061
2006-05-01 17:43:29 +00:00
Guy Harris 53e371e8a7 Add a Makefile to generate the dissectors from UN*X.
svn path=/trunk/; revision=18060
2006-05-01 17:42:01 +00:00
Graeme Lunt f48115ba5c Operation request/result correlation and timing.
svn path=/trunk/; revision=18058
2006-05-01 10:17:59 +00:00
Anders Broman 2ebbe973de Use the asn2eth generated ldap dissector.
svn path=/trunk/; revision=18057
2006-05-01 10:04:10 +00:00
Graeme Lunt 84764fec29 Operational Attributes and Syntaxes
svn path=/trunk/; revision=18048
2006-04-30 12:53:26 +00:00
Graeme Lunt 4efe0f2423 Request/result matching, port preference and display tweaks
svn path=/trunk/; revision=18042
2006-04-30 07:23:42 +00:00
Guy Harris a6930fe4ae Add distclean and maintainerclean rules.
svn path=/trunk/; revision=17999
2006-04-25 18:45:08 +00:00
Guy Harris 09eeb3902c Add distclean and maintainerclean rules.
svn path=/trunk/; revision=17998
2006-04-25 18:35:15 +00:00
Guy Harris 2c091d5bba Add the usual Makefile.nmake comment.
Change "cd.." to "cd .." - I don't know whether they're equivalent, but,
if they're not, the former probably won't work.

svn path=/trunk/; revision=17997
2006-04-25 18:34:09 +00:00
Anders Broman aa6ce770d0 From Jeff Morris:
I tried out the 0.99.0pre1 release and I noticed that all my SCCP management messages (on SSN==1) were getting decoded as TCAP.  Turns out that the INAP dissector (due to a bug) registers to SSN==1 by default (instead of 106 and 241).  Rather than just fix that bug, the attached patch modifies the INAP dissector to use a range preference (like GSM MAP, TCAP, etc.).


svn path=/trunk/; revision=17945
2006-04-21 18:11:20 +00:00
Anders Broman 5bf31ac5bd Fix bugs:
883 checkIMEIres dissection Error in GSM MAP - branch needed for v1,v2 on Response as well
884 The "absentSubscriberParam" can not be dissected in gsm-map - missing IMPLICIT.

svn path=/trunk/; revision=17926
2006-04-20 15:23:17 +00:00
Anders Broman d422653d53 Add two missing *-exp.cnf files
tcap.asn - whitespace changes

svn path=/trunk/; revision=17828
2006-04-06 05:09:45 +00:00
Anders Broman 5426b944ee Expand some value strings, get map_error from gsm_map use the added IE's.
svn path=/trunk/; revision=17818
2006-04-05 18:54:43 +00:00
Anders Broman e47e1c864d Fix bug http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=850 problems with tagged assignments.
Add som OID names. 

svn path=/trunk/; revision=17798
2006-04-03 19:07:52 +00:00
Anders Broman 84fb70ef42 call OID subdissector for private extensiions, fix makefiles.
svn path=/trunk/; revision=17772
2006-03-30 16:46:36 +00:00
Gerald Combs f87b0f78ae Fix an off-by-one error.
svn path=/trunk/; revision=17771
2006-03-30 16:13:37 +00:00
Guy Harris 015b486dc9 Get rid of an unused variable.
svn path=/trunk/; revision=17764
2006-03-29 22:11:42 +00:00
Jaap Keuter 6d34f7ea92 Function should return a value.
svn path=/trunk/; revision=17752
2006-03-28 20:54:59 +00:00
Anders Broman 2bf7bd3a45 From Jacques, Olivier
Here is a patch for gsm_map dissector that adds USSD string decoding (mainly used in processUnstructuredSS-Request, UnstructuredSS-Request, UnstructuredSS-Notify). For now, it assumes that it will be GSM 7 bits.
It re-use packet-gsm_sms.c "gsm_sms_char_7bit_unpack" and "gsm_sms_char_ascii_decode" functions, as well as packet-smpp.c "smpp_handle_dcs" function.

svn path=/trunk/; revision=17739
2006-03-27 18:48:33 +00:00
Graeme Lunt 4dd0ac18bc Support for otherName and x400address in a GeneralName
svn path=/trunk/; revision=17728
2006-03-25 17:10:07 +00:00
Graeme Lunt c51f4fa887 Support for P1 Strong Authentication
svn path=/trunk/; revision=17727
2006-03-25 16:48:28 +00:00
Anders Broman 2f9f463ede Fix Bugs
820     gsm-map checkIMEI decoding error  
821     gsm-map sendIMSI decoding error  

svn path=/trunk/; revision=17703
2006-03-23 16:58:50 +00:00
Anders Broman f935a4f8f6 Fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=820
svn path=/trunk/; revision=17695
2006-03-22 17:10:19 +00:00
Ronnie Sahlberg f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00
Guy Harris 7db8eea5c6 Make the GUIDs in various data structures e_guid_t's rather than arrays
of 16 bytes.  Use "sizeof" for the size of e_guid_t's, and use structure
assignment to copy GUID values.

Make functions such as append_h225ras_call() and new_h225ras_call() take
pointers to e_guid_t's as arguments.

Define GUID_LEN in epan/guid-utils.h and use it as the length of a GUID
in a packet.  (Note that "sizeof e_guid_t" is not guaranteed to be 16,
although it is guaranteed to be the size of an e_guid_t.)

When constructing a display filter that matches a GUID, use
guid_to_str() to construct the string for the GUID.

svn path=/trunk/; revision=17676
2006-03-19 20:45:45 +00:00
Anders Broman b4d7dd6060 Some more variable bindings and add some mising PDU types.
svn path=/trunk/; revision=17637
2006-03-15 18:57:47 +00:00
Anders Broman beeb757f61 Start implementing the variable binding part.
svn path=/trunk/; revision=17631
2006-03-15 06:20:23 +00:00
Ronnie Sahlberg 27de4cfd39 give se_trees names so that it is easier to debug and to log how often certain trees are accessed
svn path=/trunk/; revision=17587
2006-03-11 13:02:41 +00:00
Ronnie Sahlberg 76a2df4a58 dont declare variables in the middle of a code block. many compilers do not like that.
svn path=/trunk/; revision=17573
2006-03-11 00:58:16 +00:00
Luis Ontanon 4e1ca8f2c3 fix coverity CIDs 113 and 114.
while at it change the h248 context analysis to use se_trees instead of GHashTables


svn path=/trunk/; revision=17571
2006-03-10 22:01:10 +00:00
Anders Broman 8482a05592 Fix Bug 725:
0.10.14 shows "malformed packet" when showing H323 CS: FACILITY message with opcode "Calltransfer initiate" 

svn path=/trunk/; revision=17542
2006-03-09 06:02:42 +00:00