Commit Graph

4629 Commits

Author SHA1 Message Date
Ronnie Sahlberg 09efa21b94 remove some compiler warnings
svn path=/trunk/; revision=21087
2007-03-21 08:32:15 +00:00
Ronnie Sahlberg f07bddb94d remove some compiler warnings
svn path=/trunk/; revision=21086
2007-03-21 08:11:37 +00:00
Jörg Mayer 636e20e431 Fixes for: warning: comma at end of enumerator list
svn path=/trunk/; revision=21084
2007-03-21 04:59:53 +00:00
Jörg Mayer 3cb0b3bfc7 Small spelling fixes
svn path=/trunk/; revision=21083
2007-03-21 04:58:38 +00:00
Jörg Mayer d987ac4127 Fixes for: warning: function declaration isn't a prototype
svn path=/trunk/; revision=21082
2007-03-21 04:54:20 +00:00
Jeff Morriss 62c61a071c Add tracking of retransmitted TSNs. That is, for a TSN that we found was
retransmitted, add items to its tree describing those retransmissions (frame
where the retransmission is and RTO).  Limit this to 100 retransmissions to
avoid running out of memory in pathological cases.

This adds the filters "sctp.retransmitted" (TSNs that were retransmitted)
and "sctp.retransmitted_count" (count of number of times the TSN was
retransmitted).

The RTO is intentionally not added to the retransmitted TSN tree as it is
already added to the retransmission(s).  The RTO is displayed, however.

svn path=/trunk/; revision=21081
2007-03-21 04:48:32 +00:00
Luis Ontanon 5fa8e75149 packet_info.c and packet.c
add sccp_info to struct _packet_info (Sorry but the way private_data works and the fact that TCAP uses it and BSSAP/RANAP can be tunnelled on GSMMAP over TCAP makes it impossible to avoid)

SCCP
- Have SCCP to have a TAP,
- Fix associations so that every message belongs to the association.
- Export message type values so that they can be used by a tap listener

RANAP
 - Have RANAP information attached to the sccp_info 

BSSAP + GSM_A
- Have DTAP, BSSMAP and BSSAP info attached to the sccp_info

svn path=/trunk/; revision=21076
2007-03-21 00:48:46 +00:00
Martin Mathieson 09f3f70a7a Try to squash a warning seen by win32 buildbot
svn path=/trunk/; revision=21074
2007-03-20 17:20:36 +00:00
Ronnie Sahlberg 5fb41ba524 remove some unused variables
svn path=/trunk/; revision=21073
2007-03-20 15:07:28 +00:00
Ronnie Sahlberg d3192b2095 remove some compiler warnings about unused variables
svn path=/trunk/; revision=21072
2007-03-20 15:05:04 +00:00
Ronnie Sahlberg 97ee85b682 remove some compiler warnings
svn path=/trunk/; revision=21071
2007-03-20 14:58:55 +00:00
Ronnie Sahlberg 9cd50d5064 remove some compiler warnings about unused parameters
svn path=/trunk/; revision=21070
2007-03-20 14:50:15 +00:00
Ronnie Sahlberg f40aef922b remove some compiler warnings for unused parameters
svn path=/trunk/; revision=21069
2007-03-20 14:42:49 +00:00
Ronnie Sahlberg d8087438e9 ifdef out a function that is not yet used to get rid of a compiler warning
packet-bacapp.c:4269: warning: `fDeviceObjectPropertyReference' defined but not
used


svn path=/trunk/; revision=21068
2007-03-20 14:27:13 +00:00
Gerald Combs 54df000b3a Extend the bad checksum description to include '(maybe caused by "UDP
checksum offload"?)', similar to the TCP dissector.

Minor whitespace fixups.

svn path=/trunk/; revision=21067
2007-03-19 20:13:01 +00:00
Jeff Morriss 93af79c80d - Set hf_sctp_acked and hf_sctp_rtt as generated.
- Change "sctp.retransmitted" to "sctp.retransmission" since that field
  is set on messages that are retransmissions, not messages that were
  retransmitted.
- Change some formatting to make it more consistent.

svn path=/trunk/; revision=21065
2007-03-19 10:34:26 +00:00
Guy Harris 70e3ec388f Get rid of unused variable.
svn path=/trunk/; revision=21064
2007-03-19 02:36:30 +00:00
Luis Ontanon d3120ba507 bzero the tap data.
svn path=/trunk/; revision=21062
2007-03-19 00:32:33 +00:00
Guy Harris 7c7ccebace From Charles Lepple: in a Get Descriptor message, the descriptor index
comes before the descriptor type.

svn path=/trunk/; revision=21061
2007-03-19 00:03:17 +00:00
Luis Ontanon c12852a0e1 add an mtp3 tap to m3ua to allow VoIP Calls to see ISUP/BICC calls over M3UA
svn path=/trunk/; revision=21058
2007-03-18 23:14:06 +00:00
Luis Ontanon 151b327368 add a tap to h248
svn path=/trunk/; revision=21055
2007-03-18 21:55:00 +00:00
Luis Ontanon 001350a7fb protect from multiple inclussion
svn path=/trunk/; revision=21053
2007-03-18 18:55:52 +00:00
Bill Meier 04d29de81d Fix Windows Makefiles so clean removes all pdb files (PDB_FILE no longer defined)
svn path=/trunk/; revision=21052
2007-03-18 15:36:22 +00:00
Luis Ontanon 9812caa079 make sure curr_info.sig is not-NULL before derreferencing it.
similar to  Bug 1451

svn path=/trunk/; revision=21051
2007-03-18 14:57:26 +00:00
Luis Ontanon c6244e9671 make sure curr_info.evt is not-NULL before derreferencing it.
fixes Bug 1451

svn path=/trunk/; revision=21049
2007-03-18 13:53:28 +00:00
Luis Ontanon cd9c4643d4 dissect H.248 over TPKT over TCP
svn path=/trunk/; revision=21047
2007-03-17 21:44:22 +00:00
Jeff Morriss c833b61b6b Strengthen TAPA's heuristics some:
- check if the tunnel type is known
	- if it's a discover_request, check that the (first) request type
	  is known

svn path=/trunk/; revision=21041
2007-03-17 08:28:20 +00:00
Martin Mathieson 7114ed8349 Turn an error that I've encountered into an easily findable expert item.
svn path=/trunk/; revision=21036
2007-03-16 14:09:12 +00:00
Graham Bloice 0e59733dac Corrected dissection when reading binary inputs that have per point indexes, found by Steven J. Schaeffer
svn path=/trunk/; revision=21035
2007-03-16 11:39:19 +00:00
Stephen Fisher 4eeb29a8a7 Fix bug #1394: Runtime error crash after clicking on HTTP packet
The capture file the user supplied had a HTTP chunked response
in it with no actual chunks other than the zero length chunk
indicating the end of the chunks.  The fix is to only create
a new_tvb and copy it over the tvb going into the
chunked_encoding_dissector() function if the chunk size is > 0.
 

svn path=/trunk/; revision=21034
2007-03-16 00:47:26 +00:00
Jörg Mayer a00dc2564e strncmp(NULL, ...) isn't such a good idea.
svn path=/trunk/; revision=21033
2007-03-14 22:58:09 +00:00
Guy Harris a0fecf54bd Correctly return the item value through the pointer.
svn path=/trunk/; revision=21030
2007-03-14 18:25:19 +00:00
Guy Harris 78b8245bcc "dissect_tapa_static()" is a new-style dissector; register it as such.
svn path=/trunk/; revision=21029
2007-03-14 18:23:19 +00:00
Graeme Lunt c05709dc70 "When X.264/ISO 11570 default identification is being used, there is no user data field in the
CALL REQUEST packet.  This is for X.225/ISO 8073 COTP."

Added this default handling.


svn path=/trunk/; revision=21026
2007-03-14 17:28:55 +00:00
Jörg Mayer e2c6534c5e Improve the heuristic for the tapa discovery classification.
This should fix bug 1437.

svn path=/trunk/; revision=21025
2007-03-14 15:40:44 +00:00
Stephen Fisher eeea95ccbe HTTP Export Object updates:
- Split the HTTP tap into two taps: one for the HTTP statistics
   and the other for the export object function.  This allows the
   HTTP statistics to work again (they seem to have been
   partially broken since SVN rev 18901).
 - Pass the conversation data (conv_data) between functions now
   instead of using the global variable stat_info (now only used
   for the HTTP stats)
 - Pass only pointers from the HTTP dissector to the Export Object
   tap, where we'll then copy the values and insert into the slist.
 - Make sure we free all memory allocated by this feature when
   we're done with it.
 - Various other minor improvements


svn path=/trunk/; revision=21021
2007-03-13 20:42:04 +00:00
Martin Mathieson e14e7fe455 Make m2pa dissector findable by name.
svn path=/trunk/; revision=21020
2007-03-12 11:21:02 +00:00
Jeff Morriss 62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Jeff Morriss 44328ec205 From David Buechi:
- don't show EPL src- and dst-address of SoC frame (same as SoA)
- show SoA requested service only if it's not "NO_SERVICE"
- NMT state in StatusResponse in words, not numbers
- don't show MC and PS flags in SoC (it's now configurable via "Preferences")

Furthermore I extended the value_string struct for the NMT-Command-IDs
(asnd_cid_vals). This change is used to fully decode the NMTRequest frames.

svn path=/trunk/; revision=21017
2007-03-10 15:06:11 +00:00
Jeff Morriss e9ca912aab From Joost Yervante Damad via bug 1383: support for Erlang Port Mapper Daemon
message dissection.

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1383

svn path=/trunk/; revision=21016
2007-03-10 08:36:24 +00:00
Luis Ontanon 0c8d5247b6 Make sure ENDTRY is evaluated.
On windows if ENDTRY is not evaluated after a exception is being thrown wireshark will crash in dissect_packet() while attempting to pop the last frame of the exception stack.

svn path=/trunk/; revision=21015
2007-03-10 02:13:00 +00:00
Luis Ontanon 403fa20bf1 Make sure ENDTRY is evaluated.
On windows if ENDTRY is not evaluated after a exception is being thrown wireshark will crash in dissect_packet() while attempting to pop the last frame of the exception stack.

svn path=/trunk/; revision=21014
2007-03-10 02:11:51 +00:00
Ronnie Sahlberg 10588355f9 move some variable declarations to the start of the block.
many compilers do not support the nonstandard feature to declare variables in the middle of a block.



svn path=/trunk/; revision=21012
2007-03-09 20:02:25 +00:00
Jörg Mayer fb820f0a07 GCC warning fixes
epan/dissectors/
packet-bctp.c:
	no newline at end of file
packet-epl.c:
	C++ style comments are not allowed in ISO C90
packet-sccp.c:
	missing initializer
packet-sccp.h:
	comma at end of enumerator list
packet-sctp.c:
	suggest parentheses around assignment used as truth value
packet-vnc.c:
	control reaches end of non-void function
	pointer targets in passing argument 1 of 'g_strtod' differ in
		signedness
	pointer targets in passing argument 3 of 'vnc_client_to_server'
		differ in signedness
gtk/
main.c:
	C++ style comments are not allowed in ISO C90
u3.h:
	function declaration isn't a prototype

Other (trivial) stuff
packet-sccp.h:
	Add svn properties


svn path=/trunk/; revision=21011
2007-03-09 13:14:09 +00:00
Jörg Mayer f9560b982a Regenerated with current pidl compiler
svn path=/trunk/; revision=21009
2007-03-09 13:11:33 +00:00
Michael Tüxen da56836f74 Add HMAC Algo constants.
svn path=/trunk/; revision=21008
2007-03-09 10:49:23 +00:00
Gerald Combs 0e181d05c8 Fix for bug 1264 from Julian Cable:
I've refactored the offending code branch and added some comments so
  hopefully the intent is a bit clearer. The loop termination conditions
  are now obviously independent of the content on the wire (they were
  meant to be before, but I admit it was obscure). I've tried using the
  ephemeral memory routines.

Add a check for a maximum fragment count, and bail out of reassembly instead
of triggering an ep_alloc exception.  Add Julian to AUTHORS.  Update the 
release notes.

svn path=/trunk/; revision=21007
2007-03-09 01:40:30 +00:00
Luis Ontanon 7f413f1325 actually compile H.248.7
svn path=/trunk/; revision=21003
2007-03-08 22:59:44 +00:00
Luis Ontanon a3099a387c Yet another H.248 package: H.248.7 Gateway control protocol: Generic Announcement package
svn path=/trunk/; revision=21001
2007-03-08 09:59:16 +00:00
Luis Ontanon b6ab56f26d fix a syntax error on the last check-in...
svn path=/trunk/; revision=21000
2007-03-08 00:43:08 +00:00