Commit Graph

1403 Commits

Author SHA1 Message Date
Stig Bjørlykke 863674322d From Peter Johansson:
Correct a misspelling.

svn path=/trunk/; revision=27399
2009-02-09 10:29:17 +00:00
Ulf Lamping 043532d63e add missing mt.exe calls, to include manifest files into exe / dll files
svn path=/trunk/; revision=27357
2009-02-02 23:09:36 +00:00
Guy Harris 2ba37de400 Fix uninitialized variable.
More indentation cleanups.

svn path=/trunk/; revision=27306
2009-01-26 23:48:10 +00:00
Guy Harris 248db0a42a Non-constant strings should not be used as format items; the format
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.

Clean up indentation.

svn path=/trunk/; revision=27304
2009-01-26 22:58:47 +00:00
Ulf Lamping f9e110d4cd fix a minor comment bug
svn path=/trunk/; revision=27299
2009-01-26 19:53:22 +00:00
Ulf Lamping 269cec3108 add some expert infos
svn path=/trunk/; revision=27298
2009-01-26 19:52:19 +00:00
Jaap Keuter ba1cb8b69e Make the column check actually check the information column status.
svn path=/trunk/; revision=27224
2009-01-13 20:47:06 +00:00
Guy Harris a2f9627d09 Fix the URL for the RLM stuff at Cisco.
Add some heuristics to the RLM LAPD-over-UDP dissector, so as not to
misdissect as many packets.

Fetch the LAPD dissector handle only once.

Change some Boolean arguments to gboolean from int.

svn path=/trunk/; revision=27217
2009-01-13 06:54:06 +00:00
Jaap Keuter aa69531a1b From Didier Gautheron:
Add missing {0, NULL} tuples to value string declarations.

svn path=/trunk/; revision=27201
2009-01-09 07:39:13 +00:00
Jaap Keuter 013ab7897d Fix for bug 2902:
Remove global variables for packet information, pass these through function calls. 
Reduce label_SUB[M|A]_[Method|Attribute] routines.
Actually check column status before writing to it.

svn path=/trunk/; revision=27199
2009-01-08 20:40:08 +00:00
Jaap Keuter 4b6b4b672c Fix for bug 2902:
Actually check column status before writing to it.

svn path=/trunk/; revision=27192
2009-01-08 07:36:11 +00:00
Jeff Morriss 896b654b4a Don't look up the mtp3 dissector (twice) for every packet: do it once at
proto_reg_handoff time and store the result.

If we don't call the mtp3 dissector on the payload then call the data dissector
to make it easier to see the payload.

svn path=/trunk/; revision=27160
2009-01-05 20:37:04 +00:00
Anders Broman f5bdbc6af9 Change install-plugins target to install plugins in "$(INSTALL_DIR)\plugins\$(VERSION)" instead.
svn path=/trunk/; revision=27124
2008-12-29 12:37:15 +00:00
Bill Meier 9a3563e807 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Bill Meier b3d131b43d Fixes for issues reported by Chris Maynard in bug #2813;
Also: fix a typo

svn path=/trunk/; revision=27082
2008-12-22 13:34:51 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Stig Bjørlykke e4e7334be0 From Jim Young (bug 3105):
Trivial patch to change two C++ style comments to standard C style comments.

svn path=/trunk/; revision=26944
2008-12-09 13:42:00 +00:00
Ulf Lamping 4f46066fa0 add missing version check for new block
svn path=/trunk/; revision=26917
2008-12-04 21:26:35 +00:00
Ulf Lamping 6e0a9d6df0 add block dissections:
- PDIRBeginEndData
- PDIRData V1.1

svn path=/trunk/; revision=26916
2008-12-04 20:52:11 +00:00
Jörg Mayer b719d7ac35 Unistim still eats the TAPA packets :-(
svn path=/trunk/; revision=26910
2008-12-04 09:31:44 +00:00
Jaap Keuter f5b04f0124 From Don Newton:
Set default port of Unistim back to 5000; The Unistim dissector is made a heuristic dissector.

svn path=/trunk/; revision=26904
2008-12-02 23:02:32 +00:00
Jaap Keuter 7c65de9865 From Don Newton:
Flesh out call duration timer message.

svn path=/trunk/; revision=26898
2008-12-02 07:09:01 +00:00
Stig Bjørlykke 94e9e2b1ec Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Anders Broman 41671d662e From Marc Moussali:
Make it easier to add custom plugins.

svn path=/trunk/; revision=26627
2008-10-30 19:45:40 +00:00
Bill Meier 54b25b075a #include <emem.h>
svn path=/trunk/; revision=26602
2008-10-28 17:35:38 +00:00
Bill Meier 9c7e579d89 Minor cleanup for proto_register & proto_reg_handoff ...
svn path=/trunk/; revision=26601
2008-10-28 17:31:51 +00:00
Bill Meier 49a99b0fa0 proto_register & proto_reg_handoff related; remove unnecessary code ....
svn path=/trunk/; revision=26599
2008-10-28 15:04:44 +00:00
Bill Meier 278b32d71f Minor cleanup related to proto_register/proto_reg_handoff ...
svn path=/trunk/; revision=26596
2008-10-28 00:29:15 +00:00
Bill Meier 05c1929f1d proto_register/proto_reg_handoff; Various small cleanup and bug-fixing
remove unnecessary #include prefs.f and emem.h in a few cases...

svn path=/trunk/; revision=26554
2008-10-25 20:24:31 +00:00
Stig Bjørlykke e08522f0dd From Florian Lohoff (bug 2959):
rudp looks up the ciscosm dissector for every single packet. Make this a one
time in proto_handoff and use the dissector handle.

While at it - decode the checksum when there is one. An indicator is that the
header length has space for the checksum.

Additionally we have seen "stray bytes" after the checksum we can't explain. So
decode them as data when there are some.

svn path=/trunk/; revision=26427
2008-10-13 12:55:16 +00:00
Guy Harris ef51ff82fb Get one more pointer difference.
svn path=/trunk/; revision=26163
2008-09-07 17:49:03 +00:00
Guy Harris bdec87026c To compute the difference between two addresses, cast the pointers
holding those addresses to "void *" and then to "char *" (so we don't
get warnings from casting directly to "char *" or errors from
subtracting two "void *"s), and subtract them, rather than casting the
pointers to an integral type possibly shorter than the pointers (to
avoid warnings and to avoid the admittedly-infinitesimal chance that the
two pointers don't differ in the bits that fit into the integral type).

svn path=/trunk/; revision=26151
2008-09-06 18:27:33 +00:00
Guy Harris 768b822f9b Use GINT_TO_POINTER() to cast integral values to gpointer in
g_hash_table_lookup() calls, in the hopes of suppressing warnings on
platforms with 32-bit ints and 64-bit pointers.

svn path=/trunk/; revision=26149
2008-09-06 17:27:20 +00:00
Bill Meier a3a9ff5a2b #include <prefs.h> not required
svn path=/trunk/; revision=26103
2008-08-29 01:40:32 +00:00
Bill Meier 4aa1788a3b #include <emem.h> not req'd
svn path=/trunk/; revision=26095
2008-08-26 03:19:29 +00:00
Jaap Keuter 677ce2b209 From Frank Wang:
dl-map decoder error when decode HARQ_DLMAP_IE and normal IE.

svn path=/trunk/; revision=26020
2008-08-14 18:05:18 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Martin Mathieson ad16b7b403 Declare next_tvb volatile. This prevents the warning:
packet-infiniband.c:806: warning: variable 'next_tvb' might be clobbered by `longjmp' or `vfork'

seen with gcc 3.4.6 (building for 32-bits on a pentium 4).

svn path=/trunk/; revision=25916
2008-08-04 16:36:16 +00:00
Anders Broman e2070d0efb From Stephen Donnelly:
Fences incorrectly set in source/destination columns in IB plugin.

svn path=/trunk/; revision=25880
2008-07-31 09:08:13 +00:00
Guy Harris 476c61472a No C++ comments - some compilers don't allow them (at least not by default).
svn path=/trunk/; revision=25878
2008-07-30 19:11:28 +00:00
Anders Broman de0ca39861 From Stephen Donnelly:
Infiniband Dissector Plugin 1.2.0

svn path=/trunk/; revision=25876
2008-07-30 15:47:11 +00:00
Anders Broman c954861fe5 From Bruno Verstuyft:
DOCSIS3.0 support in wireshark (MDD, REG-REQ-MP, REG-RSP-MP)

svn path=/trunk/; revision=25875
2008-07-30 15:13:12 +00:00
Jeff Morriss 688abd6e54 Fix checkapi target for the plugins
svn path=/trunk/; revision=25864
2008-07-29 23:16:04 +00:00
Jeff Morriss b4d2c37635 Allow checkapis target to work in out-of-tree builds (s#../../#$(top_srcdir)).
Also use $(top_builddir) instead of ../../ in a couple of other spots.

svn path=/trunk/; revision=25863
2008-07-29 22:06:37 +00:00
Martin Mathieson 7921dca80d Fix DLMAP UL_interference_and_noise_level_IE decode error (bug 2737).
From Frank Wang.

svn path=/trunk/; revision=25816
2008-07-24 08:53:14 +00:00
Martin Mathieson 9c34677453 Fix HARQ_ULMAP_IE decoder padding error (bug 2738).
From Frank Wang.

svn path=/trunk/; revision=25815
2008-07-24 08:46:13 +00:00
Martin Mathieson 56455be25a This file predominantly uses spaces, so remove tabs that were making
indentation look wrong in my editor.


svn path=/trunk/; revision=25805
2008-07-23 14:32:24 +00:00
Martin Mathieson ee1534f851 Fix bug 2663 (DLMAP HAEQ_DLMAP_UE decode error).
From Frank Wang.

svn path=/trunk/; revision=25801
2008-07-23 11:18:33 +00:00
Bill Meier e2e72c7664 Add NULL termination element to value_string arrays
svn path=/trunk/; revision=25799
2008-07-22 21:53:50 +00:00
Bill Meier f2fd24c9c0 Change C++ style comments to C style ...
svn path=/trunk/; revision=25762
2008-07-18 02:48:37 +00:00
Sake Blok 53bee63aa1 Oops... missed one ;
svn path=/trunk/; revision=25740
2008-07-14 21:02:30 +00:00
Sake Blok 03e0f71e8f From Richard Kuemmel (bug 2668):
Removed the line 
tvb_ensure_bytes_exist(tvb, offset, 44);
from  again. 
This is not correct, because the frame might have been captured before the
os added the padding bytes. E.g. in Windows the frames are captured on the
protocol layer. When another protocol driver sends a frame this frame does 
not include the padding bytes.  

Also the dataLength variable in case of bMox==TRUE  was not calculated
correctly.


svn path=/trunk/; revision=25738
2008-07-14 19:56:37 +00:00
Jeff Morriss 71c1e4faf0 Change the stats tree API to use signed chars instead of guint8s for all its
strings; this should fix a number of signed/unsigned char warnings.
Reindent a bunch, too.

svn path=/trunk/; revision=25716
2008-07-11 21:13:39 +00:00
Jaap Keuter 77c287a58c From Frank Wang:
The ULMAP decoder can get a wrong bit offset when decoding CQICH_Alloc_IE.
The finishing position shoud not pad to byte but pad to the length specified,
which can be nibble aligned.

svn path=/trunk/; revision=25703
2008-07-11 16:03:06 +00:00
Martin Mathieson 5283264092 Fix bug 2662 (ULMAP HARQ_ULMAP_IE decode error).
From Frank Wang.

I'd prefer to delete wrong code, but we'll see if anyone misses it.















svn path=/trunk/; revision=25675
2008-07-08 16:05:41 +00:00
Guy Harris a04774395f Add Makefile.common files for epan/dfilter and epan/ftypes.
Add checkapi rules to Makefile.am files.

svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Guy Harris 40773753ad Get rid of a misleading comment (it says "no need to modify anything
under here", right above a comment that tells you what you need to
modify under there...).

svn path=/trunk/; revision=25655
2008-07-02 01:43:50 +00:00
Guy Harris b6e20d89be Put printf into a separate "termoutput" API group. For most files,
check for it - but not for TShark plugins, as they are expected to
print to the standard output.

svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
Gerald Combs 83aacf0a09 Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.

svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
Martin Mathieson 7001a1564b For for compressed DLMAP decode error.
From Frank Wang (bug 2640).

svn path=/trunk/; revision=25599
2008-06-25 08:54:22 +00:00
Martin Mathieson 4aa522855d Make sure info column is set correctly when tree == NULL.
Fixes but 2561.













svn path=/trunk/; revision=25530
2008-06-23 13:02:50 +00:00
Martin Mathieson d2036aca8a Try again to get labels matching function names.
svn path=/trunk/; revision=25529
2008-06-23 10:08:13 +00:00
Martin Mathieson 8d053ee86d Fix wimax UL-MAP ext IE decode error.
From Frank Wang (bug 2548).











svn path=/trunk/; revision=25528
2008-06-23 09:24:32 +00:00
Martin Mathieson 89ed3a03bb Wimax: support TLV type 48 in REG-REQ/REG-RSP.
From cfreeer, fixes bug 2571.










svn path=/trunk/; revision=25495
2008-06-20 15:55:32 +00:00
Martin Mathieson 2cddcc6b58 Fix wimax encoding err when packing subheader present.
From Frank Wang, fixes bug 2570.









svn path=/trunk/; revision=25494
2008-06-20 10:26:18 +00:00
Martin Mathieson 5da0fe48b0 Support TLV type 36 in wimax plugin.
From cfreeer (fix for bug 2569).








svn path=/trunk/; revision=25493
2008-06-20 10:17:13 +00:00
Ulf Lamping bd8528644e fix BlockError strings
svn path=/trunk/; revision=25490
2008-06-19 18:44:23 +00:00
Bill Meier 9a53920530 Do plugins Checkapi only if the checkapi target is explicitly invoked.
svn path=/trunk/; revision=25382
2008-05-27 02:14:14 +00:00
Martin Mathieson 03d7032acd Show ops, etc even when no filter set.
Also avoid crash I was seeing when changing preferences.

svn path=/trunk/; revision=25379
2008-05-26 08:22:33 +00:00
Jaap Keuter ab26f8d8a3 From cfreeer:
Wimax vals_tek_encryption_ids does not confirm the latest spec. Zero should be
"No TEK encryption" instead of "Reserved".

svn path=/trunk/; revision=25367
2008-05-23 05:36:09 +00:00
Jeff Morriss a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Stig Bjørlykke d1208e55e1 Initialize aitem.
svn path=/trunk/; revision=25302
2008-05-14 11:02:39 +00:00
Tomas Kukosa 1e82573549 fix missing brackets causing uninitialized hidden_item
svn path=/trunk/; revision=25300
2008-05-14 10:48:59 +00:00
Tomas Kukosa 19c327d160 From Anders Broman:
Patches for broken build

svn path=/trunk/; revision=25298
2008-05-14 10:21:41 +00:00
Stig Bjørlykke 38011c53da From cfreeer (bug 2541):
Add tlv_tree for PKM_FLOW_CONTROL and MAX_SUPPT_SECURITY_ASSNS.

svn path=/trunk/; revision=25297
2008-05-14 08:46:47 +00:00
Stig Bjørlykke fe1738c394 From cfreeer (bug 2540):
Corrected use of hf_snp_auth_policy_support.

svn path=/trunk/; revision=25296
2008-05-14 08:38:58 +00:00
Jaap Keuter 9b0b67d6bb From cfreeer:
The offset need to be increased while decoding.

svn path=/trunk/; revision=25292
2008-05-14 05:52:32 +00:00
Anders Broman d22975841b Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25283
2008-05-13 06:55:45 +00:00
Bill Meier fe5c2d9820 g_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf
svn path=/trunk/; revision=25276
2008-05-11 18:33:49 +00:00
Jaap Keuter cacee64927 From Hans-Peter Bock:
Attached to this post you find a patch for integration into wireshark that adds
a dissector for SERCOS III, ethertype 0x88cd.

svn path=/trunk/; revision=25270
2008-05-10 14:44:32 +00:00
Anders Broman 8db8e90221 Use PROTO_ITEM_SET_HIDDEN().
Fix ID marking
Add checkapi to makefiles

svn path=/trunk/; revision=25260
2008-05-09 07:07:50 +00:00
Anders Broman db6d0b9a4c Run checkAPI in plugins dir.
svn path=/trunk/; revision=25259
2008-05-08 18:24:08 +00:00
Anders Broman bc12adaf1b Add Id tag.
svn path=/trunk/; revision=25236
2008-05-05 19:06:31 +00:00
Anders Broman ad890397cc Don't use proto_tree_add_item_hidden().
svn path=/trunk/; revision=25235
2008-05-05 18:58:53 +00:00
Anders Broman 57ebbbbb2c Dount use proto_tree_add_item_hidden().
svn path=/trunk/; revision=25233
2008-05-05 17:19:51 +00:00
Anders Broman 023a81709a Make it possible to run checkapi on all plugins trough makefile.nmake
Note: Commented out in the plugins giving errors for now.

svn path=/trunk/; revision=25231
2008-05-05 16:55:19 +00:00
Jaap Keuter 40b433984b Now with EAP dissector safety valve.
svn path=/trunk/; revision=25204
2008-04-30 10:59:48 +00:00
Jaap Keuter 6e9d862cd8 From cfreeer:
There is no EAP decoder to decode EAP messages packed in Wimax PKM messages. 
I called the EAP decoder found in the Wireshark.

svn path=/trunk/; revision=25203
2008-04-30 09:15:50 +00:00
Bill Meier 2bce8b248c Bug 2493: Fix (Part 3 of 3):
To prevent Windows compiler errors when using flex 2.5.35.
  Ignore 'signed /unsigned mismatch' warnings


svn path=/trunk/; revision=25174
2008-04-25 18:26:54 +00:00
Bill Meier 0d4b874b44 Bug 2493: Fix (Part 2):
To prevent Windows compiler errors when using flex 2.5.35.
 Fixes "missing unistd.h" and yywrap "mismatched parameter" warnings
 [Upcoming Part 3: ignore 'signed /unsigned mismatch' errors]

svn path=/trunk/; revision=25173
2008-04-25 17:40:29 +00:00
Stig Bjørlykke b472360c7d From Mohan (bug 2501):
Add a missing break statement.

svn path=/trunk/; revision=25168
2008-04-24 21:51:14 +00:00
Jaap Keuter 81db026301 Fix for bug 2475:
Add a preference to the UNISTIM dissector so that you can set the default port back to 5000, even though this conflicts with other dissectors.

svn path=/trunk/; revision=25118
2008-04-19 10:41:45 +00:00
Jörg Mayer abaea4e100 The generated code warns about 'input' being unused. -Werror turns this into a failure
svn path=/trunk/; revision=25027
2008-04-14 21:29:29 +00:00
Jörg Mayer 46efef6b04 Get rid of some unused functions to prevent -Werror from causing the compile to fail
svn path=/trunk/; revision=25026
2008-04-14 21:24:12 +00:00
Ulf Lamping b3d55eb095 clarify the stats_tree menu items
svn path=/trunk/; revision=25009
2008-04-14 01:11:07 +00:00
Ulf Lamping 8b4f26afc6 fix the Win32 build: tfs_yes_no -> tfs_yes_no_sbc
svn path=/trunk/; revision=24840
2008-04-08 03:50:44 +00:00
Jaap Keuter b3e4a7bb02 Fix for bug 2401:
Repair header field type definitions, based on a patch from Chris Yang.

svn path=/trunk/; revision=24839
2008-04-07 22:46:50 +00:00
Stephen Fisher 726a1caaf1 - Remove GLIB1 code
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
  g_strsplit code for the no longer supported GLIB1 builds


svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
Stephen Fisher 13802b1d84 Remove GTK1 code.
svn path=/trunk/; revision=24827
2008-04-07 04:34:54 +00:00
Martin Mathieson 50ea8167c1 Make wimax mac mgmt protocol findable by name.
Bug 2409.

svn path=/trunk/; revision=24782
2008-04-05 05:04:14 +00:00
Martin Mathieson 88744abd6f Don't load in files unless tree is set.
If a user wants to load or capture quickly, they won't want to wait
for the file to be processed after the first frame.

svn path=/trunk/; revision=24781
2008-04-05 04:48:36 +00:00
Martin Mathieson 4cfefcc5a4 Use proto_register_prefix() with wimaxasncp plugin.
Also fix a crash problem seen with no filters (i.e. NULL tree).

svn path=/trunk/; revision=24767
2008-04-04 05:38:13 +00:00
Jaap Keuter b704bdcbc5 Remove the pre-release flag from FILEFLAGS in the resource file.
svn path=/trunk/; revision=24757
2008-03-29 23:04:33 +00:00
Anders Broman 1a2b14d60c In glib 2.16 g_malloc Changed from:
- gpointer g_malloc         (gulong	 n_bytes) G_GNUC_MALLOC;
to:
+ gpointer g_malloc         (gsize	 n_bytes) G_GNUC_MALLOC;

svn path=/trunk/; revision=24710
2008-03-21 16:10:47 +00:00
Gerald Combs 121e3d432e Try to fix distcheck again.
svn path=/trunk/; revision=24637
2008-03-15 00:21:02 +00:00
Gerald Combs b1bd2972ff Fix distcheck.
svn path=/trunk/; revision=24636
2008-03-14 23:43:35 +00:00
Gerald Combs 7519d12f8f Make sure the Infiniband plugin is properly built and packaged.
svn path=/trunk/; revision=24634
2008-03-14 21:53:16 +00:00
Stig Bjørlykke 5d9ca601d8 Added missing Id keywords, eol-style and ignore targets.
svn path=/trunk/; revision=24632
2008-03-14 19:48:49 +00:00
Stig Bjørlykke 3351980a29 Make infiniband plugin compile.
svn path=/trunk/; revision=24631
2008-03-14 19:35:54 +00:00
Gerald Combs 68d23708bc From Stephen Donnelly via bug 2235:
This plugin implements a dissector for Infiniband. It is released 
under the GPL v2.

Rather than using say libpcap to capture raw (unframed) IP packets 
from near the top of an IPoIB stack, this plugin dissects link level
Infiniband frames.

Infiniband trace files can be read from Endace ERF format trace 
files, or from libpcap DLT_ERF files containing ERF TYPE_INFINIBAND 
records. There is currently no native DLT_INFINIBAND in libpcap.

Each record contains a hardware timestamp, capture metadata such as 
port Id, and a complete link level Infiniband frame starting from
the Local Route Header.

svn path=/trunk/; revision=24628
2008-03-14 17:47:53 +00:00
Jörg Mayer dc6789a84f Set default port of Unistim from 5000 to 0: It grabs the TAPA
packets that I need.
The Unistim dissector should be made a heuristic dissector that
is willing to coexist with other dissectors. Until such a time
the port should remain 0.

svn path=/trunk/; revision=24573
2008-03-06 12:54:08 +00:00
Stephen Fisher 9ef2001f7b Fix the declaration of a true_false_string
svn path=/trunk/; revision=24572
2008-03-05 22:28:51 +00:00
Anders Broman 7a5b90df34 From Peter Johansson :
Support for EtherCAT subdissectors.

svn path=/trunk/; revision=24566
2008-03-05 20:42:58 +00:00
Jaap Keuter fcf8509f69 Create proper dependancies for plugin.c
svn path=/trunk/; revision=24520
2008-03-01 12:31:01 +00:00
Stig Bjørlykke fc5527ef6c Quote argument to test in plugins Makefiles, as proposed by Greg A. Woods.
svn path=/trunk/; revision=24488
2008-02-27 16:18:30 +00:00
Jeff Morriss 74905320f8 From Richard Kuemmel via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1430 : fix length mask.
svn path=/trunk/; revision=24459
2008-02-25 15:21:20 +00:00
Gerald Combs 7abeb02747 If we have an SVN revision number, use it as the build number under Windows
instead of "0".

svn path=/trunk/; revision=24376
2008-02-18 18:08:14 +00:00
Bill Meier 73f45b105e Fix a (never used) 'anonymous struct'
svn path=/trunk/; revision=24279
2008-02-07 00:59:14 +00:00
Stig Bjørlykke b0df21c5fd Eliminate an anonymous struct, as noticed by Andrew Hood.
svn path=/trunk/; revision=24277
2008-02-06 22:05:10 +00:00
Stig Bjørlykke cfc7b3276c Rewrote some prohibited APIs in plugins/ (sprintf, strcpy, strcat).
svn path=/trunk/; revision=24274
2008-02-05 22:30:32 +00:00
Stig Bjørlykke d5d2e97b47 Fixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.
svn path=/trunk/; revision=24180
2008-01-24 19:30:43 +00:00
Ulf Lamping adccc10596 add some parentheses as suggested by the OS X buildbot
svn path=/trunk/; revision=24122
2008-01-17 19:30:35 +00:00
Ulf Lamping 6cfbb485bf better conformance to the released DCP protocol spec:
- redesign/refactoring the code to support BlockQualifier
- fix handling of BlockInfo 
- rename some display strings for better spec conformance
- remove LLDP suboption

svn path=/trunk/; revision=24120
2008-01-17 18:29:51 +00:00
Jeff Morriss 283ddb3d0c Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2186 (many unnamed structs in packet-ecatmb.h) by adding predictable (but not very descriptive) struct names
svn path=/trunk/; revision=24061
2008-01-10 22:19:53 +00:00
Richard van der Hoff 1350d63c1e From Chris Maynard (bug 1852):
These packet-g*.c files all have display filter issues:

1) packet-gryphon.c: PROTOABBREV is "gryphon", but display filter fields are
prefixed with only "gryph".

2) packet-gmrp.c: PROTOABBREV is "gmrp", but display filter fields are prefixed
with "garp".

3) packet-gssapi.c: PROTOABBREV is "gss-api", but display filter fields are
prefixed with "gssapi".

4) packet-gvrp.c: PROTOABBREV is "gvrp", but display filter fields are prefixed
with "garp", most of which conflict with packet-gmrp.c's display filter fields.




svn path=/trunk/; revision=24058
2008-01-10 16:35:54 +00:00
Stig Bjørlykke 22afd80efc As noted by David Halik in bug 2172:
Removed an unnamed union member in ethercat.

svn path=/trunk/; revision=24024
2008-01-07 20:56:24 +00:00
Jörg Mayer 0c797861ba Warning fixes: function declaration isn’t a prototype
svn path=/trunk/; revision=23862
2007-12-14 15:14:40 +00:00
Jaap Keuter b5a733b0a8 Fix for bug 2098:
Test that message length is at least the minumum required, otherwise generate expert item..

svn path=/trunk/; revision=23854
2007-12-13 08:02:29 +00:00
Jaap Keuter bd5066006c The referenced sample files should be complete and correct.
svn path=/trunk/; revision=23848
2007-12-12 22:10:50 +00:00
Jörg Mayer 5998d1dbd2 mgcp is now in epan/dissectors/
svn path=/trunk/; revision=23843
2007-12-11 22:03:26 +00:00
Tomas Kukosa 910c8f6281 From Ales Kocourek
example plugin updated

svn path=/trunk/; revision=23839
2007-12-11 11:54:15 +00:00
Guy Harris 191da2295c Get rid of unused file. (No other plugin has it.)
svn path=/trunk/; revision=23812
2007-12-08 22:52:02 +00:00
Gerald Combs 2a67c4d472 Change calls to g_ntohs, g_ntohl, g_htons, and g_htonl to their
epan/pint.h equivalents. Add warnings about trying to operate on tvb
data directly.

svn path=/trunk/; revision=23787
2007-12-06 18:53:58 +00:00
Martin Mathieson b0998315f9 Fix some specifier strings (%d -> %u).
svn path=/trunk/; revision=23785
2007-12-06 17:47:00 +00:00
Bill Meier 69fbf4c69f Simplify Windows Makefile to improve maintainability
by reducing the number of changes req'd to add a plugin.

svn path=/trunk/; revision=23772
2007-12-05 19:43:50 +00:00
Stig Bjørlykke cbcfc45a72 I suppose we still need va_start/va_end when using se_strdup_vprintf.
svn path=/trunk/; revision=23769
2007-12-05 13:06:26 +00:00
Guy Harris 0be3a6524f To generate a session-lifetime string given a format and va_list, use
se_strdup_vprintf().

svn path=/trunk/; revision=23765
2007-12-05 10:27:49 +00:00
Bill Meier 6e6d13ccb9 Add missing profinet to maintainer-clean
svn path=/trunk/; revision=23757
2007-12-05 03:23:54 +00:00
Tomas Kukosa 4df43619aa Codec plugin example. The stub for ImTelephone libraries.
(It is not compiled by default.)

svn path=/trunk/; revision=23699
2007-12-03 09:59:18 +00:00
Gerald Combs 70510e21c8 Change each filter prefix to match the protocol name ("wmx"). Add a
"wmx" prefix to each sub-protocol. "wmx"-ize the preferences and
dissector registration.

svn path=/trunk/; revision=23660
2007-11-28 22:56:27 +00:00
Gerald Combs af85c74ade Tweak the order in which fields are registered, so that they don't
show up as protocols.

svn path=/trunk/; revision=23656
2007-11-28 22:29:00 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Jeff Morriss b2991dfd21 Oops, don't put a comment inside a comment
svn path=/trunk/; revision=23610
2007-11-26 19:11:26 +00:00
Jeff Morriss 309f7503e5 Get rid of C++/C99 style comments--not all compilers support them
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
Jeff Morriss 565d493671 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1914 when building out of the source tree by not issuing a complaint if the wimaxasncp dictionary is not found. This is ugly but it's how diameter does it, too, and I am not aware of a better way.
svn path=/trunk/; revision=23565
2007-11-24 16:09:47 +00:00
Martin Mathieson 9fb579537e - Prettify "Value" node that contains EAP tree with top-level details
- Lose unuseful header file

svn path=/trunk/; revision=23499
2007-11-19 19:07:49 +00:00
Martin Mathieson 24d6a39eb0 Embedding EAP inside wimaxasncp.
svn path=/trunk/; revision=23474
2007-11-16 23:03:09 +00:00
Guy Harris 6f1740aa6c Cast "char"s to "unsigned char" before handing them to <ctype.h> macros.
svn path=/trunk/; revision=23417
2007-11-10 00:36:01 +00:00
Martin Mathieson 0f63de9281 From Stephen Croll.
Dynamically register filter fields from TLV definitions.

svn path=/trunk/; revision=23414
2007-11-09 14:41:04 +00:00
Anders Broman 6226035893 Apply yet another set of the optimization patches:
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().

On the other hand 
	if (tvb_bytes_exist(tvb, 0, 20)
is more readable than
	if (tvb_length(tvb) >= 20

so only do it in heuristic function

svn path=/trunk/; revision=23412
2007-11-09 06:01:18 +00:00
Anders Broman a6850bb34e Delete generated files at distclean.
svn path=/trunk/; revision=23368
2007-11-05 20:44:10 +00:00
Anders Broman dbcabb1938 Get rid of most of the legacy oid stuff.
svn path=/trunk/; revision=23333
2007-11-01 22:07:43 +00:00
Stephen Fisher d33e4cc381 Change a few g_string_append_printf() (GTK2 only) calls to g_strdup_printf()
and g_string_append() to work on GTK 1.2 also.


svn path=/trunk/; revision=23311
2007-10-30 05:49:41 +00:00
Martin Mathieson 7c80a7feae Add expert item for cases of unmatched function type or message op.
svn path=/trunk/; revision=23276
2007-10-26 10:38:16 +00:00
Jeff Morriss c7bed1298f s/fopen()/eth_fopen()/ in plugins/ (for bug 1827).
svn path=/trunk/; revision=23221
2007-10-17 21:25:16 +00:00
Jeff Morriss 0918c7159b sizeof() returns a 64-bit number when compiling for 64-bit (and a 32-bit number when compiling for 32-bit) so cast sizeof() values that are passed to g_snprintf() to guint (since that appears to be the intent of the display).
svn path=/trunk/; revision=23205
2007-10-16 14:54:51 +00:00
Jörg Mayer 4604a19971 Fix a warning about different variable sizes that prevented compilation
with gcc.

svn path=/trunk/; revision=23204
2007-10-16 14:30:41 +00:00
Stig Bjørlykke fe8e1e3fbc Fixed compiler errors.
svn path=/trunk/; revision=23196
2007-10-15 21:46:08 +00:00
Anders Broman 407faa6a2d Try to fix the buildbot.
svn path=/trunk/; revision=23193
2007-10-15 20:12:02 +00:00
Anders Broman e922e453dd Add ethercat again
svn path=/trunk/; revision=23191
2007-10-15 19:19:33 +00:00
Anders Broman 3c419f798c Make MGCP a builtin dissector to reduce the number of plugins.
(Leave the MGCP plugin dir for now).

svn path=/trunk/; revision=23190
2007-10-15 18:57:10 +00:00
Anders Broman 721796617d From Peter Johansson:
addressing the compilation problems

svn path=/trunk/; revision=23188
2007-10-15 18:39:58 +00:00
Bill Meier 4644ce7263 Fix Windows maintainer-clean/distclean/clean to recurse thru subdirs only once (instead of worst-case 1+2+3 times)
svn path=/trunk/; revision=23187
2007-10-15 16:44:31 +00:00
Martin Mathieson bafcd03634 In source tree, move wimaxasncp TLV files from plugin folder -> new top-level wimaxasncp folder.
svn path=/trunk/; revision=23184
2007-10-15 12:32:19 +00:00
Anders Broman dfec0c6079 Remove Ethercat from the makefiles(second try)
svn path=/trunk/; revision=23180
2007-10-15 05:45:50 +00:00
Anders Broman 2cc898ef83 Remove Ethercat from the makefiles
svn path=/trunk/; revision=23179
2007-10-15 05:26:22 +00:00
Jaap Keuter c9131582af Someone has a compromised filesystem since it contained all kinds of stuff from other plugins.
Tried to clean it up and get it in line with the rest of the codebase.
Still doesn't compile without warnings though.

svn path=/trunk/; revision=23177
2007-10-14 21:01:01 +00:00
Anders Broman c644b82279 Ethercat plugin
Author :
Richard Kuemmel <r.kuemmel[AT]beckhoff.de>

Updates and bugfixes:
Peter Johansson <peterjohansson73[AT]gmail.com>

svn path=/trunk/; revision=23174
2007-10-14 15:45:24 +00:00
Anders Broman 3238f6b87a Ethercat plugin
Author :
Richard Kuemmel <r.kuemmel[AT]beckhoff.de>

Updates and bugfixes:
Peter Johansson <peterjohansson73[AT]gmail.com>

svn path=/trunk/; revision=23173
2007-10-14 15:44:05 +00:00
Stephen Fisher 239f4e2ebb Fix Unix buildbots ("warning: 'msg_type' may be used uninitialized in this
function")


svn path=/trunk/; revision=23172
2007-10-14 00:56:53 +00:00
Anders Broman b5e2191dd6 Decode SDP inside Cisco SM messages(huge guesswork).
svn path=/trunk/; revision=23171
2007-10-13 21:59:33 +00:00
Gerald Combs ff5826a106 Fix wimaxasncp compilation under Windows. Rename a macro that's defined
by the platform SDK, cast an int, and use the top-level Makefile.nmake.inc
to build wimaxasncp_dict.{c|obj}.

svn path=/trunk/; revision=23165
2007-10-12 18:26:47 +00:00
Martin Mathieson 13bf6bc269 Another blind attempt to fix the Windows buildbot.
Could someone please review this (I'm leaving for the day soon)?

svn path=/trunk/; revision=23164
2007-10-12 16:51:42 +00:00
Jeff Morriss be55140415 Fix hex-pane byte highlighting for the PDU message type item
svn path=/trunk/; revision=23163
2007-10-12 15:41:53 +00:00
Martin Mathieson faffc473d1 Add targets for lex compilation.
svn path=/trunk/; revision=23162
2007-10-12 15:00:20 +00:00
Martin Mathieson 258eab8c26 Try to fix distcheck. Is this change appropriate?
svn path=/trunk/; revision=23161
2007-10-12 13:29:54 +00:00
Martin Mathieson 2c994a337f Added missing header file for distcheck.
svn path=/trunk/; revision=23160
2007-10-12 12:26:38 +00:00
Martin Mathieson 278271b8f7 Add missing file.
svn path=/trunk/; revision=23158
2007-10-12 10:44:49 +00:00
Martin Mathieson 358c4399ba TLVs now defined in XML (from Stephen Croll).
svn path=/trunk/; revision=23156
2007-10-12 09:59:10 +00:00
Ulf Lamping 5c901658e7 add FSParameterBlock and ARFSUDataAdjust blocks
svn path=/trunk/; revision=23140
2007-10-10 18:33:21 +00:00
Ulf Lamping 37d9fc37da - add DomainName fields for PDInterfaceMrpDataAdjust and PDInterfaceMrpDataReal
- lower expert info level if AR wasn't found

svn path=/trunk/; revision=23106
2007-10-09 05:39:48 +00:00
Richard van der Hoff 4d2920314d From Chris Maynard <christopher.maynard@gtech.com>:
With the exception of docsis's packet-tlv.c file, these are all simple problems
with the prefix not exactly set to PROTOABBREV.  For example, for
packet-bpkmattr.c, the field names are prefixed with "docsis.bpkmattr." instead
of "docsis_bpkmattr.".

packet-tlv.c had one mis-named field, namely "docsis.cos.sid".  It has been
changed to "docsis_tlv.cos.sid" in the patch to be attached, which includes
patches for 29 files in the plugins/docsis/ directory ...


svn path=/trunk/; revision=23088
2007-10-07 23:46:44 +00:00
Stig Bjørlykke 87cffefe2f Added parentheses to make the buildbot happy.
svn path=/trunk/; revision=23065
2007-10-03 19:35:32 +00:00
Ulf Lamping 2a8f9b4c99 check version of each block and don't try to dissect a block if the version is not as expected (to avoid "miss-dissections")
svn path=/trunk/; revision=23064
2007-10-03 18:02:27 +00:00
Ronnie Sahlberg 022aaeb39d make the sbus dissector nwe-style and make it check that the packet does
indeed look like sbus before taking it.


this fixes bug 1871


svn path=/trunk/; revision=23057
2007-10-02 22:04:07 +00:00
Ulf Lamping c3131594a8 update to latest IEC draft
svn path=/trunk/; revision=23041
2007-10-02 05:04:35 +00:00
Martin Mathieson 8e59e99b5c - show type (number) of unrecognised tlvs in the tlv root item
- also add this as an expert item
- tlv root item is now an FT_BYTES item (allowing filtering on whole tlv contents)

svn path=/trunk/; revision=22986
2007-09-26 14:47:22 +00:00
Ulf Lamping 33f27f437f slightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_header
svn path=/trunk/; revision=22970
2007-09-25 21:56:43 +00:00
Stig Bjørlykke 19aa309fea From Don Newton:
added null termination to uftp and cleaned comments in packet-unistim.c

svn path=/trunk/; revision=22940
2007-09-24 19:56:17 +00:00
Jaap Keuter f2c1b7e8f0 From Chad Singer:
I fixed a bug in packet_unistim.c which was causing a 'malformed packet' to
appear when an open stream command is read with no endpoint ip (as is sometimes
done) I added a simple msg_len check to avoid this. 
I also added UFTP to the unistim dissector and adjusted the unistim call-detection 
in voip-info.c to start on an open stream as well as keypresses..

svn path=/trunk/; revision=22929
2007-09-24 06:19:56 +00:00
Jaap Keuter 816b438354 From Don Newton:
Added phone type using Nortel branded Polycom unistim conference phone.

svn path=/trunk/; revision=22910
2007-09-19 18:57:09 +00:00
Jaap Keuter bb983c053e Fix for bug 1687:
Add RFC 3807 defined V5 interface boundary primitives message class.

svn path=/trunk/; revision=22882
2007-09-16 14:22:06 +00:00
Jaap Keuter 0503c37133 Add RT(C)P conversation setup.
svn path=/trunk/; revision=22862
2007-09-13 18:47:10 +00:00
Jaap Keuter f0d360a48a Implement dissect_message loop i.s.o. recursive calls.
svn path=/trunk/; revision=22857
2007-09-12 21:46:55 +00:00
Jaap Keuter e1541263e4 From Chad Singer:
UNISTIM Tap interface plus call grapher.

svn path=/trunk/; revision=22834
2007-09-10 07:21:27 +00:00
Ulf Lamping 1366745e45 start an experiment to provide MS Visual Studio 2005 solution / project files for a lot easier debugging. They still use the underlying Makefile.nmake files for the actual build process.
svn path=/trunk/; revision=22831
2007-09-09 13:59:58 +00:00
Martin Mathieson 9d0e61f12c Replace remaining non-printable characters that looked like spaces with real spaces.
svn path=/trunk/; revision=22824
2007-09-07 15:58:24 +00:00
Martin Mathieson fe8b214d35 Small cleanup:
- remove unprintable chars (pasted from formatted spec doc?)
- use _U_ for unsused function argument
- remove accidental(?) assignment in function parameter
- make indentation consistent by removing the (few) tabs in the file

svn path=/trunk/; revision=22819
2007-09-07 13:53:49 +00:00
Martin Mathieson aef34dca35 Try Stephen Croll's workaround.
svn path=/trunk/; revision=22818
2007-09-07 09:56:19 +00:00