Commit Graph

172 Commits

Author SHA1 Message Date
Bill Meier 66d340863f (Minor) Cleanup signal callbak signatures and related:
- Don't mark callback arg as _U_ if actually used (and vice-versa);
- Use Null as user_data in g_signal_callback if unused in callback;
- Use correct signature for certain event callbacks.

svn path=/trunk/; revision=33895
2010-08-23 19:29:08 +00:00
Jeff Morriss e76dd3ebdb Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3387 (crash
when changing the font and deleting a column at the same time while using
the old packet list):

Don't calculate the default column widths until after both the font and column
preferences have been applied.

This isn't a problem in the new packet list.

svn path=/trunk/; revision=32500
2010-04-16 22:48:33 +00:00
Bill Meier 538dd47d5d Fix various gcc -Wshadow warnings.
svn path=/trunk/; revision=31731
2010-01-29 19:09:01 +00:00
Stig Bjørlykke 40b377bd66 Fixed opening correct preferences page.
svn path=/trunk/; revision=31149
2009-12-02 09:39:13 +00:00
Stig Bjørlykke 537cacc926 Added an option to open the Preferences directly in the Layout or Columns page.
svn path=/trunk/; revision=31084
2009-11-26 08:57:21 +00:00
Anders Broman c52de3ee90 Change option menu to combo box.
svn path=/trunk/; revision=30087
2009-09-23 14:30:56 +00:00
Jörg Mayer 32becb4637 () -> (void)
svn path=/trunk/; revision=28352
2009-05-13 17:29:13 +00:00
Stig Bjørlykke ccf0c65532 Initialize some uninitialized variables.
svn path=/trunk/; revision=28345
2009-05-13 10:03:12 +00:00
Bill Meier f7f397581e prefs_dlg: Cancel always reverts to "Last Saved" [Part 1]
svn path=/trunk/; revision=28276
2009-05-05 13:19:46 +00:00
Stig Bjørlykke 6e0dc25aa9 From Didier Gautheron (bug 3126):
Update expert info icon on redissect.

svn path=/trunk/; revision=28269
2009-05-04 21:13:14 +00:00
Bill Meier 40d7944873 prefs_column: Rework & cleanup Column Preferences dialog code
- Re-create packet-list only when Columns change vs every time Edit!Preferences invoked;
 - Select next row in Column List after delete of a row;
 - Remove no-longer needed code;
 - ...

svn path=/trunk/; revision=28268
2009-05-04 14:46:51 +00:00
Bill Meier 94c5bee0db prefs_dlg: Fix an inadvertant character deletion in last commit;
svn path=/trunk/; revision=28266
2009-05-03 17:57:06 +00:00
Bill Meier 6d5ce0f34e prefs_dlg: use consistent indentation
svn path=/trunk/; revision=28265
2009-05-03 17:50:51 +00:00
Guy Harris 54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
Bill Meier 8fcf19fad5 prefs_dlg: gtk_label_get() --> gtk_label_get_text()
svn path=/trunk/; revision=28033
2009-04-11 15:14:55 +00:00
Bill Meier 27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Stig Bjørlykke 62f60df6b4 From Jakub Zawadzki (bug 3331):
g_free() is NULL safe, so we don't need check against it.

svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
Stig Bjørlykke 680daffcaa Removed an unused argument to prefs_tree_page_add().
svn path=/trunk/; revision=26875
2008-11-29 12:43:16 +00:00
Stig Bjørlykke 8e568cd895 Save preferences when selected from menu, unless having enabled the save button.
Added a preferences icon to the menu.

svn path=/trunk/; revision=26872
2008-11-28 21:22:25 +00:00
Stig Bjørlykke 32b542de4f Use invisible event boxes so the preferences looks good when using themes.
svn path=/trunk/; revision=26502
2008-10-20 19:18:12 +00:00
Stig Bjørlykke 381285f61c Add filter autocomplete for more places we use filter entries.
svn path=/trunk/; revision=26491
2008-10-19 13:40:52 +00:00
Bill Meier 4b53209990 Remove some obsolete comments related to GTK 1.
svn path=/trunk/; revision=25949
2008-08-07 12:31:43 +00:00
Bill Meier 56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Stig Bjørlykke 860028c634 Removed the usage of topic_available() as we now have all topics.
svn path=/trunk/; revision=25505
2008-06-21 13:36:31 +00:00
Martin Mathieson 1ad98b5c11 Rename "Taps/Statistics" preference group to be simply "Statistics".
"Tap" is a term likely only to be known to developers, and
"Statistics" matches the Menu item under which all of the affected
windows are launched.

svn path=/trunk/; revision=25151
2008-04-23 16:49:34 +00:00
Martin Mathieson e158960f5a Rename prefs_rtp_player files to prefs_taps.
(see rev 25133)

svn path=/trunk/; revision=25143
2008-04-21 21:56:45 +00:00
Martin Mathieson d4dca0d94b Allow configuration of tap update interval.
- rename rtp_player config group to taps/statistics
- will rename prefs_rtp_player files later
  (svn didn't seem keen to rename with changes present,
   and output says its just a copy/delete anyway...)

svn path=/trunk/; revision=25133
2008-04-21 10:57:32 +00:00
Stig Bjørlykke a4f76f95a0 Added an option to display hidden protocol items.
svn path=/trunk/; revision=25108
2008-04-17 23:14:01 +00:00
Sake Blok a287b0f3f5 From Jim Young (bug 2212):
Add the profile name to the title of all the configuration windows.
(this is a rewrite of Jim's patch)


svn path=/trunk/; revision=25016
2008-04-14 15:01:34 +00:00
Ulf Lamping 6fd6381ab3 change all preferences related filenames from xy_prefs to prefs_xy
svn path=/trunk/; revision=24975
2008-04-13 13:10:32 +00:00
Ulf Lamping 644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping 55c2be83db move stock icon code from toolbar.c into specific stock_icons file(s)
svn path=/trunk/; revision=24921
2008-04-12 00:49:20 +00:00
Ulf Lamping 8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier 10f2ea11d5 OBECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24894
2008-04-11 16:26:32 +00:00
Anders Broman c973aa3830 Remove:
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif

svn path=/trunk/; revision=24868
2008-04-09 19:39:58 +00:00
Ulf Lamping df724f83cd remove GTK1 specific font handling
svn path=/trunk/; revision=24842
2008-04-08 04:47:32 +00:00
Ulf Lamping 3b7fe5fc6c remove GTK1 code
svn path=/trunk/; revision=24823
2008-04-07 00:42:04 +00:00
Michael Tüxen 4306c7037d Include epan/strutil.h for gtk-1.2 builds.
svn path=/trunk/; revision=24513
2008-03-01 10:23:57 +00:00
Stig Bjørlykke 7deec480ff Next attempt to cleanup some string functions, including:
strncpy -> g_strlcpy, strncat -> g_strlcat

svn path=/trunk/; revision=24504
2008-02-29 13:33:37 +00:00
Stig Bjørlykke 10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Jaap Keuter 44ea74a5da Move libsmi settings from virtual mibs protocol page to name resolution page.
svn path=/trunk/; revision=24131
2008-01-18 07:18:32 +00:00
Jaap Keuter 32e4818641 Whitespace cleanup of AIRPCAP code.
svn path=/trunk/; revision=24127
2008-01-17 22:28:31 +00:00
Jaap Keuter 2e0f8088c3 From Jim Young:
This patch provides a new RTP Player preferences dialog.  It allows one to
select the maximum number of visable channels in the RTP Player window.  The
default is four (4) channels which is the maximum number of usable channels 
that the RTP Player can display and still have access to the bottom row buttons 
on a 1024*768 resolution display.  Specifying a value less than 1 or greater than 
10 will be result in the RTP Player displaying the default 4 channels.

svn path=/trunk/; revision=24112
2008-01-16 07:36:34 +00:00
Tomas Kukosa a5ca7ec384 hide implementation of module list
(it makes easier change from GList to GTree as we have many modules now and GList implementation is slow for searching)

svn path=/trunk/; revision=23669
2007-11-29 07:52:52 +00:00
Ronnie Sahlberg 2830cf2045 fix the path to include g_ascii_strcasecmp.h
svn path=/trunk/; revision=23636
2007-11-28 01:23:09 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Stig Bjørlykke f174dede0a Avoid redraw hex dump windows if redissecting.
svn path=/trunk/; revision=23532
2007-11-21 18:56:05 +00:00
Stephen Fisher 9a0ecd31d1 Fix bug #1548: call of "Protocol Preferences" results in GTK error msg
at the command line


svn path=/trunk/; revision=21808
2007-05-16 21:45:02 +00:00
Graeme Lunt a51f1694c9 This change allows a structure to be created under the "Protocols" section of the preferences.
A new function is introduced, prefs_register_protocol_subtree(), that allows the subtree the protocol should appear under to be specified. The subtree is specified as a string, with a '/' delimiting each subtree element. For example,
	prefs_register_protocol(proto_dap, prefs_register_dap);
becomes
	prefs_register_protocol_subtree("OSI/X.500", proto_dap, prefs_register_dap);

The function will create all the intermediate subtree nodes that are required, if they don't already exist. 
This allows the grouping of procotols which should make the list of protocols more manageable as even more are added. The current aim is to group by protocol family e.g. 
+ OSI
  + X.400
      X.411
      X.420
  + X.500
      DISP
      DAP
      DOP
      DSP
  + X.509
      X509AF
      X509CE
      ...

but others grouping could be envisioned (e.g. by first letter). 

As the intermediate nodes may already have preferences (e.g. OSI), then modules are now allowed to have submodules. Previously each node was either a subtree or held preferences. This is consistent with the "User Interface" node.

The subtree structure has no effect on how the preferences are saved to file, and the "Protocol Preferences..." menu option will bring up the preferences expanded to the correct node.

In addition, a new "blank page" has been introduced for intermediate nodes that have no preferences (and is also used when the "Protocols" node itself is chosen). This prevents confusion when the user moves from a node with preferences to a node without preferences, but the page old page is still shown.

There is also a change to prevent '#' characters in a value being treated as a comment when parsing the preferences file. (There is nothing that adds comments when writing the preferences file.) 


svn path=/trunk/; revision=21066
2007-03-19 19:08:22 +00:00