Bug: 13069
Change-Id: Ia89b29413b565235c8af40adb5722b9e2528d651
Reviewed-on: https://code.wireshark.org/review/18559
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Rename attribute dissecting functions and their local variables to
improve code readability, and adjust white space.
old new
------------------------------------------------------------------
dissect_rohc_supported dissect_rohc_attribute
dissect_transform_ike2_attribute dissect_ike2_transform_attribute
option attribute
optlen value_len
rohc attr_type
transform_attr_type attr_type
cfg_attr_type attr_type
rohc_tree tree
transform_attr_type_tree tree
cfg_attr_type_tree tree
sub_rohc_tree attr_tree
sub_transform_attr_type_tree attr_tree
sub_cfg_attr_type_tree attr_tree
rohc_item attr_item
transform_attr_type_item attr_item
cfg_attr_type_item attr_item
------------------------------------------------------------------
Change-Id: I135e5deb802edc575e7fddd1bb397272aac0888c
Reviewed-on: https://code.wireshark.org/review/18553
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 13066
Change-Id: Ia00441a6eea49c56f75f1757041bc7732ff32d00
Reviewed-on: https://code.wireshark.org/review/18555
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Mirror it after protocol dissector API.
Change-Id: I7985bcfa9e07654c7cf005efec94efc205d7a304
Reviewed-on: https://code.wireshark.org/review/18496
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: I8c0d18f104bf37686b9b53ad9e7d1b9f8a709f5c
Reviewed-on: https://code.wireshark.org/review/18519
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
and reindent
Change-Id: I3c8835f03e52858e7cb3262043a3fc895b1c4d19
Reviewed-on: https://code.wireshark.org/review/18517
Reviewed-by: Michael Mann <mmann78@netscape.net>
When preference 'Assume bottom of stack label as flow label' is set
all labels are shown as flow labels. This has to be limited to that
MPLS label where Bottom-of-Stack is TRUE.
Change-Id: Iaa8abd095edb7de7f745a78c742a9347d4dbf3d9
Reviewed-on: https://code.wireshark.org/review/18516
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The point of sending an Enable Request is to enable the respective MO.
If the MO responds with any MO state != ENABLED there is something
fishy. Let's inform the user with some Expert Info about it.
Change-Id: Ib33e5dbc37894049b93bb71782787b8c96c04326
Reviewed-on: https://code.wireshark.org/review/18454
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Give the right buffer to the decoding function
Bug: 13065
Change-Id: I0e41e04fb68602d95ea6f060c1a37c8b8596134d
Reviewed-on: https://code.wireshark.org/review/18548
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Will now show country and operator
Change-Id: Ic16623c226228ab0c3e31d33cda81953c80551d6
Reviewed-on: https://code.wireshark.org/review/18512
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Also add expert info for failing conversion.
Change-Id: I75bb385c430527e41775822ab0495684ab660c08
Reviewed-on: https://code.wireshark.org/review/18431
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
In OM2000, it is not usual to receive NACK, REJECT or "performed not
according to request" type messages. Let's highlight them using expert
info as a convenience to the user.
Change-Id: I47b865c32fd9ec82ec63699babd31f3849f3006c
Reviewed-on: https://code.wireshark.org/review/18453
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
There are some IEs in the Downlink Data Indication which are
conditional. As the condition cannot be found in the packets
themselves (to my knowledge), let's introduce a preference.
Change-Id: I408c73e5f48018d3ea4ebcacb7bd94358a9eaac5
Reviewed-on: https://code.wireshark.org/review/18482
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: I6ebc828eb7eafd3ca41275a9b0b9b45a0994a7d3
Reviewed-on: https://code.wireshark.org/review/18493
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Modbus RTU is typically seen over serial links, which can be captured
by sniffing USB traffic. This patch enables decoding USB payloads as
Modbus RTU.
Bug: 13055
Change-Id: I70d970760aa1b37b0f56dda9d3384e72d27c9d0a
Reviewed-on: https://code.wireshark.org/review/18468
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
