Commit Graph

35389 Commits

Author SHA1 Message Date
Jeff Morriss 664c69dbaa Use proto_tree_add_item() when it saves us from having to retrieve the value
and without causing us to potentially run into bug 3834.

Add a couple hf entries for things that had been added with add_text().

svn path=/trunk/; revision=36946
2011-04-29 02:16:13 +00:00
Jeff Morriss 6b13963a63 If we're in a message return (UDTS or XUDTS), set pinfo->in_error_pkt to help
make it obvious to the user that this is an error message.

Fix up some indentation.

svn path=/trunk/; revision=36945
2011-04-29 01:45:34 +00:00
Jeff Morriss 53e5c3422c Add default color filters for SCTP abort messages and checksum errors.
svn path=/trunk/; revision=36944
2011-04-29 01:28:28 +00:00
Anders Broman e0c80c4138 From Pascal Quantin:
the dissection of the UE capabilities when the RAT
type is set to geran-cs (the value part of Classmark 2 starts at the third byte). 
Moreover it adds a subtree to enhance the display of Mobile Station Classmark 2 and 3 and MS Radio Access Capability IEs.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5867

svn path=/trunk/; revision=36943
2011-04-28 19:59:14 +00:00
Guy Harris 94afa45fbf Array indices are integers, not Booleans. (The code is the same, given
that TRUE is #defined as 1 and FALSE is #defined as 0, but let's not
depend on that.)

svn path=/trunk/; revision=36942
2011-04-28 19:00:28 +00:00
Bill Meier 597f4b28bb Remove an XXX comment;
svn path=/trunk/; revision=36941
2011-04-28 18:18:30 +00:00
Bill Meier c22cde8de5 External subdissectors should be called regardless of 'if(tree)'.
svn path=/trunk/; revision=36940
2011-04-28 18:01:38 +00:00
Bill Meier 60c04b1d84 Add missing $Id$ and "Wireshark ... Copyright ..."
svn path=/trunk/; revision=36939
2011-04-28 15:52:32 +00:00
Bill Meier 3fe0a82016 Remove an unneeded forward declaration (fixes compiler error);
Move a global variable to be local to proto_reg-handoff...

svn path=/trunk/; revision=36938
2011-04-28 15:18:54 +00:00
Bill Meier 18e5081475 Add missing "Wireshark .... Copyright ..".
svn path=/trunk/; revision=36937
2011-04-28 14:59:31 +00:00
Bill Meier a1b99c7218 Convert what appears to be the use of "4 space tabs" to spaces.
svn path=/trunk/; revision=36936
2011-04-28 14:48:39 +00:00
Bill Meier 8f0f8a5435 #include <stdio.h> not req'd;
Define all internal fcns as static;
fragment_table_init() & reassembled_table_init() need to be
  called form a registered_init fcn;
proto_register... and proto_reg_handoff should be at the end of the file as
  per Wireshark convention;
proto_reg_handoff .... doesn't need 'if (initialized)...';
proto_register... doesn't need 'if (proto_mux27010 == -1)...'

svn path=/trunk/; revision=36935
2011-04-28 14:38:29 +00:00
Anders Broman 1648ab23e9 Minor updates.
svn path=/trunk/; revision=36934
2011-04-28 14:22:18 +00:00
Anders Broman 20b894a9d2 Add grouped AVP:s
svn path=/trunk/; revision=36933
2011-04-28 13:43:23 +00:00
Jeff Morriss e84589d205 Add SVN Id tag. Don't use deprecated dissector_add().
svn path=/trunk/; revision=36932
2011-04-28 13:14:36 +00:00
Jakub Zawadzki 6aa7c2d371 Try to fix:
value_string.c(175) : warning C4244: '=' : conversion from '__int64' to 'gint', possible loss of data

svn path=/trunk/; revision=36931
2011-04-28 11:53:29 +00:00
Jakub Zawadzki 1ea1e9fef2 Change value_string_ext->_vs_match to return value_string struct (instead of strptr),
Now index can be easily calculated so remove idx pointer from all match functions.

Just in case change names if someone is using wireshark internals.

svn path=/trunk/; revision=36930
2011-04-28 11:15:46 +00:00
Stig Bjørlykke de18d83f61 Initialize if_device to NULL at start and when g_free.
This fixes a bug introduced in revision 36741.

svn path=/trunk/; revision=36929
2011-04-28 08:48:35 +00:00
Stig Bjørlykke 42f8e1fa5a Removed unused variables and functions.
Terminate strings by setting the first char to 0.

svn path=/trunk/; revision=36928
2011-04-28 06:39:56 +00:00
Anders Broman a663d91ca6 From Hans-Christoph Schemmel:
A variant of 3GPP TS 27.010 multiplexing protocol dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5829

svn path=/trunk/; revision=36927
2011-04-28 05:36:26 +00:00
Anders Broman c752fb8b87 Fix warnings:
packet-radiotap.c(240) : error C2220: warning treated as error - no 'object' file generated
packet-radiotap.c(240) : warning C4305: 'initializing' : truncation from 'double' to 'const float'
packet-radiotap.c(310) : warning C4305: 'initializing' : truncation from 'double' to 'const float'
packet-radiotap.c(315) : warning C4305: 'initializing' : truncation from 'double' to 'const float'
packet-radiotap.c(370) : warning C4305: 'initializing' : truncation from 'double' to 'const float'
packet-radiotap.c(380) : warning C4305: 'initializing' : truncation from 'double' to 'const float'

svn path=/trunk/; revision=36926
2011-04-28 05:11:53 +00:00
Jeff Morriss 1722bec6e7 From Roland Knall via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5786 :
This patch registers a dissector table to allow other dissectors to register as
subdissectors for modbus/tcp data.

Additionally it registers the dissector, so it can be invoked by another
dissector by name.

Additionally this version of the patch adds the Data field not as a text field,
but rather as a field which can be selected and tested for by name.

svn path=/trunk/; revision=36925
2011-04-28 03:01:54 +00:00
Jeff Morriss ed8ea7bb34 After testing for the presence of python-config, fix typo so that we actually
test whether we found it or not.

If the user asked for Python support, error out if we find we can't use it.

svn path=/trunk/; revision=36924
2011-04-28 02:24:46 +00:00
Jeff Morriss 9cb00ac9fc Fix one of the complaints in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5818 :
Create the wspy_dissectors data directory (by installing the one example
dissector).  This dissector won't be loaded (its name doesn't match the regexp)
but it forces the presence of the directory (so people will know where to put
their dissectors).

svn path=/trunk/; revision=36923
2011-04-28 01:53:40 +00:00
Jeff Morriss 39d326a77c Don't dump core if Python was not able to load the dissector registration file
(e.g., due to a syntax error).

svn path=/trunk/; revision=36922
2011-04-28 01:45:23 +00:00
Bill Meier 4e782042de #include <stdlib.h> not needed;
use consistent indentation.

svn path=/trunk/; revision=36921
2011-04-28 01:07:43 +00:00
Gerald Combs 3af2a4c81f From Juliusz Chroboczek via bug 5812:
This should not trigger with any Babel packets generated by the current
version of babeld, but could potentially do so with a future version
that performs more aggressive compression for IPv4 addresses.

svn path=/trunk/; revision=36920
2011-04-27 23:20:15 +00:00
Guy Harris d7b8350c7c Picky, picky....
While we're at it, catch invalid MCS/channel width/GI combinations.

svn path=/trunk/; revision=36919
2011-04-27 23:06:23 +00:00
Anders Broman 7dce5861cc From Pascal Quantin:
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
2011-04-27 22:18:00 +00:00
Jeff Morriss b798f159bf My version of Python (2.5.2) core dumps if PySequence_Check is called with a
NULL pointer (because no dissectors were registered).  Don't call that function
with a NULL pointer.

Also update the output when no dissectors are registered.  Not sure if we
should be printing *anything* in this situation, but for now make the output
interesting.

svn path=/trunk/; revision=36917
2011-04-27 22:15:42 +00:00
Guy Harris 49b410ffbe Put the rate in for the MCS field, if all the information needed to
calculate the rate is present.

Don't put the rate in for MCS indices in the Rate field - we need not
only the MCS index but the bandwidth (20 MHz vs. 40 MHz) and the length
of the guard interval.  Note in a comment that those other items *might*
be available from some other radiotap fields.

Expand a comment on the hack to try to figure out whether a Rate field
with the 0x80 bit set is a FreeBSD MCS index or a high data rate.

svn path=/trunk/; revision=36916
2011-04-27 21:59:47 +00:00
Jeff Morriss 90a78c635a Fix part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4878 :
Put our one python example in the source distribution.

svn path=/trunk/; revision=36915
2011-04-27 21:26:38 +00:00
Bill Meier 89f055b5fd Comment out some unused code;
Use #if 0/#endif to comment out some code instead of using /* */;
Use consistent indentation & do some whitespace cleanup.

svn path=/trunk/; revision=36914
2011-04-27 19:40:20 +00:00
Bill Meier f396f68124 Remove unneeded #include <stdlib.h>;
Use consistent indentation;
Add editor modelines;
Use #if 0/#endif to comment out code instead of /* */.

svn path=/trunk/; revision=36913
2011-04-27 19:24:32 +00:00
Bill Meier 00d378fbf8 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36912
2011-04-27 18:13:31 +00:00
Bill Meier c588ff282a From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36911
2011-04-27 18:09:39 +00:00
Bill Meier fafe30d42d From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36910
2011-04-27 17:58:22 +00:00
Bill Meier 1ab1009cc4 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  Do some (minor) indentation cleanup..

svn path=/trunk/; revision=36909
2011-04-27 17:39:25 +00:00
Bill Meier e73a3a0cb5 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  Do some (minor) whitespace cleanup and re-formatting.

svn path=/trunk/; revision=36908
2011-04-27 17:30:39 +00:00
Bill Meier 5c778feb6b From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  #include <string.h> not req'd.


svn path=/trunk/; revision=36907
2011-04-27 17:22:20 +00:00
Bill Meier e777d9e375 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  #include <stdlib.h> not req'd;
  Do some whitespace cleanup.

svn path=/trunk/; revision=36906
2011-04-27 17:15:57 +00:00
Bill Meier 7ba088eaa5 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  #include <stdlib.h> not req'd.


svn path=/trunk/; revision=36905
2011-04-27 17:06:54 +00:00
Bill Meier 62cea3bb0a #include <stdlib.h> not required;
Whitespace cleanup.

svn path=/trunk/; revision=36904
2011-04-27 17:00:04 +00:00
Bill Meier abf57a9af2 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36903
2011-04-27 16:34:37 +00:00
Bill Meier 77d86cadf5 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  Remove uneeded #include <stdlib.h>, <gmodule.h>;
  Do some whitespace cleanup.

svn path=/trunk/; revision=36902
2011-04-27 16:29:09 +00:00
Bill Meier 3db5412ee7 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36901
2011-04-27 16:25:05 +00:00
Jeff Morriss 211b659885 From Mathieu Parent via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5826 :
Attached patch fixes dissection of ServiceURLStatMessage.

svn path=/trunk/; revision=36900
2011-04-27 15:23:20 +00:00
Jeff Morriss 889d33c6b2 From Anand Thakur via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5843 :
This diff files includes some AVPs from Ericsson GGSN documentation used for Gx
messaging between a GGSN and a PCRF.

From me: correct one spelling mistake.

svn path=/trunk/; revision=36899
2011-04-27 14:10:55 +00:00
Jeff Morriss 4794e37bbc Put the length of the country code in parenthesis (for readability).
svn path=/trunk/; revision=36898
2011-04-27 13:32:28 +00:00
Jakub Zawadzki 1b8aa36735 Packet editor: add support for FT_BOOLEAN, and integer bitmasks.
svn path=/trunk/; revision=36897
2011-04-27 12:53:57 +00:00