- Simplify proto_reg_handoff() & move it to the end of the file as per convention;
- Reformat hf[] & ei[] for readability;
- Add editor modelines & do whitespace changes.
Change-Id: If01432c5b86129aaaab478493bbb218295bcb65c
Reviewed-on: https://code.wireshark.org/review/3622
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Move them to the end of the list of optional programs.
Make it clear that echld is not built by default.
Change capitalization of tshark and tfshark.
Change-Id: Ib702ed72eb2469968e06a16c73a4009ba4cf68ad
Ping-Bug: 10380
Reviewed-on: https://code.wireshark.org/review/3596
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
bug:10384
Signed-off-by: oyv <ronningstad@gmail.com>
Change-Id: Ic31772c551f36fc8d144a5eaeae987a1e5f3e3f1
Reviewed-on: https://code.wireshark.org/review/3601
Reviewed-by: Michael Mann <mmann78@netscape.net>
(cherry picked from commit 9337e7962df8bc12f27019b20dedbb2311669949)
Change-Id: Ic31772c551f36fc8d144a5eaeae987a1e5f3e3f1
Reviewed-on: https://code.wireshark.org/review/3609
Reviewed-by: Michael Mann <mmann78@netscape.net>
This will, at least, make it show up as the meaning of a field
containing an NLPID; whether it's actually used to say "a TRILL packet
follows" is another matter.
At least partially addresses bug 10382, and fully addresses it if it's
never actually used to say "a TRILL packet follows".
Change-Id: Ic9dc8ec432532bde692fad3aa9cc97a3109aa634
Reviewed-on: https://code.wireshark.org/review/3602
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Convert textify.sh to PowerShell. Use PowerShell's built-in line ending
conversion so that we don't depend on unix2dos.
Only copy the help toc and text files to the staging directory.
Add PowerShell to the Developer's Guide. Fixup some other content.
(asn1/Makefile.inc.nmake contains a call to u2d. Hopefully that's not
a problem.)
Change-Id: I61a92aa54820d01015abb9ffa65815558ae31c71
Reviewed-on: https://code.wireshark.org/review/3487
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Other minor cleanup while in the neighborhood.
Change-Id: If73a029f564219782c313d4154c24c7ce7458b52
Reviewed-on: https://code.wireshark.org/review/3574
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix apparent cut-n-pasteo: if offset_e is set then we should be looking
at offset_e (instead of offset_s) and ts_end (instead of ts_start).
Bug: 10370
Change-Id: I0683ad55ac782c7fd03b7dbdf3f34df713267de5
Reviewed-on: https://code.wireshark.org/review/3589
Reviewed-by: Evan Huus <eapache@gmail.com>
The echo and output of make-dissector-reg.py is sufficient.
Change-Id: I89462435e8966012ec057ccd45adb595f692b0fb
Reviewed-on: https://code.wireshark.org/review/3587
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Add support for the taskbar progress indicator on Windows via
QtWinExtras. It is almost as if we're a grown up Windows application.
Change-Id: I378206b49510d4bd08f2437d8e9a1b01bc6f1351
Reviewed-on: https://code.wireshark.org/review/3576
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
errors out if you %exclude a file that's not there.
Fixes the issue reported by Chris on the -dev list.
Change-Id: If8d8b6a9ee69c3d94756b729a809f3c04fc2517f
Reviewed-on: https://code.wireshark.org/review/3586
Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
Petri-Dish: Christopher Maynard <Christopher.Maynard@gtech.com>
Change-Id: I18b6e17091c0f019535a0dc1734e60795339bb04
Reviewed-on: https://code.wireshark.org/review/3584
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
(the existing code uses bus_id 0 by default and creates a new conversation)
Change-Id: I33a105bdf4218ac2dd21cf76825e972ff2dd1b9b
Reviewed-on: https://code.wireshark.org/review/3583
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: I338ce8d6eb0865af9d0f5669c44389ade2bf0f49
Reviewed-on: https://code.wireshark.org/review/3582
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
store the major spec version there
Change-Id: I55564cbca7fb9faa307f1a684858d2e5d2393fc9
Reviewed-on: https://code.wireshark.org/review/3581
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
dissect the AC interface header descriptor
Change-Id: I10f81e5cbf3837d958b255b5a3405ac2465b171f
Reviewed-on: https://code.wireshark.org/review/3580
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
reject the descriptor if the class is not audio
Change-Id: Ie07f0fb711884e63cbe86d9417570108edd6b5ab
Reviewed-on: https://code.wireshark.org/review/3578
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: I0ad2168f89f8c4fbb2d2324f60de1276d023b41c
Reviewed-on: https://code.wireshark.org/review/3579
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: Idd590dc4d79c1a550d35544b46a79a5cc755f503
Reviewed-on: https://code.wireshark.org/review/3577
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
- We now support Gtk+-3, Gtk+-2, and Qt (Gtk+-1 is long dead).
- Sync several of the configure options to what ./configure actually does
(don't bother listing features which default to disabled though).
- Don't mention sysconfdir since manuf doesn't go there any more (it goes
in datadir).
- Remove special install instructions for an ancient version of libpcap.
- Point users to the Q&A site.
Change-Id: I96a9e13fcf4225c526c5d9b536425b2d20e659f6
Reviewed-on: https://code.wireshark.org/review/3566
Reviewed-by: Evan Huus <eapache@gmail.com>
/home/jmayer/work/wireshark/git/epan/dissectors/packet-ipp.c: In function ‘dissect_ipp’:
/home/jmayer/work/wireshark/git/epan/dissectors/packet-ipp.c:583:78: error: ‘name_val’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if ((name_length > 5) && name_val && !strcmp(name_val+name_length-5, "-time")) {
^
/home/jmayer/work/wireshark/git/epan/dissectors/packet-ipp.c:557:11: note: ‘name_val’ was declared here
char *name_val;
^
Change-Id: I5e49596010572b285e4ca8f210cdcf49d56bfc10
Reviewed-on: https://code.wireshark.org/review/3572
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
In file included from /home/jmayer/work/wireshark/git/epan/wslua/lrexlib_glib.c:199:0:
/home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h: In function ‘generic_find_func’:
/home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h:486:14: error: ‘ud’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
TUserdata *ud;
^
/home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h: In function ‘algf_gsub’:
/home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h:281:14: error: ‘ud’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
TUserdata *ud;
^
Change-Id: I835103ea562ced44bc3cce5fadf6115476a78d0e
Reviewed-on: https://code.wireshark.org/review/3568
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
We can't use tree_item == NULL to determine which branch of the previous if was
hit, since proto_tree_add_item can return NULL when run without tree, which was
leading to an infinite loop since we were never advancing the offset. Use the
actual locator_type instead.
Introduced by either g3635d7bed70 or gebff85fdbb although neither of them
directly touch this code path. I'm guess that g3635d7bed70 removed an if (tree)
guard in some calling function which would have prevented this, but I haven't
checked. The bug would still have been there before, it just wouldn't have been
hit because it's only present with a NULL tree. Somebody more familiar with the
protocol should probably go over a capture or two and make sure this isn't a
symptom of some other decoding gone awry in the recent changes.
Change-Id: Ie1ce89b16ef667b437c0d99c25e3f3cb2504347d
Reviewed-on: https://code.wireshark.org/review/3564
Reviewed-by: Evan Huus <eapache@gmail.com>
This patch adds additional header decoding information, such as header
encoding representation, including header table size update (HPACK
draft-09, section 7).
Previously when user clicks the decoded header info, it highlights
wrong byte sequence in compressed pane. This patch fixes this and now
clicking header will highlight the byte sequence it was decoded from.
Change-Id: I611a34edef31640c59a1f8bbc26db1c42eb16ce2
Reviewed-on: https://code.wireshark.org/review/3407
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Remove some trailing white space at the same time.
(The ./configure options in INSTALL are significantly out of date--that will
be the subject of a separate commit.)
Change-Id: I3c03f90dab099e6d3386a235f35b691e7ff671be
Reviewed-on: https://code.wireshark.org/review/3563
Reviewed-by: Daniel Black <danielblack@fedoraproject.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
This improves the detection of Diameter messages within a TCP bytestream (i.e.,
when the Diameter PDUs don't neatly align with frames).
Bug: 10362
Change-Id: I49a6e8cf076a6ab8a14761493aab9f3b11e4756e
Reviewed-on: https://code.wireshark.org/review/3557
Petri-Dish: Evan Huus <eapache@gmail.com>
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Bill Meier