Commit Graph

86808 Commits

Author SHA1 Message Date
Martin Mathieson 7199a04c4c BTLE: Fix a copy/paste error in control_opcode_vals 2023-01-23 10:32:52 +00:00
Gerald Combs 6787835373 [Automatic update for 2023-01-22]
Update manuf, services enterprise numbers, translations, and other items.
2023-01-23 00:27:45 +00:00
Gerald Combs cd9f7b64c7 Logray: Remove the "Follow Stream" dialog
We don't reassemble log data into streams, so remove the "Follow" dialog
(for now, at least).
2023-01-22 23:36:23 +00:00
John Thacker b71d87ed27 Gitlab CI: Switch to the OpenSUSE 15.4 container
15.3 has reached EOL: https://en.opensuse.org/Lifetime
2023-01-22 22:59:13 +00:00
João Valverde c864a8a994 Release Notes: Fixup entry 2023-01-22 17:42:22 +00:00
John Thacker dda2ead9c0 rpm: Update spec for latest dependencies
SpeexDSP is now required.
Update the required cmake and glib versions.
Our CMake build process now expects a C++ compiler to always be present,
so require it even if not building the GUI.

Only default to Qt 6 on distributions where we know we have it,
otherwise default to Qt 5 for now.

Update the required RPM version to 4.13 (which all distributions that
can currently build have) to ensure we have Boolean dependencies.
Use Boolean dependencies instead of checking the distribution, hopefully
to improve building on various other RPM-based distributions.

Redefine the cmake_install macro on SUSE to what is used on RH/Fedora.
The default SUSE macro calls the builder (make or ninja) insted of
cmake --install, which makes it difficult to pass options.

Remove tests and workarounds for RHEL 7, and SUSE < 15.2, since those
distributions are too old to build anyway.
Remove a workaround for an old broken librotli-devel package in
SUSE that's been long since fixed.
2023-01-21 23:49:35 -05:00
John Thacker c65d5a0a80 wiretap: Reprocess Name Resolution Blocks during redissect
Keep name resolution information as mandatory elements for
NRBs, and when the ipv4 or ipv6 callback is set, have name
resolution entries from already read NRBs sent to the callback.
rescan_packets can use this when redissecting to reobtain the
name resolution entries from the NRB, similar to what is done
with Decryption Secrets Blocks. (This can also later be used
if we read NRBs and DSBs in pcapng_open before the first packet,
and before the callbacks are set.)

This doesn't yet make the changes to wtap_dumper to write them out,
but is a step towards that too. (It's not clear in cases where we
dissect packets whether we want to copy the entire NRB, or only
write out actually used addresses as done now. For copying without
reading a file, like with editcap, we presumably do want to copy them.)

Fix #13425. Ping #15502
2023-01-21 22:25:03 +00:00
João Valverde ee5435784d Add an item to the release notes 2023-01-21 17:42:09 +00:00
Alexis La Goutte 3c97c2f226 BGP: Fix check warning
packet-bgp.c hf_bgp_ls_tlv_te_default_metric_value : - filter 'bgp.ls.tlv.te_default_metric_value' appears consecutively - labels are 'TE Default Metric (old format)' and 'TE Default Metric'
packet-bgp.c:4026 proto_tree_add_item called for hf_bgp_mcast_vpn_nlri_source_as  -  item type is FT_UINT16 but call has len 4
packet-bgp.c:4095 proto_tree_add_item called for hf_bgp_mcast_vpn_nlri_source_as  -  item type is FT_UINT16 but call has len 4
2023-01-21 14:57:33 +00:00
João Valverde ad8118b14a RPM: Try to fix build on openSUSE
SUSE defines %cmake_install as something other than cmake install.
2023-01-21 14:36:51 +00:00
Joakim Karlsson dee461254b GTPv2: Track Session during Inter RAT Mobility signaling 2023-01-21 14:33:04 +00:00
Dylan Ulis 39d9c77109 ENIP: CPF format only applies to List responses 2023-01-21 13:34:09 +00:00
João Valverde 630bb1ccee Debian: Try to fix build 2023-01-21 12:52:50 +00:00
João Valverde 133bebb18b Qt: Fix build with Qt version < 5.14 2023-01-21 12:14:07 +00:00
Martin Mathieson c84a54c82f Checked encoded values for proto_tree_add_item() 2023-01-21 11:16:20 +00:00
Alexis La Goutte 2bde511bb5 SMB2: Add (Request) Lock Sequence Number/Index
Close 18810
2023-01-21 01:01:46 +00:00
João Valverde 8f67074e36 Actually load user extcaps from the new path
Don't just say it, do it too.

Follow-up to 39124f2f8f.
2023-01-21 00:37:49 +00:00
João Valverde 5b57eb61f1 RPM: Fix breakage because of $docdir
%docdir only marks a directory as containing documentation.
It also needs to be included.
2023-01-21 00:05:20 +00:00
João Valverde 39124f2f8f Fix Personal Extcap folder path
The personal extcap folder $XDG_CONFIG_DIR/wireshark on Linux is
inconsistent with the global extcap folder (lib/wireshark/extcap)
and personal plugins folder (.local/lib/wireshark/plugins) and also
the configuration folder should not contain architecture-specific files.

The extcap personal folder is changed from:

    .config/wireshark/extcap

to:

    .local/lib/wireshark/extcap
2023-01-20 22:30:26 +00:00
John Thacker b230aa1df0 epan: Do not add dependent packets more than once
Do not add a dependent frame if it's already been added to a
frame's list. Do not mark a frame as a dependent of a displayed
frame if we've already marked it as such in this pass.

Clear the list of dependent frames if we reset the frame data,
because the list of dependent frames depends on the dissection
and may not be valid if redissecting (because, for example,
a reassembly preference may have changed.)

Move the pointer to the list of dependent frames away from the
bitfields to a location that minimizes the struct size.

Fixup f870c6085d
Fix #18809
2023-01-20 16:16:47 +00:00
João Valverde 8bbe35aaf7 AUTHORS: Fix non-standard entry format 2023-01-20 15:43:47 +00:00
hidd3ncod3s f268ef2f17 Support for TDS SSPI Token parsing. 2023-01-20 15:01:36 +00:00
João Valverde d7427e73af Qt: Fix capitalization of About->Folder characterization
Capitalize Lua as a proper name.

Uncapitalize "Extcap Paths" for consistency.
2023-01-20 14:55:23 +00:00
João Valverde 28a4466c7b NSIS: Leave old uninstall entries intact 2023-01-20 13:45:31 +00:00
João Valverde c66fc43e5b GUI: Ship authors as a Qt resource file 2023-01-20 13:35:03 +00:00
Martin Mathieson be51acfffb Fix some issues seen by tools/check_typed_item_calls.py 2023-01-20 12:47:59 +00:00
João Valverde 5f63989ee0 Update authors file in place
Instead of having AUTHORS.src and copying that to a new AUTHORS
file with git log information appended to that have a single
AUHTORS file and update it in place with git log info.
2023-01-20 12:04:57 +00:00
João Valverde 597bcca9ee wsutil: Add get_docfile_path() 2023-01-20 10:16:20 +00:00
PMcL d45a733258 mako: Updated Metamako trailer dissection
Minor updates to some variable names and wording of fields.
2023-01-20 09:27:01 +00:00
Alexis La Goutte 8080189ff3 h261: remove if(tree) check
not longer needed
2023-01-20 07:36:05 +00:00
Alexis La Goutte d4932b3313 h261: Remove extra space 2023-01-20 07:36:05 +00:00
Alexis La Goutte 1844094e07 H261: Fix encoding of H261 vmvd
Close #18812
2023-01-20 07:36:05 +00:00
John Thacker 199ecf2983 Qt: Clear selection, not current, in drawCurrentPacket
QItemSelectionModel tracks both the selected index and the
current index.

PacketList redraws when the *selected* index changes, not
the current index. Clearing the current index, and then marking
the same packet as selected and current fires currentChanged but
not selectionChanged. So drawCurrentPacket needs to call
clearSelection(), not clearCurrentIndex(), in order to trigger
a redissection of the currently selected packet and update
the packet details.

For example, if you mark or unmark the currently selected frame,
this causes the packet details to update. Cf 52955b9c43,
which fixed the same issue but for Find Packet.

Fix #14330.
2023-01-19 19:51:37 -05:00
John Thacker c380f516a2 GTP, GTPv2: Add request/response framenum types
Add the appropriate FT_FRAMENUM string types to the request
and response fields for GTP and GTPv2, so that arrows are
drawn for the related packet symbols.
2023-01-20 00:51:19 +00:00
João Valverde c22f47bba6 Wix: Remove leftover component 2023-01-19 22:17:11 +00:00
John Thacker 38fbccd33e Follow: Remove use of follow type from FollowStreamDialog
We can check if we have a follower. follow_type_t is still
used in the constructor, for now, since other parts call it.
2023-01-19 14:49:37 -05:00
João Valverde 2ab291b3b2 GUI: Ship license + acknowledgements as Qt resource 2023-01-19 19:14:32 +00:00
John Thacker 0a840b5dd8 Follow: Remove check for FOLLOW_TCP for fragments in Qt
Only TCP uses fragments, but we don't need to check FOLLOW_TCP
because the fragments pointers exist but are null if not being
used. See the similar code in epan/follow.c

Part of making it simpler for dissectors to register with Follow.
2023-01-19 18:34:45 +00:00
Sergey V. Lobanov 4d2d0b7f6d MP4: add support for segment boxes (styp, sidx)
sidx and styp boxes are implemented according to 3GPP TS 26.244
Both boxes are added as mp4 magic bytes due to mp4 segments start from them

pcap and mp4 samples: https://wiki.wireshark.org/SampleCaptures#mp4-init-segments-and-segments
2023-01-19 17:59:50 +00:00
João Valverde 776aafc7de CMake: Install CSS to DOCDIR 2023-01-19 17:55:20 +00:00
Kevin Grigorenko 43c5eedc97 Handle NULL http2_session_t parsing an H2 settings frame 2023-01-19 17:35:48 +00:00
João Valverde 74909f1499 Install PDML files to DOCDIR
Add README because this stuff is somewhat obscure and move XSLT
file to DOCDIR because it is not used by wireshark directly.
2023-01-19 17:08:36 +00:00
Joakim Karlsson c06a38da31 CMake: Update a compiler version check 2023-01-19 16:58:58 +00:00
Jorge Mora ae4868f4bd NFS: fix IO_ADVISE hints mask
Use correct tree for hints mask in IO_ADVISE so it is displayed
properly within the operation.
2023-01-19 15:40:38 +00:00
John Thacker 1dac8660fc DHCP: Use BASE_CUSTOM for formatting time options
Use BASE_CUSTOM and custom formatting functions for formatting
DHCP options that are time fields, instead of
proto_tree_add_uint_format_value(). This makes the formatted form
show up in columns.

Fix #18743
2023-01-19 09:41:55 +00:00
João Valverde 59b15749af Wix: Remove stale reference to dftest 2023-01-19 09:15:13 +00:00
Mikael Kanstrup c4db402db5 Add follow websocket stream support
The websocket protocol masking feature makes follow TCP stream
on websocket traffic show masked payload. To easily view unmasked
and reassembled websocket payload add follow websocket stream
support.
2023-01-19 03:14:18 +00:00
João Valverde 06519be205 Install documentation (HTML manuals) to DOCDIR
Install documentation to DOCDIR instead of DATADIR.
The code must be fixed to open the Help URLs from
this new path.

This only affects Unix-like FHS platforms. Windows
installation does its own thing.

Needs testing with macOS packaging.
2023-01-19 01:40:59 +00:00
João Valverde 9c9c5343d8 RPM: Remove some unnecessary doc files
INSTALL and READMEs for all the different platforms are totally
unnecessary and arguably wrong. ChangeLog is not useful either IMO.
2023-01-19 00:27:50 +00:00
João Valverde 9e6faf4169 Remove dftest man page
DFTest is a private test utility and isn't installed anywhere.

I don't think it makes sense to maintain a man page. Certainly
doesn't make sense to ship it.

The doc file is understandably minimal so just nuke it.
2023-01-19 00:17:56 +00:00