osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Use g_snprintf instead of sprintf: Coverity 622. 

Use g_strlcpy instead of strcpy: Coverity 632.

svn path=/trunk/; revision=36595
This commit is contained in:
Chris Maynard 2011-04-12 17:52:52 +00:00
parent bbea8c7cf7
commit f9fa7e8def
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
capinfos.c
View File

@ -803,7 +803,7 @@ hash_to_str(const unsigned char *hash, size_t length, char *str) {
int i;
for (i = 0; i < (int) length; i++) {
sprintf(str+(i*2), "%02x", hash[i]);
g_snprintf(str+(i*2), 3, "%02x", hash[i]);
}
}
#endif /* HAVE_LIBGCRYPT */
@ -1033,9 +1033,9 @@ main(int argc, char *argv[])
for (opt = optind; opt < argc; opt++) {
#ifdef HAVE_LIBGCRYPT
strcpy(file_sha1, "<unknown>");
strcpy(file_rmd160, "<unknown>");
strcpy(file_md5, "<unknown>");
g_strlcpy(file_sha1, "<unknown>", HASH_STR_SIZE);
g_strlcpy(file_rmd160, "<unknown>", HASH_STR_SIZE);
g_strlcpy(file_md5, "<unknown>", HASH_STR_SIZE);
if (cap_file_hashes) {
fh = ws_fopen(argv[opt], "rb");