From ed9c9cc01a67df9d75d084302eb5c42a69f36c47 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Sun, 29 Oct 2006 20:56:00 +0000 Subject: [PATCH] from Stephen fischer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Attached is a patch to fix bug #1163: "Dissector bug. ISO8073 COTP protocol."  The SES dissector was incorrectly believing it had PDUs within the COTP PDUs.  I added an additional heuristic check to see if the length of the SES PDU is 0, then return false since it can't be zero length. Thanks,  Steve svn path=/trunk/; revision=19733 --- epan/dissectors/packet-ses.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/epan/dissectors/packet-ses.c b/epan/dissectors/packet-ses.c index 022f39719b..6ba5dd9739 100644 --- a/epan/dissectors/packet-ses.c +++ b/epan/dissectors/packet-ses.c @@ -1803,6 +1803,9 @@ dissect_ses_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree) /* OK,let's check SPDU length */ /* get length of SPDU */ len = get_item_len(tvb, offset+1, &len_len); + if(len == 0) + return FALSE; /* Not a valid PDU */ + /* add header length */ len+=len_len; /* do we have enough bytes ? */