osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix two cases of 'if (x = y)' which should be 'if (x == y)'. 

Found by reviewing msvc level 4 warnings "assignment within conditional expression".

(Unfortunately most of the warnings are false positives so this warning can't be enabled)



svn path=/trunk/; revision=35726
This commit is contained in:
Bill Meier 2011-01-31 18:58:38 +00:00
parent 88d53d925f
commit ed78f0a33e
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-dcm.c
View File

@ -5348,7 +5348,7 @@ dissect_dcm_tag_value(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, dcm_s
else if ((val8 >= 0x20) && (val8 <= 0x7E)) {
/* No extended ASCII, 0-9, A-Z, a-z */
}
else if ((i == vl_max -1) && (val8 = 0x00)) {
else if ((i == vl_max -1) && (val8 == 0x00)) {
/* Last Byte can be null*/
is_padded = TRUE;
}

2
gtk/voip_calls.c
View File

@ -2481,7 +2481,7 @@ MGCPcalls_packet( void *ptr _U_, packet_info *pinfo, epan_dissect_t *edt _U_, co
}
/* if there is a Busy or ReorderTone, and the call was Ringing or Setup the call is Rejected */
if ( (isSignal("ro", pi->signalReq) || isSignal("bz", pi->signalReq)) && ((callsinfo->call_state == VOIP_CALL_SETUP) || (callsinfo->call_state = VOIP_RINGING)) ) {
if ( (isSignal("ro", pi->signalReq) || isSignal("bz", pi->signalReq)) && ((callsinfo->call_state == VOIP_CALL_SETUP) || (callsinfo->call_state == VOIP_RINGING)) ) {
callsinfo->call_state = VOIP_REJECTED;
}